- Issue created by @smustgrave
- 🇺🇸United States smustgrave
FYI I tagged for novice for new users to try first
- 🇺🇸United States smustgrave
So please reserve for them. Ticket isn’t 24hours old yet
- 🇸🇬Singapore anish.a Singapore
FYI, these are the errors
30/30 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ ------------------------------------------------------------------------------ Line quicktabs_accordion/src/Plugin/TabRenderer/AccordionTabs.php ------ ------------------------------------------------------------------------------ 54 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line quicktabs_jqueryui/src/Plugin/TabRenderer/UiTabs.php ------ ------------------------------------------------------------------------------ 27 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ----------------------------------------------------------------------------------- Line src/Controller/QuickTabsController.php ------ ----------------------------------------------------------------------------------- 48 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ----------------------------------------------------------------------------------- ------ ----------------------------------------------------------------------------------- Line src/Form/QuickTabsInstanceEditForm.php ------ ----------------------------------------------------------------------------------- 49 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ----------------------------------------------------------------------------------- ------ ----------------------------------------------------------------------------------- Line src/Plugin/Block/QuickTabsBlock.php ------ ----------------------------------------------------------------------------------- 50 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ----------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------ Line src/Plugin/Derivative/QuickTabsBlock.php ------ ------------------------------------------------------------------------------ 18 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Plugin/TabRenderer/QuickTabs.php ------ ------------------------------------------------------------------------------ 74 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Plugin/TabType/BlockContent.php ------ ------------------------------------------------------------------------------ 67 \Drupal calls should be avoided in classes, use dependency injection instead 69 \Drupal calls should be avoided in classes, use dependency injection instead 75 \Drupal calls should be avoided in classes, use dependency injection instead 81 \Drupal calls should be avoided in classes, use dependency injection instead 97 \Drupal calls should be avoided in classes, use dependency injection instead 98 \Drupal calls should be avoided in classes, use dependency injection instead 121 \Drupal calls should be avoided in classes, use dependency injection instead 122 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ -------------------------------------------------------------------------------------------------------------------- Line src/Plugin/TabType/NodeContent.php ------ -------------------------------------------------------------------------------------------------------------------- 35 \Drupal calls should be avoided in classes, use dependency injection instead 60 \Drupal calls should be avoided in classes, use dependency injection instead 62 Method Drupal\quicktabs\Plugin\TabType\NodeContent::render() should return string but return statement is missing. 64 \Drupal calls should be avoided in classes, use dependency injection instead 70 \Drupal calls should be avoided in classes, use dependency injection instead ------ -------------------------------------------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------ Line src/Plugin/TabType/QtabsContent.php ------ ------------------------------------------------------------------------------ 27 \Drupal calls should be avoided in classes, use dependency injection instead 48 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Plugin/TabType/ViewContent.php ------ ------------------------------------------------------------------------------ 76 \Drupal calls should be avoided in classes, use dependency injection instead 81 \Drupal calls should be avoided in classes, use dependency injection instead 86 \Drupal calls should be avoided in classes, use dependency injection instead 89 \Drupal calls should be avoided in classes, use dependency injection instead 102 \Drupal calls should be avoided in classes, use dependency injection instead 180 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ -------------------------------------------------------------------------------------------------------------------- Line src/Plugin/views/style/Quicktabs.php ------ -------------------------------------------------------------------------------------------------------------------- 5 Interface Drupal\Core\Form\FormStateInterface referenced with incorrect case: Drupal\core\form\FormStateInterface. ------ -------------------------------------------------------------------------------------------------------------------- [ERROR] Found 29 errors - 🇸🇬Singapore anish.a Singapore
@lavanyatalwar It is already being worked on by @rahul_ in DrupalCon Singapore and he is already in finishing stages. I suggest to take up another issue to avoid duplicate work.
- 🇮🇳India rahul_ Alirajpur
I am still working on this, will continue for another 24 hours.
Till Now -
I fixed most of the Errors mentioned above, and only a few are remaining, once I fix them tomorrow, and test the module, I will mark PR as ready for review.ddev . phpstan analyze web/modules/contrib/quicktabs - 🇺🇸United States smustgrave
Following up on this, would like to include in the release.
- 🇸🇬Singapore anish.a Singapore
@rahul_ Can you push the WIP in the branch, so that I can take a look.
- 🇮🇳India rahul_ Alirajpur
@anish.a you can continue from scratch, because due to some mistake, all my code is reverted :(.
- 🇸🇬Singapore anish.a Singapore
I am taking this up. I will push the changes on what I had done by today itself.
- 🇸🇬Singapore anish.a Singapore
Created a draft MR. I still need to fix the dependency injection errors, continuing the work.
- 🇸🇬Singapore anish.a Singapore
Changing the status and assigning to me as I am continuing working on this.
- 🇸🇬Singapore anish.a Singapore
I had submitted a rough draft and I need some help on finishing it.
-
smustgrave →
committed 7b37f0d9 on 4.0.x authored by
anish.a →
Issue #3492949: Address PHPSTAN issues
-
smustgrave →
committed 7b37f0d9 on 4.0.x authored by
anish.a →
Automatically closed - issue fixed for 2 weeks with no activity.