🇮🇳India @lavanyatalwar

Heyy @avpaderno,
I have fixed the comments you dropped on the MR but now I am not clear about the following warnings of phpcs

--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 124 | WARNING | Only string literals should be passed to t() where possible
     |         | (Drupal.Semantics.FunctionT.NotLiteralString)
--------------------------------------------------------------------------------
FILE: ...y-3475949/web/modules/custom/liqpay-3475949/src/Controller/LiqpayPages.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 57 | WARNING | Only string literals should be passed to t() where possible
    |         | (Drupal.Semantics.FunctionT.NotLiteralString)
--------------------------------------------------------------------------------

If you could guide me , I would be highly obiliged since I am quite new to drupal community.

lavanyatalwar → created an issue.

Thanks @ankitv18. I agree, I could have used that method.

Thanks @anybody
Sure I'll have a look on the issue you are refering.
Let me first resolve the comments on this issue.

@anybody
Now all the errors have been resolved.
Kindly check and merge :)

Okay
Should I fix phpunit errors as well?
Because I see some errors related to views as well (missing schema) that is not related to the this module.

Heyy @anybody,
I was resolving cspell errors and found the problem lies mostly in the term 'giftcards'.
Pipeline failure error log suggests to change it to 'giftcard' instead.
I think changing it will generate an error in th functionality.
So should I skip cspell or change the term?

Working on it.

Okay I'll work upon it.
Also @avpaderno what should I keep the default title in line 124 Liqpay.php and line 57 of LiqpayPages.php (if the string in argument is empty).
Should I keep the title as 'default title' only ?

Hey @leslieg,
Personally, I prefer using "Add to queue" and "Remove from queue" for clarity—it just feels more intuitive. I also really like the UI approach that Gin uses for bulk operations; I think it strikes a good balance between functionality and visibility.

Heyy @benjifisher,
Fixed the missing return type issue.
Kindly check :)

Hey @sunil jolapara, @avpaderno,
As I see there are multiple other phpcs errors in the file. Should I resolve them aswell?
Also you suggested to remove the doc comments from readme.md file, but when I remove those comments, I encounter phpcs errors stating

----------------------------------------------------------------------
  3 | ERROR | Missing short description in doc comment
 16 | ERROR | Doc comment is empty
----------------------------------------------------------------------

Kindly suggest.

Working on it.

Thanks @benjifisher for your feedback.
I'll work on the issue you mentioned asap.
And hope the contribution done by me brings some value to your module :)

@benjifisher
Also I am a newbie to drupal community and I am facing some problem understanding this task
"Add a new permission that applies only to entities managed by a workflow. Advise site owners to review whether the new permission is appropriate for their site and their users."
If you could help me, I would be highly obiliged.

Hi @benjifisher,
I am getting this pipeline failure for the following issue and this is not related to the changes I have made

---- Drupal\Tests\block\Functional\BlockTest ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Fail      Other      phpunit-11.xml       0 Drupal\Tests\block\Functional\Block
    PHPUnit Test failed to complete; Error: PHPUnit 10.5.35 by Sebastian
    Bergmann and contributors.
    
    Runtime:       PHP 8.3.12
    Configuration: /builds/issue/drupal-3480675/core/phpunit.xml.dist
    
    ...........F..                                                    14 / 14
    (100%)
    
    HTML output was generated.
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-1-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-2-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-3-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-4-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-5-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-6-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-7-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-8-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-9-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-10-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-11-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-12-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-13-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-14-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-15-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-16-42144665.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-17-67738122.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-18-67738122.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-19-67738122.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-20-67738122.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-21-67738122.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-22-67738122.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-23-67738122.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-24-67738122.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-25-67738122.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-26-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-27-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-28-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-29-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-30-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-31-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-32-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-33-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-34-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-35-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-36-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-37-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-38-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-39-14385962.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-40-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-41-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-42-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-43-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-44-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-45-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-46-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-47-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-48-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-49-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-50-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-51-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-52-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-53-24155744.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-54-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-55-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-56-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-57-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-58-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-59-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-60-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-61-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-62-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-63-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-64-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-65-24518180.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-66-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-67-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-68-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-69-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-70-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-71-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-72-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-73-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-74-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-75-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-76-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-77-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-78-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-79-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-80-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-81-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-82-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-83-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-84-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-85-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-86-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-87-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-88-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-89-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-90-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-91-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-92-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-93-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-94-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-95-24518180.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-96-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-97-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-98-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-99-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-100-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-101-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-102-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-103-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-104-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-105-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-106-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-107-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-108-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-109-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-110-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-111-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-112-81038441.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-113-30839567.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-114-30839567.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-115-30839567.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-116-30839567.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-117-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-118-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-119-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-120-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-121-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-122-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-123-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-124-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-125-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-126-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-127-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-128-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-129-15334238.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-130-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-131-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-132-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-133-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-134-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-135-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-136-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-137-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-138-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-139-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-140-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-141-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-142-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-143-42149417.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-144-62152517.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-145-62152517.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-146-62152517.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-147-62152517.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-148-62152517.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-149-62152517.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-150-62152517.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-151-62152517.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-152-62152517.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-153-25732516.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-154-25732516.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-155-25732516.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-156-83107053.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-157-83107053.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-158-83107053.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-159-83107053.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-160-96295970.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-161-96295970.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-162-93769269.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-163-93769269.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-164-93769269.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-165-93769269.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-166-93769269.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-167-93769269.html
http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_block_Functional_BlockTest-168-93769269.html
Time: 02:00.175, Memory: 8.00 MB
There was 1 failure:
1) Drupal\Tests\block\Functional\BlockTest::testBlockAccess
Behat\Mink\Exception\ResponseTextException: The text "Hello test world" was
not found anywhere in the text of the current page.
/builds/issue/drupal-3480675/vendor/behat/mink/src/WebAssert.php:907
/builds/issue/drupal-3480675/vendor/behat/mink/src/WebAssert.php:293
/builds/issue/drupal-3480675/core/tests/Drupal/Tests/WebAssert.php:979
/builds/issue/drupal-3480675/core/modules/block/tests/src/Functional/BlockTest.php:581
FAILURES!
Tests: 14, Assertions: 227, Failures: 1.

Working on the suggested changes.

Working on it.

Heyy @batigolix
Does this issue still needs work or is it already done?

Working on it.

Heyy @djg_tram
I am attaching a icon.
Kindly check :)

Hi @andileco,
I looked at your videos, and I think you are doing a good job in video tutorials.
I just think that along with videos, if you can just add some documentation and images on the page you attached your video link, it would be better so that whoever doesn't want to see the video can just go through the documentation and proceed with them while taking a look at the images.

Heyy @bramdriesen,
Poll module is no more compatible with drupal 8.
How to contribute to this issue now ?

Heyy @fatima2345,
Can you elaborate what exactly is the issue you are encountering?

lavanyatalwar → made their first commit to this issue’s fork.

Working on it.

Hey @chancenyasulu,
I have created a MR.
Kindly check and merge :) .

Heyy @chancenyasulu ,
So here , an empty file named packt_main.js is pushed that is creating a phpcs error.
Should I remove this file??

Hey @d-xpert,
There are no eslint errors, instead there is some problem in phpcs.
Should I resolve them?

Working on it.

Hey @batigolix,
I am not able to see the pipeline issue.

Hey @chrisfromredfin,
I have raised a MR that has passed all the stages.
Kindly check and merge :)

Okay, I 'll work upon it and resolve the linting problem.

I have added a MR, kindly review it.

Hey @libbna,
Yes, I am working on it.

lavanyatalwar → changed the visibility of the branch 3473145-entityvieweventconstruct-argument-4 to active.

lavanyatalwar → changed the visibility of the branch 3473145-entityvieweventconstruct-argument-4 to hidden.