Hi @chhavi.sharma,
The changes you made look good to me. However, as per
#8
✨
Sort component stories
Active
, the weight key/property needs to be introduced. Therefore, I’m moving the issue back to Needs Work.
Also, I’m attaching a screen recording showing the issue working as expected.
The code changes look good, and the cloudflare.composer_dependency_check service has been removed. Moving this issue to RTBC.
I was able to reproduce the issue and encountered the same error. However, it was resolved after applying MR!9. I'm attaching a screenshot of the error. Moving the issue to RTBC.
Hi @wxactly,
Thanks for the merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them.
The code changes look good to me. I’ve also attached a screenshot of the old error, and the pipeline for PHPUnit now passes. Moving it to RTBC.
MR is conflicted. Moving to NW.
@dhruv.mittal Thanks for the MR. However, it seems the pipeline is failing due to this merge request. Please take a look.
Tests are failing. Needs tests.
Issue summary needs to be updated
Okay, I'll work on comments #16 and #17. Also, @joseph.olstad, there was a change in MR!38 as well. I'm attaching a screenshot for your reference, kindly have a look.
Done with the changes @joseph.olstad,
Kindly review and merge :)
Thanks for the MR, @avpaderno. The changes look good to me.
Looking into it.
lavanyatalwar → changed the visibility of the branch 3519112-reject-button-text-typo to hidden.
Looks good, Creating MR for it.
Hi @nitin shrivastava,
Could you please elaborate on what exactly this issue is about? The hamburger toggle seems to be working fine on my end.
I'm attaching a screen recording for your reference.
Hi @sandip,
I believe the styling change you mentioned, i.e., box-sizing: border-box;, is not needed. The issue is resolved simply by adding padding=0;, and the MR is good to go.
Kindly take a look and review once.
Hi @catch,
I reviewed both the patch and the current codebase. It seems the patch is based on an older version of the code, which has since changed significantly.
Could you please take a look and confirm?
Looking into it
The changes look good to me. Thus, moving the issue to RTBC.
Done with the changes
@anybody, @rhovland Kindly check and merge :)
Sure, wroking on it.
There is no option visible to me for editing frontend entities even in 2.x branch. So unassigning this issue.
Hi @hanan alasari,
Are you working on this issue??
Kindly review :)
Been over a year so going to pick it up
Working on it.
Hello @bramdriesen,
I have added the required field to configure the Google Maps API key in the theme-settings.php file located at web/themes/custom/corporate_lite-3512058/theme-settings.php. The configuration is being properly saved and fetched.
I have attached a screenshot for your reference. Please have a look and let me know if any changes are required.
Thanks!
Hi @bramdriesen,
I have added the required field to config the Google Maps API key on the web/themes/custom/conference_lite-3509419/theme-settings.php, under the 3rd party integrations section. The configuration is being properly saved and fetched.
I am attaching screenshot for reference. Please have a look and let me know if any changes required here.
Thanks !
Hi @bramdriesen,
I have transitioned from using hook_form_alter to hook_user_login. According to my tests, all functionalities are working as intended.
Kindly review and merge :)
Hi @bramdriesen,
I attempted to use hook_user_login() instead of hook_form_alter(). However, I observed that the module permits both user1 and admin to access the site. Upon further investigation, I discovered that hook_user_login() is triggered after a user has successfully logged in, which may not align with the intended functionality of this module.
Could you please provide your suggestions?
Hi @mitthukumawat,
I attempted to reproduce the error you mentioned by importing the files through git cloning. However, I did not encounter the Limiting characters line in this scenario. Conversely, when I used composer require to include the files, the line appeared as expected. I've attached a screenshot illustrating the absence of the limiting line during the cloning method. Could you please review this and provide your insights?
Thank you!
lavanyatalwar → created an issue.
Reviewing this.
Hi @ivnish, Created the MR.
Kindly review and merge :)
Working on it
Fixed the spacing issue. Kindly review :)
Hi @trackleft2,
Thank you for the code changes, they look great! Attaching a screenshot and moving it back to RTBC.
Working on MR comments.
I just checked the functionality, and it looks good to me.
I am attaching screen recordings of the before and after states of applying the MR.
Moving it to RTBC.
The changes look good to me.
The help text has been updated as required to address the issue.
Attaching screenshots for your reference.
@drupalnesia, I have fixed the pager styling on the appearance page.
Attaching a screenshot for your reference. Kindly check :)
lavanyatalwar → made their first commit to this issue’s fork.
Hi @mp,
Could you please confirm if I’m understanding this correctly?
When going to Structure > Taxonomy Manager and adding a new term from there, is there a chance that terms could be duplicated?
Please let me know if it looks good to you, and then I'll update the description as well.
Hi @knyshuk.vova, @gapple,
I investigated the issue and found that the new token always overrides the most recent one.
I set the maximum token limit to 3, so after the 3rd token is saved, it overrides the latest one (the 3rd token).
I'm attaching the screenshots for your reference.
@utkarsh_33,
Done with the changes. Kindly check and merge :)
If the screenshot looks good to you, should I go ahead and update the MR ?
Hi @utkarsh_33,
I don’t think the changes to the SVG are necessary. I made some adjustments, like using display: flex and align-items: center on the span, and I think it looks fine now.
I’m attaching a screenshot, please have a look.
Hi @chrisfromredfin,
I’ve resolved this issue and am attaching screenshots for your reference.
Please have a look and let me know if any further changes are required.
Hi @chrisfromredfin,
I was trying to reproduce the issue and just want to make sure I’m understanding it correctly. I’ve attached a screenshot, please let me know if I’ve got it right.
Hello @helena zajika,
Thank you for the merge! However, I noticed that the credits for the issue were not included. It would be great if you could add them.
Thanks!
Hi @Gaurav_Gupta, @blacksnipe,
I reviewed the MR!5, and it seems the task is incomplete. While the checkbox button to reflect changes in derivative image styles is visible, the changes themselves are not showing up. I’ve attached a screen recording for your reference.
I have reviewed the MR and it looks good to me. I have also checked the UI and it looks fine. I am attaching a screenshot for your reference.
@ricmayak1,
I have fixed the issue with the breadcrumb not rendering.
I am attaching screenshots for your reference.
Looking into it.
I have reviewed this issue, and it seems to have been resolved. I am attaching the screenshots for reference.
Reviewed, and it looks good to me. Moving it to RTBC.
Updating MR for this patch.
Working on it
@baldwinlouie, the pipeline is green now.
Kindly review :)
Working on it.