🇮🇳India @lavanyatalwar

Hi @pcambra,
Thanks for the quick merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them.

It's working as expected for me.

Back to NR

Resolved the conflicts.
Kindly review and merge :)

Credited XO

After selecting the users you want to give credits to, if the issue has been resolved, you need to change the issue status to 'Fixed'. This will ensure the credits are distributed.
Thanks :)

Hi @hkoosha,
Thanks for the quick merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them.

Done with the changes. Kindly review :)

Hi @hkoosha,
I have completed the intended work. Kindly review and merge :)

Hi @hejazee @hkoosha,
I was in the process of removing deprecated methods and came across lines like this:

'title' => t('Time (e.g. @format)', ['@format' => static::formatExample($time_format)]),

Now, I have two options: I can either remove these lines completely, or I can add static hardcoded examples, like this: 'title' => t('Time (e.g. HH:MM:SS)'),
What do you think?

lavanyatalwar → made their first commit to this issue’s fork.

The changes look good to me. Also the pipeline is green now.
Moving it to RTBC.

Made the changes. Kindly review

Patch looks good. Creating a MR for it.

Hi @drdam,
Raised the MR for the patch provided.
Kindly review :)

@anybody, @rhovland
Kindly have a look and merge :)

Merge conflicts resolved.

lavanyatalwar → created an issue.

Hi @catcat811, @arunsahijpal,
I’m unable to reproduce this error. I added Simple Hierarchical Select as the widget and tried adding terms and sub-terms in my vocabulary. Everything worked fine, and the content was added without any issues.
Could you please let me know if I’m missing something?
I am adding screen recording of the same for your reference.

Patch #6 🐛 Implicitly marking parameter $site_path as nullable is deprecated Active looks good, but since using patches is not preferred, we need a MR instead.

Hi @chhavi.sharma,
The changes you made look good to me. However, as per #8 ✨ Sort component stories Active , the weight key/property needs to be introduced. Therefore, I’m moving the issue back to Needs Work.
Also, I’m attaching a screen recording showing the issue working as expected.

The code changes look good, and the cloudflare.composer_dependency_check service has been removed. Moving this issue to RTBC.

I was able to reproduce the issue and encountered the same error. However, it was resolved after applying MR!9. I'm attaching a screenshot of the error. Moving the issue to RTBC.

Hi @wxactly,
Thanks for the merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them.

The code changes look good to me. I’ve also attached a screenshot of the old error, and the pipeline for PHPUnit now passes. Moving it to RTBC.

MR is conflicted. Moving to NW.

@dhruv.mittal Thanks for the MR. However, it seems the pipeline is failing due to this merge request. Please take a look.

Tests are failing. Needs tests.

Issue summary needs to be updated

Okay, I'll work on comments #16 and #17. Also, @joseph.olstad, there was a change in MR!38 as well. I'm attaching a screenshot for your reference, kindly have a look.

Done with the changes @joseph.olstad,
Kindly review and merge :)

Thanks for the MR, @avpaderno. The changes look good to me.

Looking into it.

lavanyatalwar → changed the visibility of the branch 3519112-reject-button-text-typo to hidden.

Looks good, Creating MR for it.

Hi @nitin shrivastava,
Could you please elaborate on what exactly this issue is about? The hamburger toggle seems to be working fine on my end.
I'm attaching a screen recording for your reference.

Hi @sandip,
I believe the styling change you mentioned, i.e., box-sizing: border-box;, is not needed. The issue is resolved simply by adding padding=0;, and the MR is good to go.
Kindly take a look and review once.

Hi @catch,
I reviewed both the patch and the current codebase. It seems the patch is based on an older version of the code, which has since changed significantly.
Could you please take a look and confirm?

Looking into it

The changes look good to me. Thus, moving the issue to RTBC.

Done with the changes
@anybody, @rhovland Kindly check and merge :)

Sure, wroking on it.

There is no option visible to me for editing frontend entities even in 2.x branch. So unassigning this issue.

Hi @hanan alasari,
Are you working on this issue??

Kindly review :)

Been over a year so going to pick it up

Working on it.

Hello @bramdriesen,
I have added the required field to configure the Google Maps API key in the theme-settings.php file located at web/themes/custom/corporate_lite-3512058/theme-settings.php. The configuration is being properly saved and fetched.
I have attached a screenshot for your reference. Please have a look and let me know if any changes are required.
Thanks!

Hi @bramdriesen,

I have added the required field to config the Google Maps API key on the web/themes/custom/conference_lite-3509419/theme-settings.php, under the 3rd party integrations section. The configuration is being properly saved and fetched.

I am attaching screenshot for reference. Please have a look and let me know if any changes required here.
Thanks !

Hi @bramdriesen,
I have transitioned from using hook_form_alter to hook_user_login. According to my tests, all functionalities are working as intended.
Kindly review and merge :)

Hi @bramdriesen,
I attempted to use hook_user_login() instead of hook_form_alter(). However, I observed that the module permits both user1 and admin to access the site. Upon further investigation, I discovered that hook_user_login() is triggered after a user has successfully logged in, which may not align with the intended functionality of this module.
Could you please provide your suggestions?

Hi @mitthukumawat,
I attempted to reproduce the error you mentioned by importing the files through git cloning. However, I did not encounter the Limiting characters line in this scenario. Conversely, when I used composer require to include the files, the line appeared as expected. I've attached a screenshot illustrating the absence of the limiting line during the cloning method. Could you please review this and provide your insights?
Thank you!

lavanyatalwar → created an issue.

Reviewing this.

Hi @ivnish, Created the MR.
Kindly review and merge :)

Working on it

Fixed the spacing issue. Kindly review :)

Hi @trackleft2,
Thank you for the code changes, they look great! Attaching a screenshot and moving it back to RTBC.

Working on MR comments.

I just checked the functionality, and it looks good to me.
I am attaching screen recordings of the before and after states of applying the MR.
Moving it to RTBC.

The changes look good to me.
The help text has been updated as required to address the issue.
Attaching screenshots for your reference.

@drupalnesia, I have fixed the pager styling on the appearance page.
Attaching a screenshot for your reference. Kindly check :)