šŸ‡®šŸ‡³India @lavanyatalwar

Account created on 27 September 2024, 6 months ago
#

Merge Requests

More

Recent comments

šŸ‡®šŸ‡³India lavanyatalwar

The changes look good to me. Thus, moving the issue to RTBC.

šŸ‡®šŸ‡³India lavanyatalwar

Done with the changes
@anybody, @rhovland Kindly check and merge :)

šŸ‡®šŸ‡³India lavanyatalwar

There is no option visible to me for editing frontend entities even in 2.x branch. So unassigning this issue.

šŸ‡®šŸ‡³India lavanyatalwar

Hi @hanan alasari,
Are you working on this issue??

šŸ‡®šŸ‡³India lavanyatalwar

Hello @bramdriesen,
I have added the required field to configure the Google Maps API key in the theme-settings.php file located at web/themes/custom/corporate_lite-3512058/theme-settings.php. The configuration is being properly saved and fetched.
I have attached a screenshot for your reference. Please have a look and let me know if any changes are required.
Thanks!

šŸ‡®šŸ‡³India lavanyatalwar

Hi @bramdriesen,

I have added the required field to config the Google Maps API key on the web/themes/custom/conference_lite-3509419/theme-settings.php, under the 3rd party integrations section. The configuration is being properly saved and fetched.

I am attaching screenshot for reference. Please have a look and let me know if any changes required here.
Thanks !

šŸ‡®šŸ‡³India lavanyatalwar

Hi @bramdriesen,
I have transitioned from using hook_form_alter to hook_user_login. According to my tests, all functionalities are working as intended.
Kindly review and merge :)

šŸ‡®šŸ‡³India lavanyatalwar

Hi @bramdriesen,
I attempted to use hook_user_login() instead of hook_form_alter(). However, I observed that the module permits both user1 and admin to access the site. Upon further investigation, I discovered that hook_user_login() is triggered after a user has successfully logged in, which may not align with the intended functionality of this module.
Could you please provide your suggestions?

šŸ‡®šŸ‡³India lavanyatalwar

Hi @mitthukumawat,
I attempted to reproduce the error you mentioned by importing the files through git cloning. However, I did not encounter the Limiting characters line in this scenario. Conversely, when I used composer require to include the files, the line appeared as expected. I've attached a screenshot illustrating the absence of the limiting line during the cloning method. Could you please review this and provide your insights?
Thank you!

šŸ‡®šŸ‡³India lavanyatalwar

Hi @ivnish, Created the MR.
Kindly review and merge :)

šŸ‡®šŸ‡³India lavanyatalwar

Hi @trackleft2,
Thank you for the code changes, they look great! Attaching a screenshot and moving it back to RTBC.

šŸ‡®šŸ‡³India lavanyatalwar

I just checked the functionality, and it looks good to me.
I am attaching screen recordings of the before and after states of applying the MR.
Moving it to RTBC.

šŸ‡®šŸ‡³India lavanyatalwar

The changes look good to me.
The help text has been updated as required to address the issue.
Attaching screenshots for your reference.

šŸ‡®šŸ‡³India lavanyatalwar

@drupalnesia, I have fixed the pager styling on the appearance page.
Attaching a screenshot for your reference. Kindly check :)

šŸ‡®šŸ‡³India lavanyatalwar

lavanyatalwar ā†’ made their first commit to this issueā€™s fork.

šŸ‡®šŸ‡³India lavanyatalwar

Hi @mp,
Could you please confirm if Iā€™m understanding this correctly?
When going to Structure > Taxonomy Manager and adding a new term from there, is there a chance that terms could be duplicated?

šŸ‡®šŸ‡³India lavanyatalwar

Please let me know if it looks good to you, and then I'll update the description as well.

šŸ‡®šŸ‡³India lavanyatalwar

Hi @knyshuk.vova, @gapple,
I investigated the issue and found that the new token always overrides the most recent one.
I set the maximum token limit to 3, so after the 3rd token is saved, it overrides the latest one (the 3rd token).
I'm attaching the screenshots for your reference.

šŸ‡®šŸ‡³India lavanyatalwar

@utkarsh_33,
Done with the changes. Kindly check and merge :)

šŸ‡®šŸ‡³India lavanyatalwar

If the screenshot looks good to you, should I go ahead and update the MR ?

šŸ‡®šŸ‡³India lavanyatalwar

Hi @utkarsh_33,
I donā€™t think the changes to the SVG are necessary. I made some adjustments, like using display: flex and align-items: center on the span, and I think it looks fine now.
Iā€™m attaching a screenshot, please have a look.

šŸ‡®šŸ‡³India lavanyatalwar

Hi @chrisfromredfin,
Iā€™ve resolved this issue and am attaching screenshots for your reference.
Please have a look and let me know if any further changes are required.

šŸ‡®šŸ‡³India lavanyatalwar

Hi @chrisfromredfin,
I was trying to reproduce the issue and just want to make sure Iā€™m understanding it correctly. Iā€™ve attached a screenshot, please let me know if Iā€™ve got it right.

šŸ‡®šŸ‡³India lavanyatalwar

Hello @helena zajika,
Thank you for the merge! However, I noticed that the credits for the issue were not included. It would be great if you could add them.
Thanks!

šŸ‡®šŸ‡³India lavanyatalwar

Hi @Gaurav_Gupta, @blacksnipe,
I reviewed the MR!5, and it seems the task is incomplete. While the checkbox button to reflect changes in derivative image styles is visible, the changes themselves are not showing up. Iā€™ve attached a screen recording for your reference.

šŸ‡®šŸ‡³India lavanyatalwar

I have reviewed the MR and it looks good to me. I have also checked the UI and it looks fine. I am attaching a screenshot for your reference.

šŸ‡®šŸ‡³India lavanyatalwar

@ricmayak1,
I have fixed the issue with the breadcrumb not rendering.
I am attaching screenshots for your reference.

šŸ‡®šŸ‡³India lavanyatalwar

I have reviewed this issue, and it seems to have been resolved. I am attaching the screenshots for reference.

šŸ‡®šŸ‡³India lavanyatalwar

Reviewed, and it looks good to me. Moving it to RTBC.

šŸ‡®šŸ‡³India lavanyatalwar

@baldwinlouie, the pipeline is green now.
Kindly review :)

šŸ‡®šŸ‡³India lavanyatalwar

Hi @quietone,
Is this issue fixed, or is there anything else that still needs to be addressed?

šŸ‡®šŸ‡³India lavanyatalwar

I have reviewed the MR and attached the screenshots of the UI for reference. Everything looks good to me, so Iā€™m moving it to RTBC.

šŸ‡®šŸ‡³India lavanyatalwar

@sinn, Added gitlab-ci.yml
Kindly review :)

šŸ‡®šŸ‡³India lavanyatalwar

I have updated the MR with the patch provided in #13. Kindly review it :)

šŸ‡®šŸ‡³India lavanyatalwar

lavanyatalwar ā†’ made their first commit to this issueā€™s fork.

šŸ‡®šŸ‡³India lavanyatalwar

I have reviewed the issue, and it seems to have been resolved. I am attaching a screenshot for reference and moving it to RTBC.

šŸ‡®šŸ‡³India lavanyatalwar

I have reviewed MR!9, and it looks good to me. I am attaching the screenshots for reference and moving it to RTBC.

šŸ‡®šŸ‡³India lavanyatalwar

The pipeline for phpstan is green. Moving it to RTBC.

šŸ‡®šŸ‡³India lavanyatalwar

@alok_singh, could you please elaborate on what exactly our goal is in this issue? How will our main menu look after the issue is fixed?

šŸ‡®šŸ‡³India lavanyatalwar

@useernamee,
The pipeline is all green now.
Kindly review :)

šŸ‡®šŸ‡³India lavanyatalwar

Fixed the 80 char wrapping error
Kindly review :)

šŸ‡®šŸ‡³India lavanyatalwar

Hi @yasminorj,
Thank you for providing the MR. I applied MR!654, and it was successfully applied, fixing the specified issue.
Thank you,
Moving it to RTBC.

šŸ‡®šŸ‡³India lavanyatalwar

Fixed the issues reported by phpcs
Kindly review :)

šŸ‡®šŸ‡³India lavanyatalwar

@swirt, I tried to reproduce this issue, but the source code is still not available.

Production build 0.71.5 2024