Account created on 27 September 2024, 5 months ago
#

Merge Requests

More

Recent comments

🇮🇳India lavanyatalwar

Hi @ivnish, Created the MR.
Kindly review and merge :)

🇮🇳India lavanyatalwar

Hi @trackleft2,
Thank you for the code changes, they look great! Attaching a screenshot and moving it back to RTBC.

🇮🇳India lavanyatalwar

I just checked the functionality, and it looks good to me.
I am attaching screen recordings of the before and after states of applying the MR.
Moving it to RTBC.

🇮🇳India lavanyatalwar

The changes look good to me.
The help text has been updated as required to address the issue.
Attaching screenshots for your reference.

🇮🇳India lavanyatalwar

@drupalnesia, I have fixed the pager styling on the appearance page.
Attaching a screenshot for your reference. Kindly check :)

🇮🇳India lavanyatalwar

lavanyatalwar made their first commit to this issue’s fork.

🇮🇳India lavanyatalwar

Hi @mp,
Could you please confirm if I’m understanding this correctly?
When going to Structure > Taxonomy Manager and adding a new term from there, is there a chance that terms could be duplicated?

🇮🇳India lavanyatalwar

Please let me know if it looks good to you, and then I'll update the description as well.

🇮🇳India lavanyatalwar

Hi @knyshuk.vova, @gapple,
I investigated the issue and found that the new token always overrides the most recent one.
I set the maximum token limit to 3, so after the 3rd token is saved, it overrides the latest one (the 3rd token).
I'm attaching the screenshots for your reference.

🇮🇳India lavanyatalwar

@utkarsh_33,
Done with the changes. Kindly check and merge :)

🇮🇳India lavanyatalwar

If the screenshot looks good to you, should I go ahead and update the MR ?

🇮🇳India lavanyatalwar

Hi @utkarsh_33,
I don’t think the changes to the SVG are necessary. I made some adjustments, like using display: flex and align-items: center on the span, and I think it looks fine now.
I’m attaching a screenshot, please have a look.

🇮🇳India lavanyatalwar

Hi @chrisfromredfin,
I’ve resolved this issue and am attaching screenshots for your reference.
Please have a look and let me know if any further changes are required.

🇮🇳India lavanyatalwar

Hi @chrisfromredfin,
I was trying to reproduce the issue and just want to make sure I’m understanding it correctly. I’ve attached a screenshot, please let me know if I’ve got it right.

🇮🇳India lavanyatalwar

Hello @helena zajika,
Thank you for the merge! However, I noticed that the credits for the issue were not included. It would be great if you could add them.
Thanks!

🇮🇳India lavanyatalwar

Hi @Gaurav_Gupta, @blacksnipe,
I reviewed the MR!5, and it seems the task is incomplete. While the checkbox button to reflect changes in derivative image styles is visible, the changes themselves are not showing up. I’ve attached a screen recording for your reference.

🇮🇳India lavanyatalwar

I have reviewed the MR and it looks good to me. I have also checked the UI and it looks fine. I am attaching a screenshot for your reference.

🇮🇳India lavanyatalwar

@ricmayak1,
I have fixed the issue with the breadcrumb not rendering.
I am attaching screenshots for your reference.

🇮🇳India lavanyatalwar

I have reviewed this issue, and it seems to have been resolved. I am attaching the screenshots for reference.

🇮🇳India lavanyatalwar

@baldwinlouie, the pipeline is green now.
Kindly review :)

🇮🇳India lavanyatalwar

Hi @quietone,
Is this issue fixed, or is there anything else that still needs to be addressed?

🇮🇳India lavanyatalwar

I have reviewed the MR and attached the screenshots of the UI for reference. Everything looks good to me, so I’m moving it to RTBC.

🇮🇳India lavanyatalwar

@sinn, Added gitlab-ci.yml
Kindly review :)

🇮🇳India lavanyatalwar

I have updated the MR with the patch provided in #13. Kindly review it :)

🇮🇳India lavanyatalwar

lavanyatalwar made their first commit to this issue’s fork.

🇮🇳India lavanyatalwar

I have reviewed the issue, and it seems to have been resolved. I am attaching a screenshot for reference and moving it to RTBC.

🇮🇳India lavanyatalwar

I have reviewed MR!9, and it looks good to me. I am attaching the screenshots for reference and moving it to RTBC.

🇮🇳India lavanyatalwar

The pipeline for phpstan is green. Moving it to RTBC.

🇮🇳India lavanyatalwar

@alok_singh, could you please elaborate on what exactly our goal is in this issue? How will our main menu look after the issue is fixed?

🇮🇳India lavanyatalwar

@useernamee,
The pipeline is all green now.
Kindly review :)

🇮🇳India lavanyatalwar

Fixed the 80 char wrapping error
Kindly review :)

🇮🇳India lavanyatalwar

Hi @yasminorj,
Thank you for providing the MR. I applied MR!654, and it was successfully applied, fixing the specified issue.
Thank you,
Moving it to RTBC.

🇮🇳India lavanyatalwar

Fixed the issues reported by phpcs
Kindly review :)

🇮🇳India lavanyatalwar

@swirt, I tried to reproduce this issue, but the source code is still not available.

🇮🇳India lavanyatalwar

@abelpzl, has this issue been completed, or is there something else that still needs to be addressed?

🇮🇳India lavanyatalwar

The changes looks good to me
Moving it to RTBC.

🇮🇳India lavanyatalwar

Fixed the phpcs pipeline.
Kindly check :)

🇮🇳India lavanyatalwar

Hi @lucashedding
Thank you for updating the MR. Pipeline is green for stylelint and eslint now.
Moving it to RTBC+

🇮🇳India lavanyatalwar

Resolved the MR conflicts.
Kindly check :)

🇮🇳India lavanyatalwar

The phpcs pipeline is green now.
But still phpstan, eslint, stylelint, cspell fail.

🇮🇳India lavanyatalwar

@avpaderno, Updated the issue summary
Kindly review :)

🇮🇳India lavanyatalwar

Added the MR with required changes.
Kindly review :)

🇮🇳India lavanyatalwar

It LGTM, creating a MR for it.

🇮🇳India lavanyatalwar

@primsi, is this issue resolved, or is there something else that still needs to be addressed?

🇮🇳India lavanyatalwar

@joachim, fixed MR comments.

🇮🇳India lavanyatalwar

I reran the tests and the pipeline is all green now.

🇮🇳India lavanyatalwar

Hi @zaporylie,
I tried applying the patch, but I encountered errors during the process. Additionally, I noticed that most of the changes indicated by the patch have already been fixed.
I'm attaching screenshots for your reference.

🇮🇳India lavanyatalwar

@joachim, fixed the MR comments.

Production build 0.71.5 2024