🇮🇳India @lavanyatalwar

I have reviewed the MR and it looks good to me. I have also checked the UI and it looks fine. I am attaching a screenshot for your reference.

@ricmayak1,
I have fixed the issue with the breadcrumb not rendering.
I am attaching screenshots for your reference.

Looking into it.

I have reviewed this issue, and it seems to have been resolved. I am attaching the screenshots for reference.

Reviewed, and it looks good to me. Moving it to RTBC.

Updating MR for this patch.

Working on it

@baldwinlouie, the pipeline is green now.
Kindly review :)

Working on it.

Hi @quietone,
Is this issue fixed, or is there anything else that still needs to be addressed?

Made the suggested changes.
Kindly review :)

Working on it.

I have reviewed the MR and attached the screenshots of the UI for reference. Everything looks good to me, so I’m moving it to RTBC.

@sinn, Added gitlab-ci.yml
Kindly review :)

Working on it

I have updated the MR with the patch provided in #13. Kindly review it :)

lavanyatalwar → made their first commit to this issue’s fork.

I have reviewed the issue, and it seems to have been resolved. I am attaching a screenshot for reference and moving it to RTBC.

Working on it.

I have reviewed MR!9, and it looks good to me. I am attaching the screenshots for reference and moving it to RTBC.

The pipeline for phpstan is green. Moving it to RTBC.

@alok_singh, could you please elaborate on what exactly our goal is in this issue? How will our main menu look after the issue is fixed?

Created a MR.

Working on it.

Working on it.

@useernamee,
The pipeline is all green now.
Kindly review :)

Working on it.

Fixed the 80 char wrapping error
Kindly review :)

Working on it.

Hi @yasminorj,
Thank you for providing the MR. I applied MR!654, and it was successfully applied, fixing the specified issue.
Thank you,
Moving it to RTBC.

Fixed the issues reported by phpcs
Kindly review :)

Working on it.

@swirt, I tried to reproduce this issue, but the source code is still not available.

@abelpzl, has this issue been completed, or is there something else that still needs to be addressed?

The changes looks good to me
Moving it to RTBC.

Fixed the phpcs pipeline.
Kindly check :)

Working on it.

Working on it.

Working on it

Hi @lucashedding
Thank you for updating the MR. Pipeline is green for stylelint and eslint now.
Moving it to RTBC+

Resolved the MR conflicts.
Kindly check :)

Working on it.

The phpcs pipeline is green now.
But still phpstan, eslint, stylelint, cspell fail.

Working on it

@avpaderno, Updated the issue summary
Kindly review :)

Added the MR with required changes.
Kindly review :)

It LGTM, creating a MR for it.

Working on it.

Moving the issue to NR.

Patch looks good, creating an MR for it.

@primsi, is this issue resolved, or is there something else that still needs to be addressed?

@joachim, fixed MR comments.

I reran the tests and the pipeline is all green now.

Hi @zaporylie,
I tried applying the patch, but I encountered errors during the process. Additionally, I noticed that most of the changes indicated by the patch have already been fixed.
I'm attaching screenshots for your reference.

@joachim, fixed the MR comments.

Working on it.

Hi @dhruv.mittal

Thank you for updating the MR. I applied MR!89, it was applied smoothly and fixed the specified issue.
Thank you
Moving it to RTBC+

@joachim, I have updated the config schema.
Kindly check :)

Hi @nicxvan, I have removed all the comments containing 'hook_process' from the code.
Kindly check :)

Working on it.

lavanyatalwar → made their first commit to this issue’s fork.

Working on it.

Hi @alok_singh,
You have done changes in _components.scss file but your changes are not reflecting in main.css.
Moving it back to NW.

Also, @quietone, the pipeline is failing due to PHP static analysis. It states that the method setTextMode doesn't have a return type specified. Should I set its return type to void, as nothing appears to be intended to be returned?

      public function setTextMode($textMode, $untilTag = NULL) {
        // Do nothing, we never enter text mode.
      }

Hi @quietone,
I have added return comments everywhere.
Kindly check and merge. :)

Working on it.

Hi @clarkssquared, I have resolved the first error you mentioned, but I am not seeing the second error in my terminal. Could you please let me know the command you used to reproduce this error?

lavanyatalwar → made their first commit to this issue’s fork.

Hi @alok_singh,
I just checked the UI of the theme, but it does not match the one you attached.
Kindly check.

@ankitv18, Done with the changes.
Kindly check

Working on the suggestions.

@joelpittet, The pipeline is green now.
Kindly check and merge :)

@joelpittet, I fixed all the stylelint errors except for the empty CSS blocks with no styling.

Hi @joelpittet,
In the file calendar-overlap.css, there are some classes where no CSS is being applied. Should I remove them?

.calendar-calendar .day-view .full td.multi-day .calendar.dayview .contents div,
.calendar-calendar
  .week-view
  .full
  td.multi-day
  .calendar.weekview
  .contents
  div {
}

Also in calender.css

/* Item styles */
.calendar-pager__item {}

/* Current page indicator */
.pager__item--current {}

.calendar-pager__item-title--backwards {}
.calendar-pager__item-title--forward {}

Hello @sethhill,
Thanks for the quick merge! However, I noticed that the credit for the issue was not provided. It would be great if you could include the credits.
Thanks!

Fixed the MR comments
Moving it to NR.

lavanyatalwar → made their first commit to this issue’s fork.

Working on it.

@joelpittet,
I have addressed all the PHPCS errors except for those related to the commented code. I'll now focus on the MR comments.

@joelpittet, I was working on the file CalendarHelper.php, and it contains some commented code that causes PHPCS errors due to indentation issues with spaces. Should I remove the commented code or fix the indentation?
Error-

  511 | ERROR   | Comment indentation error, expected only 1 spaces
  513 | WARNING | Line exceeds 80 characters; contains 94 characters
  513 | ERROR   | Comment indentation error, expected only 3 spaces
  516 | ERROR   | Comment indentation error, expected only 3 spaces
  519 | WARNING | Line exceeds 80 characters; contains 128 characters
  519 | ERROR   | Comment indentation error, expected only 3 spaces
  522 | WARNING | Line exceeds 80 characters; contains 130 characters
  522 | ERROR   | Comment indentation error, expected only 3 spaces
  523 | WARNING | Line exceeds 80 characters; contains 98 characters
  526 | WARNING | Line exceeds 80 characters; contains 127 characters
  526 | ERROR   | Comment indentation error, expected only 3 spaces
  527 | WARNING | Line exceeds 80 characters; contains 92 characters
  532 | ERROR   | Comment indentation error, expected only 1 spaces

code-

// $from_to = [
        // $table_name . '.' . $db_info['columns'][$table_name]['value'],
        // $table_name . '.' . (!empty($field['settings']['todate'])
        // ? $db_info['columns'][$table_name]['value2']
        // : $db_info['columns'][$table_name]['value']),
        // ];
        // if (isset($field['settings']['tz_handling'])) {
        //   $tz_handling = $field['settings']['tz_handling'];
        //   $db_info = date_api_database_info($field, $revision);
        //   if ($tz_handling == 'date') {
        //     $offset_field = $table_name . '.' . $db_info['columns'][$table_name]['offset'];
        //   }
        //   $related_fields = [
        //     $table_name . '.' . $db_info['columns'][$table_name]['value'],
        //   ];
        //   if (isset($db_info['columns'][$table_name]['value2'])) {
        //     $related_fields = array_merge($related_fields, [$table_name . '.' . $db_info['columns'][$table_name]['value2']]);
        //   }
        //   if (isset($db_info['columns'][$table_name]['timezone'])) {
        //     $related_fields = array_merge($related_fields, [$table_name . '.' . $db_info['columns'][$table_name]['timezone']]);
        //     $timezone_field = $table_name . '.' . $db_info['columns'][$table_name]['timezone'];
        //   }
        //   if (isset($db_info['columns'][$table_name]['rrule'])) {
        //     $related_fields = array_merge($related_fields, [$table_name . '.' . $db_info['columns'][$table_name]['rrule']]);
        //            $rrule_field = $table_name . '.' . $db_info['columns'][$table_name]['rrule'];
        //          }
        //        }
        // Get the delta value into the query.
        // if ($field['cardinality'] != 1) {
        //   array_push($related_fields, "$table_name.delta");
        //   $delta_field = $table_name . '_delta';
        // }

Working on it.

Thank you, @jonathan1055
I have applied the suggestions from the MR.
Kindly review it.

I'll pick this up from here

Done with the changes, moving it to NR.

Creating a MR with suggested changes.

@cilefen, I’ve generated the MR. Please have a look.

lavanyatalwar → made their first commit to this issue’s fork.

I have reviewed it, and the issue seems to have been resolved. I am attaching a screen recording for reference. Moving it to RTBC.

I have reviewed it, and the error seems to have been resolved. I am attaching a screenshot for reference. Moving it to RTBC.

@larowlan, Worked on the MR comments.
Kindly check :)