Account created on 27 September 2024, 8 months ago
#

Merge Requests

More

Recent comments

🇮🇳India lavanyatalwar

Hi @lostcarpark, please take a look at the changes.

🇮🇳India lavanyatalwar

Made the required changes.
Kindly review and merge :)

🇮🇳India lavanyatalwar

@danrod, the hamburger icon isn't accessible below 767px. I assume this issue will be resolved once the hamburger bug is fixed. I'll go ahead and create an issue for it.

🇮🇳India lavanyatalwar

Donw with the changes.
Kindly review and merge :)

🇮🇳India lavanyatalwar

Added the service definition in #3526674 📌 Add TokenHooks to services.yml Active .
Please review.

🇮🇳India lavanyatalwar

For now since the parent issue has not been solved yet, I am assuming the class namespace to be 'Drupal\verify_email\Hook\TokenHooks'

🇮🇳India lavanyatalwar

Rebased the branch.
Kindly review and merge :)

🇮🇳India lavanyatalwar

Created a MR.
The upgrade status module now shows the status as compatible, and there are no errors or warnings in the dblogs.
Kindly review :)

🇮🇳India lavanyatalwar

Raised the MR. Please review :)

🇮🇳India lavanyatalwar

No worries, I was going to move it to RTBC anyway :)

🇮🇳India lavanyatalwar

I've just created a separate permission for accessing the book list, and it's working well for me. I'm attaching screenshots for your reference, showing the /books path being accessed by both an admin user and an anonymous user. As you can see, the path is now restricted for the anonymous user.

🇮🇳India lavanyatalwar

Hi @pcambra,
Thanks for the quick merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them.

🇮🇳India lavanyatalwar

Resolved the conflicts.
Kindly review and merge :)

🇮🇳India lavanyatalwar

After selecting the users you want to give credits to, if the issue has been resolved, you need to change the issue status to 'Fixed'. This will ensure the credits are distributed.
Thanks :)

🇮🇳India lavanyatalwar

Hi @hkoosha,
Thanks for the quick merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them.

🇮🇳India lavanyatalwar

Done with the changes. Kindly review :)

🇮🇳India lavanyatalwar

Hi @hkoosha,
I have completed the intended work. Kindly review and merge :)

🇮🇳India lavanyatalwar

Hi @hejazee @hkoosha,
I was in the process of removing deprecated methods and came across lines like this:

'title' => t('Time (e.g. @format)', ['@format' => static::formatExample($time_format)]),

Now, I have two options: I can either remove these lines completely, or I can add static hardcoded examples, like this: 'title' => t('Time (e.g. HH:MM:SS)'),
What do you think?

🇮🇳India lavanyatalwar

The changes look good to me. Also the pipeline is green now.
Moving it to RTBC.

🇮🇳India lavanyatalwar

Patch looks good. Creating a MR for it.

🇮🇳India lavanyatalwar

Hi @drdam,
Raised the MR for the patch provided.
Kindly review :)

🇮🇳India lavanyatalwar

Hi @catcat811, @arunsahijpal,
I’m unable to reproduce this error. I added Simple Hierarchical Select as the widget and tried adding terms and sub-terms in my vocabulary. Everything worked fine, and the content was added without any issues.
Could you please let me know if I’m missing something?
I am adding screen recording of the same for your reference.

🇮🇳India lavanyatalwar

Patch #6 🐛 Implicitly marking parameter $site_path as nullable is deprecated Active looks good, but since using patches is not preferred, we need a MR instead.

🇮🇳India lavanyatalwar

Hi @chhavi.sharma,
The changes you made look good to me. However, as per #8 Sort component stories Active , the weight key/property needs to be introduced. Therefore, I’m moving the issue back to Needs Work.
Also, I’m attaching a screen recording showing the issue working as expected.

🇮🇳India lavanyatalwar

The code changes look good, and the cloudflare.composer_dependency_check service has been removed. Moving this issue to RTBC.

🇮🇳India lavanyatalwar

I was able to reproduce the issue and encountered the same error. However, it was resolved after applying MR!9. I'm attaching a screenshot of the error. Moving the issue to RTBC.

🇮🇳India lavanyatalwar

Hi @wxactly,
Thanks for the merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them.

🇮🇳India lavanyatalwar

The code changes look good to me. I’ve also attached a screenshot of the old error, and the pipeline for PHPUnit now passes. Moving it to RTBC.

🇮🇳India lavanyatalwar

@dhruv.mittal Thanks for the MR. However, it seems the pipeline is failing due to this merge request. Please take a look.

🇮🇳India lavanyatalwar

Okay, I'll work on comments #16 and #17. Also, @joseph.olstad, there was a change in MR!38 as well. I'm attaching a screenshot for your reference, kindly have a look.

🇮🇳India lavanyatalwar

Thanks for the MR, @avpaderno. The changes look good to me.

🇮🇳India lavanyatalwar

lavanyatalwar changed the visibility of the branch 3519112-reject-button-text-typo to hidden.

🇮🇳India lavanyatalwar

Hi @nitin shrivastava,
Could you please elaborate on what exactly this issue is about? The hamburger toggle seems to be working fine on my end.
I'm attaching a screen recording for your reference.

🇮🇳India lavanyatalwar

Hi @sandip,
I believe the styling change you mentioned, i.e., box-sizing: border-box;, is not needed. The issue is resolved simply by adding padding=0;, and the MR is good to go.
Kindly take a look and review once.

🇮🇳India lavanyatalwar

Hi @catch,
I reviewed both the patch and the current codebase. It seems the patch is based on an older version of the code, which has since changed significantly.
Could you please take a look and confirm?

🇮🇳India lavanyatalwar

The changes look good to me. Thus, moving the issue to RTBC.

🇮🇳India lavanyatalwar

Done with the changes
@anybody, @rhovland Kindly check and merge :)

Production build 0.71.5 2024