lavanyatalwar → created an issue.
Reviewing this.
Hi @ivnish, Created the MR.
Kindly review and merge :)
Working on it
Fixed the spacing issue. Kindly review :)
Hi @trackleft2,
Thank you for the code changes, they look great! Attaching a screenshot and moving it back to RTBC.
Working on MR comments.
I just checked the functionality, and it looks good to me.
I am attaching screen recordings of the before and after states of applying the MR.
Moving it to RTBC.
The changes look good to me.
The help text has been updated as required to address the issue.
Attaching screenshots for your reference.
@drupalnesia, I have fixed the pager styling on the appearance page.
Attaching a screenshot for your reference. Kindly check :)
lavanyatalwar → made their first commit to this issue’s fork.
Hi @mp,
Could you please confirm if I’m understanding this correctly?
When going to Structure > Taxonomy Manager and adding a new term from there, is there a chance that terms could be duplicated?
Please let me know if it looks good to you, and then I'll update the description as well.
Hi @knyshuk.vova, @gapple,
I investigated the issue and found that the new token always overrides the most recent one.
I set the maximum token limit to 3, so after the 3rd token is saved, it overrides the latest one (the 3rd token).
I'm attaching the screenshots for your reference.
@utkarsh_33,
Done with the changes. Kindly check and merge :)
If the screenshot looks good to you, should I go ahead and update the MR ?
Hi @utkarsh_33,
I don’t think the changes to the SVG are necessary. I made some adjustments, like using display: flex and align-items: center on the span, and I think it looks fine now.
I’m attaching a screenshot, please have a look.
Hi @chrisfromredfin,
I’ve resolved this issue and am attaching screenshots for your reference.
Please have a look and let me know if any further changes are required.
Hi @chrisfromredfin,
I was trying to reproduce the issue and just want to make sure I’m understanding it correctly. I’ve attached a screenshot, please let me know if I’ve got it right.
Hello @helena zajika,
Thank you for the merge! However, I noticed that the credits for the issue were not included. It would be great if you could add them.
Thanks!
Hi @Gaurav_Gupta, @blacksnipe,
I reviewed the MR!5, and it seems the task is incomplete. While the checkbox button to reflect changes in derivative image styles is visible, the changes themselves are not showing up. I’ve attached a screen recording for your reference.
I have reviewed the MR and it looks good to me. I have also checked the UI and it looks fine. I am attaching a screenshot for your reference.
@ricmayak1,
I have fixed the issue with the breadcrumb not rendering.
I am attaching screenshots for your reference.
Looking into it.
I have reviewed this issue, and it seems to have been resolved. I am attaching the screenshots for reference.
Reviewed, and it looks good to me. Moving it to RTBC.
Updating MR for this patch.
Working on it
@baldwinlouie, the pipeline is green now.
Kindly review :)
Working on it.
Hi @quietone,
Is this issue fixed, or is there anything else that still needs to be addressed?
Made the suggested changes.
Kindly review :)
Working on it.
I have reviewed the MR and attached the screenshots of the UI for reference. Everything looks good to me, so I’m moving it to RTBC.
@sinn, Added gitlab-ci.yml
Kindly review :)
Working on it
I have updated the MR with the patch provided in #13. Kindly review it :)
lavanyatalwar → made their first commit to this issue’s fork.
I have reviewed the issue, and it seems to have been resolved. I am attaching a screenshot for reference and moving it to RTBC.
Working on it.
I have reviewed MR!9, and it looks good to me. I am attaching the screenshots for reference and moving it to RTBC.
The pipeline for phpstan is green. Moving it to RTBC.
@alok_singh, could you please elaborate on what exactly our goal is in this issue? How will our main menu look after the issue is fixed?
Created a MR.
Working on it.
Working on it.
@useernamee,
The pipeline is all green now.
Kindly review :)
Working on it.
Fixed the 80 char wrapping error
Kindly review :)
Working on it.
Hi @yasminorj,
Thank you for providing the MR. I applied MR!654, and it was successfully applied, fixing the specified issue.
Thank you,
Moving it to RTBC.
Fixed the issues reported by phpcs
Kindly review :)
Working on it.
@swirt, I tried to reproduce this issue, but the source code is still not available.
@abelpzl, has this issue been completed, or is there something else that still needs to be addressed?
The changes looks good to me
Moving it to RTBC.
Fixed the phpcs pipeline.
Kindly check :)
Working on it.
Working on it.
Working on it
Hi @lucashedding
Thank you for updating the MR. Pipeline is green for stylelint and eslint now.
Moving it to RTBC+
Resolved the MR conflicts.
Kindly check :)
Working on it.
The phpcs pipeline is green now.
But still phpstan, eslint, stylelint, cspell fail.
@avpaderno, Updated the issue summary
Kindly review :)
Added the MR with required changes.
Kindly review :)
It LGTM, creating a MR for it.
Moving the issue to NR.
Patch looks good, creating an MR for it.
@primsi, is this issue resolved, or is there something else that still needs to be addressed?
@joachim, fixed MR comments.
I reran the tests and the pipeline is all green now.
Hi @zaporylie,
I tried applying the patch, but I encountered errors during the process. Additionally, I noticed that most of the changes indicated by the patch have already been fixed.
I'm attaching screenshots for your reference.
@joachim, fixed the MR comments.
Working on it.