🇮🇳India @lavanyatalwar

@vishal.kadam Thank you for the review.
I've implemented the suggested changes.
Please take a look and let me know if anything else needs to be updated.
Thanks!

lavanyatalwar → created an issue.

lavanyatalwar → created an issue.

@lostcarpark
Done with the changes. Please review :)

Done with the changes
Please review :)

Working on the suggestions.

lavanyatalwar → made their first commit to this issue’s fork.

I made the changes. Please check

Hi @lostcarpark, please take a look at the changes.

Made the required changes.
Kindly review and merge :)

lavanyatalwar → created an issue.

@danrod, the hamburger icon isn't accessible below 767px. I assume this issue will be resolved once the hamburger bug is fixed. I'll go ahead and create an issue for it.

Donw with the changes.
Kindly review and merge :)

lavanyatalwar → created an issue.

Back to NR.

Kindly review and merge :)

Added the service definition in #3526674 📌 Add TokenHooks to services.yml Active .
Please review.

For now since the parent issue has not been solved yet, I am assuming the class namespace to be 'Drupal\verify_email\Hook\TokenHooks'

Rebased the branch.
Kindly review and merge :)

lavanyatalwar → made their first commit to this issue’s fork.

Created a MR.
The upgrade status module now shows the status as compatible, and there are no errors or warnings in the dblogs.
Kindly review :)

Raised the MR. Please review :)

No worries, I was going to move it to RTBC anyway :)

Reviewing this

I've just created a separate permission for accessing the book list, and it's working well for me. I'm attaching screenshots for your reference, showing the /books path being accessed by both an admin user and an anonymous user. As you can see, the path is now restricted for the anonymous user.

lavanyatalwar → changed the visibility of the branch 3525698-content-creation-fails to hidden.

lavanyatalwar → created an issue.

Hi @pcambra,
Thanks for the quick merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them.

It's working as expected for me.

Back to NR

Resolved the conflicts.
Kindly review and merge :)

Credited XO

After selecting the users you want to give credits to, if the issue has been resolved, you need to change the issue status to 'Fixed'. This will ensure the credits are distributed.
Thanks :)

Hi @hkoosha,
Thanks for the quick merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them.

Done with the changes. Kindly review :)

Hi @hkoosha,
I have completed the intended work. Kindly review and merge :)

Hi @hejazee @hkoosha,
I was in the process of removing deprecated methods and came across lines like this:

'title' => t('Time (e.g. @format)', ['@format' => static::formatExample($time_format)]),

Now, I have two options: I can either remove these lines completely, or I can add static hardcoded examples, like this: 'title' => t('Time (e.g. HH:MM:SS)'),
What do you think?

lavanyatalwar → made their first commit to this issue’s fork.

The changes look good to me. Also the pipeline is green now.
Moving it to RTBC.

Made the changes. Kindly review

Patch looks good. Creating a MR for it.

Hi @drdam,
Raised the MR for the patch provided.
Kindly review :)

@anybody, @rhovland
Kindly have a look and merge :)

Merge conflicts resolved.

lavanyatalwar → created an issue.

Hi @catcat811, @arunsahijpal,
I’m unable to reproduce this error. I added Simple Hierarchical Select as the widget and tried adding terms and sub-terms in my vocabulary. Everything worked fine, and the content was added without any issues.
Could you please let me know if I’m missing something?
I am adding screen recording of the same for your reference.

Patch #6 🐛 Implicitly marking parameter $site_path as nullable is deprecated Active looks good, but since using patches is not preferred, we need a MR instead.

Hi @chhavi.sharma,
The changes you made look good to me. However, as per #8 ✨ Sort component stories Active , the weight key/property needs to be introduced. Therefore, I’m moving the issue back to Needs Work.
Also, I’m attaching a screen recording showing the issue working as expected.

The code changes look good, and the cloudflare.composer_dependency_check service has been removed. Moving this issue to RTBC.

I was able to reproduce the issue and encountered the same error. However, it was resolved after applying MR!9. I'm attaching a screenshot of the error. Moving the issue to RTBC.

Hi @wxactly,
Thanks for the merge! However, I noticed that the credits have not been provided. It would be greatly appreciated if you could include them.

The code changes look good to me. I’ve also attached a screenshot of the old error, and the pipeline for PHPUnit now passes. Moving it to RTBC.

MR is conflicted. Moving to NW.

@dhruv.mittal Thanks for the MR. However, it seems the pipeline is failing due to this merge request. Please take a look.

Tests are failing. Needs tests.

Issue summary needs to be updated

Okay, I'll work on comments #16 and #17. Also, @joseph.olstad, there was a change in MR!38 as well. I'm attaching a screenshot for your reference, kindly have a look.

Done with the changes @joseph.olstad,
Kindly review and merge :)

Thanks for the MR, @avpaderno. The changes look good to me.