- Issue created by @lostcarpark
- 🇮🇳India lavanyatalwar
Made the required changes.
Kindly review and merge :) - 🇮🇪Ireland lostcarpark
Thanks for working on this. Some change to the text is needed. In particular, it needs to reference the available token.
- 🇮🇳India lavanyatalwar
Hi @lostcarpark, please take a look at the changes.
- 🇮🇪Ireland lostcarpark
Sorry to be picky, but I think the description could be a tiny bit clearer.
Also, sorry for not including in the original request, but I think we should have a test case for this. This can be added in
VerifyEmailSetupTest.php
, in thetestVerifyEmailConfig
function, just before submitting the form. Add the following assertion:$this->assertSession()->elementExists('xpath', '//div[@id="edit-email-body--description"][contains(text(), "Email message to be sent to user. Place token [verify-email:url] to insert the login link")]');
I promise this is the last change!
- 🇮🇪Ireland lostcarpark
That looks perfect now, and all tests are passing.
Moving to RTBC.
-
lostcarpark →
committed 9cc5e0e7 on 1.1.x authored by
lavanyatalwar →
Resolve #3526890 "Add description to"
-
lostcarpark →
committed 9cc5e0e7 on 1.1.x authored by
lavanyatalwar →
- 🇮🇪Ireland lostcarpark
@lavanyatalwar, thank you for working on this issue, and thanks for your patience with my nit-picking.
Merge completed, moving to fixed.
- 🇮🇪Ireland lostcarpark
That looks perfect now, and all tests are passing.
Moving to RTBC.