- Issue created by @lostcarpark
- 🇮🇳India lavanyatalwar
For now since the parent issue has not been solved yet, I am assuming the class namespace to be 'Drupal\verify_email\Hook\TokenHooks'
- 🇮🇪Ireland lostcarpark
Just a couple of small fixes needed. Please use the class namespace and name for the service name, so it can be referenced by
TokenHooks::class
. Also, please move the position inservices.yml
, so that hook services are grouped together.Thanks for working on this.
- 🇮🇪Ireland lostcarpark
Looks good now.
There is a PHPCS warning, but that is due to an earlier merge and expected.
Moving to RBTC and will merge shortly.
-
lostcarpark →
committed 48f74453 on 1.1.x authored by
lavanyatalwar →
Resolve #3526674 "Add tokenhooks to"
-
lostcarpark →
committed 48f74453 on 1.1.x authored by
lavanyatalwar →
- 🇮🇪Ireland lostcarpark
Merge complete. Now moving to fixed.
Thank you for your work on this issue.
- First commit to issue fork.
- 🇮🇳India nidhi27
Hii,
There was a typo in class name. I have resolved this MR !28.
Thanks!
-
lostcarpark →
committed 4a3f78e4 on 1.1.x authored by
nidhi27 →
Resolve #3526674 "Add tokenhooks to"
-
lostcarpark →
committed 4a3f78e4 on 1.1.x authored by
nidhi27 →
- 🇮🇪Ireland lostcarpark
Accidentally specified the class name as "TokenHooks" when it should have been "TokensHooks". Thanks for catching this, @nidhi27.
Tests currently failing because of empty test class, but will be fixed soon.