🇮🇳India @nidhi27

Hii,

Can you explain this ?

Hii,

Can you provide more detail on this ?

Hii,

Can you provide more details like what should be the path?

Hi,

Is it resolved?

Hii,

Can you please explain this?

Hii,

Changes are done. Let me know if any changes are needed.

Thanks!

Hi @swirt,

I have added the support for views documentation. Let me know if any changes are needed.
Thanks!

Hi,

I have tested the functionality and its working as expected. But test cases are failing because somewhere path is added. We can change it to any valid internal url. (E.g. )

Moving it to needs work.

Assigning my self for review.
Thanks!

Hii,

I have done the suggested changes.
Thanks!

Hii,

Changes seems fine and working as expected.

Thanks!

Hii,

Assigning to myself for review.

Hii,

I have done the suggested changes.
Thanks!

Hii,

I have done the suggested changes.
Thanks!

Hi @swirt,

It was miss from phpcs bug. But here in this MR I have resolved. Thanks!

Hii,

Issue is resolved. Now showing for taxonomy as well.
Thanks!

Hii @swirt,

I have tried to debug the issue but not able to understand why it disappears taxonomy only.

Hii @kul.pratap,

For path field its not showing the forward slash.

But for redirect_path field it is still showing the forward slash.

As per point 3,
In src/From/VerifyEmailAddEditForm, remove the '#field_prefix' => '/' from path and redirect_path. Add a #description stating the path should be a valid path within the site.

Needed to change in redirect path as well.

Kindly refer the comment above. Thanks!

Hii @kul.pratap,

Thanks for working on this. I've just flagged some minor issues that need correcting.

Hii,

I have created MR !41 to resolve this feature request. Let me know if any changes are needed.
Thanks!

Hii,

I have applied suggested changes.
Thanks!

Hii,

I have created MR !40 to resolve all the phpunit tests issues. Thanks!

nidhi27 → made their first commit to this issue’s fork.

Hii,

I have created MR !11 for this feature request. Let me know if any changes are needed.

Thanks!

Hii,

If we use the core token module than token_tree wont be available for UI.

Kindly share your views on implementation. Thanks!

Hii @swirt,

Can you please guilde me on this so that I can understand the requirement.

Thanks!

Hii @swirt,

Can you please guilde me on this so that I can understand the requirement.

Thanks!

Hii,

I have created MR !6 to resolve phpstan issues. Four issues that are currently showing in phpstan column are already resolved in phpcs issues.
Thanks!

Hii,

I have created MR !5 to resolve phpcs issues.
Thanks!

nidhi27 → made their first commit to this issue’s fork.

Hii,

I have resolved the comments.

Thanks!

Hii,

I have created MR !10 for this feature request. Let me know if any changes are needed.
Thanks!

Hii,

I have tried to resolve some of the errors. But there are still many errors that needs to be taken care.
Thanks!

nidhi27 → changed the visibility of the branch 3448212-deleting-a-content to hidden.

Hii,

It will be good to work on this after merging the MR of https://www.drupal.org/project/content_model_documentation/issues/3517038 📌 Fix PHP CS errors Active to avoid any conflicts. Let me know your view. Thanks!

Hii,

I have resolved all the phpcs errors.
Thanks!

Hii,

I have removed drupal_flush_all_caches(); from both the files.
Thanks!

Hii,

I have added rebuild and now after saving the entity it is not throwing any error. Let me know if this is the correct way or not.
Thanks!

Hii,

I have created the test files in https://www.drupal.org/project/front/issues/3438841 ✨ Make "Disable front page redirects for the administrator role" checkbox dependent using Form States API Active . It would be good to add tests for this after merge to avoid the conflicts.

Hii,

I have added the test case for this functionality. Let me know if any changes are needed.
Thanks!

Pipeline is passed now!

Assigning this to myself to resolve the phpch issues.

Hello,

Now all the phpstan issues are cleared. Thanks!

Hii,

I have created MR #36 for this feature request. Let me know if there are any changes needed.
Thanks!

Hii,

I have added the changes.
Thanks!

Hi @swirt,

There may be possibility that one content type can have multiple patterns also. In that case it will be good to show in table. Kindly share your view.
Thanks!

Hii,

I have created MR #4 to add this feature. Let me know if any changes are needed.

Thanks!

HI @lostcarpark,

Can I work on this?

Hi @swirt,

I have created MR #35 for this. Let me know if any changes are needed.
Thanks!

Hi @swirt,

It would be great if you can tell me the structure to display the data.

Thanks!

Hi @swirt,

I have created MR #34 to resolve this issue. Let me know if there are any changes needed.
Thanks!

Hi,

I have created MR #9 to resolve this issue. I have added the option in config form. Let me know if changes are needed.

nidhi27 → changed the visibility of the branch 3493506- to hidden.

Hi @swirt,

Got it your explanation. I observed that if menus are fieldable at that time its showing in the option.

For example, If you install menu_item_extras module at that time all the menu options are showing.

Kindly confirm is it expected behaviour or not.

Hi @swirt,

How it was working earlier?

Hii @swirt,

I have ceated MR for this. Let me know if any changes are need.

Thanks!

Hi @swirt,

Can you provide the more details on this ?

Hi @swirt,

I have implemented this section. I took the reference from core modules for this. Let me know if any changes are needed.
Thanks!

Hi @swirt,

Can you provide the step to reproduce this ?

Hi @swirt,

I have created MR !31 to resolve this issue. Let me know if any changes are needed.

Thanks!

Hi @pgrandeg,

Extremely sorry for the inconvenience. I missed to add the class in template. Now we can search by name or hexcode. I have committed the latest changes. Kindly look into it.

Thanks!

Hi @swirt,

I have addressed your comment. Thanks!

Hi @swirt,

I have created MR !30 for this issue. Let me know if any changes are needed.
Thanks!

Hi @swirt,

I have created MR !29 for this. I have implemented the 3rd approach for this. I am not sure whether it is correct method to implement this feature. It is not applicable for module and fields.
Let me know if any changes are needed.
Thanks!

Hi @swirt,

Can you please guide in which format data should be displayed?
Thanks!

Hi @swirt,

I have created MR !28 to add the reset button.

I have added the blue colour to filter button so that user can differentiate between two buttons. I have reloaded the form on clicking the reset button this will be helpful for https://www.drupal.org/project/content_model_documentation/issues/3386798 ✨ Make Field Search use query parameters as filter values Active .

Let me know if you have any other idea. Thanks!