- Issue created by @lostcarpark
- Merge request !12Issue #3518341: simplify redirect to thank you page. → (Merged) created by Unnamed author
- 🇮🇳India kulpratap2002
I created an MR for the proposed resolution and tested this, and it is working as designed.
- 🇮🇳India nidhi27
Hii @kul.pratap,
Thanks for working on this. I've just flagged some minor issues that need correcting.
- 🇮🇳India kulpratap2002
@nidhi27 Thank you for reviewing it.
I think the namespace has just been removed by mistake, now I have corrected it also the GitLab pipeline passed with no errors and warnings.
Please review. - 🇮🇳India sagartiwari
I reviewed the recent changes; the changes seem fine, and functionality doesn't break attached screenshot for the same.
Thanks.
-
lostcarpark →
committed 3eef9814 on 1.0.x authored by
kul.pratap →
Issue #3518341: simplify redirect to thank you page.
-
lostcarpark →
committed 3eef9814 on 1.0.x authored by
kul.pratap →
- 🇮🇪Ireland lostcarpark
Thanks everyone for contributing.
@kul.pratap nice work on the fix.
@kul.pratap good catch on the namespace.
@sagartiwari thank you for the review. The screenshots are nice, but slightly overkill. It's usually enough to say you tested the change, and have reviewed the code.
Merged #11 and moving to fixed. Automatically closed - issue fixed for 2 weeks with no activity.