🇮🇳India @kulpratap2002

Account created on 27 September 2024, 7 months ago
#

Recent comments

🇮🇳India kulpratap2002

Created an MR for the solution.
Please review.

🇮🇳India kulpratap2002

The error occurred because the module attempted to call $entity->toUrl('yoast-analysis-analyse') on entities that do not define the 'yoast-analysis-analyse' link template (e.g., field_config). To fix this, I added a condition to check if the link template exists using $entity->getEntityType()->hasLinkTemplate('yoast-analysis-analyse') before calling toUrl().

I have resolved the error.
Please review.

🇮🇳India kulpratap2002

@nidhi27 Thank you for reviewing it.
I think the namespace has just been removed by mistake, now I have corrected it also the GitLab pipeline passed with no errors and warnings.
Please review.

🇮🇳India kulpratap2002

I created an MR for the proposed resolution and tested this, and it is working as designed.

🇮🇳India kulpratap2002

@hoanglv I think you forgot to give the credit.

🇮🇳India kulpratap2002

The MR resolved the error, so moving this to RTBC.

Attaching a screenshot for reference.

🇮🇳India kulpratap2002

@shivam_tiwari Fixed the error, Please review.

🇮🇳India kulpratap2002

@shivam_tiwari I have made the suggested changes, Please review.

🇮🇳India kulpratap2002

I have tried the things below

1. Debugging Class Loading & Autoload Issues

  • Verified Composer autoloading: lando composer dump-autoload -o
  • Checked CKEditor AI Agent’s namespace in composer.json
  • Findings: No immediate resolution; issue persisted when OpenAI was enabled.

2. Checking Dependency Conflicts

  • Checked module dependencies:
    lando drush pm:list --status=enabled | grep openai
  • Investigated if OpenAI modifies dependency injection.
  • Findings:

    OpenAI requires guzzlehttp/guzzle, which could affect service resolution.

    No direct conflicts found, but OpenAI modifies service injection.

3. Testing OpenAI Event Subscriber & Dependency Injection Conflicts

  • Disabled OpenAI’s Event Subscriber in openai.services.yml.
  • Rebuilt cache and tested again (still Issue persisted).
  • Debugged class resolution:
    $resolver = \Drupal::service('class_resolver'); dpm($resolver->getInstanceFromDefinition('Drupal\ckeditor_ai_agent\Form\AiAgentSettingsForm'));
🇮🇳India kulpratap2002

I have fixed the buttons' style and the failing phpcs and cspell jobs.

🇮🇳India kulpratap2002

Also, the placeholder is missing. Instead of the field, it displays the last search text as the placeholder.

🇮🇳India kulpratap2002

kul.pratap made their first commit to this issue’s fork.

🇮🇳India kulpratap2002

Also tested this and working fine for me.

🇮🇳India kulpratap2002

@vladimiraus, I have only changed one file, not 1000 files. All other commits are not done by me, I have only done one commit.

🇮🇳India kulpratap2002

@gurkawal Your changes working as expected and i have tested this on my site, you have created an option to change the "RESET" button text accordinglly to the need of user.

Attaching screenchosts for reference.

Before:

After:

Changes after changing lable:

🇮🇳India kulpratap2002

After changes, the warning is gone I have tested it on my site.
Please review.

🇮🇳India kulpratap2002

@penyaskito, I cannot reproduce this error. I can see the dashboard icon on the Drupal CMS installation, and the dashboard module version is 2.0.0.

Attaching screenshot for reference :

🇮🇳India kulpratap2002

I have added the String Interpolation.
Please review

🇮🇳India kulpratap2002

I have tested this on my site and there are no issues, Gitlab CI has been added to it and a functional test has also been added to this and all the Gitlab pipelines are green which means it doesn't have warnings and errors.
So moving this issue to RTBC.

🇮🇳India kulpratap2002

I’ve addressed the TypeError in ParagraphEditForm::save() by adding a check for $this->rootParent before calling shouldCreateNewRevision().

Since the missing rootParent seems to be caused by a bug in the All Entity Preview module, I opted for a middle-ground approach:

If rootParent is missing, a warning is logged to help with debugging.
The form still triggers a save—defaulting to creating a new revision— to prevent potential data loss.
I didn’t use a hard error (like throwing an exception) to avoid breaking content workflows. Let me know if you'd prefer stricter error handling or further adjustments!

🇮🇳India kulpratap2002

@jaydeep_patel The problem is that the logo's default size is too large. Since CSS is coming from the CDN, we can't adjust the image size, so the option is to change the logo's default size. After changing the logo's size, it looks good.
The other option is to add the width:50% for the class .pico img so that if someone could upload the logo with a different size then it can't affect the logo size.

🇮🇳India kulpratap2002

@tim-diels Thank you for your description of modifiers. I have now created the option to enable modifiers. In the custom replacement character, we should define the character by which we can replace a space. I have also tested that autofill with string modifiers works fine with special characters and symbols it can remove special characters and symbols automatically during autofill.

I have attached the video for reference.

Also, the Gitlab pipeline now passing with no errors or warnings.

Please review.

Thank you

🇮🇳India kulpratap2002

@tim-diels Thanks. Please provide a detailed description of what we want. Should we create a field in the widget where the pattern is defined by the developer? Then, we can create the functionality according to that.

🇮🇳India kulpratap2002

I have created an option for string replacement, attaching screenshots and a video for reference.

Please review.
Thank you

🇮🇳India kulpratap2002

kul.pratap made their first commit to this issue’s fork.

🇮🇳India kulpratap2002

When we installed the module in Drupal 11, the following error occurred:

PHP Fatal error:  Type of Drupal\migrate_wizard\Form\BaseFormFields::$typedConfigManager 
must be Drupal\Core\Config\TypedConfigManagerInterface (as in class Drupal\Core\Form\ConfigFormBase)
This happened because Drupal 11 enforces stricter type-checking. The BaseFormFields class extends ConfigFormBase, which already defines $typedConfigManager as an instance of TypedConfigManagerInterface.

However, in the module's code, the property was declared without a type:

protected $typedConfigManager = NULL;

This meant that when Drupal tried to validate the type against the parent class (ConfigFormBase), it found a mismatch, causing the fatal error.

Please review.
Thanks

🇮🇳India kulpratap2002

kul.pratap changed the visibility of the branch 2.x to hidden.

🇮🇳India kulpratap2002

I have worked on this issue and made this module Drupal 11 compatible.

Before :

After :

Please review.

Thank you.

🇮🇳India kulpratap2002

I also tested this on my local setup with Drupal 11 and PHP 8.3, using the Infinite Scroll module in a View. I also tested it on a mobile emulator, and the scrolling behavior worked as expected, with +1 to #3.

Attaching video for reference.
Thank you.

🇮🇳India kulpratap2002

@liam morland I have applied the dependency injection through constructor property promotion, but for file "UrlEmbedFilter.php" when I am adding constructor property promotion it fails the PHPUnit pipeline that's why I have reverted the changes in it.
Now Please review.
Thanks

🇮🇳India kulpratap2002

I have corrected the menu style for the n-levels and also the menu style for the first level because the theme style is aligned left. According to the theme, I have done the styling.

After:

Please review.

🇮🇳India kulpratap2002

I have tested the changes and they look good to me, after selecting a responsive option from Bootstrap settings, now the table is responsive.
So moving this to RTBC.
Thank You

🇮🇳India kulpratap2002

I have tested the changes and styling looks correct according to theme
Moving this issue to RTBC
Thanks.

🇮🇳India kulpratap2002

@fjgarlin I have tested the MR and It is working with multiple emails also,
So, moving this to RTBC, Attaching screenshots for reference.

Before:

After:

🇮🇳India kulpratap2002

@utkarsh_kumar_singh I have tested the changes but did not notice any difference before and after. Please make the necessary updates. Moving this to "Needs Work”.

🇮🇳India kulpratap2002

I have done the changes now all block types are showing and now we can also create block of these block types in the gutenberg editor.
Attaching screenchot for reference:

Before Changes:/

After Changes

Please review.

Thanks

🇮🇳India kulpratap2002

@benjifisher Thank you for reviewing and for your kind words! I’m excited to contribute to Drupal core, and I appreciate your guidance. Looking forward to making more contributions!
@quietone Thank you merging.

🇮🇳India kulpratap2002

@anybody, the issue is that default_widget = "office_hours_exceptions", but there is no widget with the ID office_hours_exceptions. The widget ID is actually office_hours_exceptions_only, so we can change it accordingly.

🇮🇳India kulpratap2002

"@johnv, as per #8, I have also changed the default_widget to office_hours_default, which solves the problem."
So should i create a MR with this change.
@anybody what are your suggestions?

🇮🇳India kulpratap2002

I have tested the changes

Here are the changes:

UI changes:

Before:

After:

Moving it to RTBC
Thank You

🇮🇳India kulpratap2002

I am uploading the patch because everything is different in 2.0.x-dev compared to 2.0.0-alpha6 there is no option for select and deselect in 2.0.x-dev, which is now a tagged version. This patch resolves the issue correctly, and the select and deselect functionalities are now working fine for 2.0.0-alpha6.
Thank you.

🇮🇳India kulpratap2002

Updated the requirement of the module to also use Voting API 4.x.

Production build 0.71.5 2024