🇮🇳India @kulpratap2002

I have added the String Interpolation.
Please review

I have tested this on my site and there are no issues, Gitlab CI has been added to it and a functional test has also been added to this and all the Gitlab pipelines are green which means it doesn't have warnings and errors.
So moving this issue to RTBC.

It's working fine for me.
Moving this to RTBC.

I’ve addressed the TypeError in ParagraphEditForm::save() by adding a check for $this->rootParent before calling shouldCreateNewRevision().

Since the missing rootParent seems to be caused by a bug in the All Entity Preview module, I opted for a middle-ground approach:

If rootParent is missing, a warning is logged to help with debugging.
The form still triggers a save—defaulting to creating a new revision— to prevent potential data loss.
I didn’t use a hard error (like throwing an exception) to avoid breaking content workflows. Let me know if you'd prefer stricter error handling or further adjustments!

@jaydeep_patel The problem is that the logo's default size is too large. Since CSS is coming from the CDN, we can't adjust the image size, so the option is to change the logo's default size. After changing the logo's size, it looks good.
The other option is to add the width:50% for the class .pico img so that if someone could upload the logo with a different size then it can't affect the logo size.

@tim-diels Thank you for your description of modifiers. I have now created the option to enable modifiers. In the custom replacement character, we should define the character by which we can replace a space. I have also tested that autofill with string modifiers works fine with special characters and symbols it can remove special characters and symbols automatically during autofill.

I have attached the video for reference.

Also, the Gitlab pipeline now passing with no errors or warnings.

Please review.

Thank you

@tim-diels Thanks. Please provide a detailed description of what we want. Should we create a field in the widget where the pattern is defined by the developer? Then, we can create the functionality according to that.

I have created an option for string replacement, attaching screenshots and a video for reference.

Please review.
Thank you

kul.pratap → made their first commit to this issue’s fork.

When we installed the module in Drupal 11, the following error occurred:

PHP Fatal error:  Type of Drupal\migrate_wizard\Form\BaseFormFields::$typedConfigManager 
must be Drupal\Core\Config\TypedConfigManagerInterface (as in class Drupal\Core\Form\ConfigFormBase)
This happened because Drupal 11 enforces stricter type-checking. The BaseFormFields class extends ConfigFormBase, which already defines $typedConfigManager as an instance of TypedConfigManagerInterface.

However, in the module's code, the property was declared without a type:

protected $typedConfigManager = NULL;

This meant that when Drupal tried to validate the type against the parent class (ConfigFormBase), it found a mismatch, causing the fatal error.

Please review.
Thanks

quietone → credited kul.pratap → .

kul.pratap → changed the visibility of the branch 2.x to hidden.

I have worked on this issue and made this module Drupal 11 compatible.

Before :

After :

Please review.

Thank you.

I also tested this on my local setup with Drupal 11 and PHP 8.3, using the Infinite Scroll module in a View. I also tested it on a mobile emulator, and the scrolling behavior worked as expected, with +1 to #3.

Attaching video for reference.
Thank you.

@liam morland I have applied the dependency injection through constructor property promotion, but for file "UrlEmbedFilter.php" when I am adding constructor property promotion it fails the PHPUnit pipeline that's why I have reverted the changes in it.
Now Please review.
Thanks

I have corrected the menu style for the n-levels and also the menu style for the first level because the theme style is aligned left. According to the theme, I have done the styling.

After:

Please review.

I have tested the changes and they look good to me, after selecting a responsive option from Bootstrap settings, now the table is responsive.
So moving this to RTBC.
Thank You

I have tested the changes and styling looks correct according to theme
Moving this issue to RTBC
Thanks.

@fjgarlin I have tested the MR and It is working with multiple emails also,
So, moving this to RTBC, Attaching screenshots for reference.

Before:

After:

@utkarsh_kumar_singh I have tested the changes but did not notice any difference before and after. Please make the necessary updates. Moving this to "Needs Work”.

I have done the changes now all block types are showing and now we can also create block of these block types in the gutenberg editor.
Attaching screenchot for reference:

Before Changes:/

After Changes

Please review.

Thanks

Working it.

@benjifisher Thank you for reviewing and for your kind words! I’m excited to contribute to Drupal core, and I appreciate your guidance. Looking forward to making more contributions!
@quietone Thank you merging.

Working

Before:

After:

So, we need to verify everywhere that the IDs of the field formatter and field widget are correct.

@anybody, the issue is that default_widget = "office_hours_exceptions", but there is no widget with the ID office_hours_exceptions. The widget ID is actually office_hours_exceptions_only, so we can change it accordingly.

"@johnv, as per #8, I have also changed the default_widget to office_hours_default, which solves the problem."
So should i create a MR with this change.
@anybody what are your suggestions?

@anybody i am working on this.

I have tested the changes

Here are the changes:

UI changes:

Before:

After:

Moving it to RTBC
Thank You

I am uploading the patch because everything is different in 2.0.x-dev compared to 2.0.0-alpha6 there is no option for select and deselect in 2.0.x-dev, which is now a tagged version. This patch resolves the issue correctly, and the select and deselect functionalities are now working fine for 2.0.0-alpha6.
Thank you.

Working on it.

Updated the requirement of the module to also use Voting API 4.x.

@jonathanshaw The HostEntity::isAvailableForRegistration method is not present in either the HostEntity.php class or the HostEntityInterface.php. Should we implement this function first to use it in RegisterAccessCheck? Additionally, could you provide some details on what functionality this method should perform?

.

I have fixed the type,Please review
Thanks.

Working on it.

@sourojeetpaul I have added a once function that resolved the problem, and now scroll to bottom screen is also working fine.
Please review.

@dstorozhuk Configration link in info.yml is already present in the forked repo, i have tested it on my local drupal installation the config form of module is working fine, and the changes looks good to me, so moving this to RTBC.
Thank You

@dhruv.mittal Now it is working fine, i have tested, Moving this to RTBC.

GitLab CI does not report PHP_CodeSniffer errors/warnings
Moving this to RTBC.
Thanks.

@tanushree Gupta, the issue persists across all content types, not just article. You have addressed it only for articles, but it remains unresolved for other content types.

@dhruv.mittal , You have only made the changes for a specific page but it should be done for all pages.

kul.pratap → made their first commit to this issue’s fork.

@berdir i have removed the broken route from monitoring_prometheus.routing.yml
Please review
Thank You

@berdir Thanks for your reply.

If MonitoringPrometheusSettingsForm doesn't exist and there is no route defined for it, I can only find a single route for MonitoringSettingsForm and if we remove that then setting form doesn't show. Considering the issue summary mentions removing the broken route, what should be our next step?

I can't reproduce this issue because the routing.yml file contains only one route for the settings form, and I can't find any other separate settings form with a route.

@tim-diels i have done the rebase, Please review
Thank You

Working on it.

"@nikolay shapovalov, I have resolved all the issues, and the pipeline has successfully passed.
Kindly review it.
Thank you!"

@liam_morland, I have now removed the use of DeprecationHelper::backwardsCompatibleCall().
Please review,
Thank you

I have resolved phpcs errors now pipeline is fully green,
Thank you.

Working on it.

@quietone Please review.

@quieton Should I resolve the unresolved issues in the MR as mentioned by you?

@quietone Thank you for the feedback. I will review the comments in the MR and address them.

kul.pratap → made their first commit to this issue’s fork.

@anish.a Should i remove the code below the comment because the reference issue is fixed.

Replaced the "depends" keyword with "dependencies" in default content and removed the old "depends" keyword.

I have improved the menu style.
Please find the attached screenshot for your reference.