- Issue created by @VladimirAus
- Merge request !11515Issue #3480419 by mondrake, smustgrave, catch: Method... → (Open) created by Unnamed author
- 🇦🇺Australia VladimirAus Brisbane, Australia
Thanks @kul.pratap.
Seems like you brought many other changes. Please, only commit changes related to the issue, not 1000 files. - 🇮🇳India kulpratap2002
@vladimiraus, I have only changed one file, not 1000 files. All other commits are not done by me, I have only done one commit.
- 🇮🇳India kulpratap2002
kul.pratap → changed the visibility of the branch 3513598-typeerror-arrayfilter-argument to hidden.
- 🇮🇳India kulpratap2002
kul.pratap → changed the visibility of the branch 3513598-typeerror-arrayfilter-argument to active.
- 🇳🇿New Zealand quietone
@kul.pratap, if you view the MR on GitLab, https://git.drupalcode.org/project/drupal/-/merge_requests/11515/diffs, in the upper right corner you will see the number of changes as,
1000+ files + 4548 − 12566
. I have seen that number of changes when someone was not working on 11.x HEAD. I think this needs a rebase on 11.x. There is help for that at Rebase a merge request → - 🇦🇺Australia jannakha Brisbane!
Further investigation of the issue:
- when Use aggregation is on, fields on the view have "Aggregation settings"
- if Aggregation type set to "Group results together" other form options (Group column and Group columns (additional)) are rendered
- if Aggregation type set to Max/Min/etc other form options are not rendered, but they are being processed by submitGroupByForm() in web/core/modules/views/src/Plugin/views/field/EntityField.php
- if Aggregation type set to other than "group" - EntityField::submitGroupByForm() still processes although EntityField::buildGroupByForm() was never called (only HandleBase::buildGroupByForm() is called)see attached screenshots
- 🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .
- 🇦🇺Australia jannakha Brisbane!
jannakha → changed the visibility of the branch 3513598-typeerror-arrayfilter-argument to hidden.
- 🇦🇺Australia jannakha Brisbane!
jannakha → changed the visibility of the branch 3513598-typeerror-array_filter to hidden.
- 🇳🇱Netherlands Lendude Amsterdam
#12 reads like the solution shouldn't be what I see in the commit in #10, we shouldn't just revert to an empty array to ignore the problem, we should probably fix the submit flow described in #12 right? EntityField::buildGroupByForm() should be called or EntityField::submitGroupByForm() shouldn't not be called? Am I reading that right?
- 🇦🇺Australia jannakha Brisbane!
@lendude exactly! #10 is just treatment of a symptom, not an actual solution to the potentially bigger issue.
If EntityField::buildGroupByForm() is not called, then EntityField::submitGroupByForm() should not be called.
EntityField::submitGroupByForm() expects certain fields to be there (hence the null exception).I haven't found a reason why EntityField::buildGroupByForm() is not called but EntityField::submitGroupByForm() is called on aggregations like min/max/sum/etc, but when it's default (eg group) both EntityField::buildGroupByForm() and EntityField::submitGroupByForm() are called.