Vancouver
Account created on 5 July 2007, about 17 years ago
#

Merge Requests

More

Recent comments

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks for keeping this up-to-date, I would agree with you that the CSS stuff needs to be moved to a separate fix if it's needed.
Issue summary could explain this better

πŸ› | Calendar | Off by a day
πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

joelpittet β†’ changed the visibility of the branch 3443616-off-by-a to hidden.

πŸ› | Calendar | Off by a day
πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Sorry to hear that is happening, I wonder if it's some timezone issue. Can you provide details on reproducing it?

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Made a release beta2 with that change in. Sorry for the delay. This is a duplicate of πŸ› Creation of dynamic properties is deprecated Fixed

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks I did a partial commit of most of the changes but not the permissions change on the route or many of the unused variable removals.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@DD 85 it looks like you are missing an email from that error, so might be a different issue. We are using MR 14

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

This has been a while, I am going to close as fixed and remove MR 22 patch from my sites. If someone chimes in with it still happening we can re-open. Just triaging ;)

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

This looks fixed from #9

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

joelpittet β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

joelpittet β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

joelpittet β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

It looks like it might be the first stable release. I believe we are close for D10 as well.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I don't plan on doing this...

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Generally I don't fix these kinds of issues because they are disruptive to the issue queue existing patches. But there are no issues to conflict with so I commited them. Thank you both for the clean-up.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I've committed the schema file to the dev branch. Thanks for bringing this to my attention!

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks for adding a test to prove the problem exists and fixing my typo!

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thank you both, this issue is indeed major as it is a WSOD for content editors. I have reviewed the patches and tested it out and it works well.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Love this, it what I was asking for in ✨ Provide Layout Templates with a variable to indicate they are in layout mode Closed: duplicate closed it as a dupe

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@ELC, I share your frustration and have personally disabled emails from the update module in favor of using composer audit to catch more serious security issues. However, I believe this discussion belongs upstream in either the Drupal core queue β†’ or the Drupal.org infrastructure β†’ queue.

I have had many discussions with them regarding this frustrating scenario (on Slack). It’s technically a security issue since we (maintainers) are no longer supporting that branch. This means a security issue could arise, and we are indicating that we will not address it on that minor release branch. Additionally, this problem is historical as we never used to have semantic versions, which compounds the issue, as do our branch naming conventions and how Drupal.org creates releases.

Alternatively, we could keep it open on this project as you’re suggesting, but this would be like playing whack-a-mole. Other maintainers might do this accidentally or on purpose, and you would end up chasing them around the queue. That’s why I recommend taking this problem upstream.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

joelpittet β†’ created an issue.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks for the support @irinaz. The release is out. I will create a follow-up for the next release

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Fixed in dev

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

This is a quick fix that should go in soon as possible on a deprecated annotation service

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Yes this has had a deprecation notice for some time. Time to let it go!

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I am going to cut a stable release next.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

This is a bit stale just closing for now

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks for fixing this @cboyden. I have committed it to the dev branch

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks for this, I have committed it to latest dev branch

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Getting a bit closer...

I have it set to PHP 7.4 which did help.

MAX PHP: https://git.drupalcode.org/project/feeds/-/jobs/1864063
Not MAX PHP: https://git.drupalcode.org/project/feeds/-/jobs/1864177
PHP 7.4 explicit: https://git.drupalcode.org/project/feeds/-/jobs/1864327

I will likely disable some tests if they are from third party integrations failing:

  1. Organic groups integration 0 passes, 4 fails, and 3 exceptions
  2. Rules integration 0 passes, 4 fails, and 7 exceptions

I might also create a new release for OG to help here too...

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Changed the template comments to the current template and read the docs on the test dependencies:
https://project.pages.drupalcode.org/gitlab_templates/info/drupal7/#depe...

This is the first one of these I am doing, so we'll see how it goes...

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

joelpittet β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Committed so now compatible with D11

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks @ramil g, I have committed this for the next release.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I agree with @jwilson3 in #66. This should be default to always use the aspect ratio. That said, if there is no value set for this setting (on existing sites) it should remain off as mentioned in #67.

It's unfortunate that the default settings are always merged, this is why we can't have nice things *whines*.

It seems like this should be set the default for new installs and maybe we need an update hook to set it to FALSE for existing sites? Would that work?

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@smustgrave Thanks for taking a look. I believe this is correct in this case but thanks for checking. This case I know the user-input is the source of the problem which is in the issue summary. FYI it looks like this ?tags[0][0] to help read the URL encoding above.

This problem is discrete but part of a bigger set of attack vectors in the parent.

If you could point to a place where I can add a test case, that would really help me out. Otherwise I will take a horrible guess...

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I'm cherry-picking pieces of this attack but one part (for me at least) was this πŸ› TypeError: Illegal offset type in isset or empty in FormValidator->performRequiredValidation() Needs review which I made a follow-up from this for

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@timwood This latest solution seems to check all the boxes. I check if there is a base_path and strip it out only when the destination URL is starts with a starting / (which might be always), then the full URL built has a base_path included (can't seem to get around this without manually building it)

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Adding another related issue #2418219: Deprecate destination URLs that don't include the base path β†’ as I dig into this further. Specifically #2418219-22: Deprecate destination URLs that don't include the base path β†’ from @claudiu.cristea

Or better keep the current behavior: if the destination starts with a slash, it has the base path prefix. No slash, it's the internal path or alias.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@Grevil I tried to do that one yesterday too but 2 problems:

  1. Drush 13 (unlucky) wasn't installing on my Drupal 11 local environment
  2. Looking at the new annotations for the class in core we are overriding I assume it's not going to be as easy as enabling it compatibility (but I need to just try it...), I saw some CRs that gave me pause though
πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks @iler for jumping back to grant the extra access and for being a part of the community for the time you have.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

By fits and spurts... I will close this but if you have any other RTBC's that I missed that you have been using for years (especially a bug fix) I can add you as a co-maintainer to keep things moving.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Closing this as outdated because the event subscriber was removed and replaced in πŸ› Suppress display of regular system menu blocks in Layout Builder RTBC

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Missed this but yes this will require a 9.x only version as 8.x will not be compatible with this change

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks I have merged this in to the 2.x branch

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

There are big changes to plugin discovery and other things so we'll need to test this out before deciding if 1.x or 2.x is the right place for this.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Ran out of time to test and commit this so moving to the next release plan

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Ran out of time to test and commit this so moving to the next release

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I committed a few of the planned and RTBC'd issues. I will close this as the release happens and move to the 1.12 the remaining

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thank you @dougreen for applying my feedback. I have committed this for the next release.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thank you and I appreciate the tests on this as well. I have committed this for an upcoming release of 1.11

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks all for your patience, I have committed this to the dev release for inclusion in the upcoming release.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Closing this as it was released a while ago.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

There is not enough info and I don't know what twig tweak is intended to do, so best just try to do it and describe your experience (success or failure)

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Going to close this as works as designed as per comment #2

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

This sounds like it would conflict with https://www.drupal.org/project/block_class β†’

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I tried to reproduce the error you reported and could not on a stock drupal 10.2 site with the standard install profile, logged in and logged out with the user menu placed in the content area.

If you can provide more details to reproduce we can look at re-opening this issue.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

This doesn't sound like critical, and it is hard to tell if it's a bug or a feature or a support request. I will leave it as a bug request for now and hopefully someone confirm the steps to reproduce

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@jeroendegloire Before squashing this bug I wonder what got it into this case in the first place. Is it possible to put a breakpoint where this is and see what is happening with the pluginid in this case? Maybe this error is highlighting a bigger data problem in your site that should be addressed.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Merging the MR was proving challenging, made a small change and merged it manually. I manually tested it and works with layout builder and block layout and simplifies the code.

Also I reverted the code in πŸ› Duplicate menu blocks appear in Layout Builder choose block form Fixed as it does double the work as it was doing hook_plugin_filter_TYPE__CONSUMER_alter

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I appreciate the intent behind this fix but the problem with coding standard fixes is that they disrupt the fixes in the queue for actual bugs and features and forces them to be re-rolled (unnecessarily).

I would recommend these fixes be fixed when the lines, themselves, are being fixed in active issues, or the very least the same files.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver
πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks @BenStallings I have merged new gitlab CI template.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thank you all I have committed the patch and pushed to the latest dev release. It matches \Drupal\system\Plugin\Block\SystemMenuBlock::blockForm fix to the same problem

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Closing this as fixed again, please open a new issue if you are experiencing problems.

I may revert the commit here in favour of πŸ› Suppress display of regular system menu blocks in Layout Builder RTBC as it looks like it covers more ground than this does.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

This is the issue I got added in, feel free to reach out to them through contact form #2615792: Offer to co-maintain β†’ . I'm not sure who else has the permissions

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I appreciate the intent behind this fix but the problem with coding standard fixes is that they disrupt the fixes in the queue for actual bugs and features and forces them to be re-rolled (unnecessarily).

I would recommend these fixes be fixed when the lines, themselves, are being fixed in active issues, or the very least the same files.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks for everybody who looked into this and sorry for the delay in committing it. I've committed it for next release

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

While I appreciate everybody's effort, I am not confident in the motivation around this change though in the issue summary... .txt file readme's are valid as well. See this for reference:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... β†’

I have no need/motivation to make this change so I will close. If there is an updated rationale around the need for such a change I might consider it in the future.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks @jweowu for fixing the regression without too much changes. It seems like people are happy with this change and it will be in the next release

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

What issues are causing you most problems here? I see 9 RTBC issues 4 of which are bug reports that probably need to be addressed.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Oh darn, I don't have the right permissions to add you, jumped the gun there, I will just give you an RTBC

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Welcome, I haven't used this in years so it's low on my priority list, I am glad to have you aboard Chris!

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I'm seeing this as well, same sequence too

"SQLSTATE[HY000]: General error: 1366 Incorrect string value: '\\xC0\\xA7\\xC0\\xA2%2...' for column 'message' at row 1: INSERT INTO \"watchdog\" (

the error is happening when inserted as a message in watchdog for me.

And is triggered by an exposed form field tacked onto the "All" value:
?name=&order=field_person_lname&research_groups=All&research_interests=All%C0%A7%C0%A2%252527%252522%5C%27%5C%22&sort=desc

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I have committed the changes, I'll see how that affects it all before releasing the changes.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Ok manually merged the MR because it wouldn't let me catch up the MR in the UI... thanks everybody for working on this and for the patch @anairamzap

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

joelpittet β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I will close this as fixed. Thank you for the last patch @berliner and all others who were involved and care about IPE

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I'm using the patch in comment #32, thanks @alexpott for posting it for 10.2

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Probably need this to trigger the handler, cross referencing ✨ Implement Repair 301 Handler Active

Production build 0.69.0 2024