Vancouver
Account created on 5 July 2007, over 16 years ago
#

Merge Requests

More

Recent comments

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Same issue as #41

[warning] Undefined array key "use_page" Profile2Type.php:57
 [warning] Undefined array key "use_page" Profile2Type.php:57
 [warning] Undefined array key "use_page" Profile2Type.php:57
 [warning] Undefined array key "use_page" Profile2Type.php:57
 [warning] Undefined array key "use_page" Profile2Type.php:57
 [warning] Undefined array key "use_page" Profile2Type.php:57

Apparently that key is not saved in 1.7 of profile2

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@very_random_man maybe you can provide more info? We use config_split also. What version and what config was being split? Maybe we can reproduce the error and fix it. Thabks

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Removing anchors as they are automatic now

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Let's use this status to ensure where the question is coming from.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@paulrad, any comment on #6 as to my concerns?

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver
πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

We’ve been using it, thanks for implementing this @john.oltman!

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I reviewed the addition, while it doesn't affect me it could help some scenarios. Thanks again @tonytheferg

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

This looks great, I needed to uninstall/re-install the module to get the new view code after patching (expected). And ran into πŸ› The field access_count has already been deleted and it is in the process of being purged. Active while doing the uninstall, but running cron to clean up the fields worked.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Running
ddev drush cron totally cleaned up that code (locally) just took 4+ min.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Ran into this as well, thanks for posting @tonytheferg

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Hiding the patch in #34 because it's a duplicate of the MR3

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

New plan, stop setting the Return-Path header (and other from/sender headers). Let the sender decide that (which will need to decide how to get it on the envelope for sendmail).

I deprecated the MimeMailFormatHelper::mimeMailHeaders() public method (in case someone is using it because it's public API)

Thoughts?

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

The curly braces around the params looks incorrect, no? * {@param $permission}

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@Grabby I'm running into the same issue. The label needs to be changed on a "form view mode" not a "display view mode". Although it doesn't look configurable (drupal core issue? or needs a module?)

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks for the patch @djeka, it totally works. I'm setting to "Needs Work" because it side-steps the submit handler "submitForm()" and that could cause some issues if some of those checks like 'filterEmptyItems()' doesn't get called.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I'm seeing this as well.

The Update action doesn't close when fallback is in place.

Here's a screenshot tour

Display Fallback

Edit Form

After clicking "Update", fallback not show (Problem this issue is trying to solve)

Cancel, value not updated value

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks @alexpott, usually the test failures would kick it back to needs work, probably a transition to gitlab thing...
Anyways, this patch makes this problem with RFC 2822 Return-Path more problematic
πŸ› RfcComplianceException: RFC 2822 Needs work

Because prior to this, we stripped the return-path out, so it didn't validate it through Symfony. With this patch it's still there, so gets validate and makes that issue a problem for my case as well... (I haven't applied the patch in that one because I'd rather not rely on multiple patches to solve a problem if I can help it).

I still like the solution here, just need to find a way to make everybody happy... and the testbot

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I did a really rough draft CR https://www.drupal.org/node/3418522 β†’ , please edit at a will. I'm not sure how to describe it as "envelope sender" but that is the correct term it sounds strange.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I agree with @iamclean's assessments and answers to @alexpott from #32.

I love this patch because it removes complexity and clears up misconceptions of how this Return-path works and conflated with From (in my case for bounces) and still does the same thing it used to.

I'm using mimemail which makes the -f flag not work because the Return-path is in the <from@example.org> format and never matches the site_mail.

Moved this to a reroll MR, for the bot

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

joelpittet β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

The easiest [return-]path forward is to remove the <> even though it's valid.

I wonder how those other contrib module senders would break without the <> or do they expect it?

I don't want to discount the strong plea in #10 #3257799-10: RfcComplianceException: RFC 2822 Return-Path β†’ and explaination in TR in #3257799-6: RfcComplianceException: RFC 2822 Return-Path β†’ and it really should be solved in core and/or Symfony. I encourage all who is reading this to read through TRs comments (a few times).

There seems to be a core issue that might resolve this that I plan to test out a bit and try to push forward here:
πŸ› Setting the "Return-Path" header doesn't follow RFC 5321 Needs work

#3257799-23: RfcComplianceException: RFC 2822 Return-Path β†’ is the reroll of #3 and my current favourite for RTBCing, but I will leave it not RTBC because it really needs to be addressed in core

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Sorry @timwood, I haven't got a chance to dig into what went wrong with my last MR.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@smustgrave any hints at where tests of this nature should go or could extend?

Test Scenario:

  • External Library + minified included in the URL = Fail as expected
  • External Library + without minified included in the URL = Skipped
πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Patch in #46 totally puts a dent in this for us, we got around 600+ logs directly related to this. Thanks @Berdir.

Thanks @alexpott for taking this upstream as well though it looks like it might have stalled?

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@djsagar Why move it to 11.x-dev it's a bug, did the policy change or doesn't it get applied to the latest release's branch? I maybe missed a memo

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Oh wow @chetan 11, I'll take a look right away! Thanks!

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Ping me on slack if I forget

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Yes I will be happy to have some help. I’d like to get that vertical tab overflow issue in Claro solved.

I’ll add you later today

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Ideally it would be nicer to consider the include invalid cache and rebuild the asset or something...

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Here's a patch to workaround this issue.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Turns out we accidently put the field name as Message instead of message. This problem might be solved as user error, though a validation would be nice, maybe this should be a feature request?

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

While I don't recommend this module (read the project page near the end to see what this means) I am putting it here to show that it's a problem that people are trying to solve.
https://www.drupal.org/project/ckeditor5_allowed_html β†’

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

There is a workaround but maybe undesirable to Add "Source editing" button
<span class>

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

The following attribute(s) can optionally be supported by enabled plugins and should not be added to the Source Editing "Manually editable HTML tags" field: Style (

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

To add to the cases:

We have these tags in our output (from D6 migration) and we want to preserve allowing them but they can’t be added to the Allowed Tags anymore (I'm ok with that actually, as long as I can find a way to add them back in somewhere) and are not accepted in the Source Code allowed tags because other buttons define them

<iframe src allowfullscreen width height frameborder>
<div class>
<ul type class>
<ol type class>
<img title class>
<table class>

We worked around this with a creative MODULE.ckeditor5.yml plugin definitions

MODULE_ckeditor5_allowHtml:
  ckeditor5:
    plugins: [htmlSupport.GeneralHtmlSupport]
    config:
      htmlSupport:
        allow:
          - name: table
            classes: true
          - name: ol
            classes: true
            attributes:
              - key: type
            ...ETC...
  drupal:
    label: Arbitrary HTML support
    elements: 
      - <table class>
      - <ol class type>
            ...ETC...
    conditions: [ckeditor5_table]

But that is because there were buttons and added iframe support with a module for that (but regretting that already)

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Has this ever worked? I can't do that using core's filter either, I think this is a ckeditor5 issue

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I have MR4 a go against 2.x-dev and it works well. I'm RTBCing this as it seems like it's good to go. The upgrade path after that was seamless, thanks all who worked on this.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

We are doing this FTR:

/**
 * Implements hook_update_projects_alter().
 */
function HOOK_update_projects_alter(&$projects) {
  unset($projects['ckeditor']);
}
πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I do believe it's ready to review though, this seems to work and will work in both D10.2 and earlier

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks @DamienMcKenna welcome to the team!

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Because ckeditor4 is a dependency still and we had it disabled (though I really like this module's functionality) we decided to uninstall the module for now until it gets a bit more support for CKEditor 5.

Sounds like the other core issue needs to be fixed as well before this module will function it all it's former glory
πŸ› EditorFileReference should compute a px if a % is specified, even though % is not allowed in HTML5 Needs work

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

No idea if this works in D7 but it might... https://github.com/backdrop-contrib/ckeditor5

It's a big change to move though so we won't explore that and focus on getting these sites upgraded to D10. For the interim we will just mute the error messages for ckeditor. I'm pretty sure there is a hook for that.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Good question we are trying to figure this out in the interim as well.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I'm not a fan of the DOMDocument API, so my apologies for being verbose. If only there was an appendHTML() this would have been a 1 liner.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

https://stackoverflow.com/a/9760247/80281

Use DOMDocument::loadHTMLFile() instead of load(). That's what it has been made for. HTML is not XML.

XML does not know the named entity  . However if you use loadHTML, the XML parser will get the HTML named entities loaded so the error goes away.

See as well: XML parser error: entity not defined.

I think this makes sense, that masterminds/html5 has been in there I believe since Drupal 8.0 release because I remember solving problems with it in the tests prior to twig being included in core.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Further investigation is that it seems to be related to
Html::normalize()
https://www.drupal.org/node/2441811 β†’

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Here's a reroll of #12 with the patch paths relative to the project and for 2.x

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

This sounds like a great feature to bring back what D7 had. I'm moving it to the 2.0.x-dev branch for testing against Drupal 10

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@daften, The only change here is the interface change or did you both run into other changes needed?

This seems like the only change needed to fix this problem:

-  public function getEntity() {
+  public function getEntity(): MenuLinkConfigInterface {

Alternatively you could change to the decorator instead of extending and avoid these kind of bugs. Would that be an OK direction for this issue?

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks for the reroll. We use this in production as it gets past the failed SQL query on aggregation

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

This solved the immediate problem as the decorator pattern (I've implemented in menu_block)
#2968049: Dependency Injection issue β†’ . Probably needs a bit of clean up to remove the generator comments and remove the ignore but it does fix the problem so I'll RTBC

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Thanks @dlross, I took the zip and simplified it a bit and got it working for myself, here it is as a merge request.

The biggest change is I left the regex capture groups alone and changed it to h[23] instead of (h2|h3) which introduces another capture group. And I removed a condition that looked the same as the else {

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

✨ Next level nesting for toc filter Active I added some code here in case someone is looking

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

joelpittet β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I made no headway on this except confirming it's a problem. There is indication here of the problem #1891420: panel page wrong markup β†’ in toc_filter

The gist is that we have the context of it being "text_trimmed" but it's too late and it's already been trimmed. One solution could be to get the original value, strip out the [toc...] knowing the "text_trimmed" context, and re-run the filters (and avoid the infinite loop) but that seems super wasteful...

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@lucaslg Thank you for tackling this! On big piece of the puzzle is in!

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

A fairly obscure but safe quick fix for consideration:
https://www.drupal.org/project/drupal/issues/3406060 πŸ› TypeError: array_keys(): Argument #1 ($array) must be of type array, string given in array_keys() (line 366 of list.module Needs review

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Marking as RTBC, I was about to make the same patch. The related issue is ✨ Provide per-field template suggestions Fixed

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Don't get me wrong, I appreciate the new life you've given to this module, keep up the good work!

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@Snator

I ran into a fatal error due to this change, not totally sure if I should post here or fix multiupload_filefield_widget so I'll do both. πŸ› ArgumentCountError: Too few arguments to function image_insert_content(), 3 passed in multiupload_imagefield_widget/multiupload_imagefield_widget.module Active

ArgumentCountError: Too few arguments to function image_insert_content(), 3 passed in multiupload_imagefield_widget/multiupload_imagefield_widget.module on line 125 and exactly 4 expected in image_insert_content() (line 42 of insert/includes/image.inc).
The website encountered an unexpected error. Please try again later.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Should anybody need to care about their out bound links SSL certs?

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@eiriksm thanks for the reply.

Here's the docs
https://docs.guzzlephp.org/en/stable/request-options.html?highlight=veri...

I'm torn on this turning "verify": FALSE option as it says "don't" in the docs, but we can't control other people's poor SSL practices...

Here's an MR that tries to get the ball rolling and something we can test to see if it solves part of the problem.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@bad.shape.guy I'm guessing your kidding, but regardless it will be 7.100 Each number in X.Y.Z or X.Y in this case is independently incremented. Same with when it was 7.9

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Adding a couple issues here to the Simple fixes

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

@poker10 Thanks yeah likely a dup but note this solution will resolve other similar bugs instead of playing whack-a-mole on each instance.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I just added an isset() "Check$field variable is an object before accessing properties on it."

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Full disclosure, I work with ramil g, and I think this is an elegant solution to providing compatibility to a widget that is effectively a Select widget, just more advanced.

Marking as RTBC because we are using it in production.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

Here will solve some of the deprecation I noticed in my log.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

The notices in #1 I'm seeing when a views page show the body field

    Warning: Undefined array key "on_off" in _tableofcontents_apply_toc() (line 155 of /var/www/html/public/sites/all/modules/contrib/tableofcontents/tableofcontents.module).
    Warning: Trying to access array offset on value of type null in _tableofcontents_apply_toc() (line 155 of /var/www/html/public/sites/all/modules/contrib/tableofcontents/tableofcontents.module).

I found that it was due to 'text_trimmed' because the toc was expanded then truncated.
[toc on_off::hide=0 on_off::automatic=0 on_off::min_limit=5 box::title=On+this+page box::minlevel=2 box::maxlevel=3 box::hide_show=1 box::collapsed=0 header::id_strip::digits=0 header::id_strip::dashes=0 header::id_strip::periods=0 header::id_strip::

Ideally if that is the context, we'd strip out the [toc] and not expand it with settings. I'll try to write a patch for this later.

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I'm quite sure we should have committed my exception from #5, lol

+    // This is likely an AJAX request, return early.
+    if (empty($css)) {
+      throw new \Exception('This should not ever happen, wonder if test produce this helvetica scenario.');
+    }
+

For the uninitiated https://www.youtube.com/watch?v=-Y-yKmzP-4U

πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

I added the ltrim() that core uses in various parts

See prior art:

core/lib/Drupal/Core/Form/ConfirmFormHelper.php
core/modules/migrate/src/Plugin/migrate/process/MenuLinkParent.php
core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
core/modules/views/src/Plugin/views/field/FieldPluginBase.php
πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

My MR above had a side-effect, apparently there are cases where the URL is missing the first slash resulting in:

CRITICAL

Message:   
InvalidArgumentException encountered while initiating SAML login: The user-entered string 'home' must begin with a '/', '?', or '#'. in Drupal\Core\Url::fromUserInput() (line 216 of core/lib/Drupal/Core/Url.php).
Time:   
2023-10-26T12:31:32.458774-07:00
Channel:   
samlauth
Context:   
exception:   
{
    "class": "InvalidArgumentException",
    "message": "The user-entered string 'home' must begin with a '/', '?', or '#'.",
    "code": 0,
    "file": "core/lib/Drupal/Core/Url.php:216",
    "trace": [...

I'll update the code to mitigate against that possibility (though it might be on our end).

Production build https://api.contrib.social 0.61.6-2-g546bc20