Report on Content Edit page

Created on 5 February 2025, 8 months ago

Problem/Motivation

"It shows all broken links in the reports/logs section and on the content edit page, if a link check has been failed". I don't see a report on the Content Edit page.

Steps to reproduce

Check Broken Link Report, Click on Entity Link, Edit Node, No report

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States dorianwinterfeld

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @dorianwinterfeld
  • πŸ‡³πŸ‡΄Norway eiriksm Norway

    Probably a wording from the Drupal 6 or 7 version lingering around.

    Do you have a suggestion on more accurate wording? πŸ€“

  • πŸ‡ΊπŸ‡ΈUnited States dorianwinterfeld

    I understand that this feature did exist in the D7 version of the module. Was is removed? Any chance of adding it back in? I have editors that are asking about it.

  • πŸ‡ΊπŸ‡ΈUnited States anthonyroundtree

    I'd also like to see this feature return. I'm getting the same inquiries from users about this going away and wanted it to be brought back.
    https://www.drupal.org/project/linkchecker/issues/3471233 ✨ Displaying broken links on nodes Active

  • πŸ‡³πŸ‡΄Norway eiriksm Norway

    Sounds like a great idea, then!

    Merge requests welcome!

  • πŸ‡¨πŸ‡¦Canada joelpittet Vancouver
  • πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

    Went to town a bit on the Issue summary, hope that helps, not sure to move this to 3.x or not, but 2.1.x to start @eiriksm correct this if I am wrong.

  • @joelpittet opened merge request.
  • πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

    The tests were written by AI, but I reviewed them, manually tested the code, and went through a few iterations to be transparent about the process.

    Here is a screenshot of the manual test in a production D10 site.
    β†’

  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    Just a hunch

  • πŸ‡ΊπŸ‡ΈUnited States anthonyroundtree

    Maybe I'm doing something wrong, but reviewing this through drupalpod and not seeing any changes.

  • πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

    @anthonyroundtree that's a good way to test. The trick is you need to create content with bad links, run cron a few times to get it, look to see it's on the broken link report, then go edit that content and it should show in a warning at the top. (that is the hope)

    Though I thought drupalpod had stopped working or maybe I am confusing it.

  • πŸ‡ΊπŸ‡ΈUnited States anthonyroundtree

    Thanks.

    Well, then it's failing. I'm intentionally creating broken links and they are not appearing on the edit page.
    Steps to reproduce

    1. Go to Structure -> Basic Page -> Manage Fields
    2. Edit Body and enable link checker and Save all changes
    3. Create basic page
    4. Enter content and add links that are intentionally broken links
    5. Save page
    6. Run cron
    7. Click on Edit
    8. Result - broken links do not appear

    Just in case I missed something I took the next steps

    1. Go to Reports -> Broken links
    2. If broken links appear then stop
    3. If broken links do not appear, go to /admin/config/content/linkchecker
    4. Under General Settings, changed the settings to Internal and External links
    5. go to Maintenance and I pushed both Reanalyze and Clear link data buttons
    6. Save
    7. Review Broken links report
    8. Select basic page with reported links
    9. Reports do not show on the Edit page
  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    @anthonyroundtree , there could be many reasons. Can you please provide some details into your setup? Is your environment using docker? are you using varnish with a reverse proxy? Has your linkchecker view filters been changed manually?

  • πŸ‡ΊπŸ‡ΈUnited States anthonyroundtree

    @joseph.olstad
    I'm actually using drupalpod for testing with a standard setup. It is running core 11.1.8. The image version is drupalforge/drupalpod:latest.

  • πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

    @anthonyroundtree it sounds like you did all the right things, thanks for detail your test! I am quite puzzled, I will try those too on a fresh DDEV instance later this evening.

    I have functional tests in there too prove it's working but maybe they are wrong.

    Is there a way in DrupalPod to tell if the Merge Request (MR) is applied to linkchecker?

  • πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

    @anthonyroundtree again appreciate you laying out the steps in #14.
    I just tried it out on a fresh Drupal 11 site using DDEV, following your steps from #14 #3504635-14: Report on Content Edit page β†’ with this MR applied.

    Here are the screenshots I captured during testing:

    Before running cron β€” link hasn’t been picked up yet:
    β†’

    After running cron β€” broken link appears in the report:
    β†’

    Node edit form now shows warning message as expected:
    β†’

    It looks like the patch/MR may not have been applied in your DrupalPod session. If you’re able to confirm whether it was, I’d be happy to compare setups β€” or feel free to share your DrupalPod steps and I’ll try to reproduce that way.

    One thing I realized while testing, it would really be nice to get this feature in as well: ✨ Allow to check link status on demand Needs work maybe on save we can trigger the checks (follow-up issue to that one and this one)

  • πŸ‡ΊπŸ‡ΈUnited States anthonyroundtree

    Can you resend the image for confirmation?

  • πŸ‡ΊπŸ‡ΈUnited States anthonyroundtree

    Just want to follow up, but drupalforge may not be checking the links consistently. When it does check links I can confirm that it seems to be working.

Production build 0.71.5 2024