- Issue created by @dorianwinterfeld
- π³π΄Norway eiriksm Norway
Probably a wording from the Drupal 6 or 7 version lingering around.
Do you have a suggestion on more accurate wording? π€
- πΊπΈUnited States dorianwinterfeld
I understand that this feature did exist in the D7 version of the module. Was is removed? Any chance of adding it back in? I have editors that are asking about it.
- πΊπΈUnited States anthonyroundtree
I'd also like to see this feature return. I'm getting the same inquiries from users about this going away and wanted it to be brought back.
https://www.drupal.org/project/linkchecker/issues/3471233 β¨ Displaying broken links on nodes Active - π³π΄Norway eiriksm Norway
Sounds like a great idea, then!
Merge requests welcome!
- π¨π¦Canada joelpittet Vancouver
Went to town a bit on the Issue summary, hope that helps, not sure to move this to 3.x or not, but 2.1.x to start @eiriksm correct this if I am wrong.
- @joelpittet opened merge request.
- π¨π¦Canada joelpittet Vancouver
The tests were written by AI, but I reviewed them, manually tested the code, and went through a few iterations to be transparent about the process.
Here is a screenshot of the manual test in a production D10 site.
β - πΊπΈUnited States anthonyroundtree
Maybe I'm doing something wrong, but reviewing this through drupalpod and not seeing any changes.
- π¨π¦Canada joelpittet Vancouver
@anthonyroundtree that's a good way to test. The trick is you need to create content with bad links, run cron a few times to get it, look to see it's on the broken link report, then go edit that content and it should show in a warning at the top. (that is the hope)
Though I thought drupalpod had stopped working or maybe I am confusing it.
- πΊπΈUnited States anthonyroundtree
Thanks.
Well, then it's failing. I'm intentionally creating broken links and they are not appearing on the edit page.
Steps to reproduce- Go to Structure -> Basic Page -> Manage Fields
- Edit Body and enable link checker and Save all changes
- Create basic page
- Enter content and add links that are intentionally broken links
- Save page
- Run cron
- Click on Edit
- Result - broken links do not appear
Just in case I missed something I took the next steps
- Go to Reports -> Broken links
- If broken links appear then stop
- If broken links do not appear, go to /admin/config/content/linkchecker
- Under General Settings, changed the settings to Internal and External links
- go to Maintenance and I pushed both Reanalyze and Clear link data buttons
- Save
- Review Broken links report
- Select basic page with reported links
- Reports do not show on the Edit page
- π¨π¦Canada joseph.olstad
@anthonyroundtree , there could be many reasons. Can you please provide some details into your setup? Is your environment using docker? are you using varnish with a reverse proxy? Has your linkchecker view filters been changed manually?
- πΊπΈUnited States anthonyroundtree
@joseph.olstad
I'm actually using drupalpod for testing with a standard setup. It is running core 11.1.8. The image version is drupalforge/drupalpod:latest. - π¨π¦Canada joelpittet Vancouver
@anthonyroundtree it sounds like you did all the right things, thanks for detail your test! I am quite puzzled, I will try those too on a fresh DDEV instance later this evening.
I have functional tests in there too prove it's working but maybe they are wrong.
Is there a way in DrupalPod to tell if the Merge Request (MR) is applied to linkchecker?
- π¨π¦Canada joelpittet Vancouver
@anthonyroundtree again appreciate you laying out the steps in #14.
I just tried it out on a fresh Drupal 11 site using DDEV, following your steps from #14 #3504635-14: Report on Content Edit page β with this MR applied.Here are the screenshots I captured during testing:
Before running cron β link hasnβt been picked up yet:
βAfter running cron β broken link appears in the report:
βNode edit form now shows warning message as expected:
βIt looks like the patch/MR may not have been applied in your DrupalPod session. If youβre able to confirm whether it was, Iβd be happy to compare setups β or feel free to share your DrupalPod steps and Iβll try to reproduce that way.
One thing I realized while testing, it would really be nice to get this feature in as well: β¨ Allow to check link status on demand Needs work maybe on save we can trigger the checks (follow-up issue to that one and this one)
- πΊπΈUnited States anthonyroundtree
Can you resend the image for confirmation?
- πΊπΈUnited States anthonyroundtree
Just want to follow up, but drupalforge may not be checking the links consistently. When it does check links I can confirm that it seems to be working.