🇳🇴Norway @eiriksm

Thanks for the patch, that looks very correct. 👌🌈

However, the steps to reproduce seem inaccurate? And the suggested fix does not align with what is the proposed solution? Based on the content of the text it seems to be generated by some LLM, so not surprised about this inaccuracy 🤓

For sure we have tests that covers exactly the steps to reproduce. So I feel pretty confident that is not the case. Which makes also the patch and issue hard to QA and verify.

In addition. Once we have actual accurate steps to reproduce it should be easy to add a test for this as well.

So the status is "needs work" based on

- needs steps to reproduce
- needs test
- needs issue summary update

Thanks for the contribution! 🚀

Amazing, thank you 🙏😍

Pretty sure this can be closed after #[3410282] was merged

The MR is now up to date and running tests.

It seems to still fail, like mentioned above 🤓

eiriksm → created an issue.

Currently working with Drupal 10

eiriksm → made their first commit to this issue’s fork.

This looks pretty good ♥️🚀

Would need to write some tests for this. Is this something you can fix up in the Mr so you think? 🤓

eiriksm → created an issue.

Awesome thanks 🙏

eiriksm → created an issue.

eiriksm → created an issue.

eiriksm → created an issue.

eiriksm → created an issue.

Great work, thanks everyone

If someone could convert this into a merge request, that would be a great start.

It also would be nice to add some tests here. I hope that should be fairly easy, adding to the existing coverage.

Finally. A bit unsure if showing a 502 is more helpful than showing it was never checked. Don't we have other codes for such errors in the codebase already? 🤓

eiriksm → created an issue.

For some reason the merge button had some hiccups here, but I think this is merged now?

eiriksm → made their first commit to this issue’s fork.

eiriksm → created an issue.

@vladimiraus I just checked your permissions, and you should have access?

I don't know which merge thing you checked, but I usually use the one on the bottom of the issue form (under the commit credit and stuff). Does that not work either?

eiriksm → created an issue.

eiriksm → created an issue.

Tagged 2.0.1

https://www.drupal.org/project/linkchecker/releases/2.0.1 →

eiriksm → created an issue.

eiriksm → created an issue.

eiriksm → created an issue.

eiriksm → created an issue.

eiriksm → made their first commit to this issue’s fork.

eiriksm → made their first commit to this issue’s fork.

eiriksm → made their first commit to this issue’s fork.

eiriksm → made their first commit to this issue’s fork.

eiriksm → created an issue.

eiriksm → made their first commit to this issue’s fork.

eiriksm → made their first commit to this issue’s fork.

eiriksm → created an issue.

eiriksm → created an issue.

eiriksm → made their first commit to this issue’s fork.

Still needs steps to reproduce and tests ✌️

eiriksm → created an issue.

eiriksm → made their first commit to this issue’s fork.

eiriksm → created an issue.

This code makes sense and all, but seems strange how you would find yourself in such a situation.

Would at least need steps to reproduce, and ideally a test as well

Thanks. Released https://www.drupal.org/project/ajax_requirement/releases/2.0.3 →

eiriksm → created an issue.

eiriksm → created an issue.

eiriksm → created an issue.

eiriksm → made their first commit to this issue’s fork.

Great! thanks! ♥️🚀👌

amazing! ❤️

Released 2.0.2 which should be compatible just now. Thanks!

eiriksm → made their first commit to this issue’s fork.