For some reason the merge button had some hiccups here, but I think this is merged now?
@vladimiraus I just checked your permissions, and you should have access?
I don't know which merge thing you checked, but I usually use the one on the bottom of the issue form (under the commit credit and stuff). Does that not work either?
Still needs steps to reproduce and tests ✌️
eiriksm → made their first commit to this issue’s fork.
This code makes sense and all, but seems strange how you would find yourself in such a situation.
Would at least need steps to reproduce, and ideally a test as well
Thanks. Released https://www.drupal.org/project/ajax_requirement/releases/2.0.3 →
Great! thanks! ♥️🚀👌
amazing! ❤️
Released 2.0.2 which should be compatible just now. Thanks!
In this MR I also added config schema (this is in theory required to run tests out of the box).
However, when adding a schema for the test mode, the error no longer happens in the tests. So I pushed a commit where I temporarily disabled the strict schema check, and demonstrated that the tests will catch the bug: https://git.drupalcode.org/issue/vipps_recurring_payments-3509640/-/jobs...
Later it was re-enabled, and the latest test run includes both the schema fix, added back strict schema for tests, and the actual fix for the config class
Thanks, awesome!
Sounds like a great idea, then!
Merge requests welcome!
What you committed is more or less exactly what I have been implementing only in custom code. So this is actually perfect!
Thanks!
Oh my concerns are more towards usability and confusion.
If I have a colleague, for whom it will be faster to click a couple buttons on stage or prod and then get a PR out of it. Great. They can add a token to their user
The administrator of my client website however. They will see the words access token and think this looks like an error or is noisy. They don't have a GitHub user. Heck, they don't know what GitHub is
So it's rather easy for me to fix this in custom code, but I wanted to hear if this was a scenario the actual contrib project wanted to cater for directly 🤓
Created https://www.drupal.org/project/linkchecker/issues/3506219 📌 Create tests for showing the translated entity link Active for the tests
Alright looks simple enough. Let's do tests in a follow up
Thank to everyone who worked on this! ♥️🚀
Could someone provide exact steps to reproduce from a clean install of Drupal in the summary please? 🤓✌️
Oh there are steps here now, awesome!
That should make it trivial to write a test then!
There are still no clear steps to reproduce this issue, and still no tests 🤓✌️
I will not merge this since d9 is legacy, but leaving it here for being able to patch if necessary
That being said, it's still possible to trigger in other ways than with a constant. It was just randomly how I discovered it back in the day (can't even remember reporting it hehe time flies)