- Issue created by @ashbeeb
- 🇩🇪Germany marc.bau
What links are never checked?
If non-existend you should get an error. e.g. host name lookup failed.
- 🇺🇸United States eahonet
Any updates to this one @ashbeeb ? I have a non-existent url (a .com) that continues to show "Last Checked" as "Never".
- 🇦🇪United Arab Emirates schlaukopf Somerville, NJ, USA
I was able to reproduce the same error and found that the issue occurs with domains that don’t exist. Guzzle was unable to resolve the host, which resulted in a ConnectException being thrown instead of a RequestException. This patch addresses the issue by handling TransferException, which will cover both cases.
- 🇮🇳India divya.sejekan
The Patch is applied successfully. Links never checked issue looks resolved , now the links are verified and related error messages . Tried with bunch of different types of URLS.
Steps to reproduce:
1. Make a basic page with links to http://nonexistentdomainasdf.com and http://eia.gov
2. Re-scan to add links to list
3. Run cron
4. See that links are still listed as "Never" checkedRTBC++
- 🇳🇴Norway eiriksm Norway
Great work, thanks everyone
If someone could convert this into a merge request, that would be a great start.
It also would be nice to add some tests here. I hope that should be fairly easy, adding to the existing coverage.
Finally. A bit unsure if showing a 502 is more helpful than showing it was never checked. Don't we have other codes for such errors in the codebase already? 🤓
- First commit to issue fork.