immaculatexavier → created an issue.
Done the below Fixes for PHPUnit 10:
- Removed usage of $this in static providerCanLoginWithoutTfa().
- Replaced $this->equalTo() with Assert::equalTo() from PHPUnit\Framework\Assert.
- Replaced $this->stringContains() with Assert::stringContains().
- Used UnitTestCase::createStub(TranslationInterface::class) for generating translation stubs inside static context.
Needs review.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
Hi @quietone,
Enabled Drupal.NamingConventions.ValidEnumCase sniff in core/phpcs.xml.dist. Verified the change by running PHPCS on a test enum file with intentional violations—errors were correctly reported.
Do you need any further actions?
immaculatexavier → made their first commit to this issue’s fork.
Hi,
Now added the test case testSwitchLangcodeWithoutExistingTranslation() to the existing ContentTranslationLanguageChangeTest class. This expands the current test coverage instead of creating a new test class, aligning with the feedback to reuse existing tests where possible. The test validates the fallback logic when switching the langcode on a node that doesn't yet have a translation.
Kindly let me know if any further adjustments are needed.
Hi all,
I've added a functional test to cover the scenario mentioned in this issue. The test checks that when a user creates an article node in German and then switches the language to English using the language selector on the edit form, it saves without any errors.
This covers the exact steps described in the issue and ensures the language switch functionality works as expected. Happy to make adjustments if needed.
Thanks!
immaculatexavier → made their first commit to this issue’s fork.
I have added logs for deleting and adding terms.
Kindly find the screenshot
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
I've adjusted the render structure to ensure the wrapper is applied correctly around the link as expected. Let me know if you see anything else that needs attention.
Before Fix:
https://www.drupal.org/files/issues/2025-07-01/Before%20Fix.png →
After Fix:
https://www.drupal.org/files/issues/2025-07-01/After%20Fix.png →
immaculatexavier → made their first commit to this issue’s fork.
Rerolled against 3.3.x
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → changed the visibility of the branch 3532469-documentation-mentions-drupal to hidden.
immaculatexavier → made their first commit to this issue’s fork.
Created MR in accordance to the Proposed resolution against 11.x.
immaculatexavier → made their first commit to this issue’s fork.
Removed Sam Becker (Sam152) from the MAINTAINERS.txt file under both:
- Content Moderation
- Workflows sections
Created MR.
Yet to inform Core Committers Slack channel . Can you please share me the Core Committers Slack channel ID.
immaculatexavier → made their first commit to this issue’s fork.
Created MR against 11.x
immaculatexavier → made their first commit to this issue’s fork.
- Removed redundant check for Settings::get('update_free_access') from UpdateKernel::handleAccess(), since this logic is already handled in DbUpdateAccessCheck::access().
- Centralized access control logic for update.php in DbUpdateAccessCheck to follow the single-responsibility principle.
- Updated the docblock in DbUpdateAccessCheck::access() to clearly docu
ment that it is now the sole authority for handling update_free_access and permission-based access decisions.
This cleanup avoids duplication, improves maintainability, and makes access logic more predictable.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
Rerolled and Created MR against Seven 1.0.x
immaculatexavier → made their first commit to this issue’s fork.
Updated issue summary
immaculatexavier → made their first commit to this issue’s fork.
Rerolled and created MR.
Sorry i didn't notice as this has Novice issue.
Created MR for the same.
Hi
Rerolled and created MR
webform_submission is now included in getSupportedEntityTypes(), enabling proper logging.
The settings form gracefully handles additional entity types without assuming label() exists, preventing the InvalidArgumentException.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
Rerolled and created MR against #3
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
Fixed the merge conflicts.
I've updated Step 2: Prepare the new signature in the documentation as part of this change. Specifically, I replaced the broad phpcs:disable Drupal.Commenting with targeted phpcs:ignore annotations for:
Drupal.Commenting.DocComment.TagGroupSpacing
Drupal.Commenting.FunctionComment.ParamNameNoMatch
This ensures that we only suppress the necessary sniffs and maintain all other coding standards. The change is in line with the recommendations discussed in #3531685 Proposed Resolution
https://www.drupal.org/about/core/policies/core-change-policies/how-to-d... →
Replaced the broad phpcs:disable Drupal.Commenting with targeted phpcs:ignore statements (TagGroupSpacing and ParamNameNoMatch) to suppress only the necessary coding standard warnings when adding new method parameters, improving code clarity and avoiding unintentional suppression of unrelated PHPCS checks.
immaculatexavier → made their first commit to this issue’s fork.
Create MR against 2.x
https://git.drupalcode.org/project/term_merge/-/merge_requests/33
immaculatexavier → made their first commit to this issue’s fork.
Created MR against #2
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
Working on PHPStan fixes.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → created an issue.
immaculatexavier → changed the visibility of the branch 3517902-dialogclass-is-deprecated to hidden.
#9 is the Merge Request against 6.3.x
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
Rerolled against the patch #13 🐛 Views keyword search bug when using node revisions Active and created Merge Request
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
Rerolled and Created MR for the same against #7 and #9
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.
immaculatexavier → made their first commit to this issue’s fork.