- Issue created by @joachim
- First commit to issue fork.
- ๐ฎ๐ณIndia immaculatexavier
- Removed redundant check for Settings::get('update_free_access') from UpdateKernel::handleAccess(), since this logic is already handled in DbUpdateAccessCheck::access().
- Centralized access control logic for update.php in DbUpdateAccessCheck to follow the single-responsibility principle.
- Updated the docblock in DbUpdateAccessCheck::access() to clearly docu
ment that it is now the sole authority for handling update_free_access and permission-based access decisions.
This cleanup avoids duplication, improves maintainability, and makes access logic more predictable.
- ๐บ๐ธUnited States smustgrave
How was it determined this was the one to be removed? Summary should mention.
- ๐บ๐ธUnited States xjm
Since this is also changing the behavior of this access checker, I'd also expect to see documentation of research into any other uses/callers.
- ๐บ๐ธUnited States xjm
Also, just as a reminder, our policy requires documenting whenever AI is used to help craft code or documentation โ .
- ๐ฌ๐งUnited Kingdom joachim
> The added documentation is very wordy and duplicates the code in prose without adding information, unfortunately. It does not really add value.
Yes, I wondered whether it was AI-generated too. Please don't do that.
- ๐ฎ๐ณIndia divyansh.gupta Jaipur
Since there is no reply from @immaculatexavier from long time,
I am working on it!! - ๐ฎ๐ณIndia divyansh.gupta Jaipur
Iโve updated the issue summary to reflect the decision to keep the update_free_access check in DbUpdateAccessCheck::access(), since thatโs the dedicated access checker for the update routes. It makes sense for that logic to live there, rather than duplicating it in UpdateKernel::handleAccess().
I also added a docblock to explain how the access check works now. Please review and let me know if anything needs to be adjusted further.
- ๐บ๐ธUnited States smustgrave
Re-iterating #7
Also, just as a reminder, our policy requires documenting whenever AI is used to help craft code or documentation.