Converted patch into MR, also added test to verify this,
Please review!!
divyansh.gupta → changed the visibility of the branch 2.x to hidden.
divyansh.gupta → changed the visibility of the branch 3269933-inconsistent-moderation-state to hidden.
divyansh.gupta → changed the visibility of the branch 3269933-8.1.x-inconsistent-moderation-state to hidden.
Working on tests.
Please review!!
Resolved the merge conflicts.
Please review
divyansh.gupta → changed the visibility of the branch 2938731-order-total-range to hidden.
Working on it!!
Re-rolled it @heddn
divyansh.gupta → made their first commit to this issue’s fork.
Ok @smustgrave,
Seen many people do such issue so thought anyone can do these, will keep that in mind from next time!!
Applied the changes and the issue is fixed for me,
The changes also looks good to me,
Thus moving this to RTBC
Please resolve merge conficts.
I have reviewed the issue and now the flagged prompts are also coming in logs.
The changes looks good to me, also the pipeline is green with no merge conflicts.
Thus moving this to RTBC!
Removed yoroy from maintainers.txt,
Please review!
Was able to reproduce the error, also resovled it.
Before:
After:
Please review!!
Working on it!!
Working on it!!
Rebased it @quietone
divyansh.gupta → made their first commit to this issue’s fork.
Rerolled the MR,
Please review!!
Working on it!!
This was happening because $classResolver wasn’t declared as a property before being assigned in the constructor. I’ve added the missing property declaration to fix it properly.
Please review!!
Working on it
Rerolled successfully,
Please review!!
Rebased, and also resolved the pipeline errors,
Please review!!
Working on the rebase.
Working on the rebase.
yes i used better exposed filter option only but was unable to reproduce the issue, the RESET button was working absolutely fine for me.
@ahmad khader,
I tried reproducing the error as per the steps you mentioned but the reset button is working absolutely fine for me, but leaving this to active if anyone else is able to reproduce this.
Working on it!!
The data-action-id attribute is correctly rendered on each bulk action button, allowing frontend code to identify which action was triggered. Matches the intent of the issue. Moving to RTBC.
Before:
After:
Reviewing this
Sorry @bohart, for not testing and directly pushing the patch as MR, now i have worked and made all tests pass, also here is an screenshot proving that i have successfully made the key selection using key module.
Please review!!
@bohart,
I have resolved the pipelines errors and now it's all green,
Also i did not test the changes because it thought these were already tested and only the patch was to be converted to MR, do you want me to test the changes?
Thank you!!
Converted patch into MR, also done some changes manually as patch was not applying directly.
Please review!!
Provided the patch as MR,
Please review!!
Working on it
Working on it!
Added typehints, resolved merge conflicts, updated change record.
Please review!!
Working on it!!
Updated the details about timestamp,
Please review!!
Working on it!!
Rebased and resolved all merge conflicts.
Please review!!
Working on the rebase!!
Converted the patch to MR, but could not write proper tests.
Please review!!
Working on it!!
Created a new MR against 6.0.x also there are no merge conflicts or any extra changes,
Please review!
Working on it!!
Made the changes
Please review!!
working on it!!
Working on it!!
Created an MR for this issue!!
Please review!!
Working on it!!
I added RouteNotFoundException to the list of caught exceptions in recordEntity(), so it now safely skips saving the URL if the route doesn't exist.
Please review!!
Working on it!!
Made some changes in tests, now the pipeline's all green,
Please review!!
Working on it!!
Fixed the MR,
Please review!!
Working on it!!
I have successfully rebased the branch, so if somebody can review this!
Working on it!!
Resolved merge conflicts, thus moving back to NR!!
divyansh.gupta → made their first commit to this issue’s fork.
I’ve uploaded a merge request for review.
The MR adds a safeguard to avoid calling load(NULL) when $fid is not set.
While I couldn’t reproduce the issue locally, the patch avoids a fatal error in such cases without introducing side effects.
Please review!!
Converted the patch to MR,
please review!!
Working on it!!
Rebased the branch against 2.0.x.
Please review!!
Working on it!!
Also when i am going to the commit fc5be3ffdcca2be09754da0e82cd16c211ae2f6c then i am able to reproduce the phpunit errors on my local but there is an latest commit which is reverting this commit that is why MR is coming empty should i reset the forked branch to this commit Issue #3437567: Add a template for a key value pair
Thank you!!
Hello @japerry,
When i rebased the MR to check if there any other tests that might cause errors in future, the MR became empty and it is not showing any changes that are to be committed, also i cloned the repo and ran pipeline on local but it is passing without any error.
So could you please help here.
Working on this!!
I’ve been trying to reproduce this issue but wasn't able to.
Here’s what I did:
- Created a media item (video) with a thumbnail.
- Manually set the thumbnail__target_id field to NULL directly in the database.
- Cleared the cache and then tried editing and deleting that media item — everything worked fine, no errors showed up.
- So far, I haven’t been able to trigger the error (InvalidArgumentException: Field is unknown). Maybe this has already been fixed in recent updates, or I might be missing a specific step.
If anyone has more detailed steps to reproduce this issue, I’d really appreciate it!
Thanks!
Working on it!!
Rebased the patch and converted into MR since patches are deprecated.
Also the steps to reproduce are already present in the issue summary.
Please review!!
Now the entire pipeline is green,
Please review!!
Working on it!!
ok working on the PHPunit tests!!
Applied the patch and added a MR for this issue!!
Please review!!
Working on it!!
Fixed the composer, phpstan pipelines,
Please review!!
Hello @scott_euser!!,
Thanks for the feedback!
You are correct, the issue was present on multiple steps. I have reviewed the entire form logic in EmailOTPCheck.php and confirmed that my MR addresses the button order in every relevant step.
Like:
-->The fix has been applied to Step 2 (fapiOtpVerificationPageTwo).
-->The fix has been applied to Step 3 (fapiSetPasswordPageThree).
-->Step 1 and Step 4 of the form do not contain a "Back" button, so no changes were needed there.
Also i have made the pipeline green as there were some PHPCS related issues, also if you need changes in any particular file or step that i missed bymistake, then please guide me through it!!
Thanks you!!
The problem was occurring because the back button was defined before submit button, so correcting the order fixed the issue for me,
Please review!!
Working on it!!
Working on it!!
I tried to reproduce this issue but could not reproduce this using domain access,
So could you please provide steps to reproduce, so i did not convert this patch into MR!!
Thank you
Working on it!!
I was able to reproduce this issue!!
Before applying the patch, there was a missing schema warning for settings.show_cookies_settings_button when checked using the Config Inspector module.
After applying the patch and clearing cache, the warning is gone, and everything is working as expected..
Changes looks good to me thus moving this to RTBC.
Reviewing this!!
I have reviewed the MR!3 and the changes looks good to me as it will make the placeholder translatable,
Thus moving this to RTBC!!
The original error no longer appears, which is great but it seems that the “Lock field values” checkbox is missing when editing a user profile. This may have been unintentionally affected by the recent changes.
So moving this issue back to NW, so that someone can resolve this bug caused!!
Tested the latest changes and checked that the fix handles the issue as expected. There are no errors thrown, and the behavior aligns with the discussion in the issue summary. The test coverage looks good too. Thus marking this as RTBC.
Tested the patch and it works well. The label updates appropriately based on the type of page you're viewing and falls back to "Local Tasks" when needed. This is a nice improvement for usability and should make things clearer for non-technical users. Marking this RTBC.
I am still able to see this error on /oci-cart page.
Error:
InvalidArgumentException: The controller for URI "/oci-cart" is not callable. in Drupal\Core\Controller\ControllerResolver->getControllerFromDefinition() (line 53 of /app/web/core/lib/Drupal/Core/Controller/ControllerResolver.php).
Thus moving this to Needs Work!!
I was able to reproduce this issue, and this MR resolved the issue for me
After:
Thus moving this issue to RTBC!!
Actually the MR was pointing wrong target branch, also rebased the branch,
Please review!!
I was able to reproduce this issue and this MR solved the issue for me.
Before:
After:
Ready for RTBC, but there are some merge conflicts, thus moving it back to Needs Work!!
Marking this as RTBC. The MR ensures that the JS file is only attached for authenticated users, as expected. It’s a straightforward change and has already been confirmed to work correctly by others. Looks good to go.