Jaipur
Account created on 27 September 2024, 8 months ago
#

Merge Requests

More

Recent comments

🇮🇳India divyansh.gupta Jaipur

The issue is present in the 1.0.0 and 1.0.1 tags but not on the master branch. This is because the tags are not in sync with the latest updates on the master branch, which results in the missing route error.

Since tagging new releases or updating existing ones requires maintainer access, this will need to be addressed by a maintainer.

🇮🇳India divyansh.gupta Jaipur

I have added the code to add configuration checkpoint when an recipe is activated via project browser,
Please review.

🇮🇳India divyansh.gupta Jaipur

I was able to reproduce this issue and this MR applied succesfully for me and resolved the issue.
Before:

After:

The changes looks good to me thus moving this to RTBC+!

🇮🇳India divyansh.gupta Jaipur

I was able to reproduce this issue and this MR solved the issue for me,
Thus moving this to RTBC!!

🇮🇳India divyansh.gupta Jaipur

I have added the option to import using drush command.
Please review.

🇮🇳India divyansh.gupta Jaipur

Hello @alex.bukach,
The issue has been fixed and the MR has been merged but you forgot to add credits, can you please look into this and provide the appropriate credits as the credits keeps us motivated.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3521347-synonyms-list-field to active.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3521347-synonyms-list-field to hidden.

🇮🇳India divyansh.gupta Jaipur

This adds a check for $item->entity in getSynonyms() to prevent fatal errors when a referenced entity is missing. It ensures safer handling of broken references without affecting existing functionality.

🇮🇳India divyansh.gupta Jaipur

Please change the target branch of the MR and resolve Merge Conflicts if any after changing the target branch.

🇮🇳India divyansh.gupta Jaipur

Yes @lendude, I agree with you because in this issue also we are trying to achieve the same thing, to allow to set the exposed filter to required without having to select a default value.
So should we wait for that issue to be fixed or continue working on it?

🇮🇳India divyansh.gupta Jaipur

@lavanyatalwar,
There were issues solving Merge conflicts in MR!72, so created a new branch,
please review MR!73.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3511606-matomobasictesttestmatomopagevisibility-fails-in to hidden.

🇮🇳India divyansh.gupta Jaipur

I attempted to reproduce the issue by creating multiple menus, and in all cases, the menu is functioning correctly across all levels. If there are any specific configurations or settings that might be contributing to the issue, please let me know so I can investigate further.

🇮🇳India divyansh.gupta Jaipur

I've implemented a configuration option to enable or disable the distance field in the exposed filter.
Please review and Let me know if any changes are needed!

🇮🇳India divyansh.gupta Jaipur

I tried replicating this issue on Drupal 10 with module version 2.x, following the steps in the issue summary, but couldn’t reproduce it. If anyone else is experiencing this, please share detailed steps to reproduce, including configuration settings, specific inputs causing the issue, and any error messages or logs. This will help in identifying whether it’s environment-specific or a broader issue.

🇮🇳India divyansh.gupta Jaipur

I reviewed this issue and the changes looks good to me as there are no errors after applying MR-8.
Thus moving to RTBC!!

🇮🇳India divyansh.gupta Jaipur

I have reviewed the issue and the changes looks good to me because now the code allowds $response to be NULL.
Thus moving this to RTBC.

🇮🇳India divyansh.gupta Jaipur

I reviewed this issue and was able to reproduce this issue and MR-13 solved the problem successfully for me,
Thus moving it to RTBC.
Before:
\
After:

🇮🇳India divyansh.gupta Jaipur

I have reviewed the changes and since file_valid_extensions is deprecated these changes will solve the issue.
Thus moving this to RTBC!

🇮🇳India divyansh.gupta Jaipur

Yes i agree with the solution that $key is set before entity load in Selective::getOids, since patches are deprecated created an MR.
Please review.

🇮🇳India divyansh.gupta Jaipur

Made changes suggested in #14,
Please review.

🇮🇳India divyansh.gupta Jaipur

I was able to reproduce this issue and solved the issue by adding an access check before adding links to help page.
Please review.

🇮🇳India divyansh.gupta Jaipur

I was able to reproduce the issue successfully and after changing the route now the exception of invalid key is successfully printed on the node page without throwing any error in dblogs.
Please review.

🇮🇳India divyansh.gupta Jaipur

Raised MR against 11.x (MR !11535),
Please review.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3513601-improve-password-field to hidden.

🇮🇳India divyansh.gupta Jaipur

I have made the changes such that the order is:

  • Current Password
  • New Password
  • Confirm New Password

by adjusting the weight property of new password field.
Please review.

🇮🇳India divyansh.gupta Jaipur

Made changes as requested by @Niklan, and it is working fine after the changes,
Please review.

🇮🇳India divyansh.gupta Jaipur

Hello,
I tried the steps you asked to reproduce in Drupal core version: 11.1.4, Navigation + version: 2.0.2, Admin theme: Claro 11.1.4 (administration theme), Front theme: Olivero 11.1.4 (default theme), but for me it is coming as expected.

🇮🇳India divyansh.gupta Jaipur

I have added the file in config/install,
Please review.

🇮🇳India divyansh.gupta Jaipur

@jsutta,
I am unable to see the sticky action buttons menu even after enabling the setting in theme's setting form, so can you help me how to make the menu visible.

🇮🇳India divyansh.gupta Jaipur

Looks good to me also, since patches are deprecated providing with and MR.

🇮🇳India divyansh.gupta Jaipur

I have made changes in the tests and the pipeline is also working green after the changes,
Please review.

🇮🇳India divyansh.gupta Jaipur

Rebased and resolved a PHPStan error,
Please review.

🇮🇳India divyansh.gupta Jaipur

I tried to reproduce this issue but:

  • The issue should be raised against 2.0.x because the route given in issue summary does not exist in 8.x-1.x
  • I could not find any issue on /admin/config/development/performance/purge. So if you could provide steps to reproduce this issue and this patch does not make any changes.
🇮🇳India divyansh.gupta Jaipur

I have made changes to resolve the nullable error according to PHP:8.4,
Please review MR-15.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3510945-php-8.4-implicitly to hidden.

🇮🇳India divyansh.gupta Jaipur

I tried to reproduce this issue but was unable to reproduce it after following the steps you mentioned, but if you are facing this issue I can add a type check before using implode() ensuring that only array is entered.

🇮🇳India divyansh.gupta Jaipur

I tried to reproduce this issue but was unable to reproduce it after following the steps you mentioned, but if you are facing this issue I can add a type check before using implode() ensuring that only array is entered.

🇮🇳India divyansh.gupta Jaipur

Hello @liam morland,
I tried rebasing it on branch 3.0.x but i dont have the access to change the target branch from 8.0.x to 3.0.x, so if anyone with access would change it so that i can rebase it towards 3.0.x.

🇮🇳India divyansh.gupta Jaipur

@meghasharma
Previous two days were weekends so I was not active over here. Also i was working on it today and did not see new messages in this issue lately, but now that you have solved this issue its fine.

🇮🇳India divyansh.gupta Jaipur

I was able to reproduce this issue and the patch applied successfully and fixed the issue for me.
Please review.

🇮🇳India divyansh.gupta Jaipur

I tried to reproduce this error but was unable to reproduce this, so if this issue still persists for anyone i would make a MR for it, else I think we can close this issue.

🇮🇳India divyansh.gupta Jaipur

I have reviewed and tested the latest patch in !11.

✅ The #submit callback is no longer being unset, allowing other submit handlers (such as from Media Entity File Replace) to function correctly.
✅ The function name update issue has been resolved, and $form['actions']['submit']['#ajax']['callback'] now correctly references the updated function.
✅ The form submission process works as expected, and the modal closes properly after submission.

Everything looks good, and I don't see any regressions or issues. Moving this to RTBC.

🇮🇳India divyansh.gupta Jaipur

Since there is a unresolved thread moving it to Needs Work, Please resolve the thread.

🇮🇳India divyansh.gupta Jaipur

The change to allow string|int for the $hook argument in coi_module_implements_alter() is correct. This prevents a TypeError when Drupal incorrectly registers update hook numbers (e.g., 8001) as hook names, as described in issue #3508292. The fix ensures compatibility while keeping the existing logic intact.
Thus the changes looks good to me moving this to RTBC+!

🇮🇳India divyansh.gupta Jaipur

I have reviewed the issue and the MR-13 successfully applied for me and now it is working as expected, also the changes looks good to me thus moving it to RTBC+!

🇮🇳India divyansh.gupta Jaipur

Found that pipelines were failing because forked branch was some commits behind the main branch, so rebased my forked branch and ran the pipeline again and now all the pipelines are passing without errors/warnings.
Please review.

🇮🇳India divyansh.gupta Jaipur

I reviewed this issue and the MR applied successfully for me, and the changes fixed the issue for me as seen in the attached video.
The changes looks good to me thus moving it to RTBC+!

🇮🇳India divyansh.gupta Jaipur

I am also able to reproduce this error:

Also i found that translateContent function being used in Controller of auto_translate is being modified in this issue 📌 Discuss: Unify translate operations over ai Active , so i think we should modify the controller in auto_translate to comply with the changes made in ai_translate module.

Production build 0.71.5 2024