@marcus_johansson, Made the changes suggested on the MR,
Please review!!
Made the changes suggested,
Please review!!
I'm currently testing on Drupal 11.3-dev, and I’m able to reproduce the issue through the UI. After applying the patch, the issue is resolved in the UI as expected.
However, I wasn't able to reproduce the error reliably through automated tests. Given that, I'm submitting this MR with the patch and leaving the addition of tests to someone else who might be able to implement them more effectively.
Working on it!!
I tried reproducing the original issue locally by manually duplicating a view display with an exposed form and simulating the faulty override (exposed_form set with defaults set to FALSE). However, the test I wrote passed successfully without applying the patch.
This suggests the issue might already be resolved in the current version of core.
Do we still need to proceed with adding the test, or is this no longer reproducible and can potentially be closed?
Now the admin toolbar menu is working as expected,
Please review!!
Since there hasn't been any update from @enchufe in a while, I'm picking this up and working on the issue.
The patch successfully applied for me the changes looks good to me because it adds accessibility to errors.
Working on it!!
Hi @avpaderno, just a gentle follow-up on my earlier comment above. Appreciate your time, thanks!
I think the change record also needs to removed!!
Fixed the order of text please review.
Working on it!!
@alexpott,
Made the suggested changes, Please review!!
Hi,
Just wanted to mention that I had started the initial work on this issue. Getting credit on issues like this really helps motivate contributors like me to stay involved and keep contributing. I’d appreciate it if that could be reflected here.
Thanks, and looking forward to continuing to collaborate!
Working on it!!
Yes i agree that if there is nothing to show then also it should return an array, thus made the required changes.
Please review!!
Working on it!!
Rerolled the patch to MR, also the changes looks good to me.
Please review!
Working on it.
Hi @avpaderno,
I had previously assigned this issue to myself and mentioned that I was working on it. I was able to resolve the issue locally, but ran into a Git-related problem that prevented me from pushing the patch in time.
I noticed that you reassigned and committed a fix in the meantime. I appreciate the quick resolution and fully respect the contribution.
Just wanted to note this for transparency, as the general guideline encourages coordination before reassigning issues that are actively being worked on. Looking forward to continued collaboration—thanks again!
Working on this
@coffeymachine, Converted the patch provided by @dan_metille into MR, Please review and merge!!
Working on it
Solved all PHPUnit errors and other Gitlab-Ci warnings,
Please review.
Since patches are deprecated, provided an MR for the same.
Please review!!
Working on it.
@mably, Sorry but there was problem in previous rebase,
Rebased again properly,
Please review.
Rebased the MR!133 against 2.0.x
Please review.
Working on it.
plopesc → credited divyansh.gupta → .
The "More" link functionality is intended to work only for teaser view modes and i think it is not applicable or defined for full node display pages.
Working on it!!
I have hidden the form for new users,
Please review.
Working on it.
The issue is present in the 1.0.0 and 1.0.1 tags but not on the master branch. This is because the tags are not in sync with the latest updates on the master branch, which results in the missing route error.
Since tagging new releases or updating existing ones requires maintainer access, this will need to be addressed by a maintainer.
Working on it.
I have added the code to add configuration checkpoint when an recipe is activated via project browser,
Please review.
Working on it.
I was able to reproduce this issue and this MR applied succesfully for me and resolved the issue.
Before:
After:
The changes looks good to me thus moving this to RTBC+!
Made the Ai assitant field required:
Please review.
Ok working on it!!
I was able to reproduce this issue and this MR solved the issue for me,
Thus moving this to RTBC!!
I have added the option to import using drush command.
Please review.
Working on it.
Hello @alex.bukach,
The issue has been fixed and the MR has been merged but you forgot to add credits, can you please look into this and provide the appropriate credits as the credits keeps us motivated.
Rerolled the MR!10295,
Please review.
Working on it.
divyansh.gupta → changed the visibility of the branch 3521347-synonyms-list-field to active.
divyansh.gupta → changed the visibility of the branch 3521347-synonyms-list-field to hidden.
This adds a check for $item->entity in getSynonyms() to prevent fatal errors when a referenced entity is missing. It ensures safer handling of broken references without affecting existing functionality.
Working on it.
Changed the title, Please review.
Please change the target branch of the MR and resolve Merge Conflicts if any after changing the target branch.
Working on it.
Yes @lendude, I agree with you because in this issue also we are trying to achieve the same thing, to allow to set the exposed filter to required without having to select a default value.
So should we wait for that issue to be fixed or continue working on it?
@lavanyatalwar,
There were issues solving Merge conflicts in MR!72, so created a new branch,
please review MR!73.
divyansh.gupta → changed the visibility of the branch 3511606-matomobasictesttestmatomopagevisibility-fails-in to hidden.
Sorry but will not be able to work on it.
Working on it.
Working on it.
Made the changes, Please review.
Since there is no response for such a long time closing this issue.
I attempted to reproduce the issue by creating multiple menus, and in all cases, the menu is functioning correctly across all levels. If there are any specific configurations or settings that might be contributing to the issue, please let me know so I can investigate further.
Working on it.
I've implemented a configuration option to enable or disable the distance field in the exposed filter.
Please review and Let me know if any changes are needed!
I tried replicating this issue on Drupal 10 with module version 2.x, following the steps in the issue summary, but couldn’t reproduce it. If anyone else is experiencing this, please share detailed steps to reproduce, including configuration settings, specific inputs causing the issue, and any error messages or logs. This will help in identifying whether it’s environment-specific or a broader issue.
I reviewed this issue and the changes looks good to me as there are no errors after applying MR-8.
Thus moving to RTBC!!
I have reviewed the issue and the changes looks good to me because now the code allowds $response to be NULL.
Thus moving this to RTBC.
I reviewed this issue and was able to reproduce this issue and MR-13 solved the problem successfully for me,
Thus moving it to RTBC.
Before:
\
After:
I have reviewed the changes and since file_valid_extensions is deprecated these changes will solve the issue.
Thus moving this to RTBC!
Working on it.
Yes i agree with the solution that $key is set before entity load in Selective::getOids, since patches are deprecated created an MR.
Please review.
Working on it.
Made changes suggested in #14,
Please review.
Working on it.
I was able to reproduce this issue and solved the issue by adding an access check before adding links to help page.
Please review.
I was able to reproduce the issue successfully and after changing the route now the exception of invalid key is successfully printed on the node page without throwing any error in dblogs.
Please review.
Working on it.
Woking on it.
Raised MR against 11.x (MR !11535),
Please review.
divyansh.gupta → changed the visibility of the branch 3513601-improve-password-field to hidden.
I have made the changes such that the order is:
- Current Password
- New Password
- Confirm New Password
by adjusting the weight property of new password field.
Please review.
Working on it.
Made changes as requested by @Niklan, and it is working fine after the changes,
Please review.
Working on it.
Hello,
I tried the steps you asked to reproduce in Drupal core version: 11.1.4, Navigation + version: 2.0.2, Admin theme: Claro 11.1.4 (administration theme), Front theme: Olivero 11.1.4 (default theme), but for me it is coming as expected.
I have added the file in config/install,
Please review.
Working on it.
@jsutta,
I am unable to see the sticky action buttons menu even after enabling the setting in theme's setting form, so can you help me how to make the menu visible.
Working on it.
Working on it.
Looks good to me also, since patches are deprecated providing with and MR.
Working on it.
I have made changes in the tests and the pipeline is also working green after the changes,
Please review.