Jaipur
Account created on 27 September 2024, 3 months ago
#

Merge Requests

More

Recent comments

🇮🇳India divyansh.gupta Jaipur

I have made changes in the responsive-preview.js file and the changes are working fine for me, also attached an video of it working.
Please review.

🇮🇳India divyansh.gupta Jaipur

Hello @cilefen,
Applied the patch provided by @mjmorley and it was successfully applied, so provided MR for the same.
Please review.

🇮🇳India divyansh.gupta Jaipur

Hello @smustgrave,
I applied the patch provided in #8 and it successfully applied, so i have provided MR as requested,
Please review.

🇮🇳India divyansh.gupta Jaipur

I reviewed the patch and it was successfully applied, so provided an MR for the same,
Please review.

🇮🇳India divyansh.gupta Jaipur

Hello,
I have made the hamburger functional also attached the video,
Please review.

🇮🇳India divyansh.gupta Jaipur

Hello @quietone,
I have reviewed the changes and those changes looks good to me, done as mentioned in proposed resolution,
Thus moving it to RTBC+!!,
Thank you

🇮🇳India divyansh.gupta Jaipur

Hello @tanushree gupta,
There are merge conflicts in MR-47,
Please resolve.

🇮🇳India divyansh.gupta Jaipur

I have reviewed this issue and found the edit button's css as expected according to issue's solution,
Before fix:

After fix:

Thus moving it to RTBC+!!

🇮🇳India divyansh.gupta Jaipur

I have tested this and it is working as expected by this issue's problem
Config Form:

After image on homepage:

Thus moving it to RTBC+!!

🇮🇳India divyansh.gupta Jaipur

Sorry will not be able to work on it.

🇮🇳India divyansh.gupta Jaipur

Made the changes and removed PHP_CS errors,
Please review.

🇮🇳India divyansh.gupta Jaipur

Hello @danrod,
Resolved the phpunit please review.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3495691-fix-issues-reported to hidden.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3.0.x to hidden.

🇮🇳India divyansh.gupta Jaipur

I have made the required changes to remove all PHP_CodeSniffer errors,
Please review.

🇮🇳India divyansh.gupta Jaipur

I have resolved all eslint errors but it is not reflecting in the pipelines since the tests are failing after i resolved the merge conflicts.
Please review.

🇮🇳India divyansh.gupta Jaipur

Working on it.

🇮🇳India divyansh.gupta Jaipur

Also resolved this issue for ipad's, Please review.

🇮🇳India divyansh.gupta Jaipur

I have fixed the spacing issue in the footer please review.

🇮🇳India divyansh.gupta Jaipur

@avpaderno
Made the changes requested,
Please review.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3373061-fixes-error-warning-phpcs to hidden.

🇮🇳India divyansh.gupta Jaipur

Hello @avpaderno,
Made the changes you asked me to do in the MR.
Please review.

🇮🇳India divyansh.gupta Jaipur

Added the feature to make the fields "Path" and "To" to cover full width.
Please review.

🇮🇳India divyansh.gupta Jaipur

@avapaderno Made the changes as suggested by you please review.

🇮🇳India divyansh.gupta Jaipur

I have worked and resolved some more PHP_CodeSniffer errors and checked that there are no phpcs errors left by checking it locally.

🇮🇳India divyansh.gupta Jaipur

Hi @alyaj2a
Are you still working on this issue?

🇮🇳India divyansh.gupta Jaipur

Removed phpcs errors,
Please review.

🇮🇳India divyansh.gupta Jaipur

Solved all the phpcs errors also enabled the gitlab-ci pipeline.
Please review.

🇮🇳India divyansh.gupta Jaipur

Resolved the phpcs errors, please review it.

🇮🇳India divyansh.gupta Jaipur

I reviewed MR!10438 and the changes seem to be working fine.
Also, the pipeline is passing without any errors and warnings.
Hiding the other MR's and moving the issue to RTBC+.
Attaching before and after fix screenshots for reference.

Before:

After:

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3490443-input-and-filter to hidden.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3490443-action-btn-margin to hidden.

🇮🇳India divyansh.gupta Jaipur

Hello @chandansha
MR-6 is working fine without any merge conflicts and neither the gitlab-ci pipeline is showing any PHP_CodeSniffer error that's what this issue was asking for.

🇮🇳India divyansh.gupta Jaipur

Applied @amit.rawat777's patch and it solved the some of the PHP_CodeSniffer errors so i resolved the remaining errors, also enabled the gitlab-ci pipeline to check if there are any errors left.
Please review.

🇮🇳India divyansh.gupta Jaipur

@joshahubbers,
I have made the changes please check.

🇮🇳India divyansh.gupta Jaipur

Resolved all PHP_Codesniffer errors.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3476134-fix-phpcs-issues to hidden.

🇮🇳India divyansh.gupta Jaipur

divyansh.gupta changed the visibility of the branch 3476134- to hidden.

🇮🇳India divyansh.gupta Jaipur

did that changes to solve PHP_stan issues but reverted those changes and kept changes only solving phpcs errors.

🇮🇳India divyansh.gupta Jaipur

Solved some remaining PHP_CS error.

🇮🇳India divyansh.gupta Jaipur

Created a option to enable and disable this functionality in settings form also tested it and it is working fine from my side.

🇮🇳India divyansh.gupta Jaipur

Sorry forgot about that will make the changes.

🇮🇳India divyansh.gupta Jaipur

Resolved the merge conflicts and removed phpcs errors in the updated code after resolving merge conflicts.

🇮🇳India divyansh.gupta Jaipur

Solved all the PHP_CS errors.

🇮🇳India divyansh.gupta Jaipur

To resolve this issue, added a check to ensure that $moderations is an array before entering the foreach loop.

🇮🇳India divyansh.gupta Jaipur

@ankitv18,
i have reverted those changes which i made to resolve phpstan and cspell errors.

🇮🇳India divyansh.gupta Jaipur

Added dependency injections where ever found direct drupal calls.

🇮🇳India divyansh.gupta Jaipur

Solved Some more PHPCS errors.

🇮🇳India divyansh.gupta Jaipur

I have fixed the PHP_CodeSniffer errors and created MR.

🇮🇳India divyansh.gupta Jaipur

Hello @clarkssquared,
The error you mentioned is already mentioned in .phpcs.xml file to exclude this file and it was also not mentioned in issue summary.
<exclude-pattern>css/theme/total-control.theme.css</exclude-pattern>.
So still should i remove this error or leave it.
Also I found similar issue where it is told that it is not a issue or bug:
📌 File appears to be minified and cannot be processed Closed: works as designed .
Also if you think that remaining errors mentioned in the issue summary are solved so can you please move the state of the issue to needs review, or if you think i should solve this error than please let me know so that i can try to remove this error.

🇮🇳India divyansh.gupta Jaipur

I removed the test failure which was due to mismatch of create function with its parent class.
Please review it and tell me if any changes are to be made

🇮🇳India divyansh.gupta Jaipur

Hello @joshahubbers,
I have applied the changes according to requirements and it would be a great idea to create a seperate issue for it.
Also if you think my work is correct and requires no changes according to this issue, can you please move my ticket to needs review.

Production build 0.71.5 2024