I have made changes in the responsive-preview.js file and the changes are working fine for me, also attached an video of it working.
Please review.
Working on it.
Hello @cilefen,
Applied the patch provided by @mjmorley and it was successfully applied, so provided MR for the same.
Please review.
Working on it.
Hello @smustgrave,
I applied the patch provided in #8 and it successfully applied, so i have provided MR as requested,
Please review.
Working on it.
I reviewed the patch and it was successfully applied, so provided an MR for the same,
Please review.
Reviewing it!
Hello,
I have made the hamburger functional also attached the video,
Please review.
Working on it.
Hello @quietone,
I have reviewed the changes and those changes looks good to me, done as mentioned in proposed resolution,
Thus moving it to RTBC+!!,
Thank you
Hello @tanushree gupta,
There are merge conflicts in MR-47,
Please resolve.
I have reviewed this issue and found the edit button's css as expected according to issue's solution,
Before fix:
After fix:
Thus moving it to RTBC+!!
I have tested this and it is working as expected by this issue's problem
Config Form:
After image on homepage:
Thus moving it to RTBC+!!
Sorry will not be able to work on it.
Working on it.
Made the changes and removed PHP_CS errors,
Please review.
Working on remaining errors.
Hello @danrod,
Resolved the phpunit please review.
divyansh.gupta → changed the visibility of the branch 3495691-fix-issues-reported to hidden.
divyansh.gupta → changed the visibility of the branch 3.0.x to hidden.
Yes @danrod working on it.
I have made the required changes to remove all PHP_CodeSniffer errors,
Please review.
Working on it.
I have resolved all eslint errors but it is not reflecting in the pipelines since the tests are failing after i resolved the merge conflicts.
Please review.
Also resolved this issue for ipad's, Please review.
I have fixed the spacing issue in the footer please review.
Made the changes requested, Please review.
Updated the summary please check.
@avpaderno
Made the changes requested,
Please review.
divyansh.gupta → changed the visibility of the branch 3373061-fixes-error-warning-phpcs to hidden.
Working on it.
Hello @avpaderno,
Made the changes you asked me to do in the MR.
Please review.
Added the feature to make the fields "Path" and "To" to cover full width.
Please review.
@avapaderno Made the changes as suggested by you please review.
I have worked and resolved some more PHP_CodeSniffer errors and checked that there are no phpcs errors left by checking it locally.
Working on it.
Hi @alyaj2a
Are you still working on this issue?
Removed phpcs errors,
Please review.
Working on it.
Solved all the phpcs errors also enabled the gitlab-ci pipeline.
Please review.
Working on it.
Resolved the phpcs errors, please review it.
Working on it.
I reviewed MR!10438 and the changes seem to be working fine.
Also, the pipeline is passing without any errors and warnings.
Hiding the other MR's and moving the issue to RTBC+.
Attaching before and after fix screenshots for reference.
Before:
After:
divyansh.gupta → changed the visibility of the branch 3490443-input-and-filter to hidden.
divyansh.gupta → changed the visibility of the branch 3490443-action-btn-margin to hidden.
Hello @chandansha
MR-6 is working fine without any merge conflicts and neither the gitlab-ci pipeline is showing any PHP_CodeSniffer error that's what this issue was asking for.
Applied @amit.rawat777's patch and it solved the some of the PHP_CodeSniffer errors so i resolved the remaining errors, also enabled the gitlab-ci pipeline to check if there are any errors left.
Please review.
Working on it.
Please review.
Working on it.
I am working on it.
@joshahubbers,
I have made the changes please check.
Resolved all PHP_Codesniffer errors.
divyansh.gupta → changed the visibility of the branch 3476134-fix-phpcs-issues to hidden.
divyansh.gupta → changed the visibility of the branch 3476134- to hidden.
did that changes to solve PHP_stan issues but reverted those changes and kept changes only solving phpcs errors.
Solved some remaining PHP_CS error.
Created a option to enable and disable this functionality in settings form also tested it and it is working fine from my side.
Sorry forgot about that will make the changes.
Resolved the merge conflicts and removed phpcs errors in the updated code after resolving merge conflicts.
Solved all the PHP_CS errors.
Solved some more phpcs errors.
To resolve this issue, added a check to ensure that $moderations is an array before entering the foreach loop.
@ankitv18,
i have reverted those changes which i made to resolve phpstan and cspell errors.
Fixed CSpell and PHPStan errors.
Applied Coding Standards to 162 files.
I have made some more changes to it.
Added dependency injections where ever found direct drupal calls.
Solved Some more PHPCS errors.
I have fixed the PHP_CodeSniffer errors and created MR.
Hello @clarkssquared,
The error you mentioned is already mentioned in .phpcs.xml file to exclude this file and it was also not mentioned in issue summary.
<exclude-pattern>css/theme/total-control.theme.css</exclude-pattern>
.
So still should i remove this error or leave it.
Also I found similar issue where it is told that it is not a issue or bug:
📌
File appears to be minified and cannot be processed
Closed: works as designed
.
Also if you think that remaining errors mentioned in the issue summary are solved so can you please move the state of the issue to needs review, or if you think i should solve this error than please let me know so that i can try to remove this error.
I removed the test failure which was due to mismatch of create function with its parent class.
Please review it and tell me if any changes are to be made
Hello @joshahubbers,
I have applied the changes according to requirements and it would be a great idea to create a seperate issue for it.
Also if you think my work is correct and requires no changes according to this issue, can you please move my ticket to needs review.