trim(): Passing null to parameter #1 ($string) of type string is deprecated in _responsive_image_build_source_attributes()

Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in _responsive_image_build_source_attributes() (line 414 of core/modules/responsive_image/responsive_image.module). · _responsive_image_build_source_attributes(Array, Object, Array) (Line: 173) · template_preprocess_responsive_image(Array, 'responsive_image', Array) (Line: 287) · Drupal\Core\Theme\ThemeManager->render('responsive_image', Array) (Line: 422) · Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201) · Drupal\Core\Render\Renderer->render(Array) (Line: 479) · Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 50) · __TwigTemplate_b0521e86aaa2ccb2263d138013ee9ad9->doDisplay(Array, Array) (Line: 405) · Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378) · Twig\Template->display(Array) (Line: 390) · Twig\Template->render(Array) (Line: 55) · twig_render_template('core/themes/stable/templates/field/responsive-image-formatter.html.twig', Array) (Line: 384) · Drupal\Core\Theme\ThemeManager->render('responsive_image_formatter', Array) (Line: 422) · Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201) · Drupal\Core\Render\Renderer->render(Array) (Line: 479) · Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 44) · __TwigTemplate_7f89780e69a1d2ac98482da07a3293ff->doDisplay(Array, Array) (Line: 405) · Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378) · Twig\Template->display(Array) (Line: 390) · Twig\Template->render(Array) (Line: 55) · twig_render_template('themes/custom/klesia_extranet/templates/field/field.html.twig', Array) (Line: 384) · Drupal\Core\Theme\ThemeManager->render('field', Array) (Line: 422) · Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201) · Drupal\Core\Render\Renderer->render(Array) (Line: 479) · Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 44) · __TwigTemplate_f09ca4698c8f32f6a8ab2822b02b331c->doDisplay(Array, Array) (Line: 405) · Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378) · Twig\Template->display(Array) (Line: 390) · Twig\Template->render(Array) (Line: 55) · twig_render_template('themes/custom/klesia_extranet/templates/user/user.html.twig', Array) (Line: 384) · Drupal\Core\Theme\ThemeManager->render('user', Array) (Line: 422) · Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201) · Drupal\Core\Render\Renderer->render(Array, ) (Line: 241) · Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 564) · Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 242) · Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 132) · Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90) · Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object) · call_user_func(Array, Object, 'kernel.view', Object) (Line: 142) · Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 163) · Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80) · Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58) · Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) · Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 48) · Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) · Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23) · Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708) · Drupal\Core\DrupalKernel->handle(Object) (Line: 19) Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in _responsive_image_build_source_attributes() (line 414 of core/modules/responsive_image/responsive_image.module).

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

As a bug this will need a test case

Not sure this is the correct fix though? Shouldn't we figure out what's calling this hook that leads to this? Could be wrong on that

But the proposed solution should be added to the IS.
Comment over 1 year ago →
🇦🇺Australia nterbogt
I think it comes down to whether we support NULL or "" in other yml config. If we do, this is a bug... if not, then it's just identifying a misconfiguration that it could cope with before.
Comment over 1 year ago →
🇺🇸United States smustgrave
When can getMediaQuery() return null for a breakpoint? Think once we know the steps to trigger that it will help I think.

More of these kind of tickets have been popping for 8.1
Comment over 1 year ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
What if the breakpoint entity should handled the trimming in ::getMediaQuery and always returned a string?

And then we could add Breakpoint::hasMediaQuery instead of the empty, which is always a source of random issues.
Comment 10 months ago →
🇫🇷France kae76 France
Thank you pameeela → on your comment [ #12 🐛 trim(): Passing null to parameter #1 ($string) of type string is deprecated in _responsive_image_build_source_attributes() Needs work ] worked a treat
Comment 10 months ago →
🇮🇳India anchal_gupta
Rerolled patch aganist 11.x
Assigned to PrabuEla
Comment 9 months ago →
🇮🇳India PrabuEla chennai
Comment 9 months ago →
🇮🇳India PrabuEla chennai
Issue was unassigned.
Comment 9 months ago →
🇮🇳India PrabuEla chennai
Status changed to Needs review 9 months ago6:31pm 5 March 2024
Comment 9 months ago →
🇮🇳India priya.chat
I have added one extra check for getMediaQuery().
Status changed to Needs work 9 months ago6:37pm 5 March 2024
Comment 9 months ago →
🇺🇸United States smustgrave
#18 doesn't appear to be answered

Issue summary still needs to be updated

Tests appear to be missing.