Account created on 17 January 2007, about 17 years ago
#

Merge Requests

Recent comments

πŸ‡§πŸ‡ͺBelgium attiks

attiks β†’ created an issue.

πŸ‡§πŸ‡ͺBelgium attiks

We ran into the same issue, and converted our code to do something similar but using a flag inlineDataProvider on the base class, so whenever needed we can easily switch back to the normal behavior.

Taken from https://github.com/UN-OCHA/un_date/blob/main/tests/src/Kernel/DateRender...

  /**
   * Test with UTC timezone.
   *
   * @x-dataProvider providerTestDataUtc
   * @x-dataProvider providerTestDataRandom
   */
  public function testDateRangeUtc($expected = NULL, $start = NULL, $end = NULL, $timezone = NULL) {
    if ($this->inlineDataProvider) {
      $data = array_merge(
        $this->providerTestDataUtc(),
        $this->providerTestDataRandom(),
      );

      foreach ($data as $name => $row) {
        $expected = $row['expected'];
        $start = $row['start'];
        $end = $row['end'];
        $timezone = $row['timezone'];

        // assertions        
      }
    }
    else {
      // assertions        
    }

I also looked into changing the code, but it ain't straightforward since everything has to be static

πŸ‡§πŸ‡ͺBelgium attiks

See discussion in https://www.drupal.org/project/ga_login/issues/3297284#comment-14716408 β†’

> Setting to fixed, as this module is going to be absorbed back into tfa.

All in favor of moving to tfa module, no need for duplication

πŸ‡§πŸ‡ͺBelgium attiks

Tests fails with "Drupal\Core\Database\TransactionNoActiveException", not sure why

πŸ‡§πŸ‡ͺBelgium attiks

Logic moved to `getValueFromProperty` similar to `entity:node/1` links.

Importing is already implemented, so less code ++

πŸ‡§πŸ‡ͺBelgium attiks

Fork solves this for links like /node/1 by adding the referenced node as a dependency and storing the entity type and uuid in _meta

When importing the link is restored.

πŸ‡§πŸ‡ͺBelgium attiks

attiks β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡ͺBelgium attiks

The idea is to disable passing PHP code from the DRD site to the remote sites, so only code on disk (on the remote site) can be executed.

In the case the DRD site get hacked, it will be able to pass and execute any PHP code on the client sites, OPS people don't like it.

About the name "trusted_modules", it can be changed, but that was the best I could come up with

πŸ‡§πŸ‡ͺBelgium attiks

MR created

For settings.php you can use the following

$settings['drd.trusted_modules'] = [
  'ocha_drd',
];

Only problem left is how and where to display the output

πŸ‡§πŸ‡ͺBelgium attiks

Created a 2.x branch and removed D8 since the library only exists for D9.2+, https://www.drupal.org/node/3158256 β†’

πŸ‡§πŸ‡ͺBelgium attiks

Correct, components inside a custom theme

πŸ‡§πŸ‡ͺBelgium attiks

Tried it with the package.json from above, but without the patch, seems to be working

πŸ‡§πŸ‡ͺBelgium attiks

#7 In the case of hierarchical hierarchy we use the following solution, we render all options including the parents in 1 item, this in combination with something like select2 allows user to easily find what they need.

Vehicle > Motorbike > Honda
Vehicle > Car > Honda

Real life example

πŸ‡§πŸ‡ͺBelgium attiks

There's already an issue to add select2 to core which, once committed, will solve this.

πŸ“Œ Improve usability, accessibility, and scalability of long select lists Needs work

πŸ‡§πŸ‡ͺBelgium attiks

#82 I've updated the IS, but by reading the comments the API change is no longer needed?

πŸ‡§πŸ‡ͺBelgium attiks

#80 I'm probably missing something, but what is the policy for non js browsers, 'cos if we output a select for free tagging it will not work without javascript. Unless we are converting the input to a select using javascript?

πŸ‡§πŸ‡ͺBelgium attiks

#78 We have similar (and bigger) vocabularies as @aspilicious mentioned in #77, outputting a select list is not going to be an option. Most of the entities are tagged with multiple terms.

Dream scenario:

Have a widget that renders the right HTML depending on the amount of data and attaches the right libraries.

For example (boundaries to be defined in config):
10 or less options and without tagging: output select, no select2
200 or less options and without tagging: output select, use select 2
200 or less options and with tagging: output text, use select 2
201 or more options and without tagging: output empty select, use select 2 + ajax
201 or more options and with tagging: output input, use select 2 + ajax

Really nice to have: Add support for hierarchical vocabularies as well, so site user can select parent term as well and they are rendered as nested.

πŸ‡§πŸ‡ͺBelgium attiks

#48 does this mean that the keys need to be changed depending on the fact that you use select2?

Ex: if I remove the "'#select2' => TRUE" from a select, will this break the code?

πŸ‡§πŸ‡ͺBelgium attiks

The summary says to use it for taxonomy, why don't we use it for multiple selects as well?

Production build https://api.contrib.social 0.61.6-2-g546bc20