- Issue created by @guignonv
- π«π·France guignonv
First beta is delayed to next week due to still some instabilities. More tests are needed.
- π§πͺBelgium rp7
I've been heavily involved with the development of 2.x of this module (hence why I'm maintainer as well). Until a few months ago I wasn't aware a 3.x of this module was in the works. Is there an upgrade guide from 2.x to 3.x?
- π«π·France guignonv
Yes there is one. The updates (in the install file) *should* be able to upgrade from v2 to v3. I say "should" because I've tested on my stuff and tried to make something generic but there are always things you miss when you make this kind of "heavy" migrations and I'm sure I missed some use cases... So, you should be able to upgrade your site to xntt v3. If you experience problems, create issues and I'll see how I can help. If you're talking about "code migration" (ie. custom plugins you made for instance), I am planing to write some doc about it. I have started something in the "DEVELOPMENT.md" file but it might not be so clear I admit. For code migration, I can provide help through issues if you need to know where did "such method" moved or how to replace "that piece of code" that was calling methods that are not there anymore.
I definitely need to write a doc on how to create new xntt plugins. That would help understanding the new design and also help migrating old code as well. There is a lot of work to do and this one is not "high priority" for me right now. I needed v3 to package it in a project beta by the end of the year with a couple of other stuff. Once I got that completed (hopefully before December...), I'll be able to allocate time to more documentation.
- π§πͺBelgium rp7
@guignonv
Thanks for the update. I have a project which makes heavily use of external entities (which is a reason I started the 2.x branch for). I'll free up some space to upgrade to v3 and report back on the things I had to change on my end.My project is now in need for some extra features, such as β¨ Make external entities translatable Active and β¨ Allow to annotate without the use of inline entity form Active . I will be working on these the next few days (for v3). Could we get these on the roadmap for v3? They might require some (minor) breaking changes (not entirely sure yet) - so it would be nice to have them in before 3.x RC hits.
- πΊπΈUnited States mortona2k Seattle
Good to see the collaboration here. I think this has huge potential for Drupal.
I am interested in making it easy to pull in external information from APIs, plus Drupal - Drupal interoperability.
Throw in a plugin for scraping content from html and we'll be cooking with plutonium.
I can help with documentation and testing things as they are released.
- π§πͺBelgium rp7
I upgraded my project (using several custom storage clients) from 2.x to 3.x. Here are some remarks:
- The update hooks transforming the config to be compatible with 3.x worked flawlessly!
- Most of the things I had to do is already documented in https://git.drupalcode.org/project/external_entities/-/blob/3.0.x/DEVELO... .
- In order to alter some filters, I had some custom hooks I invoked from my custom storage clients. I was able to replace these successfully with the TRANSLITERATE_DRUPAL_FILTERS event.
- I had some custom logic in my storage clients related to sorting parameters sent to the external source. I couldn't find a way to replace these, so I created β¨ Allow to alter sorts through event subscriber Needs review .
- I faced some other issues, for which I created several tickets. ( π ID is not assigned to newly saved external entities Needs review , π JsonPath::getMappedSourceFieldName() incompatible with various JSONPath notations Needs review , π Incompatibility with Monolog Needs review )
It went better than expected. Nice work!
I did see some stuff in code I have doubts about/maybe would do differently. If it's OK by you, and once I find the time, I'll create a separate issue to list these & have a place to discuss them. - π«π·France guignonv
I did see some stuff in code I have doubts about/maybe would do differently. If it's OK by you, and once I find the time, I'll create a separate issue to list these & have a place to discuss them.
Sure! Go ahead! Most of the re-design is mine and not perfect for sure. I'm open to discussion and changes if they make sense of course. Depending on the changes, some may need to be made in a 3.1 version but we'll see.