🇫🇷France @guignonv

Yes, you're right. I fear there are other places where the ->getKey() should have been used and was not. Did you check everywhere in current code?
Anyway, many thanks for the simple fix.

Fair nought. Merged. Thanks!

Marked as fixed. Reopen if not satisfied.

Thanks for the confirmation, I appreciate! :) I mark the issue fixed.

Merged.

I'll do some refactoring on tests.

I did some polishing (your fix did not take into account everything but it was a good start). It should work as expected now.

You may do it using a custom form field but I would go for a REST storage client override that would just override the "::getEndpointUrl()" to provide the Drupal.org autocomplete URL when the request is an entity "query" and it would adjust the query parameters (maybe "::transliterateDrupalFilters()" should also be overriden?).

I got the origin of the problem.
An event subscriber was added to solve the issue you mentioned (commit #60bbb6269d8176ef053e57e9598249b2e1fff544). The purpose of that subscriber was to notify the admin user when a new route (module install, config loading, ...) overrides an existing external entity type route. The problem was the event used: RoutingEvents::FINISHED. In the event handler, there was a call to

$this->routeProvider->getAllRoutes();

but, while the route building was finished, the event was still triggered inside the route building loop, and getAllRoutes() may try rebuilding routes, leading to an infinite loop (detected and stopped by Drupal).
The solution was to use a different event: RoutingEvents::ALTER. Even if we don't alter routes there, we still have a safe access to all existing routes from the event object and we can safely check of route overrides. I tested it manually and the old behavior still works as expected. An automated test should be created though, to check if the route override warning message is well displayed but... it's not my priority :-S .

OK. I tested on Drupal 11.2.4. I enabled the Drupal.org external entity example and created a new content type with a reference field to an external entity issue.

The autocomplete will not auto-complete, but it works if you enter the correct text. For instance "Field does not support AJAX (3294240)". Basically, you must enter a short string like "X" followed by the node id in parenthesis.

Edit your content entity type and go to the "Manage form display" tab. For your reference field, use "Select list" instead of any autocomplete. Now, when you create a new content with that reference field, you should see the list of Drupal issues in there. If you don't, then I can't reproduce your problem and I'll need more inputs (Drupal version, PHP version).

The autocomplete does not work because there is no standard way of supporting the "contains" or "starts_with" operators in REST queries. It is up to the REST endpoint implementation to provide such an operator and explain how to use it. The External Entity REST storage client does not know what to happen to " https://www.drupal.org/api-d7/node → " to perform a "contains" or "starts_with" operator to get a list of issues that contains the text you typed. To have this behavior, you would have to write a REST client that overrides the default one, and overrides the "::transliterateDrupalFilters()" method to transliterate the "CONTAINS" and/or "STARTS_WITH" operators, or the "::getEndpointUrl()" to provide a different end point for filtered queries (or maybe both, I did not investigate).

Is that clearer?

Thanks for reporting. Please confirm this fix solves the problem.

I'll have a look next week.

You don't need to use annotation at all. I'll try to reproduce your issue when I can, and see. Do you have any precise steps to do so?

guignonv → created an issue.

You're right. The module needs some polishing. I'll have a look at your code after other priorities and see what can be done to avoid using the data filter. Thanks for testing.

Hi! I'll check this issue later but did you try to use Data Processor "Value filtering" to remove "null" values? Maybe it would solve your problem without touching code and tests.

guignonv → created an issue.

If you install using Composer, it should be installed automatically. If not, then you need to put it in your installation root in /vendor/galbar/.
It should look like that:

└── jsonpath
    ├── CHANGELOG.md
    ├── CONTRIBUTING.md
    ├── LICENSE
    ├── NOTICE
    ├── README.md
    ├── app
    │   ├── docgen.php
    │   └── test.php
    ├── composer.json
    ├── docs
    ├── phpunit.xml.dist
    ├── src
    │   └── Galbar
    │       ├── JsonPath
    │       │   ├── Expression
    │       │   │   ├── ArrayInterval.php
    │       │   │   ├── BooleanExpression.php
    │       │   │   ├── ChildNameList.php
    │       │   │   ├── Comparison.php
    │       │   │   ├── InArray.php
    │       │   │   ├── IndexList.php
    │       │   │   └── Value.php
    │       │   ├── InvalidJsonException.php
    │       │   ├── InvalidJsonPathException.php
    │       │   ├── JsonObject.php
    │       │   ├── JsonPath.php
    │       │   ├── Language
    │       │   │   ├── ChildSelector.php
    │       │   │   ├── Regex.php
    │       │   │   └── Token.php
    │       │   └── Operation
    │       │       ├── GetChild.php
    │       │       ├── GetRecursive.php
    │       │       └── SelectChildren.php
    │       └── Utilities
    │           └── ArraySlice.php
    └── tests
        ├── Galbar
        │   ├── JsonPath
        │   │   ├── JsonObjectIssue37Test.php
        │   │   ├── JsonObjectIssue64Test.php
        │   │   ├── JsonObjectLengthOperatorTest.php
        │   │   ├── JsonObjectTest.php
        │   │   └── JsonPathKeyRegexMatchTest.php
        │   └── Utilities
        │       └── ArraySliceTest.php
        └── bootstrap.php

@divyansh.gupta
Sorry I should have put that I was working on it. My bad, and my apologies. I just committed a fix. However, there are still things to fix. It is not possible to edit the file/image field settings now.
And the code needs to be tested: we need to make sure it does not affect existing file/image fields validation and use on nodes, and tests other aspects. The UI also needs to be improved to allow to add/remove URIs.

Please feel free to work on the new code now, I don't have time right now and I'm moving on something else.

OK, no problem. Don't forget! ;) ...and have good vacations!
Nb.: I'll apply the patch to 3.0.x as I thinks its good enough, but you can post later here if it needs to be adjusted.

UPDATE: replaced "node" by "content".

Give this a try.

Thanks for the fix! I didn't test enough when I added that new option. Should be fixed by commit #3a23bbfa615304566d1e550ecf652bbd0c0ee2c1. Could you confirm?

Should be fixed by commit #3542506. Could you confirm?

Thanks! I missed that. :)

OK, I'm quite there now.

@rp7, I had a deeper look into your code. I think, what you are trying to implement is already there (but not interfaced yet). Look at the code of current GroupAggregator: there is a set of constants STORAGE_CLIENT_MODE_* (and related STORAGE_CLIENT_FLAG_*). These are used to control how storage clients are used on a per-storage-client basis. You can find this setting and on the storage client aggregation settings:

So, you can have an external entity that is not read-only (ie. triggers save/update/delete events), but does not perform anything on its storage clients (if their modes are set to STORAGE_CLIENT_MODE_READONLY). It is more powerful to manage that for each client rather than globally. For instance, I have an external entity that uses 2 storage clients, one "TSV file" storage client, and one "SQL database" storage client. It would be possible to have the TSV file storage client in STORAGE_CLIENT_MODE_READONLY while the SQL database storage client would be in STORAGE_CLIENT_MODE_WRITEONLY. If you have a data aggregator that supports field mapping by storage client, then you can convert a TSV file into a database record just by saving an external entity!

That's just a very simple example of how it would be useful to manage the "read/write mode" on a per-storage-client basis. I'm currently implementing a more powerful data aggregator ( data model aggregator → ), based on the group aggregator, that would allow very powerful and useful things in my business. It would allow to aggregate data from several source as well as converting/transferring data from one source to others (while using custom data processors sometimes, to re-work the source data).

Now, I would like to go a bit further in this discussion and consider the other side! :-) From the Drupal side, we can manage what's going on. What about having a Drupal REST service provided by external entities, that could get triggered when external data is modified? For instance, I have an external source that updates its data and I would like to let my Drupal site know that its corresponding external entity cache needs to be invalidated/updated. Then, it would mean that I could set my local Drupal cache "permanent" and it will only be updated when the data actually changes! That would be efficient. But maybe, it could be created in a separate module.

Any update on this?

After rethinking of your use case and looking at the code, I don't believe you're trying to achieve things the right way.
I think the current REST client implementation already provides what is need to do what you want, and the xntt_views plugin could also be an alternative for dynamic filtering (while it still has issues to solve).

I will close this issue as "won't fix" but you may reopen it if you are not satisfied. You may also consider chatting with me on the #external-entities channel on Drupal slack!.

No news. Reopen if not satisfied.

guignonv → created an issue.

1) Was already solved in v3 at the very beginning.
2) Should be solved by commit # 8df83e41.

Feel free to reopen the issue if not satisfied. :-p

Commit # 60bbb626 provide major improvement: it is now possible to manage conflicting routes and choose custom routes different from the external entity type identifier.

@mortona2k: Could you check that commit #84895eda (3.0.x branch) does the job for REST client that are not supporting client-side filtering?

It should now be possible to uninstall the external entity file field sub-module. I tested with an xntt using it and it was not complaining anymore.

The merge also provides improvements on the UI: there's no need for an extra field to map the file URIs anymore. An external file URIs property is provided by the file field mapper itself for the mapping. An update is also provided to upgrade existing configs using an extra field for the URI mapping, to transfer that mapping to the new external file URI mapping. Just run the update and you should be fine.

That makes me think I was wondering if the way we assign routes could not be problematic. I forgot what I did bu I think if you use the Drupal contact form and then create an external entity called "contact", you don't have access to the contact page anymore. To be checked (I postponed that task and forgot about it). Maybe we should handle XNTT routes differently? For instance, provide a default route based on the type, like now, but allow user override on the XNTT type form? Or should forbid the use of existing routes as XNTT type machine name? There is also this recurrent problem of XNTT with underscore in their machine name that is translated as dashes in URLs (while underscores are leagal in URLs but not following standards).

As we chatted on slack, I think I'll implement a way to support the 'IN' operator on the identifier by default for any storage client. That would be a generic solution that would avoid enabling Drupal-side filtering for REST clients, which can be problematic.

Fixed by last commit.

I had a look and I have a good and a "bad" news. The good news is that it IS possible to reference external entities using a regular entity reference field, without any modification or trick. It already works. That was the good news... :-)

The "bad" news is that the storage client(s) used to fetch external entities must support the 'IN' operator in query filtering. If it does not, there's no way for the default Drupal entity reference validator to fetch all the referenced external entities and validate their IDs. That's why @mortona2k got issue referencing external entities.

When you use REST services, you don't have a "standard" query that returns all the valid IDs, given a list of IDs. For the builtin REST client, there is a way to get around that but with a real cost. On the storage client settings, in the "filtering" section, you may check the box "Enable Drupal-side filtering". This will support Drupal filters such as "IN" as well as others. The problem will be that the REST client will need to fetch ALL the external entities from the REST service to filter them on the client side, which can be a real problem if there are many and/or if the service is slow. You may use cache (and pre-populate it using the XNTT manager) but it may not be an ideal solution.

Regarding tests, the external entity reference field is already tested appropriately (SimpleExternalEntityTest::testSimpleExternalEntity()). No need to add new tests.

So, I'll close that issue as "Working as designed". For the very specific case of REST services and the "IN" filter operator, one of you may create a new issue that would be a "feature request" for the REST client. I don't see so far an easy way to add that feature so propose solutions if you create that feature request! :)

Fixed and tested in commit #be6254123de042317a9a2973374445ec66dcb84e.

Looks good to me. Merging.

It should be fixed by latest commit #fbdd08f4

UPDATE: It needs more than a simple fix. An "external file storage" class needs to be created to replace all the default file storage class methods that relies on database entries. I've started some work and it will be fixed for v3. I hesitated to change the priority to "Major" as it should be uninstallable without any issue but it does not prevent the system from working.

Noted. I'll see that soon. Seems not too complicated to fix but it'll need tests.

I'll have a look next week.

Quick note: I have several sites using external entities with references to other external entities (same xntt type as well as different xntt type). So it should work unless there is a regression somewhere I missed, that does not affect my sites.

if an API call for data with an ID returns nothing, do we assume it's deleted, or something else?

You can't "assume" things in my opinion, since you may have a service temporarily unavailable for instance, or a bug in a remote source. Maybe, it could be a setting on the storage client config, to tell how to behave...

I'm on vacation and will have a look when I'm back in a week.

First, I'd like to clarify one thing: from my perspective, you cannot use External Entities 3.0.0 with the xnttfiles module as they are not compatible. The "xnttfiles" module is compatible with external entity 2.0.x and has been integrated into 3.0.0 core now.

The problem you are referring to, however, is reproducible in 3.0.0 using the "External entities file and image fields support" sub-module.
I can reproduce the problem and I'll fix for v3. If you really have xnttfiles module installed, it might probably be because you updated from 2.0.0 to 3.0.0. I got a dev site with both xntt 3.0.0 and xnttfiles, so it is not impossible but it should not happen on clean installs.

Could you confirm which version of External Entity module you're running (2.0.x or 3.0.x) and if you are really using the xnttfiles → module (while a 3.0.0 update should have replaced the use of the xnttfiles module by the xntt 3.0.0 core file features).

UPDATE: Drupal\xntt_views\Entity\Render\ExternalEntityFieldRenderer needs to be modified line 36-39:

      $dynamic_renderers = [
        '***LANGUAGE_entity_translation***' => 'TranslationLanguageRenderer',
        '***LANGUAGE_entity_default***' => 'DefaultLanguageRenderer',
      ];

We should provide a new implementation for these classes.

Also, @kalpanajaiswal is right for ExternalEntityField that needs to be also modified to not work with SQL tables. Instead of table names, field machine names should be used.

Quick translation support setup when a single request returns all the translations, each under a sub-key. Ex.:

[
  'id' => 42,
  'en' => [
    'title' => 'some title',
    'body' => 'some content',
  ],
  'fr' => [
    'title' => 'un titre',
    'body' => 'du contenu',
  ],
];

• I assume your site has multi-lingual support enabled
• Edit your external entity type and go to the new "Language settings" tab below the "Storage" tab
• Check "Enable translations"
• For each supported language, check "Override field mapping"
• Now, for each mapped field, prefix your raw field name (or adapt your field path) with the corresponding language prefix.
  For instance, a title field initially mapped to "en.title" should be mapped to "fr.title" for the French language field mapping override. If you know some external fields are not translated, you may keep the original mapping (for instance id remains "id"). You may also remove field mapping (ie. "Not mapped") of some fields if needed as well as map language-specific fields that are not mapped by default.
• If you don't always have a translation for a given language, you may map its ID field property using the "Conditional mapping" property mapper and check if another translated field is set. For instance, you can check if the raw field "fr.title" is not empty to map the French ID field to the raw field "id". When the French title is not set or empty, the French ID field will not be mapped, resulting in a non-existent translation instance.

Fixed by the new multi-lingual and translation support for external entities added since commit #a0d7c58e503c597242e5493971d44ee5375bd22e.

I will not implement and upgrade as it is too much work for not so many users, while it is not so complicated to update manually.
Here is the manual update procedure after updating to beta 6:
- I assume your site has multi-lingual support enabled
- Edit your external entity type and go to the new "Language settings" tab below the "Storage" tab
- Check "Enable translations"
- For each supported language, check "Override field mapping"
- Now, for each mapped field, prefix your raw field name (or adapt your field path) with the corresponding language prefix
For instance, a "title" field initially mapped to "remote_title" should be mapped to "fr.remote_title" for the French language field mapping override. If you know some remote fields are not translated, you may keep the original mapping (for instance for numbers or identifiers).

Update: I will soon merge the update on translation support. Once it is done, it might impact this issue and we will see what it still needs to have problems fixed since it was related to the language module (from my previous investigations).

Thanks kalpanajaiswal, I checked what you pointed out and the changes make sense (and not a big deal). Merged.
@Colan if you can test and confirm the fix, I let you close the issue.

Duplicate of 🐛 Call to undefined method ExternalEntityStorage::getTableMapping() in Drupal\views\Entity\Render\TranslationLanguageRenderer->getLangcodeTable() Active

Added a link for entity developers.

Updated and improved the documentation to better use native features and go farther.

I just committed (143a9d5e236ae1b6f9442b6e6711867427b2871b) a new working implementation for multi-lingual support on branch "3.0.x-translation-support". I'm planing to try to write an update to turn vertical aggregators using the 'language' mode into language field mapping overrides and deprecate 'translation' vertical aggregation.

I just committed (143a9d5e236ae1b6f9442b6e6711867427b2871b) a new working implementation for multi-lingual support on branch "3.0.x-translation-support".

Now, when you have external sources that provide multiple languages, you can override storage settings and field mapping accordingly. No need to have a specific raw structure keyed by Drupal language codes, and no need to use vertical aggregator with "language" type aggregation!

I've removed the "language" field mapping as it is automatically set according to the language overrides. However, I wonder if there is a use case where people would get external data without knowing their language and would need to force-map that field to an external value providing the language. I'll think more about it and may change things a little.

I'll need to try to write an update to turn vertical aggregators using the 'language' mode into language field mapping overrides.

I'll also need to add translation tests before asking for community tests and merging to core.

I'll check that once I'm done with the translation support issue.
It's weird though. I don't see how the system would know about external files since their virtual file identifier is not in the database.

I've added branch "3.0.x-translation-support" to main repos. Work in progress...

I'm not there yet but I'll keep an eye on this issue. ;)

Merged. Thanks! :)

Investigation update:

Drupal ContentEntityBase expects to have translations stored in member ->translations[$langcode]['entity'].
Furthermore, translated field values need to be stored in ->values[$field_name][$langcode] (provided by the mapped raw data array to the constructor).

I want to support those use cases:
- data aggregator providing all the translated data at once in the raw data array (ie. not possible or not efficient to separate translations)
- data aggregator only return one (or a reduced set of) translated data but can fetch the requested translated data on demand
- fetched translated data may not be keyed using Drupal language codes

New approach, closer to @rp7 initial one:
- A new "Language settings" tab on external entity type configuration (ExternalEntityTypeForm) where:
- translations can be enabled/disabled
- for each non-default language, a checkbox to enable field mapping override and another one for storage (data aggregator) override
- for both overrides, the same sub-forms used for the default field mapping and storage settings. When override becomes checked, it will duplicate original settings and user will be able to completely change the settings (ie. remove a field mapping or even change the data aggregator for instance).
- on xntt loading, ExternalEntityStorage::extractEntityValuesFromRawData() will populate ->values[$field_name][$langcode] with the data it has
- to manage on-demand translation, ExternalEntity::getTranslation() will be overriden to fetch additional translations when needed
- to know if a translation is available for a given langcode, either their is a corresponding storage config override (meaning new data needs to be fetched) or a corresponding field mapping override (meaning data is already there but translated fields need to be mapped)

-This post may be updated later according to new investigations-

UPDATE: I'll also include filed mapping override by language to support the use case of this issue: data in multiple languages.
I'll create a branch.

guignonv → made their first commit to this issue’s fork.

Fixed code style and added ordering of options in annotation selection part to find items in alphabetical order.
Merged.