Value mapping plugin is breaking numeric keys

I'm able to bypass the config form by editing the yaml file and importing.

Now mapping the key to value is working, however only for IDs for existing terms.

It's not able to create new terms from text, even though the field allows it.

I tried using the automatic detection plugin, hoping that would convert it if needed. Maybe that's where the logic should go for an entity lookup, or should it be another plugin? I'll make another ticket for it, but still hashing out how things work in this one.

I switched to a text field to simplify, but still having trouble. Looks like importing numeric keys from config doesn't work around it.

This call to mergeDeep() is clobbering the array keys:
https://git.drupalcode.org/project/external_entities/-/blob/3.0.x/src/Da...

https://www.drupal.org/project/drupal/issues/2115245 →
....?

Switching from NestedArray:mergeDeep() to mergeDeepArray() with $preserve_integer_keys = TRUE seems to work.

This will need testing to see if the change breaks anything.
NestedArray:mergeDeep() is still used in many places and may need further review.

I'm able to map the integers to text for a text field.
Also able to map integers to taxonomy ids for term reference field.

Still can't create new taxonomy terms from the mapped text (#2), but that can be a different issue.

I updated the External Entities Drupal.org submodule to demonstrate how this works.

Just enable external_entities_drupalorg and go to the route for an issue:
/drupalorg-rest-issue/3536965

You should see the Title, Body, and Status for this issue.

Patch for 3.0 beta 5.

I'm on vacation and will have a look when I'm back in a week.

Looks good to me. Merging.

Automatically closed - issue fixed for 2 weeks with no activity.