Fix the issues reported by phpcs

@chetan 11 can you push your progress, I would like to get this issue moving

HI @pefferen,
I have fixed all the phpcs issue in the above module, please check raised MR,
Thanks.

nice work @chetan 11, the test are failing. in one instance because the definition of the constant has changed, the define function can be replaced with const in this case, only not as a class inside a module file. We can also move the constant to ExternalEntityInterface and refactor the usage.

 /**
  * Property indicating if the annotated external entity should not be saved.
@@ -37,7 +37,10 @@ use Drupal\Core\Render\Element;
  *
  * @internal
  */
-define('EXTERNAL_ENTITIES_BYPASS_ANNOTATED_EXTERNAL_ENTITY_SAVE_PROPERTY', 'BYPASS_ANNOTATED_EXTERNAL_ENTITY_SAVE');
+class ExternalEntitiesConstants {
+  const BYPASS_ANNOTATED_EXTERNAL_ENTITY_SAVE_PROPERTY = 'BYPASS_ANNOTATED_EXTERNAL_ENTITY_SAVE';
+
+}

Issue summary updated

Hi

I reviewed MR!26, applied against External Entities 8.x-2.x-dev with Drupal core version 10.1.7 and there are still phpcs errors and warnings shown below:

FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/external_entities/src/ExternalEntityAccessControlHandler.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 42 ERRORS AND 1 WARNING AFFECTING 41 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  20 | ERROR   | [x] Opening brace should be on the same line as the declaration
  37 | ERROR   | [x] Opening brace should be on the same line as the declaration
  38 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  39 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  46 | ERROR   | [x] Opening brace should be on the same line as the declaration
  47 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  57 | ERROR   | [x] Opening brace should be on the same line as the declaration
  58 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  60 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  61 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
  62 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
  63 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 14
  66 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
  66 | ERROR   | [x] Expected newline after closing brace
  67 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 14
  68 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
  69 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  71 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  77 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  78 | ERROR   | [x] Opening brace should be on the same line as the declaration
  79 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  80 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  81 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
  84 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  86 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  92 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  93 | ERROR   | [x] Opening brace should be on the same line as the declaration
  94 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  96 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  97 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  98 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  98 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  99 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 100 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 101 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 102 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 103 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 14
 106 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 107 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 109 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 119 | ERROR   | [x] Opening brace should be on the same line as the declaration
 120 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 124 | ERROR   | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 42 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------

I also found warning: 1 line adds whitespace errors. after applying the MR.

Kindly check and advise, please.
Thank you.

Venkatraman Ganesan → made their first commit to this issue’s fork.

Fixed remaining phpcs issues. Please review.

All the error have been fixed.
Please refer the screenshot.

committed to dev

I suspect this latest commit broke the module. See automated test results.

oops , this is the actual revert patch I was intending on uploading in the previous comment.

The revert patch in #22 is definitely fixing the regression.
Compare the no-change results (4 failures) with the revert patch in #22 that has 100% pass no fails.

Please merge MR 30 to fix the regressions.

OR, commit patch 25.

Proven that the previous changes broke the module , see test results in the no_change patch #21

Patch #25 passes automated tests as before.

See screenshot:

Thanks for your work @joseph, was intending to continue to work on the commits but some thing came up, I will check your new work soon

thanks all for your effort, merged the issue

Thank you @pefferen