🇵🇭Philippines paraderojether
Hi
I reviewed MR!9, and there are still phpcs issues shown below:
contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_dependent_filters
FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/views_dependent_filters/README.txt
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 106 characters
--------------------------------------------------------------------------------------------------
FILE: ...sers/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/views_dependent_filters/src/Plugin/views/filter/ViewsDependentFilter.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------------------------------------------------------------
130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
143 | WARNING | Unused variable $form_state_copy.
162 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
163 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
171 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
174 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
177 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
193 | WARNING | Unused variable $controller_filter.
233 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
236 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
253 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
| | instead
--------------------------------------------------------------------------------------------------------------------------------------
Time: 155ms; Memory: 12MB🇵🇭Philippines paraderojether
Hi
I reviewed MR!7 and there are still remaining issues reported by phpcs show below:
contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig contentimport
FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/contentimport/contentimport.module
--------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------
312 | ERROR | [x] Whitespace found at end of line
315 | ERROR | [x] Expected 1 space before "?"; 0 found
315 | ERROR | [x] Expected 1 space before ":"; 0 found
317 | WARNING | [x] A comma should follow the last multiline array item. Found: $path_data
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------
Time: 296ms; Memory: 14MB🇵🇭Philippines paraderojether
Hi
I reviewed MR!17, confirmed it is applied cleanly and the configure link is added successfully.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
🇵🇭Philippines paraderojether
Hi
I reviewed MR!10, and confirmed it fixes the issues reported by phpcs.
tmgmt_openai curl https://git.drupalcode.org/project/tmgmt_openai/-/merge_requests/10.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 7849 0 7849 0 0 24386 0 --:--:-- --:--:-- --:--:-- 24917
patching file README.md
patching file 'src/OpenAiTranslatorUi.php'
patching file 'src/Plugin/tmgmt/Translator/OpenAiTranslator.php'
patching file tmgmt_openai.info.yml
patching file tmgmt_openai.install
➜ tmgmt_openai cd ..
➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig tmgmt_openai
➜ contrib
Moving this to RBTC.
Thank you.
🇵🇭Philippines paraderojether
I reviewed patch #10 and confirmed it fixes the issues reported by phpcs.
permission_watchdog git:(2.x) curl https://git.drupalcode.org/project/permission_watchdog/-/merge_requests/1.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6652 0 6652 0 0 22518 0 --:--:-- --:--:-- --:--:-- 22937
patching file permission_watchdog.install
patching file permission_watchdog.module
patching file 'src/Entity/RoleChangeLog.php'
patching file 'src/Form/SettingsForm.php'
patching file 'src/Plugin/DevelGenerate/RoleChangeDevelGenerate.php'
patching file 'src/Plugin/Field/FieldFormatter/PermissionActionDefaultFormatter.php'
patching file 'src/Plugin/Field/FieldType/PermissionActionItem.php'
patching file 'tests/src/Functional/PermissionWatchdogTest.php'
➜ permission_watchdog git:(2.x) ✗ cd ..
➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig permission_watchdog
➜ contrib
I also created an MR so that it would be easy for the maintainers to review.
Please review the MR!. Thank you.
🇵🇭Philippines paraderojether
paraderojether → made their first commit to this issue’s fork.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!32, confirmed it is applied successfully and it fixes the duplicated allowed types help text issue.
I added screenshots for reference.
Moving this RTBC.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!2, and confirmed phpcs issues listed on the description are fixed, however there are still phpcs issues remaining after running this command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig upload_node_pictures
contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig upload_node_pictures
FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/upload_node_pictures/README.md
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 24 WARNINGS AFFECTING 24 LINES
----------------------------------------------------------------------------------------------
1 | WARNING | [ ] Line exceeds 80 characters; contains 234 characters
3 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
5 | WARNING | [ ] Line exceeds 80 characters; contains 121 characters
7 | WARNING | [ ] Line exceeds 80 characters; contains 127 characters
9 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
13 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters
14 | WARNING | [ ] Line exceeds 80 characters; contains 153 characters
15 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters
16 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
17 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
18 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
19 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
20 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
24 | WARNING | [ ] Line exceeds 80 characters; contains 135 characters
28 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters
31 | WARNING | [ ] Line exceeds 80 characters; contains 132 characters
34 | WARNING | [ ] Line exceeds 80 characters; contains 211 characters
37 | WARNING | [ ] Line exceeds 80 characters; contains 221 characters
40 | WARNING | [ ] Line exceeds 80 characters; contains 148 characters
43 | WARNING | [ ] Line exceeds 80 characters; contains 211 characters
46 | WARNING | [ ] Line exceeds 80 characters; contains 167 characters
49 | WARNING | [ ] Line exceeds 80 characters; contains 169 characters
52 | WARNING | [ ] Line exceeds 80 characters; contains 181 characters
55 | WARNING | [ ] Line exceeds 80 characters; contains 215 characters
55 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------
Time: 218ms; Memory: 12MBMoving this needs work.
🇵🇭Philippines paraderojether
I updated the MR to fix the remaining phpcs issues, please review.
Thank you.
🇵🇭Philippines paraderojether
paraderojether → made their first commit to this issue’s fork.
🇵🇭Philippines paraderojether
I created MR to fix remaining issue, please review.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed patch #2, and there is 1 phpcs remaining.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig entity_pager
FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/entity_pager/src/EntityPager.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------
Time: 372ms; Memory: 12MB🇵🇭Philippines paraderojether
Hi
I reviewed patch #1, and there are still phpcs issues remaining shown below:
codemirror_editor git:(147c3b7) curl https://www.drupal.org/files/issues/2023-07-31/CodeMirrorEditorWidget.php-3370177-14.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 663 100 663 0 0 360 0 0:00:01 0:00:01 --:--:-- 361
patching file 'src/Plugin/Field/FieldWidget/CodeMirrorEditorWidget.php'
➜ codemirror_editor git:(147c3b7) ✗ cd ..
➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig codemirror_editor
FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/codemirror_editor/codemirror_editor.module
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
62 | ERROR | The text '@deprecated Use Drupal\codemirror_editor\CodemirrorModeManagerInterface::getDefinitions() instead.' does not match the standard format: @deprecated in
| | %deprecation-version% and is removed from %removal-version%. %extra-info%.
62 | ERROR | Each @deprecated tag must have a @see tag immediately following it
67 | ERROR | The trigger_error message 'codemirror_editor_load_modes() is deprecated. Use Drupal\codemirror_editor\CodemirrorModeManagerInterface::getDefinitions() instead'
| | does not match the strict standard format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
80 | ERROR | The text '@deprecated Use Drupal\codemirror_editor\CodemirrorModeManagerInterface::normalizeMode() instead.' does not match the standard format: @deprecated in
| | %deprecation-version% and is removed from %removal-version%. %extra-info%.
80 | ERROR | Each @deprecated tag must have a @see tag immediately following it
85 | ERROR | The trigger_error message 'codemirror_editor_load_modes() is deprecated. Use Drupal\codemirror_editor\CodemirrorModeManagerInterface::normalizeMode() instead' does
| | not match the strict standard format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/codemirror_editor/src/CodeMirrorLibraryBuilder.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | The text '@deprecated Use \Drupal\codemirror_editor\LibraryBuilder' does not match the standard format: @deprecated in %deprecation-version% and is removed from
| | %removal-version%. %extra-info%.
8 | ERROR | Each @deprecated tag must have a @see tag immediately following it
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 610ms; Memory: 12MBThank you.
🇵🇭Philippines paraderojether
paraderojether → made their first commit to this issue’s fork.
🇵🇭Philippines paraderojether
🇵🇭Philippines paraderojether
Hello a.aaronjake, I can't replicate the issue on my end.
🇵🇭Philippines paraderojether
paraderojether → made their first commit to this issue’s fork.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!5, and confirmed it fixes all the issues reported by phpcs.
auto_username git:(8.x-1.5) curl https://git.drupalcode.org/project/auto_username/-/merge_requests/5.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 25823 0 25823 0 0 67039 0 --:--:-- --:--:-- --:--:-- 68496
patching file .gitlab-ci.yml
patching file auto_username.module
patching file auto_username.services.yml
patching file 'config/install/auto_username.settings.yml'
patching file 'src/AutoUsernameOptions.php'
patching file 'src/AutoUsernamePunctuationOptions.php'
patching file 'src/AutoUsernameUtilities.php'
patching file 'src/Form/AutoUsernameSettingsForm.php'
➜ auto_username git:(8.x-1.5) ✗ cd ..
➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig auto_username
➜ contrib
Moving this to RTBC.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed Patch 3, applied against Bootstrap External Link Pop-up 2.x-dev and confirmed it fixes the issues reported by phpcs.
bootstrap_external_link_popup git:(2.x) curl https://www.drupal.org/files/issues/2023-05-04/fix-for-issues-reported-by-phpcs-3358093-3.patch | patch
-p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 736 100 736 0 0 1452 0 --:--:-- --:--:-- --:--:-- 1474
patching file bootstrap_external_link_popup.module
➜ bootstrap_external_link_popup git:(2.x) ✗ cd ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig bootstrap_external_link_popup
➜ contrib git:(main) ✗ Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!8, applied against Migrate Generator 8.x-2.x-dev, and confirmed fixes the issues reported by phpcs.
migrate_generator git:(8.x-2.2) curl https://git.drupalcode.org/project/migrate_generator/-/merge_requests/8.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 33546 0 33546 0 0 78327 0 --:--:-- --:--:-- --:--:-- 79681
patching file README.md
patching file migrate_generator.post_update.php
patching file 'migrate_generator_export/README.md'
patching file 'migrate_generator_export/migrate_generator_export.links.task.yml'
patching file 'migrate_generator_export/src/Commands/DrushCommands.php'
patching file 'migrate_generator_export/src/ExportManager.php'
patching file 'migrate_generator_export/src/FieldsExportManager.php'
patching file 'migrate_generator_export/src/Form/EntityTypeExportConfigForm.php'
patching file 'migrate_generator_export/src/Form/ExportForm.php'
patching file 'migrate_generator_export/src/GeneratorExportPluginManager.php'
patching file 'migrate_generator_export/src/Plugin/GeneratorExportPluginDateBase.php'
patching file 'migrate_generator_export/src/Plugin/GeneratorExportPluginInterface.php'
patching file 'migrate_generator_export/src/Plugin/migrate_generator_export/process/FileExport.php'
patching file 'src/Commands/DrushCommands.php'
patching file 'src/GeneratorProcessPluginManager.php'
patching file 'src/Plugin/GeneratorProcessPluginBase.php'
patching file 'src/Plugin/GeneratorProcessPluginDateBase.php'
patching file 'src/Scanner.php'
➜ migrate_generator git:(8.x-2.2) ✗ cd ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig migrate_generator
➜ contrib git:(main) ✗ Thank you.
🇵🇭Philippines paraderojether
🇵🇭Philippines paraderojether
I fix the remaining issues, please review.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!18, it is applied cleanly however there are still remaining phpcs 2 errors shown below:
convert_bundles git:(2.0.x) curl https://git.drupalcode.org/project/convert_bundles/-/merge_requests/18.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 37895 0 37895 0 0 76538 0 --:--:-- --:--:-- --:--:-- 77336
Checking patch convert_bundles.api.php...
Checking patch convert_bundles.install...
Checking patch convert_bundles.module...
Checking patch src/Controller/EntityController.php...
Checking patch src/ConvertBundles.php...
Checking patch src/Form/ConvertBundlesForm.php...
Checking patch src/Plugin/Action/ConvertBundlesActionBase.php...
Checking patch src/Plugin/Derivative/ConvertBundlesLocalTask.php...
Checking patch src/Routing/RouteSubscriber.php...
Applied patch convert_bundles.api.php cleanly.
Applied patch convert_bundles.install cleanly.
Applied patch convert_bundles.module cleanly.
Applied patch src/Controller/EntityController.php cleanly.
Applied patch src/ConvertBundles.php cleanly.
Applied patch src/Form/ConvertBundlesForm.php cleanly.
Applied patch src/Plugin/Action/ConvertBundlesActionBase.php cleanly.
Applied patch src/Plugin/Derivative/ConvertBundlesLocalTask.php cleanly.
Applied patch src/Routing/RouteSubscriber.php cleanly.
➜ convert_bundles git:(2.0.x) ✗ cd ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig convert_bundles
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/convert_bundles/convert_bundles.module
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Database.
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/convert_bundles/src/Form/ConvertBundlesForm.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
14 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteBuilderInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------
Time: 375ms; Memory: 12MB
Please check and advise.
Thank you.
🇵🇭Philippines paraderojether
Hi Chandansha,
I reviewed Patch #2, applied it against Search Tracking 1.0.0, and confirmed the confirmed the configure link in the module list is added successfully.
Applying Patch:
search_tracking git:(main) ✗ curl https://www.drupal.org/files/issues/2024-02-22/3423112-2.patch | patch -p1
\ % Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 416 100 416 0 0 2263 0 --:--:-- --:--:-- --:--:-- 2377
patching file search_tracking.info.yml
➜ search_tracking git:(main) ✗
I also added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi silvi.addweb,
I reviewed MR!2, applied it against Instagram Feeds Listing 1.0.0 and confirmed it fixes the issues reported by phpcs.
instagram_feeds_listing git:(main) ✗ curl https://git.drupalcode.org/project/instagram_feeds_listing/-/merge_requests/2.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6820 0 6820 0 0 13750 0 --:--:-- --:--:-- --:--:-- 14004
patching file 'src/Form/InstagramFeedAdminForm.php'
patching file 'src/InstagramBasicDisplayApi.php'
➜ instagram_feeds_listing git:(main) ✗ cd ..
➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig instagram_feeds_listing
➜ contrib git:(main) ✗ Thank you.
🇵🇭Philippines paraderojether
Hi silvi.addweb,
I reviewed MR! 3, and the MR is skipped or not applied successfully, please see below:
instagram_feeds_listing git:(main) ✗ curl https://git.drupalcode.org/project/instagram_feeds_listing/-/merge_requests/3.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 593 0 593 0 0 927 0 --:--:-- --:--:-- --:--:-- 938
Skipped patch 'instagram_feeds_listing.info.yml'.
➜ instagram_feeds_listing git:(main) ✗
Please check and advise.
Thanks.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!1, it is applied cleanly however there are phpcs issues shown below:
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/timetrack/src/Form/FavoriteProjectForm.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\timetrack\Services\ProjectService.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/timetrack/src/Form/ProjectForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/timetrack/src/Form/TimeTrackingForm.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/timetrack/src/Services/ProjectService.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Datetime\TimeInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/timetrack/src/Services/TimeEntryService.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Datetime\TimeInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------
Time: 420ms; Memory: 12MB🇵🇭Philippines paraderojether
Hi sakthi_dev
I reviewed MR!10, however it the MR is skipped or not applied cleanly.
smallbusiness git:(main) ✗ curl https://git.drupalcode.org/project/smallbusiness/-/merge_requests/10.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 623 0 623 0 0 1232 0 --:--:-- --:--:-- --:--:-- 1248
Skipped patch 'smallbusiness.theme'.
smallbusiness git:(main) ✗
Please check and advise.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!12, applied against Ridiculously Responsive Social Sharing Buttons 8.x-2.x-dev and there are still phpcs issues shown below:
jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig rrssb
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/rrssb/rrssb.module
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------
20 | WARNING | Global constants should not be used, move it to a class or interface
-------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/rrssb/src/Form/RRSSBSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------
79 | WARNING | Variable $require_follow inside unset call is undefined.
186 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
189 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/rrssb/src/Plugin/Block/RRSSBBlock.php
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
27 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------
Time: 310ms; Memory: 12MB
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!6, applied against Simple Style Guide 2.0x-dev, confirmed patch applied cleanly however there are still remaining phpcs issue shown below:
jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig simple_styleguide
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/simple_styleguide/src/Tests/StyleguidePageTest.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
20 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
70 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------------
Time: 215ms; Memory: 10MB
jetherparadero@PrometSources-MacBook-Pro-3 contrib %
Please check and advise.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed patch 23, applied against Diff 8.x-1.x-dev, and confirmed it fixes the issues reported by phpcs.
jetherparadero@PrometSources-MacBook-Pro-3 diff % curl https://www.drupal.org/files/issues/2024-04-29/3013942-coding-standard-23.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 19618 100 19618 0 0 55959 0 --:--:-- --:--:-- --:--:-- 57029
patching file README.md
patching file 'css/diff.double-column.css'
patching file 'css/diff.single-column.css'
patching file diff.links.menu.yml
patching file diff.module
patching file diff.services.yml
patching file 'src/DiffEntityParser.php'
patching file 'src/DiffLayoutBase.php'
patching file 'src/Form/GeneralSettingsForm.php'
patching file 'src/Form/RevisionOverviewForm.php'
patching file 'src/Plugin/diff/Field/EntityReferenceFieldBuilder.php'
patching file 'src/Plugin/views/field/DiffFrom.php'
patching file 'src/Plugin/views/field/DiffTo.php'
patching file 'tests/modules/diff_test/diff_test.module'
patching file 'tests/src/Functional/DiffPluginEntityTest.php'
patching file 'tests/src/Functional/DiffPluginTest.php'
patching file 'tests/src/Functional/DiffRevisionTest.php'
jetherparadero@PrometSources-MacBook-Pro-3 diff % cd ..
jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig diff
jetherparadero@PrometSources-MacBook-Pro-3 contrib %Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!5, and confirmed it is applied however I got this warning warning: 1 line adds whitespace errors. while applying the patch.
jetherparadero@PrometSources-MacBook-Pro-3 button_field % curl https://git.drupalcode.org/project/button_field/-/merge_requests/5.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 22752 0 22752 0 0 49076 0 --:--:-- --:--:-- --:--:-- 49785
<stdin>:11: trailing whitespace.
- Button field reload action has been removed. Use the Rules Core
Checking patch README.txt...
Checking patch button_field.module...
Checking patch src/Plugin/Field/FieldFormatter/ButtonFieldBase.php...
Checking patch src/Plugin/Field/FieldFormatter/ButtonFieldHtml.php...
Checking patch src/Plugin/Field/FieldFormatter/ButtonFieldImage.php...
Checking patch src/Plugin/Field/FieldType/ButtonField.php...
Checking patch src/Plugin/Field/FieldWidget/ButtonFieldBase.php...
Checking patch src/Plugin/Field/FieldWidget/ButtonFieldHtml.php...
Checking patch src/Plugin/Field/FieldWidget/ButtonFieldImage.php...
Checking patch src/Plugin/migrate/field/d7/ButtonField.php...
Checking patch tests/src/TestSite/ButtonFieldInstallTestScript.php...
Applied patch README.txt cleanly.
Applied patch button_field.module cleanly.
Applied patch src/Plugin/Field/FieldFormatter/ButtonFieldBase.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/ButtonFieldHtml.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/ButtonFieldImage.php cleanly.
Applied patch src/Plugin/Field/FieldType/ButtonField.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/ButtonFieldBase.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/ButtonFieldHtml.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/ButtonFieldImage.php cleanly.
Applied patch src/Plugin/migrate/field/d7/ButtonField.php cleanly.
Applied patch tests/src/TestSite/ButtonFieldInstallTestScript.php cleanly.
warning: 1 line adds whitespace errors.
jetherparadero@PrometSources-MacBook-Pro-3 button_field % cd ..
jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml button_field
jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig button_field
jetherparadero@PrometSources-MacBook-Pro-3 contrib %
Please check and advise for the warning after applying patch.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!3, applied against VariationCache 8.x-1.5 and confirmed the patch is applied cleanly and it fixes the issues reported by phpcs.
jetherparadero@PrometSources-MacBook-Pro-3 variationcache % curl https://git.drupalcode.org/project/variationcache/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6710 0 6710 0 0 6932 0 --:--:-- --:--:-- --:--:-- 6982
patching file README.md
patching file 'src/Cache/CacheRedirect.php'
patching file 'src/Cache/VariationCache.php'
patching file 'src/Cache/VariationCacheFactory.php'
patching file 'src/Cache/VariationCacheFactoryInterface.php'
patching file 'src/Cache/VariationCacheInterface.php'
patching file variationcache.module
jetherparadero@PrometSources-MacBook-Pro-3 variationcache % cd ..
jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml variationcache
jetherparadero@PrometSources-MacBook-Pro-3 contrib %
+1 RTBC
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!3, applied against Mega Slider 1.5.4, confirmed the patch applied however there are still phpcs that are not fixed.
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!1, applied against Session Invalidator 1.00, and confirmed it is applied successfully and the hook help is added.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi govind_giri_goswami,
I reviewed MR!1, and it is applied successfully but the content is not related to the module and it is not helpful for the users.
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!1, applied it against Media Entity PodToo 1.x-dev, confirmed patch was applied successfully, and fixed all the issues reported by phpcs.
jetherparadero@PrometSources-MacBook-Pro podtoo % curl https://git.drupalcode.org/project/podtoo/-/merge_requests/1.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3204 0 3204 0 0 4666 0 --:--:-- --:--:-- --:--:-- 4711
Checking patch src/Form/PodTooForm.php...
Checking patch src/Plugin/Field/FieldFormatter/PodTooEmbedFormatter.php...
Checking patch tests/src/Functional/PodTooEmbedFormatterTest.php...
Applied patch src/Form/PodTooForm.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/PodTooEmbedFormatter.php cleanly.
Applied patch tests/src/Functional/PodTooEmbedFormatterTest.php cleanly.
jetherparadero@PrometSources-MacBook-Pro podtoo % cd ..
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml podtoo
jetherparadero@PrometSources-MacBook-Pro contrib %Thank you.
📌 | Spam Protection, AntiSpam, reCaptcha, Stop bad bots, tor, Spam submissions, web scraping / FREE by CloudFilt | Fix the PHP_CodeSniffer issues reported by GitLab CI
🇵🇭Philippines paraderojether
Hi
I reviewed patch 2, applied it against CloudFilt - Prevent & block bad bots - Bot Manager 1.0.x-dev, confirmed patch was applied successfully, and fixed all the issues reported by phpcs.
command used: phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml cloudfilt
jetherparadero@PrometSources-MacBook-Pro cloudfilt % curl https://www.drupal.org/files/issues/2024-03-13/Issues-3427593-Fixed-phpcs-issues.patch | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 5618 100 5618 0 0 11082 0 --:--:-- --:--:-- --:--:-- 11349
Checking patch cloudfilt.info.yml...
Checking patch cloudfilt.module...
Checking patch src/Form/CloudfiltConfigForm.php...
Checking patch src/StackMiddleware/CloudfiltStackMiddleware.php...
Applied patch cloudfilt.info.yml cleanly.
Applied patch cloudfilt.module cleanly.
Applied patch src/Form/CloudfiltConfigForm.php cleanly.
Applied patch src/StackMiddleware/CloudfiltStackMiddleware.php cleanly.
jetherparadero@PrometSources-MacBook-Pro cloudfilt % cd ..
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml cloudfilt
jetherparadero@PrometSources-MacBook-Pro contrib %Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!1, applied it against Username 1.0.x-dev, confirmed MR was applied successfully, and fixed all the issues reported by phpcs.
jetherparadero@PrometSources-MacBook-Pro username % curl https://git.drupalcode.org/project/username/-/merge_requests/1.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 42260 0 42260 0 0 101k 0 --:--:-- --:--:-- --:--:-- 103k
Checking patch css/username.style.css...
Checking patch modules/username_displayname/username_displayname.install...
Checking patch modules/username_displayname/username_displayname.module...
Checking patch modules/username_phone/src/Form/UsernamePhoneForm.php...
Checking patch modules/username_phone/src/Plugin/Validation/Constraint/UsernamePhoneRequiredValidator.php...
Checking patch modules/username_phone/src/Plugin/Validation/Constraint/UsernamePhoneUnique.php...
Checking patch modules/username_phone/username_phone.module...
Checking patch src/Controller/UsernameAutocompleteController.php...
Checking patch src/Form/UsernameSettingsForm.php...
Checking patch src/Plugin/migrate/process/UsernameReplaceToken.php...
Checking patch src/Routing/UsernameRouteSubscriber.php...
Checking patch src/UsernameGenerator.php...
Checking patch username.module...
Applied patch css/username.style.css cleanly.
Applied patch modules/username_displayname/username_displayname.install cleanly.
Applied patch modules/username_displayname/username_displayname.module cleanly.
Applied patch modules/username_phone/src/Form/UsernamePhoneForm.php cleanly.
Applied patch modules/username_phone/src/Plugin/Validation/Constraint/UsernamePhoneRequiredValidator.php cleanly.
Applied patch modules/username_phone/src/Plugin/Validation/Constraint/UsernamePhoneUnique.php cleanly.
Applied patch modules/username_phone/username_phone.module cleanly.
Applied patch src/Controller/UsernameAutocompleteController.php cleanly.
Applied patch src/Form/UsernameSettingsForm.php cleanly.
Applied patch src/Plugin/migrate/process/UsernameReplaceToken.php cleanly.
Applied patch src/Routing/UsernameRouteSubscriber.php cleanly.
Applied patch src/UsernameGenerator.php cleanly.
Applied patch username.module cleanly.
jetherparadero@PrometSources-MacBook-Pro username % cd ..
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml username
jetherparadero@PrometSources-MacBook-Pro contrib %Thank you.
🇵🇭Philippines paraderojether
Hi sakthi_dev,
I reviewed MR!36, and the MR is not applied cleanly I tried git apply -v and patch -p1 but I'm getting the error shown below:
jetherparadero@PrometSources-MacBook-Pro config_pages % curl https://git.drupalcode.org/project/config_pages/-/merge_requests/36.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 29496 0 29496 0 0 39377 0 --:--:-- --:--:-- --:--:-- 39698
patching file config_pages.module
patching file 'src/Command/GetValueCommand.php'
patching file 'src/Command/SetValueCommand.php'
patching file 'src/ConfigPagesAccessControlHandler.php'
patching file 'src/ConfigPagesContextBase.php'
patching file 'src/ConfigPagesContextManager.php'
patching file 'src/ConfigPagesForm.php'
patching file 'src/ConfigPagesListBuilder.php'
patching file 'src/ConfigPagesPermissions.php'
patching file 'src/ConfigPagesTypeForm.php'
patching file 'src/ConfigPagesTypeListBuilder.php'
patching file 'src/Controller/ConfigPagesController.php'
patching file 'src/Entity/ConfigPages.php'
patching file 'src/Entity/ConfigPagesType.php'
patching file 'src/Form/ConfigPagesClearConfirmationForm.php'
patching file 'src/Plugin/Block/ConfigPagesBlock.php'
patching file 'src/Plugin/Condition/ConfigPagesValueAccess.php'
1 out of 3 hunks failed--saving rejects to 'src/Plugin/Condition/ConfigPagesValueAccess.php.rej'
patching file 'tests/src/Functional/ClearConfigPageTest.php'
patching file 'tests/src/Functional/DeleteConfigPageTypeTest.php'
jetherparadero@PrometSources-MacBook-Pro config_pages % cd ..
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml config_pages
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/config_pages/src/Plugin/Condition/ConfigPagesValueAccess.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
217 | WARNING | Unused variable $cp_type.
217 | WARNING | Unused variable $data_type.
------------------------------------------------------------------------------------------------------------------------------------------
Time: 952ms; Memory: 12MB
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi Andrii Momotov,
I reviewed MR!7, and the MR is not applied successfully I tried git apply -v and patch -p1 but I'm getting the error shown below:
jetherparadero@PrometSources-MacBook-Pro taxonomy_protect % curl https://git.drupalcode.org/project/taxonomy_protect/-/merge_requests/7.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1128 0 1128 0 0 2298 0 --:--:-- --:--:-- --:--:-- 2325
Skipped patch 'taxonomy_protect.module'.
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!2, applied it against Multiselect Dropdown 1.0.x-dev and confirmed the hook help is added successfully.
I added a screenshot for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!1, applied it against Custom UUID 1.0.x-dev, and the hook_help was added successfully.
I added a screenshot for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi Andrii Momotov,
I reviewed MR!7, applied it against Popin 2.1.x-dev, and confirmed the hook_help is added successfully.
I added a screenshot for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi Mithun S,
I reviewed MR!3, the MR is not applied cleanly and there are still remaining warnings shown below:
jetherparadero@PrometSources-MacBook-Pro custom_css_class_to_body % curl https://git.drupalcode.org/project/custom_css_class_to_body/-/merge_requests/3.diff | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 4309 0 4309 0 0 1701 0 --:--:-- 0:00:02 --:--:-- 1705
patching file README.md
patching file custom_css_class_to_body.info.yml
1 out of 1 hunks failed--saving rejects to custom_css_class_to_body.info.yml.rej
patching file custom_css_class_to_body.module
jetherparadero@PrometSources-MacBook-Pro custom_css_class_to_body % cd ..
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml custom_css_class_to_body
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/custom_css_class_to_body/custom_css_class_to_body.info.yml
----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
----------------------------------------------------------------------------------------------------------------------------
Time: 106ms; Memory: 10MB
Kindly check and advise.
Thank you.
🇵🇭Philippines paraderojether
Hi ptmkenny,
I reviewed MR!4, confirmed it is applied cleanly and it fixes the issues reported by phpcs.
jetherparadero@PrometSources-MacBook-Pro alternative_user_emails % curl https://git.drupalcode.org/project/alternative_user_emails/-/merge_requests/4.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1732 0 1732 0 0 1216 0 --:--:-- 0:00:01 --:--:-- 1228
Checking patch alternative_user_emails.module...
Checking patch src/Plugin/Validation/Constraint/AlternativeUserEmailsValidator.php...
Applied patch alternative_user_emails.module cleanly.
Applied patch src/Plugin/Validation/Constraint/AlternativeUserEmailsValidator.php cleanly.
jetherparadero@PrometSources-MacBook-Pro alternative_user_emails % cd ..
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml alternative_user_emails
jetherparadero@PrometSources-MacBook-Pro contrib %
Moving this to RTBC.
Thank you.
🇵🇭Philippines paraderojether
🇵🇭Philippines paraderojether
Hi bhaveshdas,
I reviewed MR!1, applied against Ckeditor5 entity browser 1.0.x-dev with Drupal core version 10.1.7, and confirmed it fixes the issue reported by phpcs.
Command used: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,yml,twig ckeditor5_entity_browser
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,yml,twig ckeditor5_entity_browser
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/ckeditor5_entity_browser/src/Plugin/CKEditor5Plugin/CkeditorEntityBrowser.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------------
Time: 121ms; Memory: 10MB
jetherparadero@PrometSources-MacBook-Pro contrib % cd ckeditor5_entity_browser
jetherparadero@PrometSources-MacBook-Pro ckeditor5_entity_browser % curl https://git.drupalcode.org/project/ckeditor5_entity_browser/-/merge_requests/1.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 699 0 699 0 0 1661 0 --:--:-- --:--:-- --:--:-- 1688
Checking patch src/Plugin/CKEditor5Plugin/CkeditorEntityBrowser.php...
Applied patch src/Plugin/CKEditor5Plugin/CkeditorEntityBrowser.php cleanly.
jetherparadero@PrometSources-MacBook-Pro ckeditor5_entity_browser % cd ..
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,yml,twig ckeditor5_entity_browser
jetherparadero@PrometSources-MacBook-Pro contrib %Thank you.
🇵🇭Philippines paraderojether
Hi @darkdim,
I reviewed patch #16, and the patch did not apply successfully, I got the error below when applying the patch:
jetherparadero@PrometSources-MacBook-Pro metatag_ai % curl https://www.drupal.org/files/issues/2024-01-31/3415243-option_to_bulk_update_metatags_1.patch | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 8397 100 8397 0 0 12650 0 --:--:-- --:--:-- --:--:-- 12780
Checking patch web/modules/contrib/metatag_ai/metatag_ai.module...
Checking patch web/modules/contrib/metatag_ai/metatag_ai.install...
Checking patch web/modules/contrib/metatag_ai/src/Plugin/Action/GenerateMetatagAction.php...
Checking patch web/modules/contrib/metatag_ai/src/Plugin/GenerateMetatag.php...
error: while searching for:
namespace Drupal\metatag_ai\Plugin;
use Drupal\Core\Config\ConfigFactoryInterface;
use Drupal\Core\Logger\LoggerChannelFactoryInterface;
use Drupal\Core\State\State;
use GuzzleHttp\Client;
error: patch failed: web/modules/contrib/metatag_ai/src/Plugin/GenerateMetatag.php:3
error: web/modules/contrib/metatag_ai/src/Plugin/GenerateMetatag.php: patch does not apply
Checking patch web/modules/contrib/metatag_ai/config/install/system.action.generate_metatag_action.yml...I would also like to suggest creating a merge request so that will be easy for the maintainers to check the code.
Kindly check and advise, please.
Thankyou
🇵🇭Philippines paraderojether
Hi Raveen Thakur,
I reviewed MR!6, applied against Config import single 2.0.x-dev, and confirmed the MR is applied and the README.md is also added.
I attached screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi Ashutosh Ahirwal,
I reviewed patch #4 and applied it against Lightning Layout 3.0.x-dev with Drupal core version 10.1.7 and confirmed it fixes the issues reported bu phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed patch #2, applied it against Gumlet Image Styles And Formatters 1.0.2, and confirmed that the hook had been added.
I attached screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi
I checked MR!2, and the MR is empty. I reviewed patch #2 and applied, and there are still warnings/errors reported by phpcs shown below:
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/term_manager/term_manager.module
------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 3 WARNINGS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
1 | ERROR | [x] Missing file doc comment
2 | WARNING | [x] Unused use statement
3 | WARNING | [x] Unused use statement
3 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Url.
4 | WARNING | [x] Unused use statement
6 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
7 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
8 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
9 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
10 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
11 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/term_manager/config/install/term_manager.settings.yml
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/term_manager/term_manager.links.menu.yml
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
17 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/term_manager/term_manager.routing.yml
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
32 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/term_manager/term_manager.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/term_manager/src/Form/TermManagerSettingsForm.php
-------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------
81 | ERROR | [x] Whitespace found at end of line
97 | ERROR | [x] Whitespace found at end of line
99 | ERROR | [x] Expected 1 space after comma in argument list; 7 found
99 | ERROR | [x] Expected one space after the comma, 7 found
100 | ERROR | [x] Expected 1 space after comma in argument list; 6 found
100 | ERROR | [x] Expected one space after the comma, 6 found
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/term_manager/src/Form/TermManagerMoveForm.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 59 ERRORS AND 8 WARNINGS AFFECTING 55 LINES
-------------------------------------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
6 | WARNING | [x] Unused use statement
7 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
10 | WARNING | [x] Unused use statement
13 | WARNING | [x] Unused use statement
13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\taxonomy\Entity\Vocabulary.
14 | WARNING | [x] Unused use statement
47 | WARNING | [ ] Line exceeds 80 characters; contains 148 characters
47 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
48 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
49 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
50 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
51 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
86 | ERROR | [x] Whitespace found at end of line
91 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
93 | ERROR | [x] Whitespace found at end of line
94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
95 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
96 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
97 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
97 | ERROR | [x] Whitespace found at end of line
98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
99 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
100 | ERROR | [x] Whitespace found at end of line
101 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
104 | ERROR | [x] Line indented incorrectly; expected 5 spaces, found 4
105 | ERROR | [x] Whitespace found at end of line
107 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
108 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
109 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
110 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10
110 | ERROR | [x] Whitespace found at end of line
111 | ERROR | [x] Concat operator must be surrounded by a single space
112 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
114 | ERROR | [x] Whitespace found at end of line
123 | ERROR | [x] Whitespace found at end of line
123 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
124 | ERROR | [x] Whitespace found at end of line
125 | ERROR | [x] Expected 1 space before "="; 0 found
126 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
129 | ERROR | [x] Whitespace found at end of line
146 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
155 | ERROR | [x] Whitespace found at end of line
159 | ERROR | [x] Whitespace found at end of line
161 | ERROR | [x] Whitespace found at end of line
166 | ERROR | [x] Whitespace found at end of line
173 | ERROR | [x] Inline comments must start with a capital letter
173 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
175 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
176 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
177 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
178 | ERROR | [x] Whitespace found at end of line
179 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
179 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
180 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
180 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
180 | ERROR | [x] Whitespace found at end of line
182 | ERROR | [x] Whitespace found at end of line
186 | ERROR | [x] Whitespace found at end of line
187 | ERROR | [x] Whitespace found at end of line
189 | ERROR | [x] Expected 1 blank line after function; 0 found
190 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 64 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/term_manager/src/Controller/TermManagerController.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AND 2 WARNINGS AFFECTING 13 LINES
---------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
4 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
5 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
6 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
9 | ERROR | [x] You must use "/**" style comments for a class comment
10 | ERROR | [x] Missing function doc comment
10 | ERROR | [x] Expected 1 blank line before function; 0 found
11 | ERROR | [x] Short array syntax must be used to define arrays
12 | WARNING | [x] A comma should follow the last multiline array item. Found: 'Welcome to Term Manager.'
15 | ERROR | [x] Whitespace found at end of line
16 | ERROR | [x] Missing function doc comment
17 | ERROR | [x] Short array syntax must be used to define arrays
18 | WARNING | [x] A comma should follow the last multiline array item. Found: 'Term Manager: Move Term to another Vocabulary.'
21 | ERROR | [x] Expected 1 newline at end of file; 0 found
21 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
Time: 137ms; Memory: 10MB
Moving this to Needs work.
Thank you.
🇵🇭Philippines paraderojether
Hi Shruu_rao,
I applied patch #18, and there are still remaining phpcs errors shown below:
FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/group_domain/src/GroupDomainInfo.php
------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------
30 | ERROR | Missing member variable doc comment
31 | ERROR | Missing member variable doc comment
------------------------------------------------------------------------------------------------------
Time: 369ms; Memory: 12MB
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi bluegeek9,
I reviewed MR! 23, applied against Message 8.x-1.x-dev with Drupal core version 10.1.7, and there are still remaining issues reported by phpcs shown below:
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig, message
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/message.module
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
198 | WARNING | Unused variable $message.
----------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/tests/src/Functional/MessageEntityDelete.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------
172 | WARNING | Unused variable $delete_queue.
174 | WARNING | Unused variable $check_delete_queue.
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/tests/src/Functional/MenuTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
36 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
40 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
42 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/tests/src/Functional/MessageTemplateUiTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------
69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
109 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/tests/src/Kernel/Plugin/MessagePurge/QuotaTest.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
69 | WARNING | Unused variable $i.
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/README.md
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------
21 | WARNING | Line exceeds 80 characters; contains 85 characters
65 | WARNING | Line exceeds 80 characters; contains 82 characters
90 | WARNING | Line exceeds 80 characters; contains 84 characters
-----------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/modules/message_example/message_example.tokens.inc
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------
65 | WARNING | Unused variable $token_service.
70 | WARNING | Unused variable $langcode.
73 | WARNING | Unused variable $langcode.
75 | WARNING | Unused variable $sanitize.
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/FormElement/MessageTemplateMultipleTextField.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------
67 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
68 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
84 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Form/MessageTemplateForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
135 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
136 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Form/MessageSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
92 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
98 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
99 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
107 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
112 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
145 | WARNING | Unused variable $entity_id.
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Form/MessageTemplateDeleteConfirm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
18 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
25 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Entity/MessageTemplate.php
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
353 | WARNING | Unused variable $id.
--------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Entity/Message.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
408 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/Plugin/migrate/process/MessageProcessArguments.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
24 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/message/src/MessageTemplateListBuilder.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
20 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
22 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
Time: 1.29 secs; Memory: 12MB
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi realsp,
I reviewed MR! 2, applied against QR Code Fields 1.1.0 with Drupal core version 10.1.7, and confirmed it fixes the issue reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi realsp,
I reviewed MR!1, and applied against Pinterest Widget 1.0.2 with Drupal Core version 10.1.7, and there are still remaining issues by phpcs shown below:
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/pinterest_widget/pinterest_widget.module
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
18 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "log_pinterest_messages" but expected
| | "pinterest_widget_log_pinterest_messages"
43 | WARNING | Code after the RETURN statement on line 41 cannot be executed
53 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "get_pin_help_info" but expected "pinterest_widget_get_pin_help_info"
68 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "about_pinterest" but expected "pinterest_widget_about_pinterest"
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/pinterest_widget/pinterest_widget.info.yml
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
------------------------------------------------------------------------------------------------------------------------
Time: 582ms; Memory: 12MB
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi AstonVictor,
I reviewed MR!25, and applied against Prevnext 3.0.x-dev with Drupal core version 10.1.7. The MR is applied cleanly but there are still remaining phcpcs shown below:
jetherparadero@PrometSources-MacBook-Pro prevnext % curl https://git.drupalcode.org/project/prevnext/-/merge_requests/25.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2608 0 2608 0 0 6406 0 --:--:-- --:--:-- --:--:-- 6619
Checking patch prevnext.module...
Checking patch src/Plugin/Block/PrevNextBlock.php...
Checking patch src/Plugin/views/field/PrevNextLinks.php...
Applied patch prevnext.module cleanly.
Applied patch src/Plugin/Block/PrevNextBlock.php cleanly.
Applied patch src/Plugin/views/field/PrevNextLinks.php cleanly.
jetherparadero@PrometSources-MacBook-Pro prevnext % cd ..
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig prevnext
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/prevnext/README.md
------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 88 characters
4 | WARNING | Line exceeds 80 characters; contains 100 characters
6 | WARNING | Line exceeds 80 characters; contains 86 characters
11 | WARNING | Line exceeds 80 characters; contains 91 characters
41 | WARNING | Line exceeds 80 characters; contains 86 characters
------------------------------------------------------------------------------------------------
Time: 210ms; Memory: 10MB
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi Ashutosh Ahirwal,
I reviewed patch #3, applied against Document OCR AI21 Studio 1.0.0-alpha1 with Drupal core version 10.1.7, and confirmed it fixes the issue reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi Neha-Verma,
I reviewed MR!1 and I noticed that the README file is still README.txt, I replaced it with README.md, please review.
Thank you.
🇵🇭Philippines paraderojether
paraderojether → made their first commit to this issue’s fork.
🇵🇭Philippines paraderojether
Hi
I reviewed patch #2, applied against User term node access 1.0.0-alpha1 with Drupal core version 10.1.7 and confirmed the hook help is successfully added.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi Tirupati_Singh,
I reviewed MR!11, and applied it against Required Field Display 8.x-1.x-dev with Drupal core version 10.1.7 and confirmed it fixes the issues reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi nitin_lama,
I reviewed MR!130, applied against Facets 2.0.x-dev with Drupal core version 10.1.7 and there are still remaining phpcs errors/warnings shown below:
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/facets.routing.yml
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
57 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/facets.install
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\block\Entity\Block.
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/query_type/SearchApiGranularTest.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder.
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/widget/LinksWidgetTest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityStorageInterface.
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/widget/WidgetTestBase.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Entity\Facet.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/processor/ReplaceProcessorTest.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Entity\Facet.
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/processor/UidToUserNameCallbackProcessorTest.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityStorageInterface.
-----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/processor/DependentFacetProcessorTest.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\Entity\ConfigEntityType.
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Plugin/processor/ListItemProcessorTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
19 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigManager.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Unit/Utility/FacetsUrlGeneratorTest.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityStorageInterface.
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Functional/UrlIntegrationTest.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Entity\Facet.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Kernel/Entity/FacetFacetSourceTest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Exception\Exception.
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/tests/src/Kernel/Plugin/query_type/SearchApiDateTest.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\FacetInterface.
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/tests/src/Unit/Plugin/Processor/ResetFacetsProcessorTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/tests/src/Unit/Plugin/Processor/ShowTextWhenEmptyProcessorTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/tests/src/Functional/HierarchicalFacetIntegrationTest.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\facets\Functional\FacetsTestBase.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/tests/src/Functional/IntegrationTest.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets_summary\Entity\FacetsSummary.
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/src/Form/FacetsSummarySettingsForm.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/src/Form/FacetsSummaryForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/src/Processor/ProcessorInterface.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\PluginInspectionInterface.
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/src/Plugin/Block/FacetsSummaryBlockDeriver.php
----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\PluginBase.
----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_summary/src/FacetsSummaryManager/DefaultFacetsSummaryManager.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets_summary\FacetsSummaryInterface.
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_searchbox_widget/tests/src/Unit/Plugin/widget/SearchboxLinksWidgetTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityStorageInterface.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_range_widget/tests/src/Unit/Plugin/processor/RangeSliderProcessorTest.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\UrlHelper.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/modules/facets_range_widget/tests/src/Unit/Plugin/processor/SliderProcessorTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/facets.module
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
20 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Form/FacetForm.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\FacetSource\SearchApiFacetSourceInterface.
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/FacetSource/FacetSourcePluginBase.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContainerFactoryPluginInterface.
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Processor/ProcessorPluginBase.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\DependencyTrait.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Processor/ProcessorInterface.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\PluginInspectionInterface.
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/facet_source/SearchApiBaseFacetSource.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\FacetSource\FacetSourcePluginBase.
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/CountWidgetOrderProcessor.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Processor\SortProcessorInterface.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/ActiveWidgetOrderProcessor.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Processor\SortProcessorInterface.
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/DependentFacetProcessor.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\FacetManager\DefaultFacetManager.
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/TranslateEntityAggregatedFieldProcessor.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/DateItemProcessor.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/CombineFacetProcessor.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\FacetManager\DefaultFacetManager.
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/BooleanItemProcessor.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/facets/processor/RawValueWidgetOrderProcessor.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\facets\Processor\SortProcessorInterface.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Plugin/Block/FacetBlock.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/FacetListBuilder.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html.
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/GetFacetCacheContexts.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/UrlCreated.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/QueryStringCreated.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/PostBuildFacet.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/GetFacetCacheTags.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Event/GetFacetCacheMaxAge.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\EventDispatcher\Event.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/facets/src/Utility/FacetsUrlGenerator.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpFoundation\RequestStack.
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------
Time: 6.78 secs; Memory: 20MB
Moving this to Needs work.
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi Gautam_105,
I reviewed MR!9, and there are still remaining phpcs errors/warnings shown below:
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/js/image-sizes.es.js
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/README.md
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
38 | WARNING | Line exceeds 80 characters; contains 86 characters
54 | WARNING | Line exceeds 80 characters; contains 84 characters
---------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/src/Form/ImageSizesPresetEntityForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
77 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
81 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead
87 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/src/Plugin/Field/FieldFormatter/ImageSizesPresetFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
44 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
88 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
124 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/src/Commands/GenerateImageSizeCommand.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------------------------------------
140 | WARNING | Unused variable $smallesStyle.
143 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead
204 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
206 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
288 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
291 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
301 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/image_sizes/src/Commands/AddFormatCommand.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
76 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------
Time: 345ms; Memory: 12MB
Moving this to Needs Work.
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi sakthi_dev,
I reviewed MR!3, applied against Dark Responsive 1.0.x-dev with Drupal core 10.1.7, and there are still remaining issues reported by phpcs shown below:
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/themes/contrib/dark_responsive/dark_responsive.theme
------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------
37 | ERROR | [x] Expected 1 space after IF keyword; 0 found
37 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
74 | WARNING | [ ] Unused variable $video_path.
77 | WARNING | [ ] Unused variable $video_path.
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/themes/contrib/dark_responsive/theme-settings.php
---------------------------------------------------------------------------------------------------------------
FOUND 30 ERRORS AFFECTING 17 LINES
---------------------------------------------------------------------------------------------------------------
21 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
22 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
22 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
23 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
23 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
24 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
24 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
25 | ERROR | [x] Array indentation error, expected 3 spaces but found 4
26 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
29 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
29 | ERROR | [x] Array indentation error, expected 4 spaces but found 2
30 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
30 | ERROR | [x] Array indentation error, expected 4 spaces but found 2
31 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
31 | ERROR | [x] Array indentation error, expected 4 spaces but found 2
32 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
32 | ERROR | [x] Array indentation error, expected 4 spaces but found 2
33 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
33 | ERROR | [x] Array closing indentation error, expected 2 spaces but found 1
34 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
34 | ERROR | [x] Whitespace found at end of line
35 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
36 | ERROR | [x] Array indentation error, expected 3 spaces but found 4
37 | ERROR | [x] Array closing indentation error, expected 1 spaces but found 2
38 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
39 | ERROR | [x] Expected 1 space after IF keyword; 0 found
39 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
Command used: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml,twig dark_responsive
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi Rassoni,
I also reviewed MR!1, applied against Moderate diff 1.0.x-dev with Drupal core version 10.1.7, and confirmed it fixes the issue reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi vishaljd,
I reviewed MR!72, applied against Migrate Plus 6.0.x-dev with Drupal core version 10.1.7 and there are still phpcs errors and warnings shown below:
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/migrate_example/migrate_example_setup/migrate_example_setup.install
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/migrate_json_example/migrate_json_example.install
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/migrate_plus.module
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/tests/src/Unit/data_fetcher/HttpTest.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate_plus\AuthenticationPluginInterface.
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/tests/src/Unit/data_fetcher/FileTest.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate\MigrateException.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/tests/src/Unit/process/StrReplaceTest.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 14 LINES
------------------------------------------------------------------------------------------------------------------------------------
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
33 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
34 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
47 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
48 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
58 | ERROR | [x] Expected 1 blank line after function; 2 found
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
62 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
63 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
73 | ERROR | [x] Expected 1 blank line after function; 2 found
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
77 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
78 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate/process/EntityValueTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\language\Entity\ConfigurableLanguage.
------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/README.md
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 19 WARNINGS AFFECTING 19 LINES
----------------------------------------------------------------------------------------------------
33 | WARNING | Line exceeds 80 characters; contains 123 characters
39 | WARNING | Line exceeds 80 characters; contains 147 characters
44 | WARNING | Line exceeds 80 characters; contains 154 characters
45 | WARNING | Line exceeds 80 characters; contains 129 characters
46 | WARNING | Line exceeds 80 characters; contains 91 characters
48 | WARNING | Line exceeds 80 characters; contains 136 characters
50 | WARNING | Line exceeds 80 characters; contains 153 characters
61 | WARNING | Line exceeds 80 characters; contains 148 characters
62 | WARNING | Line exceeds 80 characters; contains 347 characters
69 | WARNING | Line exceeds 80 characters; contains 108 characters
71 | WARNING | Line exceeds 80 characters; contains 119 characters
72 | WARNING | Line exceeds 80 characters; contains 114 characters
76 | WARNING | Line exceeds 80 characters; contains 102 characters
78 | WARNING | Line exceeds 80 characters; contains 161 characters
79 | WARNING | Line exceeds 80 characters; contains 171 characters
96 | WARNING | Line exceeds 80 characters; contains 176 characters
97 | WARNING | Line exceeds 80 characters; contains 111 characters
104 | WARNING | Line exceeds 80 characters; contains 88 characters
105 | WARNING | Line exceeds 80 characters; contains 90 characters
----------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/migrate_example_advanced/migrate_example_advanced.install
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/migrate_plus.install
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
21 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
-------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/AuthenticationPluginManager.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_fetcher/File.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate\MigrateException.
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_fetcher/Http.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate_plus\AuthenticationPluginInterface.
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate/source/Url.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate\Plugin\MigrationInterface.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate/process/EntityValue.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityInterface.
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate/process/StrReplace.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------
128 | ERROR | [x] Expected 1 space after IF keyword; 0 found
129 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate/process/Transpose.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate\ProcessPluginBase.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate/process/DomApplyStyles.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
143 | ERROR | [x] Use "elseif" in place of "else if"
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/DataParserPluginManager.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/DataFetcherPluginManager.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
Time: 2.23 secs; Memory: 16MB
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi Gautam_105@,
I reviewed MR!24 and applied it against S3 File System CORS Upload 8.x-1.x-dev with Drupal core version 10.1.7 and confirmed it fixes the issues reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!26, applied against External Entities 8.x-2.x-dev with Drupal core version 10.1.7 and there are still phpcs errors and warnings shown below:
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/external_entities/src/ExternalEntityAccessControlHandler.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 42 ERRORS AND 1 WARNING AFFECTING 41 LINES
------------------------------------------------------------------------------------------------------------------------------------------
20 | ERROR | [x] Opening brace should be on the same line as the declaration
37 | ERROR | [x] Opening brace should be on the same line as the declaration
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
46 | ERROR | [x] Opening brace should be on the same line as the declaration
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
57 | ERROR | [x] Opening brace should be on the same line as the declaration
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
61 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
63 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14
66 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
66 | ERROR | [x] Expected newline after closing brace
67 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14
68 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
71 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
77 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
78 | ERROR | [x] Opening brace should be on the same line as the declaration
79 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
81 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
92 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
93 | ERROR | [x] Opening brace should be on the same line as the declaration
94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
96 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
97 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
98 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
101 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
102 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
103 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14
106 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
109 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
119 | ERROR | [x] Opening brace should be on the same line as the declaration
120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
124 | ERROR | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 42 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------
I also found warning: 1 line adds whitespace errors. after applying the MR.
Kindly check and advise, please.
Thank you.
🇵🇭Philippines paraderojether
Hi nitin_lama,
I reviewed MR!10 and applied it against Country 8.x-1.x-dev with Drupal core version 10.1.7 and confirmed it fixes the issues reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi Tirupati_Singh,
I reviewed MR!5 and applied it against Page Title Visibility 8.x-1.x-dev with Drupal core version 10.1.7 and confirmed it fixes the issues reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi abhishek_gupta1,
I reviewed MR1, applied against NoIndex Metatag 1.0.0-alpha1 with Drupal core version 10.1.7, and confirmed the issue about the Deprecated function is fixed.
I added a screenshot for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi bobi-mel,
I applied MR7 against Field Defaults 2.0.x-dev with Drupal core version 10.1.7 and confirmed the hook help is added.
I did not change the status and leave it as needs review so that others also can verify. I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi Satish_kumar
I reviewed patch #2, applied against Required Content, and confirmed it fixes all the issues reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi sidharth_soman,
I reviewed patch #2, applied against Node type class 2.0.1, and confirmed it fixes all the issues reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi Soham Sengupta,
I reviewed patch #4, applied against Hook Post Action 8.x-1.x-dev, and confirmed it fixes all the issues reported by phpcs.
I added a screenshot for reference.
Thank you.
🇵🇭Philippines paraderojether
I reviewed MR!5, applied against Configurable Views Filter Block 1.0.x-dev, and confirmed it fixes the issues reported by phpcs.
I added screenshot for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi I reviewed MR!1, and there are still remaining issues reported by phpcs after applying the MR shown below:
FILE: /Users/studenttrainees/Drupal/drupalorg-issues-site/docroot/modules/contrib/document_ocr_mindee/src/Mindee.php
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------
58 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
98 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------
FILE: /Users/studenttrainees/Drupal/drupalorg-issues-site/docroot/modules/contrib/document_ocr_mindee/src/Plugin/document_ocr/processor/Mindee.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
31 | ERROR | [x] Expected "\Drupal\document_ocr_mindee\MindeeasMindeeService" but found "\Drupal\document_ocr_mindee\Mindee as MindeeService" for @var tag in member variable comment
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 186ms; Memory: 10MB
Please check.
Thank you.
🇵🇭Philippines paraderojether
Hi I reviewed patch coding-standard-fixes.patch, and there are still remaining issues of phpcs shown below:
FILE: /Users/studenttrainees/Drupal/drupalorg-issues-site/docroot/modules/contrib/back_to_top_with_pi/src/Plugin/Block/BackToTopBlock.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
190 | ERROR | [x] list(...) is forbidden, use [...] instead.
198 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------
Time: 470ms; Memory: 28MB
Please check.
Thank you.
🇵🇭Philippines paraderojether
Hi I reviewed MR!3, applied against CKEditor Resize 8.x-1.x-dev, the MR was applied cleanly and confirmed it fixes the issues reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi lostcarpark,
I reviewed MR!12, applied against Scheduled Publish 8.x-3.x-dev, the MR is applied cleanly and confirmed it fixes all the issues reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi can you please add which command has been used, which arguments have been used, because I'm getting different results after running this command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig,js questions_answers. The issues are only showing on 7 files.
Please look at the screenshot attached.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed patch coding-standard-fixes.patch and still getting the error shown below:
FILE: ...t/modules/contrib/configurable_views_filter_block/src/Plugin/Block/ConfigurableViewsExposedFilterBlock.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
164 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
Time: 300ms; Memory: 10MB
Please check.
Thank you.
🇵🇭Philippines paraderojether
Hi I reviewed patch #9, and there are still remaining issues reported by phpcs shown below:
FILE: .../studenttrainees/Drupal/drupalorg-issues-site/docroot/themes/contrib/dark_responsive/dark_responsive.theme
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------
72 | WARNING | Unused variable $video_path.
75 | WARNING | Unused variable $video_path.
----------------------------------------------------------------------------------------------------------------
FILE: ...s/studenttrainees/Drupal/drupalorg-issues-site/docroot/themes/contrib/dark_responsive/assets/css/style.css
----------------------------------------------------------------------------------------------------------------
FOUND 72 ERRORS AFFECTING 39 LINES
----------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Whitespace found at end of line
4 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
8 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
12 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
13 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
14 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
15 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
16 | ERROR | [x] Blank lines are not allowed in class definitions
20 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
21 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
22 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
23 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
24 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
27 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
31 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
32 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
34 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
35 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
35 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
36 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
37 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
42 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
46 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
50 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
51 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
55 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
56 | ERROR | [x] Blank lines are not allowed in class definitions
61 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
65 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
66 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
67 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
68 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
69 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
73 | ERROR | [x] CSS colours must be defined in lowercase; expected #dadfe1 but found #DADFE1
74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
74 | ERROR | [x] CSS colours must be defined in lowercase; expected #dadfe1 but found #DADFE1
75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
81 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
82 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 72 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
FILE: ...rs/studenttrainees/Drupal/drupalorg-issues-site/docroot/themes/contrib/dark_responsive/assets/js/custom.js
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
Time: 307ms; Memory: 10MB
Command used: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig,js dark_responsive
Please check.
Thank you.
🇵🇭Philippines paraderojether
Hi, I reviewed MR!1, the MR is skipped and not applied successfully.
Please check.
Thank you.
🇵🇭Philippines paraderojether
paraderojether → made their first commit to this issue’s fork.
🇵🇭Philippines paraderojether
Hi
I reviewed patch #2, applied against Ekam - Blogging, News Drupal theme 8.0.x-dev, and confirmed it fixes the issues reported by phpcs.
I added screenshots for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi
I reviewed patch #2, and still getting issues reported by phpcs shown below:
FILE: /Users/studenttrainees/Drupal/drupalorg-issues-site/docroot/modules/contrib/layout_builder_iframe_modal/js/iframe.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------
35 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
53 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
59 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
74 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------
FILE: /Users/studenttrainees/Drupal/drupalorg-issues-site/docroot/modules/contrib/layout_builder_iframe_modal/layout_builder_iframe_modal.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/studenttrainees/Drupal/drupalorg-issues-site/docroot/modules/contrib/layout_builder_iframe_modal/layout_builder_iframe_modal.module
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
126 | WARNING | Line exceeds 80 characters; contains 82 characters
------------------------------------------------------------------------------------------------------------------------------------------------
Time: 289ms; Memory: 10MB
Please check.
Thank You.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!3, applied against Onpage External Libraries 2.0.x-dev and confirmed it fixes the issues reported by phpcs.
I added screenshots for reference.
Thank You.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!1, and applied it against Juicer - Social Media Feed Aggregator 2.0.x-dev and confirmed it fixes the issue reported by phpcs.
I added screenshots for reference.
Thank You.
🇵🇭Philippines paraderojether
Hi reviewed MR!1, and confirmed it fixes the issue reported by phpcs.
I added screenshot for reference.
Thank You.
🇵🇭Philippines paraderojether
I reviewed patch #10, applied it against Date range picker 8.x-1.x-dev, and confirmed it fixes all the issues reported by phpcs.
I added screenshots for reference.
Thank You.
🇵🇭Philippines paraderojether
Hi
I reviewed MR!1, and confirmed it fixed the issues reported by phpcs.
I added screenshots for reference.
Thank You.
🇵🇭Philippines paraderojether
🇵🇭Philippines paraderojether
Hi I reviewed MR!4, applied against AVIF fallback 1.0.x.-dev and confirmed it fixes the issues reported by phpcs.
I added screenshots for reference.
Thank You.
🇵🇭Philippines paraderojether
Hi
I reviewed patch #2, applied against Social Auth Modal 1.x-dev, and confirmed i fixes the issues reported by phpcs.
I added screenshot for reference.
Thank you.
🇵🇭Philippines paraderojether
Hi nitin_lama
I reviewed MR!3, applied against Self evaluation 2.0.x-dev, and there are still remaining issues reported by phpcs shown below:
FILE: ...es/Drupal/drupalorg-issues-site/docroot/modules/contrib/self_evaluation/self_evaluation.routing.yml
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES
---------------------------------------------------------------------------------------------------------
7 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
15 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
23 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
31 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
39 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
124 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
137 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
150 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
163 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
176 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
191 | WARNING | Open page callback found, please add a comment before the line why there is no access
| | restriction
203 | WARNING | Open page callback found, please add a comment before the line why there is no access
| | restriction
220 | WARNING | Open page callback found, please add a comment before the line why there is no access
| | restriction
232 | WARNING | The administration page callback should probably use "administer site configuration" -
| | which implies the user can change something - rather than "access administration pages"
| | which is about viewing but not changing configurations.
---------------------------------------------------------------------------------------------------------
FILE: ...nttrainees/Drupal/drupalorg-issues-site/docroot/modules/contrib/self_evaluation/js/unique-choice.js
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------
Time: 4.04 secs; Memory: 18MB
Please check.
Thank you.