🇵🇭Philippines @paraderojether

Account created on 4 November 2022, over 2 years ago
#

Merge Requests

More

Recent comments

🇵🇭Philippines paraderojether

Hi

I reviewed MR5! and confirmed it passed phpcs on Gitlab CI. I applied the patch on Node Link Report and it is applied successfully. However there are still phpcs reported by PHP_CodeSniffer shown below:

➜  node_link_report git:(44d130a) curl https://git.drupalcode.org/project/node_link_report/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3002    0  3002    0     0   9298      0 --:--:-- --:--:-- --:--:--  9560
patching file 'src/Form/NodeLinkReportAdminForm.php'
patching file 'src/Plugin/Block/NodeLinkReport.php'
➜  node_link_report git:(44d130a) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig node_link_report/

FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/node_link_report/.tugboat/config.yml
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 46 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/node_link_report/README.md
--------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------
  2 | WARNING | Line exceeds 80 characters; contains 417 characters
 14 | WARNING | Line exceeds 80 characters; contains 85 characters
 34 | WARNING | Line exceeds 80 characters; contains 140 characters
--------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/node_link_report/node_link_report.libraries.yml
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/node_link_report/src/Plugin/Block/NodeLinkReport.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------
    6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Access\AccessResult.
  827 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 1128 | WARNING | [ ] Potential security problem: SSL peer verification must not be disabled
 1175 | WARNING | [ ] Potential security problem: SSL peer verification must not be disabled
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

Time: 393ms; Memory: 16MB

Command used: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig node_link_report/

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!5, confirmed it is applied successfully against QuickShortcuts 1.0.0, and the text of the help page is English.

I added screenshot for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!198 and confirmed it fixes the PHPCS issue reported by the Gitlab CI. However I found some issues while applying MR!198 on my end, please see below:

➜  layout_paragraphs git:(main) ✗ curl https://git.drupalcode.org/project/layout_paragraphs/-/merge_requests/198.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5814    0  5814    0     0  17900      0 --:--:-- --:--:-- --:--:-- 18225
patching file 'css/builder.css'
Reversed (or previously applied) patch detected!  Assume -R? [y] y
2 out of 3 hunks failed--saving rejects to 'css/builder.css.rej'
patching file 'templates/layout-paragraphs-builder-formatter.html.twig'
patching file 'templates/layout-paragraphs-builder-section-menu.html.twig'
patching file 'templates/layout-paragraphs-builder.html.twig'
patching file 'tests/modules/layout_paragraphs_translations_test/templates/paragraph--section.html.twig'
patching file 'tests/modules/layout_paragraphs_translations_test/templates/paragraph--text.html.twig'
patching file 'tests/src/FunctionalJavascript/BlockFieldTest.php'
patching file 'tests/src/FunctionalJavascript/FormRenderingTest.php'
patching file 'tests/src/FunctionalJavascript/NestedSectionsTest.php'
➜  layout_paragraphs git:(main) ✗

Will retain the status to "Needs Review" so that others can also check.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!59 confirmed it passed phcps using Gitlab CI. However there are still phpcs issues found using PHP_CodeSniffer shown below:

➜  maxlength git:(main) ✗ curl https://git.drupalcode.org/project/maxlength/-/merge_requests/59.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5215    0  5215    0     0  17373      0 --:--:-- --:--:-- --:--:-- 17677
patching file maxlength.install
patching file maxlength.module
patching file 'tests/src/FunctionalJavascript/MaxLengthCustomLinkWidgetTest.php'
patching file 'tests/src/FunctionalJavascript/MaxLengthCustomWidgetTest.php'
➜  maxlength git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig maxlength

FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/maxlength/tests/src/FunctionalJavascript/MaxLengthCustomLinkWidgetTest.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\field\Entity\FieldStorageConfig.
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/maxlength/maxlength.module
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\WidgetInterface.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Time: 304ms; Memory: 12MB

Will retain the status to Needs Review so that others can also check.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!8, applied against Shortcode 2.0.3, and confirmed fixes the issues reported by phpcs.

➜  shortcode git:(main) ✗ curl https://git.drupalcode.org/project/shortcode/-/merge_requests/8.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5248    0  5248    0     0  12752      0 --:--:-- --:--:-- --:--:-- 12958
patching file 'shortcode_basic_tags/templates/shortcode-button.html.twig'
patching file 'shortcode_basic_tags/templates/shortcode-clear.html.twig'
patching file 'shortcode_basic_tags/templates/shortcode-dropcap.html.twig'
patching file 'shortcode_basic_tags/templates/shortcode-img.html.twig'
patching file 'shortcode_basic_tags/templates/shortcode-item.html.twig'
patching file 'shortcode_basic_tags/templates/shortcode-link.html.twig'
patching file 'shortcode_basic_tags/templates/shortcode-quote.html.twig'
patching file 'src/ShortcodeService.php'
➜  shortcode git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig shortcode
➜  contrib git:(main) ✗

It all passed PHPCS using Gitlab CI.

Moving this to RTBC.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!15, applied against Menu Position 8.x-1.2 and there are still remaining phpcs issues shown below:

➜  menu_position git:(main) ✗ curl https://git.drupalcode.org/project/menu_position/-/merge_requests/15.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 25059    0 25059    0     0  63270      0 --:--:-- --:--:-- --:--:-- 64419
patching file CHANGELOG.txt
patching file menu_position.install
patching file 'src/Entity/MenuPositionRule.php'
patching file 'src/Form/MenuPositionRuleDeleteForm.php'
patching file 'src/Form/MenuPositionRuleForm.php'
patching file 'src/Form/MenuPositionRuleOrderForm.php'
patching file 'src/Form/MenuPositionSettings.php'
patching file 'src/Menu/MenuPositionActiveTrail.php'
patching file 'src/Plugin/Derivative/MenuPositionLink.php'
patching file 'src/Plugin/Menu/MenuPositionLink.php'
➜  menu_position git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_position

FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/menu_position/src/Form/MenuPositionRuleOrderForm.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Menu\MenuLinkManagerInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/menu_position/src/Form/MenuPositionRuleForm.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
  14 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\Context\ContextRepositoryInterface.
 250 | WARNING | [ ] Unused variable $menu_name.
 303 | WARNING | [ ] Unused variable $menu_link.
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------

Time: 484ms; Memory: 12MB

Command used: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_position

Please check and advise.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!3 and it passed phpcs using Gitlab CI, MR!3 is applied successfully against Navigation + 1.0.5 however, there are remaining issues reported by PHP_CodeSniffer:

➜  navigation_plus git:(main) ✗ curl https://git.drupalcode.org/project/navigation_plus/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 47768    0 47768    0     0   110k      0 --:--:-- --:--:-- --:--:--  112k
patching file README.md
patching file 'css/top-bar.css'
patching file 'modules/navigation_plus_entity_workflow/navigation_plus_entity_workflow.module'
patching file 'modules/navigation_plus_entity_workflow/src/Controller/WorkspaceSwitcher.php'
patching file 'modules/navigation_plus_entity_workflow/src/Routing/AfterEntityWorkflowEnhancer.php'
patching file 'modules/navigation_plus_entity_workflow/src/Routing/BeforeEntityWorkflowEnhancer.php'
patching file navigation_plus.module
patching file 'src/Controller/LoadEditablePage.php'
patching file 'src/Event/ShouldNotEditModeEvent.php'
patching file 'src/EventSubscriber/EntityUiWrapper.php'
patching file 'src/EventSubscriber/ShouldNotEditMode.php'
patching file 'src/FlagNewPage.php'
patching file 'src/Form/NodeTypeEditFormAlter.php'
patching file 'src/LoadEditablePageResponseTrait.php'
patching file 'src/ModeInterface.php'
patching file 'src/ModePluginBase.php'
patching file 'src/ModePluginManager.php'
patching file 'src/NavigationPlusUi.php'
patching file 'src/Plugin/Mode/Edit.php'
patching file 'src/ToolInterface.php'
patching file 'src/ToolPluginBase.php'
patching file 'src/ToolPluginManager.php'
➜  navigation_plus git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig navigation_plus

FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/navigation_plus.module
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/navigation_plus.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/css/sidebar.css
-------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 10 LINES
-------------------------------------------------------------------------------------------
 13 | ERROR | [x] Selectors must be on a single line
 14 | ERROR | [x] Selectors must be on a single line
 15 | ERROR | [x] Selectors must be on a single line
 16 | ERROR | [x] Selectors must be on a single line
 17 | ERROR | [x] Selectors must be on a single line
 18 | ERROR | [x] Selectors must be on a single line
 19 | ERROR | [x] Multiple selectors should each be on a single line
 19 | ERROR | [x] Selectors must be on a single line
 20 | ERROR | [x] Selectors must be on a single line
 21 | ERROR | [x] Selectors must be on a single line
 22 | ERROR | [ ] Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/css/top-bar.css
-------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------
 4 | ERROR | [ ] Style definitions must end with a semicolon
 5 | ERROR | [x] Selectors must be on a single line
 6 | ERROR | [x] Selectors must be on a single line
 7 | ERROR | [ ] Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/css/navigation.css
----------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------
 14 | ERROR | [x] Selectors must be on a single line
 15 | ERROR | [x] Selectors must be on a single line
 16 | ERROR | [ ] Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/navigation_plus_entity_workflow.info.yml
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Controller/WorkspaceSwitcher.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
--------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Routing/AfterEntityWorkflowEnhancer.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\EnhancerInterface.
---------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/modules/navigation_plus_entity_workflow/src/Routing/BeforeEntityWorkflowEnhancer.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\EnhancerInterface.
----------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/ModePluginManager.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Form/NodeTypeEditFormAlter.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Plugin/Mode/Edit.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\navigation_plus\Attribute\Mode.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Plugin/Tool/Pointer.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\TranslatableMarkup.
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/ToolPluginManager.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/Controller/LoadEditablePage.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/NavigationPlusUi.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------
   9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
  75 | WARNING | [ ] Unused variable $last_key.
 142 | WARNING | [ ] Unused variable $mode_id.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/EventSubscriber/ShouldNotEditMode.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Path\PathMatcherInterface.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/modules/contrib/navigation_plus/src/EventSubscriber/EntityUiWrapper.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\navigation_plus\ModePluginManager.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------

Time: 478ms; Memory: 12MB

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!1, applied against Laces 2.3.1, it is applied successfully but there are still phpcs issues shown below:

contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig laces

FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/laces.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/subtheme_starterkits/sublaces/css/components/laces__module__super_login__overrides.css
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 106 | ERROR | Style definitions must end with a semicolon
 176 | ERROR | Class definition is empty
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/layout/laces_node-add.css
----------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/layout/bootstrap_grid.css
----------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_popover.css
-----------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-----------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
-----------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_navbar.css
------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_sticky-header.css
-------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_textarea.css
--------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_grid.css
--------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_carousel.css
------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_tables.css
----------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_badge.css
---------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
---------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_dropdown.css
------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
 491 | ERROR | Style definition is empty
------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_forms.css
---------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
---------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
 472 | ERROR | Style definitions must end with a semicolon
 473 | ERROR | Style definitions must end with a semicolon
---------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_card.css
----------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_modal.css
---------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
---------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
 183 | ERROR | Style definition is empty
 197 | ERROR | Style definition is empty
---------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_card.css
--------------------------------------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 16 LINES
--------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
 182 | ERROR | Style definition is empty
 183 | ERROR | Style definition is empty
 187 | ERROR | Style definition is empty
 192 | ERROR | Style definition is empty
 193 | ERROR | Style definition is empty
 194 | ERROR | Style definition is empty
--------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_tooltip.css
-----------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
-----------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
 183 | ERROR | Style definition is empty
-----------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_close.css
---------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
---------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_transitions.css
---------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
---------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_link.css
----------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_offcanvas.css
-------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_forms.css
-----------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-----------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
-----------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_images.css
----------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_pagination.css
--------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_vertical-tabs.css
-------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_tables.css
------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_buttons.css
-----------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
-----------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
 181 | ERROR | Style definition is empty
-----------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_navbar.css
----------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
----------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
 236 | ERROR | Style definition is empty
----------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_dialog.css
------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_spinners.css
------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces__theme__seven__form.css
-------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-------------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_details.css
-------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_feed-icon.css
---------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
---------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_toasts.css
----------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
----------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
 185 | ERROR | Style definition is empty
----------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_entity-meta.css
-----------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-----------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
-----------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_images.css
------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_containers.css
--------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_off-canvas.css
----------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/laces_alert.css
-----------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-----------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
-----------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_breadcrumb.css
--------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
--------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
 182 | ERROR | Style definition is empty
 183 | ERROR | Style definition is empty
--------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_progress.css
------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_button-group.css
----------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_nav.css
-------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
-------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
 181 | ERROR | Style definition is empty
-------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_list-group.css
--------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/components/bootstrap_alert.css
---------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
---------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/theme/laces_media-library.css
--------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/base/laces_reboot.css
------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/css/base/laces_required.css
--------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------
  17 | ERROR | Style definitions must end with a semicolon
  18 | ERROR | Style definitions must end with a semicolon
  19 | ERROR | Style definitions must end with a semicolon
  20 | ERROR | Style definitions must end with a semicolon
  21 | ERROR | Style definitions must end with a semicolon
  22 | ERROR | Style definitions must end with a semicolon
  23 | ERROR | Style definitions must end with a semicolon
  24 | ERROR | Style definitions must end with a semicolon
  25 | ERROR | Style definitions must end with a semicolon
 107 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/laces.theme
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Render\MarkupInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/templates/form/form--node-laces-article-layout-layout-builder-form.html.twig
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
 20 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/templates/field/field--taxonomy-term--description.html.twig
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 44 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/templates/container/container--input--search.html.twig
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 25 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/templates/block/block--system-menu-block--main.html.twig
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 38 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/templates/block/block--system-menu-block--account.html.twig
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 38 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/templates/block/block--help-block.html.twig
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 52 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/templates/block/block--footer-branding.html.twig
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 31 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1issues/web/themes/contrib/laces/templates/media/responsive-image-formatter.html.twig
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
 17 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

Time: 3.21 secs; Memory: 56MB

Command used: contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig laces

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!7, and confirmed phpcs, phpstan, cspell are now passed on the Gitlab CI.

Moving this to RTBC.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!2, and confirmed it fixes the phpcs issues reported by the PHP_CodeSniffer.

➜  field_image_style git:(2.0.0) curl https://git.drupalcode.org/project/field_image_style/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 17793    0 17793    0     0  41761      0 --:--:-- --:--:-- --:--:-- 42263
patching file .gitlab-ci.yml
patching file field_image_style.module
patching file 'src/Plugin/Field/FieldFormatter/ImageStyleImageFormatter.php'
patching file 'src/Plugin/Field/FieldType/ImageStyleItem.php'
➜  field_image_style git:(2.0.0) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig field_image_style
➜  contrib git:(main) ✗

It also passed the phpcs using the Gitlab CI.

Moving this to RTBC.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!21 and confirmed it fixes the Create new account button spacing issue.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi alok_singh,

I reviewed MR!23 and it is not applied successfully.

➜  rover git:(main) ✗ curl https://git.drupalcode.org/project/rover/-/merge_requests/23.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   427    0   427    0     0    320      0 --:--:--  0:00:01 --:--:--   321
patching file 'css/style.css'
No such line 1099 in input file, ignoring
1 out of 1 hunks failed--saving rejects to 'css/style.css.rej'
➜  rover git:(main) ✗

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!19, and confirmed it fixes the spacing issue of the field.

I added a screenshot for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi szato,

I reviewed patch #2, applied it against File De-duplicator 1.2.2, and confirmed it fixes the issues reported by phpcs.

➜  file_de_duplicator git:(main) ✗ curl https://www.drupal.org/files/issues/2025-01-23/phpcs-fixes.3501752-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 24380  100 24380    0     0  46707      0 --:--:-- --:--:-- --:--:-- 47339
patching file drush.services.yml
patching file file_de_duplicator.module
patching file file_de_duplicator.permissions.yml
patching file file_de_duplicator.routing.yml
patching file file_de_duplicator.services.yml
patching file 'src/Commands/DeDuplicator.php'
patching file 'src/Controller/DuplicatesController.php'
patching file 'src/DuplicateFinder.php'
patching file 'src/Form/FindDuplicatesForm.php'
➜  file_de_duplicator git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig file_de_duplicator
➜  contrib git:(main) ✗

Moving this RTBC.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!2, applied it against Small Business theme 2.0.1, and confirmed it fixes the errors on the homepage.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi I reviewed MR!2 and there are still PHP_CodeSniffer remaining.

➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig term_manager

FILE: /Users/jetherparadero/Q1/q1contributions/web/modules/contrib/term_manager/src/Form/TermManagerMoveForm.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------
 102 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
 169 | WARNING | Term::load calls should be avoided in classes, use dependency injection instead
 173 | WARNING | Term::load calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------

Time: 245ms; Memory: 10MB

I reviewed MR!6 and it failed on eslint, phpcs, phpstan using Gitlab CI.

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi I reviewed MR!11 and it is not applied cleanly.

➜  views_load_more git:(2.x) curl https://git.drupalcode.org/project/views_load_more/-/merge_requests/11.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 22775    0 22775    0     0  69763      0 --:--:-- --:--:-- --:--:-- 72301
patching file .gitlab-ci.yml
patching file README.md
3 out of 3 hunks failed--saving rejects to README.md.rej
patching file 'src/Ajax/VLMAppendCommand.php'
5 out of 5 hunks failed--saving rejects to 'src/Ajax/VLMAppendCommand.php.rej'
patching file 'src/EventSubscriber/VLMEventSubscriber.php'
3 out of 4 hunks failed--saving rejects to 'src/EventSubscriber/VLMEventSubscriber.php.rej'
patching file 'src/Plugin/views/pager/LoadMore.php'
3 out of 3 hunks failed--saving rejects to 'src/Plugin/views/pager/LoadMore.php.rej'
patching file views_load_more.module
4 out of 4 hunks failed--saving rejects to views_load_more.module.rej
➜  views_load_more git:(2.x) ✗

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!9, and confirmed PHPCS & PHPStan issues are fixed on the Gitlab CI

However, I noticed a phpcs issue using PHP_CodeSniffer:

➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig config_provider

FILE: /Users/jetherparadero/Q1/q1contributions/web/modules/contrib/config_provider/src/ConfigProviderConfigInstaller.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\config_provider\Plugin\ConfigCollectorInterface.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q1/q1contributions/web/modules/contrib/config_provider/src/Plugin/ConfigCollector.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\StorageInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------

Time: 391ms; Memory: 10MB

Command used: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig config_provider

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi nidhish,

I reviewed MR!11, again and it did not applied cleanly on my end.

➜  flexi_style git:(1.4.1) curl https://git.drupalcode.org/project/flexi_style/-/merge_requests/11.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5945    0  5945    0     0  16466      0 --:--:-- --:--:-- --:--:-- 16841
patching file 'css/base/elements.css'
patching file 'css/base/formating.css'
patching file 'css/component/buttons.css'
patching file flexi_style.theme
1 out of 1 hunks failed--saving rejects to flexi_style.theme.rej
patching file 'fonts/fontawesome/LICENSE.txt'
patching file 'templates/form/input--submit.html.twig'
patching file theme-settings.php
➜  flexi_style git:(1.4.1) ✗

Kindly check and advise.
Thank you.

🇵🇭Philippines paraderojether

Hi @nidhish,

I reviewed MR!11, applied against FlexiStyle 1.4.1, and there are still remaining phpcs issues show bellow:

➜  flexi_style git:(main) ✗ curl https://git.drupalcode.org/project/flexi_style/-/merge_requests/11.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5209    0  5209    0     0  13844      0 --:--:-- --:--:-- --:--:-- 14040
patching file 'css/base/elements.css'
patching file 'css/base/formating.css'
patching file 'css/component/buttons.css'
patching file flexi_style.theme
patching file 'fonts/fontawesome/LICENSE.txt'
patching file theme-settings.php
➜  flexi_style git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig flexi_style

FILE: .../Q1/q1contributions/web/themes/contrib/flexi_style/css/component/field.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 26 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ions/web/themes/contrib/flexi_style/templates/form/input--submit.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 2.03 secs; Memory: 60MB

Command used: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig flexi_style

Please check and advise.
Thank you.

🇵🇭Philippines paraderojether

Hi ismaelromero,

I reviewed MR!7, applied against Matomo reporting API 3.0.x-dev and there is still on phpcs remaining:

➜  matomo_reporting_api git:(3.0.x) curl https://git.drupalcode.org/project/matomo_reporting_api/-/merge_requests/7.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 20598    0 20598    0     0  55511      0 --:--:-- --:--:-- --:--:-- 56587
patching file .gitlab-ci.yml
patching file matomo_reporting_api.install
patching file matomo_reporting_api.module
patching file matomo_reporting_api.post_update.php
patching file 'matomo_reporting_api_example/readme.md'
patching file 'matomo_reporting_api_example/src/Plugin/Block/MatomoStatisticsBlock.php'
patching file readme.md
patching file 'src/ConfigHandler.php'
patching file 'src/ConfigHandlerInterface.php'
patching file 'src/EventSubscriber/MatomoReportingApiSubscriber.php'
patching file 'src/Exception/MissingMatomoServerUrlException.php'
patching file 'src/Form/SettingsForm.php'
patching file 'src/MatomoQueryFactory.php'
patching file 'src/MatomoQueryFactoryInterface.php'
patching file 'tests/src/Kernel/AccessDeniedTest.php'
patching file 'tests/src/Unit/ConfigHandlerTest.php'
➜  matomo_reporting_api git:(3.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig matomo_reporting_api

FILE: /Users/jetherparadero/Q1/q1contributions/web/modules/contrib/matomo_reporting_api/tests/src/Unit/ConfigHandlerTest.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\matomo_reporting_api\ConfigHandler.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

Time: 306ms; Memory: 10MB

➜  contrib git:(main) ✗

Please check and advise.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!3, applied it against the Page Notifications 3.0.4, and confirmed it fixes the Warnings and Issues after a fresh install of the module.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi @alok_singh,

I reviewed MR!13, and it did not applied successfully.

 onepage_zymphonies_theme git:(main) ✗ curl https://git.drupalcode.org/project/onepage_zymphonies_theme/-/merge_requests/13.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3735    0  3735    0     0   9581      0 --:--:-- --:--:-- --:--:--  9751
patching file .gitlab-ci.yml
patching file 'css/global.css'
patching file 'sass/_global-styles.scss'
patching file 'templates/form/select.html.twig'
2 out of 2 hunks failed--saving rejects to 'templates/form/select.html.twig.rej'
➜  onepage_zymphonies_theme git:(main)

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!7 again and confirmed it passed the phpcs using Gitlab CI and PHP_CodeSniffer.

➜  recombee git:(2.0.x) curl https://git.drupalcode.org/project/recombee/-/merge_requests/7.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4790    0  4790    0     0  10822      0 --:--:-- --:--:-- --:--:-- 10961
patching file 'js/recombee.properties.js'
patching file 'js/recombee.public_scenario.js'
patching file 'js/recombee.tracker.js'
patching file 'src/Form/SettingsForm.php'
patching file 'src/Plugin/Block/RecombeePublicScenario.php'
➜  recombee git:(2.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig recombee
➜  contrib git:(main) ✗

Moving this to RTBC.
Thank you.

🇵🇭Philippines paraderojether

Hi kinyein,

I reviewed MR!7, and confirmed it passed the phpcs using Gitlab CI. However there are still phpcs issues reported using the PHP_CodeSniffer.

➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig recombee

FILE: ...rs/jetherparadero/Q1/q1contributions/web/modules/contrib/recombee/src/Form/SettingsForm.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------
  44 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  45 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  50 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  51 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  96 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 102 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 118 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-------------------------------------------------------------------------------------------------


FILE: ...Q1/q1contributions/web/modules/contrib/recombee/src/Plugin/Block/RecombeePublicScenario.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
 131 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-------------------------------------------------------------------------------------------------

Time: 165ms; Memory: 10MB

Command used: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig recombee

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi alok_singh,

I reviewed MR!15, applied it against Fepper 10.0.2, and confirmed the comment subject field is now full width on mobile.

I added a screenshot for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi alok_singh,

I reviewed MR!8, applied it against the Market Wave 1.0.6, and confirmed the Advance search input box overlapping issue is fixed.

I added a screenshot for reference.
Thank you.

🇵🇭Philippines paraderojether

I reviewed MR!8, applied it against the FlexiStyle DXP 1.0.0, and confirmed the Search button overlap Search input box issue if fixed.

I added a screenshot for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi alok_singh,

I reviewed MR!8, applied it against the FlexiStyle DXP 1.0.0, and confirmed the Login page input box overlapping issue if fixed.

I added a screenshot for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi alok_singh,

I reviewed MR!2 against FlexiStyle Bootstrap SCSS 1.0.8 and it did not apply successfully.

➜  flexistyle_bootstrap_scss git:(main) ✗ curl https://git.drupalcode.org/project/flexistyle_bootstrap_scss/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5630    0  5630    0     0  14253      0 --:--:-- --:--:-- --:--:-- 14776
patching file 'css/style.css'
1 out of 1 hunks failed--saving rejects to 'css/style.css.rej'
patching file 'scss/theme/style.scss'
1 out of 1 hunks failed--saving rejects to 'scss/theme/style.scss.rej'
➜  flexistyle_bootstrap_scss git:(main) ✗ curl https://git.drupalcode.org/project/flexistyle_bootstrap_scss/-/merge_requests/2.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5630    0  5630    0     0  12922      0 --:--:-- --:--:-- --:--:-- 13404
Skipped patch 'css/style.css'.
Skipped patch 'scss/theme/style.scss'.
➜  flexistyle_bootstrap_scss git:(main) ✗

Please check and advise.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!4, applied it against the FlexiStyle Bootstrap 1.2.9, and confirmed that the header is overlapping on the toolbar issue is fixed.

I added a screenshot for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!2, applied it against Users Bulk Delete, and confirmed phpcs are now fixed.

Code Sniffer

➜  user_bulk_delete git:(main) ✗ curl https://git.drupalcode.org/project/user_bulk_delete/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2693    0  2693    0     0   9171      0 --:--:-- --:--:-- --:--:--  9318
patching file .gitlab-ci.yml
patching file user_bulk_delete.install
patching file user_bulk_delete.module
➜  user_bulk_delete git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig user_bulk_delete
➜  contrib git:(main) ✗

It also passed on the Gitlab CI.

Moving this to RTBC!
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!2, applied it against JSON-LD REST Services 3.0.2 and confirmed it fixes the runtime error displayed on the configuration page.

➜  jsonld git:(main) ✗ curl https://git.drupalcode.org/project/jsonld/-/merge_requests/2.diff |
 patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1104    0  1104    0     0   3604      0 --:--:-- --:--:-- --:--:--  3680
patching file 'src/Form/JsonLdSettingsForm.php'
➜  jsonld git:(main)

I also added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi tostinni,

I reviewed MR!9, applied it against the Matomo reporting API 3.0.x-dev, and confirmed the configure link on the module list was added successfully.

➜  matomo_reporting_api git:(3477552-fix-the-issues) curl https://git.drupalcode.org/project/matomo_reporting_api/-/merge_requests/9.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   465    0   465    0     0   1550      0 --:--:-- --:--:-- --:--:--  1597
patching file matomo_reporting_api.info.yml
➜  matomo_reporting_api git:(3477552-fix-the-issues)

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!13 again, applied it against against Year Only 9.x-dev and confirmed the remaining phpcs are now fixed.

➜  yearonly git:(9.x) curl https://git.drupalcode.org/project/yearonly/-/merge_requests/13.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3583    0  3583    0     0   9313      0 --:--:-- --:--:-- --:--:--  9453
patching file 'src/Feeds/Target/YearOnly.php'
patching file 'src/Plugin/Field/FieldType/YearOnlyItem.php'
patching file 'src/Plugin/Field/FieldWidget/YearOnlyDefaultWidget.php'
➜  yearonly git:(9.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig yearonly
➜  contrib git:(main) ✗

Moving this to RTBC!
Thank you.

🇵🇭Philippines paraderojether

Hi divyansh.gupta,

I double checked MR!8 and this is now passed on the Gitlab CI

Moving this to RTBC.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!8 and confirmed all coding standard issues are fixed and it passed on the Gitlab CI

I also checked PHP_CodeSniffer and no phpcs issues found.

➜  simple_wysiwyg git:(1.0.x) curl https://git.drupalcode.org/project/simple_wysiwyg/-/merge_requests/8.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12342    0 12342    0     0  41947      0 --:--:-- --:--:-- --:--:-- 43153
patching file .cspell-project-words.txt
patching file .gitlab-ci.yml
patching file 'css/simple-wysiwyg.css'
patching file 'js/simple-wysiwyg.js'
➜  simple_wysiwyg git:(1.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig simple_wysiwyg
➜  contrib git:(main) ✗

Moving this to RTBC!
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!6, applied it against Upload size per role 1.0.x-dev and confirmed it fixes the issues reported by PHP_CodeSniffer.

 upload_size_per_role git:(1.0.x) curl https://git.drupalcode.org/project/upload_size_per_role/-/merge_requests/6.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8787    0  8787    0     0  29328      0 --:--:-- --:--:-- --:--:-- 29989
patching file .cspell-project-words.txt
patching file .gitlab-ci.yml
patching file 'src/Form/UploadSizePerRoleSettingsForm.php'
patching file upload_size_per_role.module
➜  upload_size_per_role git:(1.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig upload_size_per_role
➜  contrib git:(main) ✗

phpcs, phpstan, and cspell also passed on the Gitlab CI

Moving this to RTBC!
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!8, applied it against the Database logging ban operation 2.0.x and confirmed it fixes the issues reported by PHP_CodeSniffer.

dblog_ban git:(2.0.x) curl https://git.drupalcode.org/project/dblog_ban/-/merge_requests/8.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5137    0  5137    0     0  12003      0 --:--:-- --:--:-- --:--:-- 12201
patching file CHANGELOG.txt
patching file README.md
patching file 'src/Controller/IpBanUnbanController.php'
patching file 'src/Form/BanUnbanConfirmFormBase.php'
patching file 'tests/modules/dblog_ban_test/dblog_ban_test.info.yml'
patching file 'tests/src/Unit/RouteProcessorCsrfAjaxTest.php'
➜  dblog_ban git:(2.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig dblog_ban
➜  contrib git:(main) ✗

However, it display phpcs issues on the Gitlab CI

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi alok_singh,

I reviewed MR!7, applied it against Bootstrap PointNet and it did not apply successfully, I got the error below:

error: patch failed: css/bootstrap_pointnet_style.css:3
error: css/bootstrap_pointnet_style.css: patch does not apply

I did not change the issue status so other contributors can also review it.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!4, applied it against the helpfulness 2.x-dev, and confirmed it fixes the issues reported by phpcs.

helpfulness git:(2.x) curl https://git.drupalcode.org/project/helpfulness/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2611    0  2611    0     0    775      0 --:--:--  0:00:03 --:--:--   778
patching file 'src/Form/HelpfulnessBlockForm.php'
patching file 'src/Form/HelpfulnessConfirmDeleteFeedbackForm.php'
patching file 'src/Form/HelpfulnessReportForm.php'
patching file 'src/Plugin/Block/HelpfulnessBlock.php'
➜  helpfulness git:(2.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig helpfulness
➜  contrib git:(main) ✗

Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!9, applied it against Holy - atomic theme 3.0.0-alpha1, and confirmed the "Advanced search" button is now fixed.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!10, applied it against Holy - atomic theme 3.0.x-dev, and confirmed the extra spacing on the Add new comment section is removed.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed patch #2 and confirmed it is applied successfully and it fixes the rendering issue of the table.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed patch #10 and confirmed it is applied successfully the close button is added when the search is open. I tested the close button on desktop and touch devices and no issues was found while testing.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!18, applied it against Facets Pretty Paths 2.0.x-dev, and confirmed the configure link is added on the module listing page.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi,

I reviewed MR!5, applied it against PCR 2.0.x-dev and confirmed it fixes the issues reported by phpcs.

 contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pcr

FILE: /Users/jetherparadero/Q4/q4contributions/web/modules/contrib/pcr/pcr.module
------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
 11 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
 44 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q4/q4contributions/web/modules/contrib/pcr/src/Plugin/better_exposed_filters/filter/PrettyCheckboxesRadios.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\better_exposed_filters\Plugin\better_exposed_filters\filter\RadioButtons.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 338ms; Memory: 10MB

➜  contrib git:(main) ✗ cd pcr
➜  pcr git:(2.0.x) curl https://git.drupalcode.org/project/pcr/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1436    0  1436    0     0   3388      0 --:--:-- --:--:-- --:--:--  3443
patching file pcr.module
patching file 'src/Plugin/better_exposed_filters/filter/PrettyCheckboxesRadios.php'
➜  pcr git:(2.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pcr
➜  contrib git:(main) ✗

It is also passed on the on the Gitlab CI https://git.drupalcode.org/issue/pcr-3474014/-/jobs/2734627.

Thank you.

🇵🇭Philippines paraderojether

Hi alyaj2a,

I reviewed MR!3, applied against Year Only 9.x-dev and there are still error show below:

➜  contrib ✗ cd yearonly
➜  yearonly git:(9.x) curl https://git.drupalcode.org/project/yearonly/-/merge_requests/13.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2441    0  2441    0     0   5693      0 --:--:-- --:--:-- --:--:--  5784
patching file 'src/Feeds/Target/YearOnly.php'
patching file 'src/Plugin/Field/FieldWidget/YearOnlyDefaultWidget.php'
➜  yearonly git:(9.x) ✗ cd ..
➜  contrib ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig yearonly

FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/yearonly/src/Plugin/Field/FieldWidget/YearOnlyDefaultWidget.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\WidgetBase.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/yearonly/src/Plugin/Field/FieldType/YearOnlyItem.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldStorageDefinitionInterface.
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------

Please check and advise, the issue exists on 9.x-dev.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!570, applied it against Project Browser 2.0.x-dev, and confirmed the cursor is changed to a pointer when hovering over the results tab.

I added a recorded video for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi mohammad-fayoumi,

I was not able to reproduce the issue, my Drupal version is 10.3.2 with PHP version 8.3.6, can you please specify in what Drupal core version the issue occurred?

Thank you.

🇵🇭Philippines paraderojether

Hi dharmeshbarot89,

I reviewed MR!22, and there is still 1 warning remaining shown below:

➜  view_password git:(6.0.x) curl https://git.drupalcode.org/project/view_password/-/merge_requests/22.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7774    0  7774    0     0   4335      0 --:--:--  0:00:01 --:--:--  4350
patching file CHANGELOG.txt
patching file README.md
patching file 'config/install/view_password.settings.yml'
patching file 'config/schema/view_password.schema.yml'
patching file 'src/Form/PasswordSettingsForm.php'
patching file view_password.libraries.yml
patching file view_password.module
➜  view_password git:(6.0.x) ✗ cd ..
➜  contrib git:(1.0.0) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig view_password

FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/view_password/src/Form/PasswordSettingsForm.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 45 | WARNING | Unused variable $trailing_slash_message.
---------------------------------------------------------------------------------------------------------------------------------

Time: 116ms; Memory: 10MB

Thank you.

🇵🇭Philippines paraderojether

Hi,

I reviewed MR!7, applied against Single User Role 8.x-1.x-dev and confirmed phpcs issues are now resolved.

PHP_CodeSniffer

➜  single_user_role git:(8.x-1.0-beta2) curl https://git.drupalcode.org/project/single_user_role/-/merge_requests/7.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4773    0  4773    0     0   2846      0 --:--:--  0:00:01 --:--:--  2859
patching file .gitlab-ci.yml
patching file single_user_role.module
patching file 'src/Form/SingleUserRoleConfigForm.php'
➜  single_user_role git:(8.x-1.0-beta2) ✗ cd ..
➜  contrib git:(1.0.0) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig single_user_role
➜  contrib git:(1.0.0) ✗

It also passed on the Gitlab CI: https://git.drupalcode.org/issue/single_user_role-3452991/-/jobs/2681621

Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!8, applied against Micro Site 8.x-1.x-dev, and confirmed the error when opening the media library when adding a new micro site is fixed.

I added screenshots and a video for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi alyaj2a,

I reviewed MR!11, applied it against it Views Load More 2.x-dev, and there is still 1 error remaining after applying the MR.

views_load_more git:(2.x) curl https://git.drupalcode.org/project/views_load_more/-/merge_requests/11.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 20900    0 20900    0     0  21990      0 --:--:-- --:--:-- --:--:-- 22116
patching file README.md
patching file 'src/Ajax/VLMAppendCommand.php'
patching file 'src/EventSubscriber/VLMEventSubscriber.php'
patching file 'src/Plugin/views/pager/LoadMore.php'
patching file views_load_more.module
➜  views_load_more git:(2.x) ✗ cd ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_load_more

FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/views_load_more/src/EventSubscriber/VLMEventSubscriber.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views\Ajax\ViewAjaxResponse.
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

Time: 143ms; Memory: 10MB

Please check.
Thank you.

🇵🇭Philippines paraderojether

Hi lhridley,

I reviewed MR!3, applied it against Lunr Search 8.x-1.x-dev, and confirmed the configure link is added on the module listing page successfully.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi f0ns,

I reviewed patch #5, applied it against Layout disable 2.0.3, and confirmed the "navigation_layout" can't be disabled anymore.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi v.dovhaliuk,

I've tried to reproduce the issue but am unable to reproduce it.
Please provide the detailed Steps to Reproduce the issue.

Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!6, applied it against Bootstrap DateTime Picker 4.0.0-beta3, and confirmed I can select Sunday as a date now.

I added a before and after screen recording for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi @alok_singh,

I tested MR!18 and confirmed it fixes the advanced search input fields overlapping issue on mobile devices.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

I created an MR to fix the issues reported by phpcs, please review.

Thank you.

🇵🇭Philippines paraderojether

Fix the issues reported by phpcs, please review.

Thank you.

🇵🇭Philippines paraderojether

I fixed the issues reported by phpcs, please review.

Thank you.

🇵🇭Philippines paraderojether

I fixed the remaining issue, please review.

Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!4, applied against Media Thumbnails 8.x-1.x-dev and there is one phpcs error shown below:

✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig media_thumbnails

FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/media_thumbnails/src/Plugin/MediaThumbnailManager.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

Time: 350ms; Memory: 10MB

Thank you.

🇵🇭Philippines paraderojether

I created MR to fix the remaining issues, please review.

Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!33, applied against the Purge 8.x-3.x-dev and confirmed the configure link is added on the Purge UI module.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!6, applied it against Menu Admin per Menu 8.x-1.x-dev and there are still remaining phpcs issue shown below:

➜  menu_admin_per_menu git:(98d34cb) curl https://git.drupalcode.org/project/menu_admin_per_menu/-/merge_requests/16.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4928    0  4928    0     0   9338      0 --:--:-- --:--:-- --:--:--  9476
patching file README.md
patching file 'src/Routing/RouteSubscriber.php'
patching file 'tests/src/Kernel/MenuAdminPerMenuAccessTest.php'
patching file 'tests/src/Kernel/MenuAdminPerMenuPermissionsTest.php'
➜  menu_admin_per_menu git:(98d34cb) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_admin_per_menu

FILE: /Users/jetherparadero/q3do/q3issues/web/modules/contrib/menu_admin_per_menu/src/Access/MenuAdminPerMenuAccess.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
 26 | WARNING | Menu::loadMultiple calls should be avoided in classes, use dependency injection instead
 35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/q3do/q3issues/web/modules/contrib/menu_admin_per_menu/src/MenuAdminPerMenuPermissions.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/q3do/q3issues/web/modules/contrib/menu_admin_per_menu/src/MenuAdminPerMenuAccessInterface.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Menu\MenuLinkInterface.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Time: 548ms; Memory: 16MB

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!2, applied it against Pager 3.0.0, and confirmed it fixes the issue reported by phcs.

➜  pager git:(main) ✗ curl https://git.drupalcode.org/project/pager/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3554    0  3554    0     0  11521      0 --:--:-- --:--:-- --:--:-- 11729
patching file 'src/PagerStorage.php'
patching file 'src/Plugin/Block/PagerBlock.php'
➜  pager git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pager
➜  contrib git:(main) ✗

Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!6, applied against Recently Read 8.x-1.x-dev, and confirmed it fixes the issues reported by phpcs.

➜  recently_read git:(2eb445a) curl https://git.drupalcode.org/project/recently_read/-/merge_requests/6.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 37599    0 37599    0     0  87599      0 --:--:-- --:--:-- --:--:-- 89521
patching file README.txt
patching file recently_read.info.yml
patching file recently_read.install
patching file recently_read.module
patching file recently_read.views.inc
patching file 'src/Entity/RecentlyRead.php'
patching file 'src/Entity/RecentlyReadInterface.php'
patching file 'src/Entity/RecentlyReadType.php'
patching file 'src/Entity/RecentlyReadTypeInterface.php'
patching file 'src/Form/RecentlyReadConfigForm.php'
patching file 'src/Form/RecentlyReadTypeForm.php'
patching file 'src/Plugin/views/relationship/RecentlyReadRelationship.php'
patching file 'src/RecentlyReadHtmlRouteProvider.php'
patching file 'src/RecentlyReadService.php'
patching file 'src/RecentlyReadServiceInterface.php'
patching file 'src/RecentlyReadStorageSchema.php'
patching file 'src/RecentlyReadTypeListBuilder.php'
patching file 'tests/src/Functional/RecentlyReadBlockTest.php'
➜  recently_read git:(2eb445a) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig recently_read
➜  contrib git:(main) ✗

Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!5, and applied it against Systems Tags 2.0.1 and it is not applied cleanly.

➜  system_tags git:(2.0.1) curl https://git.drupalcode.org/project/system_tags/-/merge_requests/5.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 19046    0 19046    0     0  59017      0 --:--:-- --:--:-- --:--:-- 61637
Checking patch README.md...
Checking patch modules/theme/system_tags_theme.module...
error: while searching for:
 * Implements hook_theme_suggestions_HOOK_alter().
 */
function system_tags_theme_theme_suggestions_node_alter(array &$suggestions, array $variables) {
  $suggestions = array_merge($suggestions, _system_tag_node_suggestions('node__system_tag__', $variables['elements']['#node']));
}

/**

error: patch failed: modules/theme/system_tags_theme.module:27
error: modules/theme/system_tags_theme.module: patch does not apply
Checking patch src/Annotation/SystemTagFinder.php...
Checking patch src/Config/SystemPageConfigOverrider.php...
Checking patch src/Config/SystemTagDefinitions.php...
Checking patch src/Entity/SystemTag.php...
Checking patch src/Entity/SystemTagInterface.php...
Checking patch src/Form/SystemTagDeleteForm.php...
Checking patch src/Form/SystemTagForm.php...
Checking patch src/Plugin/Condition/SystemTags.php...
Checking patch src/Plugin/SystemTagFinder/SystemTagBlockFinder.php...
Checking patch src/Plugin/SystemTagFinder/SystemTagNodeFinder.php...
Checking patch src/SystemTagAccessControlHandler.php...
Checking patch src/SystemTagFinder/SystemTagFinderInterface.php...
Checking patch src/SystemTagFinder/SystemTagFinderManager.php...
Checking patch src/SystemTagFinder/SystemTagFinderManagerInterface.php...
Checking patch src/SystemTagFinder/SystemTagFinderPluginBase.php...
error: while searching for:
      $storage = $this->entityTypeManager->getStorage($entityTypeId);

      $query = $storage->getQuery()
        ->sort('changed', 'DESC', $langcode);
      $orCondition = $query->orConditionGroup();
      foreach ($fields as $field) {

error: patch failed: src/SystemTagFinder/SystemTagFinderPluginBase.php:95
error: src/SystemTagFinder/SystemTagFinderPluginBase.php: patch does not apply
Checking patch src/SystemTagHelper.php...
Checking patch src/SystemTagHelperInterface.php...
Checking patch src/SystemTagHtmlRouteProvider.php...
Checking patch src/SystemTagListBuilder.php...
Checking patch src/TwigExtension/SystemTagsTwigExtension.php...
error: while searching for:
namespace Drupal\system_tags\TwigExtension;

use Drupal\system_tags\SystemTagFinder\SystemTagFinderManagerInterface;

/**
 * Class SystemTagsTwigExtension.
 */
class SystemTagsTwigExtension extends \Twig_Extension {

  /**
   * The system tag finder manager.

error: patch failed: src/TwigExtension/SystemTagsTwigExtension.php:3
error: src/TwigExtension/SystemTagsTwigExtension.php: patch does not apply
Checking patch system_tags.module...
Checking patch system_tags.tokens.inc...
Checking patch tests/src/Functional/DefaultSystemTagsTest.php...

Kindly check and advise, please.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!1, applied it against Youtube Integration 1.0.1 and confirmed it fixes the issues reported by phpcs.

➜  youtubeintegrate git:(main) ✗ curl https://git.drupalcode.org/project/youtubeintegrate/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 47286    0 47286    0     0  85015      0 --:--:-- --:--:-- --:--:-- 86131
patching file 'css/youtube.css'
patching file 'src/Controller/YouTubeIntegrationController.php'
patching file 'src/Entity/YouTubePlaylistEntity.php'
patching file 'src/YouTubeAPI.php'
patching file 'templates/youtube-integration-playlist-item.html.twig'
patching file 'templates/youtube-integration-playlists.html.twig'
patching file youtube_integration.links.menu.yml
patching file youtube_integration.module
patching file youtube_integration.routing.yml
➜  youtubeintegrate git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig youtubeintegrate
➜  contrib git:(main) ✗

Moving this to RTBC.
Thank you.

🇵🇭Philippines paraderojether

Hi LOBsTerr,

I reviewed MR!25, applied it against CAS 2.1.0, and confirmed Cas setting is now translatable.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

I fix the remaining issues, please review.

Thank you.

🇵🇭Philippines paraderojether

paraderojether made their first commit to this issue’s fork.

🇵🇭Philippines paraderojether

I fix the remaining issue, please review.

Thank you.

🇵🇭Philippines paraderojether

paraderojether made their first commit to this issue’s fork.

🇵🇭Philippines paraderojether

Hi

I fix the remaining issues, please review.

Thank you

🇵🇭Philippines paraderojether

paraderojether made their first commit to this issue’s fork.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!7, applied it against United Nations Maps & Geoservices 1.2.0, and confirmed it fixes the issues reported by phpcs.

➜  unep_maps git:(main) ✗ curl https://git.drupalcode.org/project/unep_maps/-/merge_requests/7.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11473    0 11473    0     0  27730      0 --:--:-- --:--:-- --:--:-- 28120
patching file README.md
patching file 'css/edw_mapbox.css'
patching file edw_maps.api.php
patching file edw_maps.module
patching file 'src/Controller/EdwMapsController.php'
patching file 'src/EdwMapsElementsTrait.php'
patching file 'src/Plugin/views/style/MapboxMapStyle.php'
patching file 'src/Services/EdwMapsDataService.php'
➜  unep_maps git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig unep_maps
➜  contrib git:(main) ✗

Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!8, applied it against Event Scheduler 2.3.0-rc3 and it confirmed the configuration was added successfully.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!50, applied it against Layout Builder + and it confirmed the configuration was added successfully.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed patch #2, applied it against OPENAI Search 2.0.1 and it confirmed the configuration was added successfully.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!19, applied against Watchdog Mailer and it confirmed the configuration is added successfully.

I added screenshots for reference.
Thank you.

🇵🇭Philippines paraderojether

I updated the MR to fix the remaining issue, please review.

Thank you.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!4 and there are still remaining issue shown below:

contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig shy_one_time

FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/shy_one_time/README.md
--------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------
  99 | WARNING | Line exceeds 80 characters; contains 94 characters
 100 | WARNING | Line exceeds 80 characters; contains 115 characters
--------------------------------------------------------------------------------------

Time: 128ms; Memory: 10MB

.

🇵🇭Philippines paraderojether

Hi

I reviewed MR!9, and there are still phpcs issues shown below:

contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_dependent_filters

FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/views_dependent_filters/README.txt
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 106 characters
--------------------------------------------------------------------------------------------------


FILE: ...sers/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/views_dependent_filters/src/Plugin/views/filter/ViewsDependentFilter.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------------------------------------------------------------
 130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 143 | WARNING | Unused variable $form_state_copy.
 162 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 163 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 171 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 174 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 177 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 193 | WARNING | Unused variable $controller_filter.
 233 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 236 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 253 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
--------------------------------------------------------------------------------------------------------------------------------------

Time: 155ms; Memory: 12MB
Production build 0.71.5 2024