undefined - Contrib.social

🇵🇭Philippines paraderojether

🐛 | Disci | Table Css Distorted.

🇵🇭Philippines paraderojether

I reviewed patch #2 and confirmed it is applied successfully and it fixes the rendering issue of the table.

I added screenshots for reference.
Thank you.

🐛 | Disci | Table Css Distorted.

🇵🇭Philippines paraderojether

🐛 | Dark Awesome | Need to be implement the close icon Button on search page.

🇵🇭Philippines paraderojether

I reviewed patch #10 and confirmed it is applied successfully the close button is added when the search is open. I tested the close button on desktop and touch devices and no issues was found while testing.

I added screenshots for reference.
Thank you.

🐛 | Dark Awesome | Need to be implement the close icon Button on search page.

🇵🇭Philippines paraderojether

I will review this.

📌 | Facets Pretty Paths | Add configuration link in .info.yml

🇵🇭Philippines paraderojether

I reviewed MR!18, applied it against Facets Pretty Paths 2.0.x-dev, and confirmed the configure link is added on the module listing page.

I added screenshots for reference.
Thank you.

📌 | Pretty Checkbox Radio | Coding Standard issues

🇵🇭Philippines paraderojether

Hi,

I reviewed MR!5, applied it against PCR 2.0.x-dev and confirmed it fixes the issues reported by phpcs.

 contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pcr

FILE: /Users/jetherparadero/Q4/q4contributions/web/modules/contrib/pcr/pcr.module
------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
 11 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface.
 44 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q4/q4contributions/web/modules/contrib/pcr/src/Plugin/better_exposed_filters/filter/PrettyCheckboxesRadios.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\better_exposed_filters\Plugin\better_exposed_filters\filter\RadioButtons.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 338ms; Memory: 10MB

➜  contrib git:(main) ✗ cd pcr
➜  pcr git:(2.0.x) curl https://git.drupalcode.org/project/pcr/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1436    0  1436    0     0   3388      0 --:--:-- --:--:-- --:--:--  3443
patching file pcr.module
patching file 'src/Plugin/better_exposed_filters/filter/PrettyCheckboxesRadios.php'
➜  pcr git:(2.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pcr
➜  contrib git:(main) ✗

It is also passed on the on the Gitlab CI https://git.drupalcode.org/issue/pcr-3474014/-/jobs/2734627.

Thank you.

📌 | Year Only | Coding standard issues

🇵🇭Philippines paraderojether

Hi alyaj2a,

I reviewed MR!3, applied against Year Only 9.x-dev and there are still error show below:

➜  contrib ✗ cd yearonly
➜  yearonly git:(9.x) curl https://git.drupalcode.org/project/yearonly/-/merge_requests/13.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2441    0  2441    0     0   5693      0 --:--:-- --:--:-- --:--:--  5784
patching file 'src/Feeds/Target/YearOnly.php'
patching file 'src/Plugin/Field/FieldWidget/YearOnlyDefaultWidget.php'
➜  yearonly git:(9.x) ✗ cd ..
➜  contrib ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig yearonly

FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/yearonly/src/Plugin/Field/FieldWidget/YearOnlyDefaultWidget.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\WidgetBase.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/yearonly/src/Plugin/Field/FieldType/YearOnlyItem.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldStorageDefinitionInterface.
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------

Please check and advise, the issue exists on 9.x-dev.
Thank you.

📌 | Project Browser | Cursor pointer for results tabs

🐛 | Display Suite | Errors and warnings in Display Suite when managing taxonomy display with empty config

🇵🇭Philippines paraderojether

I reviewed MR!570, applied it against Project Browser 2.0.x-dev, and confirmed the cursor is changed to a pointer when hovering over the results tab.

I added a recorded video for reference.
Thank you.

🇵🇭Philippines paraderojether

Hi mohammad-fayoumi,

I was not able to reproduce the issue, my Drupal version is 10.3.2 with PHP version 8.3.6, can you please specify in what Drupal core version the issue occurred?

Thank you.

📌 | View Password | Coding Standard Issues

🇵🇭Philippines paraderojether

Hi dharmeshbarot89,

I reviewed MR!22, and there is still 1 warning remaining shown below:

➜  view_password git:(6.0.x) curl https://git.drupalcode.org/project/view_password/-/merge_requests/22.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7774    0  7774    0     0   4335      0 --:--:--  0:00:01 --:--:--  4350
patching file CHANGELOG.txt
patching file README.md
patching file 'config/install/view_password.settings.yml'
patching file 'config/schema/view_password.schema.yml'
patching file 'src/Form/PasswordSettingsForm.php'
patching file view_password.libraries.yml
patching file view_password.module
➜  view_password git:(6.0.x) ✗ cd ..
➜  contrib git:(1.0.0) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig view_password

FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/view_password/src/Form/PasswordSettingsForm.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 45 | WARNING | Unused variable $trailing_slash_message.
---------------------------------------------------------------------------------------------------------------------------------

Time: 116ms; Memory: 10MB

Thank you.

📌 | Single User Role | Fix the issues reported by PHP_CodeSniffer

🇵🇭Philippines paraderojether

Hi,

I reviewed MR!7, applied against Single User Role 8.x-1.x-dev and confirmed phpcs issues are now resolved.

PHP_CodeSniffer

➜  single_user_role git:(8.x-1.0-beta2) curl https://git.drupalcode.org/project/single_user_role/-/merge_requests/7.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4773    0  4773    0     0   2846      0 --:--:--  0:00:01 --:--:--  2859
patching file .gitlab-ci.yml
patching file single_user_role.module
patching file 'src/Form/SingleUserRoleConfigForm.php'
➜  single_user_role git:(8.x-1.0-beta2) ✗ cd ..
➜  contrib git:(1.0.0) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig single_user_role
➜  contrib git:(1.0.0) ✗

It also passed on the Gitlab CI: https://git.drupalcode.org/issue/single_user_role-3452991/-/jobs/2681621

Thank you.

🐛 | Micro Site | Error opening the media library when adding a new micro site

🇵🇭Philippines paraderojether

I reviewed MR!8, applied against Micro Site 8.x-1.x-dev, and confirmed the error when opening the media library when adding a new micro site is fixed.

I added screenshots and a video for reference.
Thank you.

📌 | Views Load More | Fix the issues reported by PHP_CodeSniffer

🇵🇭Philippines paraderojether

Hi alyaj2a,

I reviewed MR!11, applied it against it Views Load More 2.x-dev, and there is still 1 error remaining after applying the MR.

views_load_more git:(2.x) curl https://git.drupalcode.org/project/views_load_more/-/merge_requests/11.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 20900    0 20900    0     0  21990      0 --:--:-- --:--:-- --:--:-- 22116
patching file README.md
patching file 'src/Ajax/VLMAppendCommand.php'
patching file 'src/EventSubscriber/VLMEventSubscriber.php'
patching file 'src/Plugin/views/pager/LoadMore.php'
patching file views_load_more.module
➜  views_load_more git:(2.x) ✗ cd ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_load_more

FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/views_load_more/src/EventSubscriber/VLMEventSubscriber.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views\Ajax\ViewAjaxResponse.
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

Time: 143ms; Memory: 10MB

Please check.
Thank you.

🐛 | Lunr search | Add configure route to .info.yml

🇵🇭Philippines paraderojether

Hi lhridley,

I reviewed MR!3, applied it against Lunr Search 8.x-1.x-dev, and confirmed the configure link is added on the module listing page successfully.

I added screenshots for reference.
Thank you.

🐛 | Layout disable | Error on disabling the "navigation_layout"

🇵🇭Philippines paraderojether

Hi f0ns,

I reviewed patch #5, applied it against Layout disable 2.0.3, and confirmed the "navigation_layout" can't be disabled anymore.

I added screenshots for reference.
Thank you.

📌 | Page Templates | Access denied warning on "Delete" operation.

🇵🇭Philippines paraderojether

Hi v.dovhaliuk,

I've tried to reproduce the issue but am unable to reproduce it.
Please provide the detailed Steps to Reproduce the issue.

Thank you.

🐛 | Bootstrap DateTime Picker | Cannot select Sunday as a date

🇵🇭Philippines paraderojether

I reviewed MR!6, applied it against Bootstrap DateTime Picker 4.0.0-beta3, and confirmed I can select Sunday as a date now.

I added a before and after screen recording for reference.
Thank you.

🐛 | revolt | On mobile view, Advance search input box cut from right side.

🇵🇭Philippines paraderojether

Hi @alok_singh,

I tested MR!18 and confirmed it fixes the advanced search input fields overlapping issue on mobile devices.

I added screenshots for reference.
Thank you.

📌 | Media Entity: Unsplash | Fix the errors/warnings reported by PHP_CodeSniffer

🇵🇭Philippines paraderojether

I created an MR to fix the issues reported by phpcs, please review.

Thank you.

📌 | Media Entity: Unsplash | Fix the errors/warnings reported by PHP_CodeSniffer

🇵🇭Philippines paraderojether

paraderojether → created an issue.

📌 | Environment Indicator | Fix the errors/warnings reported by PHP_CodeSniffer

🇵🇭Philippines paraderojether

Fix the issues reported by phpcs, please review.

Thank you.

📌 | Environment Indicator | Fix the errors/warnings reported by PHP_CodeSniffer

🇵🇭Philippines paraderojether

paraderojether → created an issue.

📌 | Layout Builder Paragraphs | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

📌 | Layout Builder Paragraphs | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I fixed the issues reported by phpcs, please review.

Thank you.

📌 | Layout Builder Paragraphs | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

paraderojether → created an issue.

🐛 | Media Thumbnails | Fix the warning reported by PHP_CodeSniffer

🇵🇭Philippines paraderojether

I fixed the remaining issue, please review.

Thank you.

🐛 | Media Thumbnails | Fix the warning reported by PHP_CodeSniffer

🇵🇭Philippines paraderojether

I reviewed MR!4, applied against Media Thumbnails 8.x-1.x-dev and there is one phpcs error shown below:

✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig media_thumbnails

FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/media_thumbnails/src/Plugin/MediaThumbnailManager.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

Time: 350ms; Memory: 10MB

Thank you.

🐛 | Media Thumbnails | Fix the warning reported by PHP_CodeSniffer

🇵🇭Philippines paraderojether

📌 | Encrypted sql:dump | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I created MR to fix the remaining issues, please review.

Thank you.

📌 | Encrypted sql:dump | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

✨ | Purge | Include link to purge config page in admin menu

🇵🇭Philippines paraderojether

I reviewed MR!33, applied against the Purge 8.x-3.x-dev and confirmed the configure link is added on the Purge UI module.

I added screenshots for reference.
Thank you.

📌 | Menu Admin per Menu | Fix issues reported by phpcs

🇵🇭Philippines paraderojether

I reviewed MR!6, applied it against Menu Admin per Menu 8.x-1.x-dev and there are still remaining phpcs issue shown below:

➜  menu_admin_per_menu git:(98d34cb) curl https://git.drupalcode.org/project/menu_admin_per_menu/-/merge_requests/16.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4928    0  4928    0     0   9338      0 --:--:-- --:--:-- --:--:--  9476
patching file README.md
patching file 'src/Routing/RouteSubscriber.php'
patching file 'tests/src/Kernel/MenuAdminPerMenuAccessTest.php'
patching file 'tests/src/Kernel/MenuAdminPerMenuPermissionsTest.php'
➜  menu_admin_per_menu git:(98d34cb) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_admin_per_menu

FILE: /Users/jetherparadero/q3do/q3issues/web/modules/contrib/menu_admin_per_menu/src/Access/MenuAdminPerMenuAccess.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
 26 | WARNING | Menu::loadMultiple calls should be avoided in classes, use dependency injection instead
 35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/q3do/q3issues/web/modules/contrib/menu_admin_per_menu/src/MenuAdminPerMenuPermissions.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/q3do/q3issues/web/modules/contrib/menu_admin_per_menu/src/MenuAdminPerMenuAccessInterface.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Menu\MenuLinkInterface.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Time: 548ms; Memory: 16MB

Kindly check and advise, please.
Thank you.

📌 | Pager | Fix the errors/warnings reported by Php_Codesniffer

🇵🇭Philippines paraderojether

I reviewed MR!2, applied it against Pager 3.0.0, and confirmed it fixes the issue reported by phcs.

➜  pager git:(main) ✗ curl https://git.drupalcode.org/project/pager/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3554    0  3554    0     0  11521      0 --:--:-- --:--:-- --:--:-- 11729
patching file 'src/PagerStorage.php'
patching file 'src/Plugin/Block/PagerBlock.php'
➜  pager git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pager
➜  contrib git:(main) ✗

Thank you.

📌 | Recently Read | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I reviewed MR!6, applied against Recently Read 8.x-1.x-dev, and confirmed it fixes the issues reported by phpcs.

➜  recently_read git:(2eb445a) curl https://git.drupalcode.org/project/recently_read/-/merge_requests/6.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 37599    0 37599    0     0  87599      0 --:--:-- --:--:-- --:--:-- 89521
patching file README.txt
patching file recently_read.info.yml
patching file recently_read.install
patching file recently_read.module
patching file recently_read.views.inc
patching file 'src/Entity/RecentlyRead.php'
patching file 'src/Entity/RecentlyReadInterface.php'
patching file 'src/Entity/RecentlyReadType.php'
patching file 'src/Entity/RecentlyReadTypeInterface.php'
patching file 'src/Form/RecentlyReadConfigForm.php'
patching file 'src/Form/RecentlyReadTypeForm.php'
patching file 'src/Plugin/views/relationship/RecentlyReadRelationship.php'
patching file 'src/RecentlyReadHtmlRouteProvider.php'
patching file 'src/RecentlyReadService.php'
patching file 'src/RecentlyReadServiceInterface.php'
patching file 'src/RecentlyReadStorageSchema.php'
patching file 'src/RecentlyReadTypeListBuilder.php'
patching file 'tests/src/Functional/RecentlyReadBlockTest.php'
➜  recently_read git:(2eb445a) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig recently_read
➜  contrib git:(main) ✗

Thank you.

📌 | System Tags | Coding standards

🇵🇭Philippines paraderojether

I reviewed MR!5, and applied it against Systems Tags 2.0.1 and it is not applied cleanly.

➜  system_tags git:(2.0.1) curl https://git.drupalcode.org/project/system_tags/-/merge_requests/5.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 19046    0 19046    0     0  59017      0 --:--:-- --:--:-- --:--:-- 61637
Checking patch README.md...
Checking patch modules/theme/system_tags_theme.module...
error: while searching for:
 * Implements hook_theme_suggestions_HOOK_alter().
 */
function system_tags_theme_theme_suggestions_node_alter(array &$suggestions, array $variables) {
  $suggestions = array_merge($suggestions, _system_tag_node_suggestions('node__system_tag__', $variables['elements']['#node']));
}

/**

error: patch failed: modules/theme/system_tags_theme.module:27
error: modules/theme/system_tags_theme.module: patch does not apply
Checking patch src/Annotation/SystemTagFinder.php...
Checking patch src/Config/SystemPageConfigOverrider.php...
Checking patch src/Config/SystemTagDefinitions.php...
Checking patch src/Entity/SystemTag.php...
Checking patch src/Entity/SystemTagInterface.php...
Checking patch src/Form/SystemTagDeleteForm.php...
Checking patch src/Form/SystemTagForm.php...
Checking patch src/Plugin/Condition/SystemTags.php...
Checking patch src/Plugin/SystemTagFinder/SystemTagBlockFinder.php...
Checking patch src/Plugin/SystemTagFinder/SystemTagNodeFinder.php...
Checking patch src/SystemTagAccessControlHandler.php...
Checking patch src/SystemTagFinder/SystemTagFinderInterface.php...
Checking patch src/SystemTagFinder/SystemTagFinderManager.php...
Checking patch src/SystemTagFinder/SystemTagFinderManagerInterface.php...
Checking patch src/SystemTagFinder/SystemTagFinderPluginBase.php...
error: while searching for:
      $storage = $this->entityTypeManager->getStorage($entityTypeId);

      $query = $storage->getQuery()
        ->sort('changed', 'DESC', $langcode);
      $orCondition = $query->orConditionGroup();
      foreach ($fields as $field) {

error: patch failed: src/SystemTagFinder/SystemTagFinderPluginBase.php:95
error: src/SystemTagFinder/SystemTagFinderPluginBase.php: patch does not apply
Checking patch src/SystemTagHelper.php...
Checking patch src/SystemTagHelperInterface.php...
Checking patch src/SystemTagHtmlRouteProvider.php...
Checking patch src/SystemTagListBuilder.php...
Checking patch src/TwigExtension/SystemTagsTwigExtension.php...
error: while searching for:
namespace Drupal\system_tags\TwigExtension;

use Drupal\system_tags\SystemTagFinder\SystemTagFinderManagerInterface;

/**
 * Class SystemTagsTwigExtension.
 */
class SystemTagsTwigExtension extends \Twig_Extension {

  /**
   * The system tag finder manager.

error: patch failed: src/TwigExtension/SystemTagsTwigExtension.php:3
error: src/TwigExtension/SystemTagsTwigExtension.php: patch does not apply
Checking patch system_tags.module...
Checking patch system_tags.tokens.inc...
Checking patch tests/src/Functional/DefaultSystemTagsTest.php...

Kindly check and advise, please.
Thank you.

📌 | Youtube Integration | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I reviewed MR!1, applied it against Youtube Integration 1.0.1 and confirmed it fixes the issues reported by phpcs.

➜  youtubeintegrate git:(main) ✗ curl https://git.drupalcode.org/project/youtubeintegrate/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 47286    0 47286    0     0  85015      0 --:--:-- --:--:-- --:--:-- 86131
patching file 'css/youtube.css'
patching file 'src/Controller/YouTubeIntegrationController.php'
patching file 'src/Entity/YouTubePlaylistEntity.php'
patching file 'src/YouTubeAPI.php'
patching file 'templates/youtube-integration-playlist-item.html.twig'
patching file 'templates/youtube-integration-playlists.html.twig'
patching file youtube_integration.links.menu.yml
patching file youtube_integration.module
patching file youtube_integration.routing.yml
➜  youtubeintegrate git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig youtubeintegrate
➜  contrib git:(main) ✗

Moving this to RTBC.
Thank you.

📌 | CAS | Make cas configuration translatable

🇵🇭Philippines paraderojether

Hi LOBsTerr,

I reviewed MR!25, applied it against CAS 2.1.0, and confirmed Cas setting is now translatable.

I added screenshots for reference.
Thank you.

📌 | Unique entity title | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I fix the remaining issues, please review.

Thank you.

📌 | Unique entity title | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

paraderojether → made their first commit to this issue’s fork.

📌 | Content Dependency Tracker | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I fix the remaining issue, please review.

Thank you.

📌 | Content Dependency Tracker | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

paraderojether → made their first commit to this issue’s fork.

🐛 | Views Default User Taxonomy Argument | Drupal Coding Standards Issues | phpcs

🇵🇭Philippines paraderojether

I fix the remaining issues, please review.

Thank you

🐛 | Views Default User Taxonomy Argument | Drupal Coding Standards Issues | phpcs

🇵🇭Philippines paraderojether

paraderojether → made their first commit to this issue’s fork.

📌 | Fancy Login | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

paraderojether → made their first commit to this issue’s fork.

📌 | United Nations Maps & Geoservices | Fix the issue reported by phpcs

🇵🇭Philippines paraderojether

I reviewed MR!7, applied it against United Nations Maps & Geoservices 1.2.0, and confirmed it fixes the issues reported by phpcs.

➜  unep_maps git:(main) ✗ curl https://git.drupalcode.org/project/unep_maps/-/merge_requests/7.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11473    0 11473    0     0  27730      0 --:--:-- --:--:-- --:--:-- 28120
patching file README.md
patching file 'css/edw_mapbox.css'
patching file edw_maps.api.php
patching file edw_maps.module
patching file 'src/Controller/EdwMapsController.php'
patching file 'src/EdwMapsElementsTrait.php'
patching file 'src/Plugin/views/style/MapboxMapStyle.php'
patching file 'src/Services/EdwMapsDataService.php'
➜  unep_maps git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig unep_maps
➜  contrib git:(main) ✗

Thank you.

✨ | Event Scheduler | Add Configuration settings in info file

🇵🇭Philippines paraderojether

I reviewed MR!8, applied it against Event Scheduler 2.3.0-rc3 and it confirmed the configuration was added successfully.

I added screenshots for reference.
Thank you.

✨ | LB Plus | Add configure link to info.yml

🇵🇭Philippines paraderojether

I reviewed MR!50, applied it against Layout Builder + and it confirmed the configuration was added successfully.

I added screenshots for reference.
Thank you.

📌 | OPENAI Search | config missing in info.yml file

🇵🇭Philippines paraderojether

I reviewed patch #2, applied it against OPENAI Search 2.0.1 and it confirmed the configuration was added successfully.

I added screenshots for reference.
Thank you.

📌 | Watchdog Mailer | Add configure link to the .info.yml

🇵🇭Philippines paraderojether

I reviewed MR!19, applied against Watchdog Mailer and it confirmed the configuration is added successfully.

I added screenshots for reference.
Thank you.

📌 | Shy One-Time | Fix coding standards issues

🇵🇭Philippines paraderojether

I updated the MR to fix the remaining issue, please review.

Thank you.

📌 | Shy One-Time | Fix coding standards issues

🇵🇭Philippines paraderojether

I reviewed MR!4 and there are still remaining issue shown below:

contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig shy_one_time

FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/shy_one_time/README.md
--------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------
  99 | WARNING | Line exceeds 80 characters; contains 94 characters
 100 | WARNING | Line exceeds 80 characters; contains 115 characters
--------------------------------------------------------------------------------------

Time: 128ms; Memory: 10MB

📌 | Views Dependent Filters | Fix issues reported by phpcs

🇵🇭Philippines paraderojether

I reviewed MR!9, and there are still phpcs issues shown below:

contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_dependent_filters

FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/views_dependent_filters/README.txt
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 106 characters
--------------------------------------------------------------------------------------------------


FILE: ...sers/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/views_dependent_filters/src/Plugin/views/filter/ViewsDependentFilter.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------------------------------------------------------------
 130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 143 | WARNING | Unused variable $form_state_copy.
 162 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 163 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 171 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 174 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 177 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 193 | WARNING | Unused variable $controller_filter.
 233 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 236 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
 253 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t()
     |         | instead
--------------------------------------------------------------------------------------------------------------------------------------

Time: 155ms; Memory: 12MB

🐛 | Content Import | Fix the issues reported by PHP_CodeSniffer

🇵🇭Philippines paraderojether

Hi
I reviewed MR!7 and there are still remaining issues reported by phpcs show below:

contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig contentimport

FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/contentimport/contentimport.module
--------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------
 312 | ERROR   | [x] Whitespace found at end of line
 315 | ERROR   | [x] Expected 1 space before "?"; 0 found
 315 | ERROR   | [x] Expected 1 space before ":"; 0 found
 317 | WARNING | [x] A comma should follow the last multiline array item. Found: $path_data
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

Time: 296ms; Memory: 14MB

🐛 | Agreement | Add Configure link

🇵🇭Philippines paraderojether

I reviewed MR!17, confirmed it is applied cleanly and the configure link is added successfully.

I added screenshots for reference.
Thank you.

📌 | TMGMT Translator OpenAI | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

📌 | TMGMT Translator OpenAI | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I reviewed MR!10, and confirmed it fixes the issues reported by phpcs.

tmgmt_openai curl https://git.drupalcode.org/project/tmgmt_openai/-/merge_requests/10.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7849    0  7849    0     0  24386      0 --:--:-- --:--:-- --:--:-- 24917
patching file README.md
patching file 'src/OpenAiTranslatorUi.php'
patching file 'src/Plugin/tmgmt/Translator/OpenAiTranslator.php'
patching file tmgmt_openai.info.yml
patching file tmgmt_openai.install
➜  tmgmt_openai cd ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig tmgmt_openai
➜  contrib

Moving this to RBTC.
Thank you.

📌 | Permission watchdog | Drupal Coding Standard Issue.

🇵🇭Philippines paraderojether

I reviewed patch #10 and confirmed it fixes the issues reported by phpcs.

permission_watchdog git:(2.x) curl https://git.drupalcode.org/project/permission_watchdog/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6652    0  6652    0     0  22518      0 --:--:-- --:--:-- --:--:-- 22937
patching file permission_watchdog.install
patching file permission_watchdog.module
patching file 'src/Entity/RoleChangeLog.php'
patching file 'src/Form/SettingsForm.php'
patching file 'src/Plugin/DevelGenerate/RoleChangeDevelGenerate.php'
patching file 'src/Plugin/Field/FieldFormatter/PermissionActionDefaultFormatter.php'
patching file 'src/Plugin/Field/FieldType/PermissionActionItem.php'
patching file 'tests/src/Functional/PermissionWatchdogTest.php'
➜  permission_watchdog git:(2.x) ✗ cd ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig permission_watchdog
➜  contrib

I also created an MR so that it would be easy for the maintainers to review.
Please review the MR!. Thank you.

📌 | Permission watchdog | Drupal Coding Standard Issue.

🇵🇭Philippines paraderojether

paraderojether → made their first commit to this issue’s fork.

🐛 | SVG Image Field | Support new upload validator syntax from D10.2+

🇵🇭Philippines paraderojether

I reviewed MR!32, confirmed it is applied successfully and it fixes the duplicated allowed types help text issue.

I added screenshots for reference.
Moving this RTBC.

🐛 | Upload Node pictures | phpcs error

🇵🇭Philippines paraderojether

I reviewed MR!2, and confirmed phpcs issues listed on the description are fixed, however there are still phpcs issues remaining after running this command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig upload_node_pictures

contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig upload_node_pictures

FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/upload_node_pictures/README.md
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 24 WARNINGS AFFECTING 24 LINES
----------------------------------------------------------------------------------------------
  1 | WARNING | [ ] Line exceeds 80 characters; contains 234 characters
  3 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
  5 | WARNING | [ ] Line exceeds 80 characters; contains 121 characters
  7 | WARNING | [ ] Line exceeds 80 characters; contains 127 characters
  9 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
 13 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters
 14 | WARNING | [ ] Line exceeds 80 characters; contains 153 characters
 15 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters
 16 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
 17 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
 18 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
 19 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 20 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
 24 | WARNING | [ ] Line exceeds 80 characters; contains 135 characters
 28 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters
 31 | WARNING | [ ] Line exceeds 80 characters; contains 132 characters
 34 | WARNING | [ ] Line exceeds 80 characters; contains 211 characters
 37 | WARNING | [ ] Line exceeds 80 characters; contains 221 characters
 40 | WARNING | [ ] Line exceeds 80 characters; contains 148 characters
 43 | WARNING | [ ] Line exceeds 80 characters; contains 211 characters
 46 | WARNING | [ ] Line exceeds 80 characters; contains 167 characters
 49 | WARNING | [ ] Line exceeds 80 characters; contains 169 characters
 52 | WARNING | [ ] Line exceeds 80 characters; contains 181 characters
 55 | WARNING | [ ] Line exceeds 80 characters; contains 215 characters
 55 | ERROR   | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

Time: 218ms; Memory: 12MB

Moving this needs work.

📌 | Route Iframes | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I updated the MR to fix the remaining phpcs issues, please review.

Thank you.

📌 | Route Iframes | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

paraderojether → made their first commit to this issue’s fork.

📌 | Entity Pager | Drupal Coding Standard Issue

🇵🇭Philippines paraderojether

I created MR to fix remaining issue, please review.

Thank you.

📌 | Entity Pager | Drupal Coding Standard Issue

🇵🇭Philippines paraderojether

I reviewed patch #2, and there is 1 phpcs remaining.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig entity_pager

FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/entity_pager/src/EntityPager.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

Time: 372ms; Memory: 12MB

📌 | The CodeMirror Editor | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I reviewed patch #1, and there are still phpcs issues remaining shown below:

codemirror_editor git:(147c3b7) curl https://www.drupal.org/files/issues/2023-07-31/CodeMirrorEditorWidget.php-3370177-14.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   663  100   663    0     0    360      0  0:00:01  0:00:01 --:--:--   361
patching file 'src/Plugin/Field/FieldWidget/CodeMirrorEditorWidget.php'
➜  codemirror_editor git:(147c3b7) ✗ cd ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig codemirror_editor

FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/codemirror_editor/codemirror_editor.module
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 62 | ERROR | The text '@deprecated Use Drupal\codemirror_editor\CodemirrorModeManagerInterface::getDefinitions() instead.' does not match the standard format: @deprecated in
    |       | %deprecation-version% and is removed from %removal-version%. %extra-info%.
 62 | ERROR | Each @deprecated tag must have a @see tag immediately following it
 67 | ERROR | The trigger_error message 'codemirror_editor_load_modes() is deprecated. Use Drupal\codemirror_editor\CodemirrorModeManagerInterface::getDefinitions() instead'
    |       | does not match the strict standard format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
 80 | ERROR | The text '@deprecated Use Drupal\codemirror_editor\CodemirrorModeManagerInterface::normalizeMode() instead.' does not match the standard format: @deprecated in
    |       | %deprecation-version% and is removed from %removal-version%. %extra-info%.
 80 | ERROR | Each @deprecated tag must have a @see tag immediately following it
 85 | ERROR | The trigger_error message 'codemirror_editor_load_modes() is deprecated. Use Drupal\codemirror_editor\CodemirrorModeManagerInterface::normalizeMode() instead' does
    |       | not match the strict standard format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/codemirror_editor/src/CodeMirrorLibraryBuilder.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | The text '@deprecated Use \Drupal\codemirror_editor\LibraryBuilder' does not match the standard format: @deprecated in %deprecation-version% and is removed from
   |       | %removal-version%. %extra-info%.
 8 | ERROR | Each @deprecated tag must have a @see tag immediately following it
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 610ms; Memory: 12MB

Thank you.

📌 | Reading Rating | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

paraderojether → made their first commit to this issue’s fork.

📌 | TMGMT Translator Microsoft | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

📌 | Convert Bundles | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

Hello a.aaronjake, I can't replicate the issue on my end.

📌 | TMGMT Translator Microsoft | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

paraderojether → made their first commit to this issue’s fork.

📌 | Automatic User Names | Fix phpcs issues

🇵🇭Philippines paraderojether

I reviewed MR!5, and confirmed it fixes all the issues reported by phpcs.

auto_username git:(8.x-1.5) curl https://git.drupalcode.org/project/auto_username/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 25823    0 25823    0     0  67039      0 --:--:-- --:--:-- --:--:-- 68496
patching file .gitlab-ci.yml
patching file auto_username.module
patching file auto_username.services.yml
patching file 'config/install/auto_username.settings.yml'
patching file 'src/AutoUsernameOptions.php'
patching file 'src/AutoUsernamePunctuationOptions.php'
patching file 'src/AutoUsernameUtilities.php'
patching file 'src/Form/AutoUsernameSettingsForm.php'
➜  auto_username git:(8.x-1.5) ✗ cd ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig auto_username
➜  contrib

Moving this to RTBC.
Thank you.

📌 | Bootstrap External Link Pop-up | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I reviewed Patch 3, applied against Bootstrap External Link Pop-up 2.x-dev and confirmed it fixes the issues reported by phpcs.

bootstrap_external_link_popup git:(2.x) curl https://www.drupal.org/files/issues/2023-05-04/fix-for-issues-reported-by-phpcs-3358093-3.patch | patch
 -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   736  100   736    0     0   1452      0 --:--:-- --:--:-- --:--:--  1474
patching file bootstrap_external_link_popup.module
➜  bootstrap_external_link_popup git:(2.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig bootstrap_external_link_popup
➜  contrib git:(main) ✗

Thank you.

📌 | Migrate generator | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I reviewed MR!8, applied against Migrate Generator 8.x-2.x-dev, and confirmed fixes the issues reported by phpcs.

migrate_generator git:(8.x-2.2) curl https://git.drupalcode.org/project/migrate_generator/-/merge_requests/8.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 33546    0 33546    0     0  78327      0 --:--:-- --:--:-- --:--:-- 79681
patching file README.md
patching file migrate_generator.post_update.php
patching file 'migrate_generator_export/README.md'
patching file 'migrate_generator_export/migrate_generator_export.links.task.yml'
patching file 'migrate_generator_export/src/Commands/DrushCommands.php'
patching file 'migrate_generator_export/src/ExportManager.php'
patching file 'migrate_generator_export/src/FieldsExportManager.php'
patching file 'migrate_generator_export/src/Form/EntityTypeExportConfigForm.php'
patching file 'migrate_generator_export/src/Form/ExportForm.php'
patching file 'migrate_generator_export/src/GeneratorExportPluginManager.php'
patching file 'migrate_generator_export/src/Plugin/GeneratorExportPluginDateBase.php'
patching file 'migrate_generator_export/src/Plugin/GeneratorExportPluginInterface.php'
patching file 'migrate_generator_export/src/Plugin/migrate_generator_export/process/FileExport.php'
patching file 'src/Commands/DrushCommands.php'
patching file 'src/GeneratorProcessPluginManager.php'
patching file 'src/Plugin/GeneratorProcessPluginBase.php'
patching file 'src/Plugin/GeneratorProcessPluginDateBase.php'
patching file 'src/Scanner.php'
➜  migrate_generator git:(8.x-2.2) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig migrate_generator
➜  contrib git:(main) ✗

Thank you.

✨ | Search Tracking | Implement a configure link in the module list

🇵🇭Philippines paraderojether

📌 | Convert Bundles | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I fix the remaining issues, please review.
Thank you.

📌 | Convert Bundles | Fix the issues reported by phpcs

🇵🇭Philippines paraderojether

I reviewed MR!18, it is applied cleanly however there are still remaining phpcs 2 errors shown below:

convert_bundles git:(2.0.x) curl https://git.drupalcode.org/project/convert_bundles/-/merge_requests/18.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 37895    0 37895    0     0  76538      0 --:--:-- --:--:-- --:--:-- 77336
Checking patch convert_bundles.api.php...
Checking patch convert_bundles.install...
Checking patch convert_bundles.module...
Checking patch src/Controller/EntityController.php...
Checking patch src/ConvertBundles.php...
Checking patch src/Form/ConvertBundlesForm.php...
Checking patch src/Plugin/Action/ConvertBundlesActionBase.php...
Checking patch src/Plugin/Derivative/ConvertBundlesLocalTask.php...
Checking patch src/Routing/RouteSubscriber.php...
Applied patch convert_bundles.api.php cleanly.
Applied patch convert_bundles.install cleanly.
Applied patch convert_bundles.module cleanly.
Applied patch src/Controller/EntityController.php cleanly.
Applied patch src/ConvertBundles.php cleanly.
Applied patch src/Form/ConvertBundlesForm.php cleanly.
Applied patch src/Plugin/Action/ConvertBundlesActionBase.php cleanly.
Applied patch src/Plugin/Derivative/ConvertBundlesLocalTask.php cleanly.
Applied patch src/Routing/RouteSubscriber.php cleanly.
➜  convert_bundles git:(2.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig convert_bundles

FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/convert_bundles/convert_bundles.module
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Database.
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/convert_bundles/src/Form/ConvertBundlesForm.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 14 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteBuilderInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

Time: 375ms; Memory: 12MB

Please check and advise.
Thank you.

✨ | Search Tracking | Implement a configure link in the module list

🇵🇭Philippines paraderojether

Hi Chandansha,

I reviewed Patch #2, applied it against Search Tracking 1.0.0, and confirmed the confirmed the configure link in the module list is added successfully.

Applying Patch:

search_tracking git:(main) ✗ curl https://www.drupal.org/files/issues/2024-02-22/3423112-2.patch | patch -p1   
\  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   416  100   416    0     0   2263      0 --:--:-- --:--:-- --:--:--  2377
patching file search_tracking.info.yml
➜  search_tracking git:(main) ✗

I also added screenshots for reference.
Thank you.

🐛 | Instagram Feeds Listing | phpcs error

🇵🇭Philippines paraderojether

Hi silvi.addweb,

I reviewed MR!2, applied it against Instagram Feeds Listing 1.0.0 and confirmed it fixes the issues reported by phpcs.

instagram_feeds_listing git:(main) ✗ curl https://git.drupalcode.org/project/instagram_feeds_listing/-/merge_requests/2.diff | patch -p1   
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6820    0  6820    0     0  13750      0 --:--:-- --:--:-- --:--:-- 14004
patching file 'src/Form/InstagramFeedAdminForm.php'
patching file 'src/InstagramBasicDisplayApi.php'
➜  instagram_feeds_listing git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig instagram_feeds_listing
➜  contrib git:(main) ✗

Thank you.

📌 | Instagram Feeds Listing | Add Configure link in module

🇵🇭Philippines paraderojether

Hi silvi.addweb,

I reviewed MR! 3, and the MR is skipped or not applied successfully, please see below:

instagram_feeds_listing git:(main) ✗ curl https://git.drupalcode.org/project/instagram_feeds_listing/-/merge_requests/3.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   593    0   593    0     0    927      0 --:--:-- --:--:-- --:--:--   938
Skipped patch 'instagram_feeds_listing.info.yml'.
➜  instagram_feeds_listing git:(main) ✗

Please check and advise.
Thanks.

🐛 | Time Tracking Application | Phpcs Drupal coding standard issue