Cursor pointer for results tabs

patch is attached for this

Hi
I am unable to reproduce the Issue, The Result Tab is unable to be seen at my end.
Testing steps:

1. Install Project browser
2. Go to /admin/modules/browse

Attaching Screenshot

Hi,
I'm also unable to reproduce this issue in the local environment, but I'm able to check it out on GitPod.
I tested patch 3456978.patch → in Drupal version 10.3.1-dev on GitPod. Furthermore, I can confirm that the cursor has changed to a pointer when I hover my cursor over the results tab.

Attaching screenshots for reference.

RTBC +1

Thanks!

Hi,
Not able to reproduce the issue, result tab is not there.

I'm able to reproduce the issue on my local with Drupal 10.3.1
The patch applied cleanly...

Test Result:
The cursor has changed to a pointer when hovering the cursor over the results tab.

RTBC+1

I am able to reproduce the issue on my local with Drupal 10.3.1
The patch applied successfully.

Test Result:
The cursor has changed to a pointer on hover of the results tab.

Added before and after video for reference.

RTBC++

Thanks, I've moved this to an MR workflow and updated the code to make better sense in PB/BEM.

Rebased the branch with 2.0.x not sure why it is showing multiple changes. It is taking this commit also https://git.drupalcode.org/project/project_browser/-/merge_requests/568/....

Can someone review if working fine, we can move it to RTBC.

I think you did a bad rebase @prashant.c, and I don't think it was necessary. The entire changeset for this issue should be what I had in https://git.drupalcode.org/issue/project_browser-3456978/-/commit/289f69...

prashant.c → changed the visibility of the branch 3456978-cursor-pointer-for to hidden.

Hi

I reviewed MR!570, applied it against Project Browser 2.0.x-dev, and confirmed the cursor is changed to a pointer when hovering over the results tab.

I added a recorded video for reference.
Thank you.

Hello,
I've reviewed the changes by following the below steps:

• I installed the Project Browser module version 2.0.0-alpha3 in Drupal version 10.3.2, enabled the modules Project Browser, Project Browser Devel, Project Browser Source Example.
• Went to /admin/modules/browse and found the four tabs, on hovering the cursor had default value.
• Applied the MR!570 which applied cleanly.
• Went to /admin/modules/browse. On hovering the tabs cursor had pointer.

Attached the ss and video for reference. RTBC +.
Thanks

Thanks #21 and #22 for testing this. Kindly do not attach before/after files multiple times on any issues, if you see these were already attached above.

+1, this is ready to go. Waiting until we get a larger issue in so that one doesn't end up in rebase hell, whereas this one is nice and tiny and self-contained, and can endure the rebase much easier. :)

We now have a failing test...?

    Drupal\Tests\project_browser\FunctionalJavascript\ProjectBrowserUiTestJsonApi::testAdvancedFiltering
    WebDriver\Exception\JavaScriptError: javascript error:
    {"status":60,"value":"[object HTMLOptionElement] has no size and location"}

This seems to be consistent tho - I re-ran it three times, with the same failure each time. Plus testAdvancedFiltering isn't one that rings a bell as flaky.

The CI is passing now.Marking it NR.

I can confirm that with the latests changes the cursor changes to a pointer on the results tabs. Tested using PB 2.0.x-dev and core 11.0.1. Thanks all!

thanks!

Automatically closed - issue fixed for 2 weeks with no activity.