@Esha_Kundu

Hello @tanushree gupta,
I've reviewed your new changes, the previously mentioned issues regarding the removal of snippet has been resolved. Thanks for pointing out the hamburger menu position, I cleared the cache after applying the patch and it was rectified. The patch applied cleanly in 1.0.x and 9.1.0 versions of the theme. The mentioned issue is resolved hence moving to RTBC.
Thanks

Hello,
I've reviewed by following the below steps,

• I installed and set the rover theme ( 2.0.1) as default theme in Drupal version 10.3.6.
• Visited the search page /search/node, click opened the Advance search section to find the space between the form and button is minimal.
• Hence, applied the MR!19, which applied cleanly.
• Revisited the search page /search/node, click opened the Advance search section to find the space between the form and button is improved.

I've also reviewed the MR!19 and it looks good to me.
Including the ss for before and after for reference.
Thus, moving to RTBC. Thanks

Hello @tanushree gupta,
I reviewed the MR!25 and found that you've included the scss as I had mentioned earlier in the comment. However, you seemed to have removed a small snippet which has already been merged to resolve this 3391594 🐛 In Footer section need to align Footer title with footer Menu. Fixed issue. Additionally, the MR!25 is throwing error on applying the patch on current version 9.1.0.

error: patch failed: lib/style.css:683
error: lib/style.css: patch does not apply
error: patch failed: scss/style.scss:8
error: scss/style.scss: patch does not apply
error: patch failed: templates/layout/page.html.twig:96
error: templates/layout/page.html.twig: patch does not apply

Although the patch applies cleanly when the theme is cloned and applied on the 1.0.x branch. The menu arrow, position and design in mobile devices looks good to me. Moving to NW to resolve the removed snippet. Attaching ss of after patch.
I would suggest to create a MR keeping the target branch as 9.1.x, as the current version 9.1.0 also contains the menu design break in mobile devices.
Thanks

I'll review this.

Hello,
I followed the below steps to review,

• I installed the theme version 2.0.1 in Drupal version 10.3.6.
• Searched a value in the search block, which provided a list of search value in the search result page ( /search/node ).
• The list were having extra space on the left side.
• I applied the MR!4, which applied cleanly.
• The extra space was removed and it had appropriate space to identify the content as a list.

Attached the before and after ss for reference. The issue is resolve hence moving to RTBC.
Thanks

Hello,
I've converted the patch ( 3392873-3.patch ) mentioned in #3 🐛 Footer region rendering multiples time in a page. Active into MR !10 as per Drupal standards. The issue was getting resolved with the provided patch also I agree with @jeetmail72 that the extra if conditions should be removed. I found the indentation was incorrect after applying the patch also I encountered an issue, when the four footer regions had content a horizontal scrolled appeared in the page which seems to be unnecessary in respect to users perspective. Thus I have resolve all this problems. The issue persisted in 2.0.1 version, hence updating the version. I've included ss for the overflow issue.
Please have a look.
Thanks

esha_kundu → changed the visibility of the branch 8.x-1.x to hidden.

esha_kundu → made their first commit to this issue’s fork.

Hello @tanushree gupta,
I've reviewed the updates that you have made and found the media queries for responsive devices have been separated in MR!14. I applied the updated MR!14, which applied cleanly and on visiting the /contact/feedback page, the buttons are properly aligned. I visited the same page in Firefox browser and resized the screen for mobile devices and found the overflow issue has been resolved. As all the problems that I had mentioned earlier in #11 🐛 Website feedback form is not responsive Active have been addressed, hence moving to RTBC. Please find the ss for reference.
Thanks

@yas sorry for too many commits but I've resolved the conflicts and also fixed the Stylelint errors that were present.
Please have a look. Thanks

Sure @yas will look into this.

Hello @ravi kant,
I encountered this issue when I cloned the repo and checked in the development version 1.0.x-dev however when the theme is installed using composer from the project page the spacing issue is not found. After installing the theme I visited the login, register, reset password pages. I faced the mentioned issue. For Article content type when the comment section is placed at the end page by configuring in Manage Display, an extra spacing is noticed if the comment section is not rendering. I applied the MR!12 which applied cleanly. I revisited the pages (login, register, reset password, article content type pages, page where comment section is not rendering) the spacing issue was resolved. I've also reviewed the MR and it looked good to me.
Attaching the ss for reference and moving to RTBC.
Thanks :)

Thanks @tirupati_singh for addressing the issues that I had mentioned in #4 ✨ Display design similar to multiple selected values when the select field allows single value. Active earlier. I re-reviewed the MR!40 and it looks good to me. I applied the patch which applied cleanly after that I configured the admin theme to seven. In Manage Form Display enabled the checkbox in the field widget and verified the design for the single select field elements. The alignment and design for the single select field items was improved.

I've reviewed the MR!40 and found you have included the styling for gin, claro and seven theme in the newly created file select2.single-style.scss however separate scss files are present for these theme styling. IMO we could maintain the discrete structure of styling as present in the module.

Regarding this suggestion that I mentioned earlier, thanks for the clarification and I acknowledge that unnecessary css should be avoided loading on a page when the Single item style option is disabled.
Including ss for the after changes. Moving to RTBC.
Thanks

Hello @yas,
I've resolved the minor comment that you had added in the MR!74. I found the hover effect for this search button is different from the buttons present in theme hence fixed the hover effect for the search button. While I reviewed the MR!74 I came across that the variable was not used for the color property therefore replaced the hex-value for color with the variable. Attached video for the hover effect.
Please have a look.
Thanks

Hello,
I've reviewed the MR!41 and found the column-gap property is used for providing the space, which I think is a better approach than using margin property.
I reviewed the issue following the below steps,

1. I cloned the theme repo in Drupal version 10.3.6.
2. I installed the theme and visited the /contact/feedback page when I came across the missing space problem between the buttons in this page.
3. I applied the MR!41 and found the issue was rectified.

Attaching the before and after ss for reference. Hence moving to RTBC.
Thanks

I'll look into this.

I'll review this.

Hello,
I came across the same problem of missing screenshot in Appearance section. I've installed the theme version 1.0.7 in Drupal version 10.3.6.
When I visited /admin/appearance to install the theme, I saw the missing screenshot. I applied the MR!15, which resolved the issue. I've reviewed the MR and it seems to be a typo error in the naming of the image file, which was addressed.
IMO we should fix this.
Attached ss of before and after patch. Hence, moving to RTBC.
Thanks

Hello,
I found the issue still persists after installing the seven theme version 1.0.0 in Drupal version 10.3.6. As mentioned in #23 🐛 In ui-dialog box at Views button hover effect is odd Active the theme is removed from Drupal core. The MR provided in this issue was for the core hence I moved the code to the seven theme and raised the MR!13.
I also encountered another problem related to the dialog-box button in /en/admin/content page. After visiting the content page , I went to delete option for a content. The dialog-box opened with the delete button being displayed in focused form. On clicking anywhere except the delete button I noticed the visibility issue in the delete button. I have fixed this issue in MR!13. Please find the below image for reference.

I've attached the video for the before patch and the mentioned issue.
Please review.

I'll review it.

esha_kundu → made their first commit to this issue’s fork.

Hello @tirupati_singh,
I've reviewed the MR!40 and found you have included the styling for gin, claro and seven theme in the newly created file select2.single-style.scss however separate scss files are present for these theme styling. IMO we could maintain the discrete structure of styling as present in the module.
I installed the module and followed the steps mentioned in the issue. Encountered the design inconsistency therefore applied your patch. The design of single list item was improved after enabling the checkbox in the field widget present in Manage Form Display page and now it matches the multi-select list item design. I verified the design in seven, claro and gin admin themes. I noticed few issues in case of seven theme. The style for the single list item seems to be different compared to the multi-select list item and the alignment of the dropdown button is inappropriate. It would be nice if we could makes these updates thus moving it to NW.
NOTE: After installing the module we need to follow the steps mentioned in modules project page → to integrate the select2 library.
Attaching ss for reference.
Thanks

Hello @tanushree gupta,
I appled the MR!14 which applied cleanly. The form design is improved, resolving the earlier design issues mentioned in #9 🐛 Website feedback form is not responsive Active , however I find the submit button is not properly aligned with the form fields. In Firefox browser a horizontal scroll is coming for mobile devices. IMO if the left sidebar region includes content it is better to display the sidebar in full width in mobile devices rather than maintaining the Desktop layout as I observed many themes have designed the sidebar in such a manner. I found the horizontal scroll is occuring due to the display: table; property included in the body element. I added the below code in the responsive.css file and the overflow issue is resolved.

@media screen and (max-width: 992px) {
  body.path-contact {
    display: block;
  }
  .path-contact #wrapper {
    display: flex;
    flex-wrap: wrap;
  }
  .path-contact #wrapper>div {
    width: 100%;
  }
  .path-contact #wrapper #content {
    margin-left: 0;
  }
  .path-contact #wrapper #sidebar-left,
  .path-contact #wrapper #sidebar-right {
    width: 100%;
  }
  .path-contact #wrapper #sidebar-left {
    margin-left: 0;
  }
}

I reviewed the MR!14 and noticed that the media query is included in the style.css file while there is a separate file name responsive.css present in the theme. It would be better to maintain the separation of responsive code. Included ss for reference hence moving it to NW.
Thanks

Hello,
I've installed the gin module, followed by enabling the admin toolbar search module. Configured admin toolbar search module by activating the display the search input as menu item in /admin/config/user-interface/admin-toolbar-search-settings and setting the gin theme navigation to Legacy, Classic Drupal Toolbar. I found the overlapping issue on clicking the search bar in Chrome and the mentioned issue in comment #24 🐛 Search icon and text overlapping issue. Active in Firefox. I applied the MR!517, which applied cleanly. Checked the overlapping issue in Chrome and Firefox browser, the alignment is rectified for Desktop and other devices in both the browsers. For the comment in #35 🐛 Search icon and text overlapping issue. Active , I acknowledge that the issue is only for the gin classic-toolbar but as per my findings, the classic_toolbar.css file is attached whenever the navigation is configured to Legacy, Classic Drupal Toolbar in /admin/appearance/settings/gin page using the library gin/gin_classic_toolbar. Additionally, this library contains this file and toolbar.css for styling purpose. The remaining toolbar works correctly without getting affected by this file. Hence wrapping it within body:not(.gin--classic-toolbar) is not required in my opinion. Including ss for reference. Not quite sure about the ss provided by @selfirian in #37 🐛 Search icon and text overlapping issue. Active , cause I didn't face such a issue.
Therefore moving to RTBC as the mentioned issue is resolved. Thanks

Hello, I'll review this one.

Hello,
I've installed the project browser module version 2.0.0-alpha3 in Drupal version 10.3.6 after which I enabled the Drupal Core in the project browser config page (admin/config/development/project_browser). Visted the /admin/modules/browse page after saving the configurations. Tried filtering categories under Drupal core tab however the results obtained are inappropriate as per the filter, also the filter text is not visible after selection. The number in the tab doesn't change after filtering the categories, it shows changed number when different tabs are clicked ( sometimes single tab change works otherwise two tab change works ) but on visiting the Drupal core tab it displays the unchanged number. Attaching ss and video for better understanding.

Hello @sourojeetpaul,
The issue that I had mentioned previously in #19 🐛 Cookie settings modal buttons are not visible on smaller screens Needs review has been resolved with your current patch 3457021-20.patch → hence moving to RTBC. Attaching ss for reference.
Thanks

Hello @sourojeetpaul,
I've re-reviewed by applying the patch 3457021-18.patch → . The design fixes that I had mentioned in #17 🐛 Cookie settings modal buttons are not visible on smaller screens Needs review was addressed, which resolved the incorrect alignment and the smaller width of save button in landscape view of mobile devices. However, it seems like there is still one design issue that is not addressed. In devices having width greater than 576px the buttons are having equal space between them, but the save button is not equally spaced below 576px. I've provided ss for reference.
Please have a look.

Hello,
I've reviewed the issue by following the below steps:

1. Installed the module version 1.2.13 in Drupal version 10.3.4, enabled the module COOKiES.
2. Set Bootstrap 5 theme as Default theme.
3. In Block Layout added the Cookies UI block in the footer section.
4. Switched to responsive screen for mobile devices. Found the missing buttons (Deny all, Accept all) on opening the Cookie Settings.
5. Applied the patch in cookiesjsr library, provided in comment #14 🐛 Cookie settings modal buttons are not visible on smaller screens Needs review . The patch applied cleanly.
6. Checked the three buttons ( Deny all, Accept all, Save ) appearing both in portrait and landscape view for mobile/tab view, it looked fine in desktop devices also.
7. As per the comment #12 🐛 Cookie settings modal buttons are not visible on smaller screens Needs review , checked the buttons design for 3-4 languages (German, French, Spanish, Japanese) and it looked fine.

I would like to point out two design fixes that needs to be rectified,

• For mobile devices, I found the alignment of the save button is'nt correct.
• In landscape view the save button seems to be a bit smaller in size compared to the Deny all and Accept all buttons especially when the save text is small like in japanese its 保存.

Hence, moving to NW.

Hello @tanushree gupta,
I've installed the theme version 1.0.1 in Drupal version 10.3.4 and enabled the theme. After enabling found an unexpected error on the page for which applied the patch provided in issue: Issue #3441416 🐛 The website encountered an unexpected error RTBC . After that visited the contact page (/contact/feedback) and resizing the screen similar to mobile devices, found the form is'nt design for responsive design. I applied MR!2 but the issue wasn't resolved. Then I applied MR!14 which applied cleanly, however the issue still persists. I found the button and form design has been changed which doesn't matches with the theme design. Even the border around the fields in the form makes it difficult to identify the input field, it would be better if the border is'nt added to the div wrapping the form input/textarea elements. Hence, changing to NW. Attached ss for reference.

Hello @tanushree gupta,
The menu arrow, position and design in mobile devices looks good to me after applying the MR!20 and it applies cleanly, however the MR contains css file changes and is missing the scss file changes. Since the theme is using scss, we need to convert the css changes into scss. Therefore, moving to NW.
Thanks

Hello @tirupati_singh,
I've fixed the tags design is overflowing on mobile devices issue that you've mentioned in #13 ✨ The design of tag links needs improvement. Needs work . I found that the tags just changed the cursor pointer on hover whereas the read more button showed border color change while hovering. Therefore, I've implemented the hover effect for the tags. Please review.

Hello,
I've installed the module version 3.0.0 in Drupal 10.3.4 and added icons in the main navigation menu links followed by configuring the appearance to without text. Found the aria-label is being set in the <li> hence when the screen reader reads the menu link, it fails to identify the aria-label. After applying the MR!2, the aria-label is set in the <a> which is identified by the screen reader correctly. The issue is raised for 8.x-2.0, but it still persists in 3.0.0 and the provided MR applies in the latest version cleanly therefore need to port the changes in 3.x-dev. The MR resolves the issue therefore moving to RTBC, including before and after ss.
Thanks

I've fixed the design issue of the form in search block and created the MR!13. The search-block.scss file was using 4 spaces indentation, I've rectified it with 2 spaces indentation as mentioned in css coding standards documentation. Attaching the design fix ss, please have a look.
Thanks

I'll work on this.

I've resolved the conflicts in the MR!11. The previous code targeted #footer_nav id for styling due to which the styling wasn't being applied as the first part (i.e, footer is the menu machine name) is dynamic cause one can create custom menu and not necessarily have machine named footer. I've addressed this by changing the id to class selector and updated the MR!11.
Included ss for before and after. Please review.
Thanks

Hello,
I've reviewed the changes in MR!9, the code looks good. I've applied the new changes and the MR applied cleanly. Checked the contact form preview visibility and spacing, which was resolved. Checked the issue while previewing comments in nodes that I had mentioned previously in #12 🐛 In contact form, preview message has some styling issues. Needs review , the style that was being applied previously due to targeting the form element has been resolved.
Attaching the ss for reference. Moving to RTBC.
Thanks

Hello,
I've reviewed the changes by following the below steps:

• I installed the Project Browser module version 2.0.0-alpha3 in Drupal version 10.3.2, enabled the modules Project Browser, Project Browser Devel, Project Browser Source Example.
• Went to /admin/modules/browse and found the four tabs, on hovering the cursor had default value.
• Applied the MR!570 which applied cleanly.
• Went to /admin/modules/browse. On hovering the tabs cursor had pointer.

Attached the ss and video for reference. RTBC +.
Thanks

I've cloned the project (branch 1.0.x) in Drupal version 10.3.2 and applied the MR!11, the patch couldn't apply got the below error

Checking patch css/style.css...
error: while searching for:
.custom-pagination .page-item .page-link[title="Go to last page"] {
  border-radius: 5px;
}
.breadcrumb a, 
.breadcrumb-saprator {
  color: #f34573;
}
.breadcrumb-saprator {
  padding: 0 8px;
}

error: patch failed: css/style.css:1049
error: css/style.css: patch does not apply

I'll work on this.

Hello,
I've reviewed the changes by following the below steps:

• Installed the theme version 8.x-1.0 in Drupal version 10.3.2, found the overflowing issue on mobile devices. (The theme version 8.x-1.0 is a tag that doesn't consists of the new changes).
• As the changes have been merged in development branches 3.0.x and 8.x-1.x, therefore I removed the theme (installed using composer version 8.x-1.0) and cloned the project from git.
• In branch 8.x-1.x, installed and enabled the theme. The overflow issue was resolved.
• Then, I changed to branch 3.0.x and created a sub-theme followed by enabling the sub-theme. The issue was resolved in this as well.

Including the before and after ss for reference.
Hence, moving to RTBC.
Thanks

Hi @kristen pol,
Like you've mentioned in #5 📌 Project Browser: Create a logo for Office Hours Needs review that the line style needs to be reduced, I've made changes accordingly and also included my proposed design (both transparent).
Please let me know your thoughts.

Hello,
I've cloned the project (branch: 1.0.x), found the module search api ai chatbot is having jquery_once as one of the dependencies however it is not being used, the jquery and once library of the core is used instead. Hence, the module can't be enable due to the missing jquery_once module. To resolve this issue I've applied the MR!28 which applied cleanly and I could install the search api ai chatbot module without jquery_once module. I've included the ss for before and after, please have a look.
Thanks

@smustgrave, as per my findings if we could implement the direction in list element(ul/ol) then while viewing the node, the direction would have been implemented similar to ckeditor 4, however targeting the parent resulted in a blocker and it seems like you didn't like the idea also. I came up with the idea of handling the direction using css, please have a look at the below code

.ck-editor__editable ul:has([dir='rtl']),
.ck-editor__editable ol:has([dir='rtl']) {
  direction: rtl;
}

I've made use of the has selector for checking the direction 'rtl', depending on this condition the direction of the parent list element (ul/ol) is changed. To have a similar affect when viewing the node after changing the direction, I've include the below code in a separate css file after that I made an library for the same and attach it using preprocessor node cause including the css in the existing bidi_direction.css file, the library doesn't get attach for anonymous node view, logically the node page can be opened in anonymous view also.

.node__content ul:has([dir='rtl']),
.node__content ol:has([dir='rtl']) {
  direction: rtl;
}

I've not included the check for dir='ltr' as when it is 'ltr' the p tag isn't set to dir='ltr' it only consists of the class="ck-list-bogus-paragraph" which will result in unnecessary extra css code.
Please have a look at the below ss,

1. The node view of lists after changing the direction to 'rtl' in ckeditor 4.

2. The node view of lists after changing the direction to 'rtl' in ckeditor 5.

3. After including the css
1. ckeditor

2. node view

I've added the patch file, please let me know your opinion.
Thanks

Hello @Tanushree Gupta,
I've installed 2.0.1 version of Simple Classic Corporate Theme on Drupal version 10.3.2, the visibility and padding issue while previewing the contact form still persist. Initially I applied the MR!1 provided in #4 🐛 In contact form, preview message has some styling issues. Needs review and the patch applied cleaning resolving just the padding issue while the visibility issue still persist. I removed the changes applied in MR!1 followed by the application of MR!9 🐛 In contact form, preview message has some styling issues. Needs review , that applied cleanly. The design of the form was improved and the stated issue of visibility, padding was also resolved. I've reviewed the MR!9, changes are made targeting the form element due to which the comment form design is also altered and as per the issue we don't need to change the design of all forms. In case, we need to improve the contact form design we can just include css for that only without affecting other forms. Have attach ss regarding the changes in comment form in node page while previewing, before and after of the contact preview message.
Thanks

Hello,
I have followed the below steps to review,

• Installed the module, used the frontpage view where I enabled Ajax.
• Went to page 2 and checked the prev button href which had /views/ajax.
• Applied the MR!3, which applied cleanly.
• Rechecked by going to page 3, checked the prev button href which had /node (correct href of frontpage).

Have included the before and after ss for reference.
Hence, moving to RTBC.
Thanks :)

Hello @smustgrave,
I'm sorry for not making any updates for such a long time. I faced a blocker in targeting the parent list element (ul/ol) while resolving this issue. In the current scenario the p tag containing the list text which is present within the li element where the direction 'rtl' is getting added whenever the BiDi button is clicked, whereas the list element (ul/ol) still has the direction 'ltr'. I have tried implementing the react js functions for targeting the parent element. Also I have gone through the ckeditor plugins and functionalities. When I came across the ckeditor list reversed plugins that targets the parent element (ul/ol) and adds reversed data attribute which is similar to what I had to achieve in this case but unfortunately the parent target is being identified as paragraph instead of listitem, as a result the 'rtl' direction attribute is not being set in the parent. There is also this open issue in github regarding the incorrect padding for list: https://github.com/abedio/ckeditor5-direction/issues/1.
Sorry for the inconvenience.

I've came up with this logo and I've kept the background transparent.
Please have a look.
Thanks

I'll work on this.

I'll work on this.

I've include a bit more spacing in both the sides of the logo as it might seem to be edge to edge.
I would like to know your thoughts about the changes.
Thanks :)

My bad I've uploaded the incorrect file.
Please take a look at this one.

Hello,
This module says it is integrating Mailchimp service in the project page, which has its own logo (placed in top-left corner). The project page is also using the official logo of Mailchimp.
So, I've resized the official logo to 512x512 square dimension in png format.
Please have a look.

Hello,
As @ravi kant mentioned in the comment #5 🐛 Empty "li" tag is showing. Needs review the empty value was rendering from core system module template file links.html.twig. So I've added the link template in the theme and included the required logic. Now the empty "li" is not appearing both for login/anonymous users in homepage. Please review, I've attached ss for reference.

esha_kundu → made their first commit to this issue’s fork.

Hi,
I have resolved the overlapping issue that was mentioned in #10 ✨ The design of tag links needs improvement. Needs work . I found the issue occurred when the tag had multiple values with or without tag label. I've updated MR!30 and included ss for reference.
Please have a look. Thanks

esha_kundu → made their first commit to this issue’s fork.

Hello,
I have added the changes and raised the MR!23 for the current development branch 9.1.x. I've made the hover effect similar to the buttons in the theme.
Please have a look, I've added ss for reference.
Thanks

esha_kundu → changed the visibility of the branch 3391588-readmore-button to hidden.

Hi @Kanchan Bhogade,
As per the screenshot that you have provided I find the MR!22 failed at your end because you have been checking it in 9.1.0 version which is a tag consisting of previous changes. I think if you clone the project and checkout the current development branch 9.1.x, followed by applying the patch then this patch application error would be resolved.
Thanks

Hello,
I'll work on this.

Hi @zeeshan_khan,
I've resolved the conflicts, please check.
Thanks

Hello,
I installed the theme version 9.1.0 on Drupal version 10.3.2, the mentioned issue existed so I applied the MR!4 but got patch fail error. Updating the version for this issue. As per the comment by @zeeshan_khan, I have made changes and created MR!22. I also noticed that the dropdown arrow remained facing downward even when the menu list is expanded, according to me this is a design issue that can be solved here as well. I have addressed this and made the arrow face upward whenever the menu list is expanded.
Added ss and short clip for reference. Please review.
Thanks

I'll work on this.

Hello @zeeshan_khan,
I have coverted the fix of MR!17 in scss and updated the MR!17, please review.
Thanks

esha_kundu → made their first commit to this issue’s fork.

Hello,
I did a fresh installation of the latest version 1.0.3 of this module in Drupal site version 10.3.2, after that applied the MR!11 which applied cleanly. I have also reviewed the MR!11 and it looks good to me. After applying the MR I checked the functionality of the module and found it functions properly like it worked before applying the patch. Hence moving this to RTBC.
Thanks

Hello,
The steps to reproduce the issue is'nt clear and I've explored the module but could'nt reproduce the reported bug.
Please update the issue summary.
Thanks

I re-reviewed the MR!2 and the typo I mentioned in #15 📌 README.txt file replace with README.md file Needs review has been fixed. Hence, moving to RTBC.
Thanks

Hello @Arijit Acharya,
I have reviewed the MR!2 and as per my finding the name of the module Physical Fields is not updated here, it is provided as just Physical.
Apart from that the changes looks good and all the above stated issues have been addressed.
Thanks

Hello,
I've reviewed the changes in the MR!37 and it looks good to me. The MR!37 applied cleanly. For the UI, I applied the patch and reinstalled the theme as there are changes in the installation configuration. Now there is no errors in the theme setting page, successfully saving the configuration changes. The clickable issue for the icons in the footer is also working.
Adding ss for reference below,
1. The configurations saves successfully.

2. when the checked the show social icons checkbox. It is clickable with default social links.

Moving to RTBC.
Thanks

Hi @hcanning,
I'm not sure from where you are trying to acess the media image alt value. If you could clarify that it would be great!
I have installed the module and created a paragragraph with a reference field media type image. After that configured the formatter to Thumbnail URL in 'Manage Dispaly' for the paragraph type. Created an entity and referenced the paragraph type. Accessed the media image value using the twig template.
You can try out this, it worked for me.
{{ paragraph.field_test_image.entity.field_media_image[0].alt }}
Here field_test_image - it's the image field name within the paragraph,
field_media_image - it's the default media type image field name.
In case, you still can't access the media alt value in paragraph make sure that you have used media referenced in the paragraph type.
Thanks

Hello,
I have reviewed the MR!1 and found the MR is raised for branch 8.x-2.x whereas the version 3.0.0 is created from the branch 10.x. The changes made in the info.yml file is already present in the branch 10.x and due to this reason the MR!1 is failing in the current version. Changing the target branch might fix the patch fail issue.
Firstly I have cloned the repo, followed by applying the MR!1. Encountered the below error

error: patch failed: freshchat.info.yml:1
error: freshchat.info.yml: patch does not apply

The readme file should use Two lines prior to ##/### headings as mentioned in https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or-distribution-project/documenting-your-project/readmemd-template → .

Hi,
I have followed the below steps to review:

1. Installed and enabled the module.
2. Navigated to Administration > Configuration > Development > Scss Compiler. Encountered an error "the seven theme does not exist", resolved this by applying the patch provided in this issue https://www.drupal.org/project/scss/issues/3456650 🐛 Install script is hard coded to watch theme ‘seven’ RTBC .
   In the configuration page found the duplicative word scss in the description of the "Directory name containing SASS/SCSS source files" field as “This is usually scss or scss and is relative to theme root.”
3. Applied cleanly the MR !2.
4. Checked the description in the configuration page for the field "Directory name containing SASS/SCSS source files" which was corrected to “This is usually sass or scss and is relative to theme root.” that followed the similar order as the field name.

I have attached ss of before and after, please take a look.
Moving to RTBC.

Hi,
I came across this same issue so I applied the MR!3.
I have followed the below steps:

1. Installed the scss module without the seven theme in the site.
2. Enabled the module from Administration > Extend.
3. Navigate to Administration > Configuration > Development > Scss Compiler. Found the reported bug.
4. Applied the MR!3. The patch applied cleanly.
5. Uninstalled the module as the changes have been made in the installation configuration of theme to watch value.
6. Re-installed the module following step 1 to step 3. Found the configuration page is visible without any errors.

I have attached the ss of before and after.
Moving to RTBC.

Hi @ravi kant,
I've reviewed the MR!34 and I found you have addressed the drupal_get_path() not found issue also but that is resolved in an issue already refer https://www.drupal.org/project/school_theme/issues/3437946 🐛 drupal_get_path() is deprecated in Drupal 9.3.0 and removed from Drupal 10.0.0 RTBC . Since this issue is not a part of this issue we can ignore these changes. Apart from that the linkedin and youtube icons are not visible. Also if the checkbox to show all the social icons is selected but the social icons url is not set then the footer remains blank only with the title, for this scenario we could set the default values for the social icons url or we could use the address of the current page by making use of the '#' in href. Lastly since the footer social icon visibility is already been addressed in the issue - https://www.drupal.org/project/school_theme/issues/3442741 🐛 Linkedin and YouTube icons are not visible in footer Needs work . I think it is better to resolve the remaining footer icon related issue in related issue issue itself. I've included the related issue link.

Hi
I have followed the below steps:

1. Installed the theme(version 3.0.0) along with classy.
2. Encountered drupal_get_path() function not found as mentioned by @Kanchan Bhogade in comment #12. Resolved the issues by applying the patch for this issue https://www.drupal.org/project/school_theme/issues/3437946 🐛 drupal_get_path() is deprecated in Drupal 9.3.0 and removed from Drupal 10.0.0 RTBC . Proceeded with the next step that is check the option to show social icons in footer and while saving the configuration encountered an error call_user_func_array(): Argument #1 ($callback) must be a valid callback. See the below ss
   
   If this step is skipped then the linkedin and youtube icon appears in the footer section but the icons are not clickable.

Added the before and after ss.
Found the footer icons related issue has been addressed in this issue https://www.drupal.org/project/school_theme/issues/3442774 📌 Preprocess is not set for footer icons. Needs review .
We can resolve the footer icon clickable and the configuration saving issue in this MR as the icon visibility is already fixed here.

Hi
I've retested the MR!29 and the patch applied cleanly and the syntax error that I had encountered earlier mentioned in the comment #17 🐛 drupal_get_path() is deprecated in Drupal 9.3.0 and removed from Drupal 10.0.0 RTBC has been resolved now.
Please have a look also attached ss for reference.
Moving to RTBC.

Hello,
I have followed the below steps and encountered this syntax error, added the ss for reference

1. Installed the theme
2. Navigated to the settings page for the theme.
3. Found the error for drupal_get_path() is undefined.
4. Apply the merge which applied cleanly.
5. Found the syntax error in the settings page for the theme.

Please have a look.

Hello @sourabhsisodia_,
I applied the MR!29, it applied cleanly and the form design looks better in both desktop and mobile devices but there are some design issues that needs to be fixed.

1. The heading in nodes are also getting center aligned after applying the MR, it is at odd with the actual design
2. For logged-in users the field send yourself a copy text in contact form should be aligned with the checkbox it is currently appearing underneath the checkbox.

I have added ss, please have a look.
Thanks

Hello,
I found the issue exists in the current version, so I have raised the MR!3 for the same and updated the version.
I would be glad to hear from the maintainer if we need to create a separate field for color selection, so that heading containing links can be more customizable. For now I have implemented the color scheme similar to that of the other links (e.g. read more, add comments) present when a article/basic page is created.
I have added the ss for both without hover and with hover, before and after changes.
Please have a look.
Thanks

Esha_Kundu → made their first commit to this issue’s fork.

Sorry for the multiple commits, found some errors in configuration pages after resolving the phpcs issue so fixed those.
Please review.

Hello,
I have resolved the merge conflict and found the following warnings that was not addressed,

FILE: ...modules/custom/easy_email/src/Controller/EasyEmailController.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
 339 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 339 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 379 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 386 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $vid
 402 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 435 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $langcode
 441 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $vid
 453 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $vid
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/src/Entity/EasyEmailType.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 169 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------


FILE: .../web/modules/custom/easy_email/src/Entity/EasyEmailInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...eb/modules/custom/easy_email/src/Service/EmailTokenEvaluator.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/src/Service/EmailHandler.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
  15 | WARNING | [x] Unused use statement
 196 | WARNING | [ ] Line exceeds 80 characters; contains 82
     |         |     characters
 231 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
 235 | WARNING | [ ] Line exceeds 80 characters; contains 83
     |         |     characters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...pp/web/modules/custom/easy_email/src/Service/EasyEmailPurger.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 65 | WARNING | Line exceeds 80 characters; contains 86 characters
 69 | WARNING | Line exceeds 80 characters; contains 112 characters
----------------------------------------------------------------------


FILE: ...dules/custom/easy_email/src/Service/EmailAttachmentEvaluator.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
  11 | WARNING | [x] Unused use statement
  12 | WARNING | [x] Unused use statement
 103 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 109 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 136 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $path
 142 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $path
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../modules/custom/easy_email/src/Service/EmailHandlerInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 42 | WARNING | Line exceeds 80 characters; contains 97 characters
----------------------------------------------------------------------


FILE: ...dules/custom/easy_email/src/Form/EasyEmailRevisionRevertForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
 123 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 125 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
 127 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...app/web/modules/custom/easy_email/src/Form/EasyEmailTypeForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 196 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 276 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 377 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 387 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/src/Form/EasyEmailForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------
  11 | WARNING | [x] Unused use statement
  73 | WARNING | [x] Inline @var declarations should use the /** */
     |         |     delimiters
 346 | WARNING | [ ] Line exceeds 80 characters; contains 83
     |         |     characters
 380 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
 381 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
 478 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 501 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 505 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 510 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 513 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...dules/custom/easy_email/src/Form/EasyEmailRevisionDeleteForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
   9 | WARNING | [x] Unused use statement
 111 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 113 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
 115 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/src/EasyEmailStorage.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/src/EasyEmailListBuilder.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 57 | WARNING | [x] Inline @var declarations should use the /** */
    |         |     delimiters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/easy_email.install
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 45 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found: )
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...sy_email/modules/easy_email_override/src/Service/MailManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 74 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
 76 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
 83 | WARNING | Line exceeds 80 characters; contains 93 characters
 95 | WARNING | Unused variable $result.
----------------------------------------------------------------------


FILE: ...modules/easy_email_override/src/Service/DeclaredEmailManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 73 | WARNING | Only string literals should be passed to t() where
    |         | possible
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/easy_email.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------
   9 | WARNING | [x] Unused use statement
  10 | WARNING | [x] Unused use statement
  11 | WARNING | [x] Unused use statement
  15 | WARNING | [x] Unused use statement
  17 | WARNING | [x] Unused use statement
  18 | WARNING | [x] Unused use statement
  19 | WARNING | [x] Unused use statement
 173 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 186 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
----------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...les/custom/easy_email/tests/src/Functional/EasyEmailTestBase.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 80 | WARNING | t() calls should be avoided in classes, use
    |         | \Drupal\Core\StringTranslation\StringTranslationTrait
    |         | and $this->t() instead
----------------------------------------------------------------------


FILE: ...easy_email/tests/src/Functional/EasyEmailTemplatePreviewTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
  40 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 'html'
 114 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 'html'
 193 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 'html'
 405 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 'html'
 473 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 'html'
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 1.24 secs; Memory: 26MB

Hence, resolved all the wraning.
Please have a look.

I'll work on this.

Hello @manish-31,
I applied the MR!5 and the errors for the configuration pages that I had mentioned in #16 have been resolved.
After applying the patch the configuration pages (/admin/config/user-interface/addthis and /admin/config/user-interface/addthis/advanced) are now displaying without any errors as shown below


Thanks
Moving it forward to RTBC

Hi @Arijit Acharya I have applied the updated MR!3
These are the steps that I have followed

1. Took the clone of 1.0.x branch which is the reference branch for the tags 1.0.4 which is the latest version of the module.
2. Executed the command
   phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/viewer/
3. Found phpcs errors
   

   PHP CODE SNIFFER REPORT SUMMARY
   ----------------------------------------------------------------------
   FILE                                                  ERRORS  WARNINGS
   ----------------------------------------------------------------------
   ...r/assets/apexcharts/apexcharts.amd.js.LICENSE.txt  0       1
   ...b/modules/custom/viewer/assets/chartjs/LICENSE.md  0       3
   /app/web/modules/custom/viewer/src/ViewerModule.php   4       0
   ...les/custom/viewer/src/Commands/ViewerCommands.php  1       0
   .../custom/viewer/src/Controller/CKEditorPreview.php  2       0
   ...custom/viewer/src/Controller/ViewerController.php  1       0
   .../viewer/src/Controller/ViewerSourceController.php  1       0
   /app/web/modules/custom/viewer/src/Entity/Viewer.php  1       0
   ...modules/custom/viewer/src/Entity/ViewerSource.php  1       0
   ...tity/AccessControl/ViewerAccessControlHandler.php  1       0
   ...ccessControl/ViewerSourceAccessControlHandler.php  1       0
   .../viewer/src/Entity/Form/BaseContentEntityForm.php  1       0
   ...ewer/src/Entity/ListBuilder/ViewerListBuilder.php  1       0
   ...rc/Entity/ListBuilder/ViewerSourceListBuilder.php  1       0
   ...b/modules/custom/viewer/src/Event/ViewerEvent.php  1       0
   ...er/src/EventSubscriber/ViewerEventsSubscriber.php  1       0
   ...les/custom/viewer/src/Form/CKEditorDialogForm.php  2       2
   ...odules/custom/viewer/src/Form/Source/BaseForm.php  1       0
   ...odules/custom/viewer/src/Form/Viewer/BaseForm.php  1       0
   ...tom/viewer/src/ParamConverter/ViewerConverter.php  1       0
   ...ewer/src/ParamConverter/ViewerPluginConverter.php  1       0
   ...ewer/src/ParamConverter/ViewerSourceConverter.php  1       0
   ...rc/ParamConverter/ViewerSourcePluginConverter.php  1       0
   .../src/ParamConverter/ViewerTypePluginConverter.php  1       0
   ...b/modules/custom/viewer/src/Plugin/ViewerBase.php  1       0
   ...es/custom/viewer/src/Plugin/ViewerCellManager.php  1       0
   ...odules/custom/viewer/src/Plugin/ViewerManager.php  1       0
   .../custom/viewer/src/Plugin/ViewerProcessorBase.php  1       0
   ...stom/viewer/src/Plugin/ViewerProcessorManager.php  1       0
   ...les/custom/viewer/src/Plugin/ViewerSourceBase.php  1       0
   .../custom/viewer/src/Plugin/ViewerSourceManager.php  1       0
   ...dules/custom/viewer/src/Plugin/ViewerTypeBase.php  1       0
   ...es/custom/viewer/src/Plugin/ViewerTypeManager.php  1       0
   ...es/custom/viewer/src/Plugin/Block/ViewerBlock.php  1       0
   ...stom/viewer/src/Plugin/CKEditor5Plugin/Viewer.php  1       0
   .../Plugin/Field/FieldFormatter/ViewersFormatter.php  1       0
   ...er/src/Plugin/Field/FieldWidget/ViewersWidget.php  1       0
   .../custom/viewer/src/Plugin/Filter/ViewerFilter.php  1       0
   ...ewer/src/Plugin/viewer/processor/CsvProcessor.php  1       0
   ...es/custom/viewer/src/Plugin/viewer/source/Ftp.php  1       0
   ...s/custom/viewer/src/Plugin/viewer/source/SFtp.php  1       0
   ...custom/viewer/src/Plugin/viewer/source/Upload.php  1       0
   ...ules/custom/viewer/src/Plugin/viewer/type/Pdf.php  1       0
   ...les/custom/viewer/src/Plugin/viewer/type/Xlsx.php  1       0
   ...stom/viewer/src/Plugin/viewer/viewer/ApexLine.php  1       0
   ...tom/viewer/src/Plugin/viewer/viewer/ApexMixed.php  1       0
   ...m/viewer/src/Plugin/viewer/viewer/ApexTreemap.php  1       0
   ...tom/viewer/src/Plugin/viewer/viewer/ChartLine.php  1       0
   ...om/viewer/src/Plugin/viewer/viewer/ChartMixed.php  1       0
   .../custom/viewer/src/Plugin/viewer/viewer/PdfJs.php  1       0
   ...m/viewer/src/Plugin/viewer/viewer/Spreadsheet.php  1       0
   .../custom/viewer/src/Plugin/viewer/viewer/Table.php  1       0
   ...s/custom/viewer/src/Plugin/viewer/viewer/Tabs.php  1       0
   .../web/modules/custom/viewer/src/Services/Batch.php  1       0
   /app/web/modules/custom/viewer/src/Services/Cron.php  1       0
   ...eb/modules/custom/viewer/src/Services/FtpSftp.php  1       0
   ...ules/custom/viewer/src/Services/Notifications.php  1       0
   ----------------------------------------------------------------------
   A TOTAL OF 60 ERRORS AND 6 WARNINGS WERE FOUND IN 57 FILES
   ----------------------------------------------------------------------
   PHPCBF CAN FIX 62 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
   ----------------------------------------------------------------------

4. Applied the updated MR!3
5. Ran the same command again and Found no errors

LGTM

Hi,
There are still two errors on the configuration pages that are popping up after the phpcs errors fixes is applied. Although there are no phpcs errors left to be addressed but this errors must be resolved as it is causing a hindrance in the usage of the module. It seems that the errors are occurring due to the dependency injection which has been implemented while the phpcs errors have been resolved.
Steps to get the errors:

1. Apply the patch and visit the configuration page of addThis Social share (/admin/config/user-interface/addthis)
2. After the first error is resolved visit the advance tab settings (admin/config/user-interface/addthis/advanced)

The error that is appears on going to the configuration page of the module

The error is appears on clicking the advance settings tab in the configuration page of the module

Thanks

My bad previously I chekced the patch is being applied or not but found this issues while reviewing the code.
Due to the change of the language manager service name in services.yml file there is this error on installation, I have attached ss.
Please have a look.

Hello,
I have applied MR!5 and executed the command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig addthis_social_share/
Found no more phpcs errors.
RTBC+

I have resolved the phpcs issues that were reported after running the following command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml easy_email
for the latest branch and raised MR !30
Please review the changes.

Hi,
There is a new development branch 3.0.x-dev, so I have updated the version.
I will work on the it.