Hi,
There is a new development branch 3.0.x-dev, so I have updated the version.
I will work on the it.
Hello,
I have fixed the accessibility issue for the action buttons globally, the design break as mentioned in #13 in devices.
I found design issue noted below:
- In the bulk operations button in responsive devices the text App appeared along with the tick sign
- In the secondary tabs the border on the left side was not being visible for first tab
- In the recent logs page the Filter button size look too large
- In tab devices the operations buttons in content listing page looked larger
- In the extend page there was no space between the filter and the core
so I have fixed all the above issues.
I have attached the before and after for the issues.
Please have a look.
Hello @Gauravvvv,
As per granting credits, the contributor reviewing a patch and moving the issue foward to fixing the issue can be granted credit.
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquette/granting-credit-to-issue-contributors →
In this regard I haven't been granted credit. It would be great if you grant credit to me.
Thank you
I have resolved the thread please check.
Hello,
I will be fixing the indentations.
Hi,
I'm working on it.
Hi, I have reviewed the changes and the MR applies cleanly.
Moving to RTBC+
Hi,
I applied MR !31 and still getting some warnings and one error after executing
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,yml modules/contrib/school_theme/
FILE: /app/web/themes/contrib/school_theme/school.theme
----------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
9 | WARNING | [x] Unused use statement
10 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
14 | WARNING | [x] Unused use statement
71 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
73 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...eb/themes/contrib/school_theme/includes/flexslider/changelog.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
13 | WARNING | Line exceeds 80 characters; contains 103 characters
----------------------------------------------------------------------
FILE: /app/web/themes/contrib/school_theme/PATCHES.txt
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | WARNING | [ ] Line exceeds 80 characters; contains 104
| | characters
5 | ERROR | [x] Expected 1 newline at end of file; 3 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: /app/web/themes/contrib/school_theme/school.info.yml
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added
| | by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be
| | added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added
| | by drupal.org packaging automatically
----------------------------------------------------------------------
Hello @bindu r,
I have reduced the extra spacing between the readmore button and the content.
Added ss please have a look.
Hi,
I came across the same design issue with the tabs with this theme and I have applied the MR!17 which resolves the design issue.
I have attached the before and after ss.
Moving to RTBC.
Hello,
The issue is not in the slick views as the toggle displays as a checkbox which works correctly in other themes like claro, Olivero, etc. as you have mentioned in the steps to reproduce. In the gin theme, the checkboxes are designed as toggle buttons and for the provided settings in the slick views the checkbox element is placed in a different position due to the usage of flex on the parent wrapper. The other toggles present in the site mainly don't have grid or flex used in the parent wrapper for this the issue doesn't occur. I think this issue needs to be resolved particularly for the gin theme since it is related to the theme. I have updated the project to Gin Admin Theme along with the version and the issue summary.
I have updated the background color to black.
Please review.
Esha_Kundu → changed the visibility of the branch 3348982-content-align-center to active.
Esha_Kundu → changed the visibility of the branch 3348982-content-align-center to hidden.
hi
I have updated the requirement and installation section in the readme file.
Wrapped the words within around 80 cols as recommended by Drupal.
Please review.
Esha_Kundu → made their first commit to this issue’s fork.
I have added the patch for this.
Added the ss for the changes.
Please review.
I will work on this.
Hi
Drupal recommends butted list to be denoted by dashes.
So I have updated the syntax and made a commit.
Please review.
Esha_Kundu → made their first commit to this issue’s fork.
Updated the twitter icon with the Twitter-x icon.
Added SS.
Esha_Kundu → made their first commit to this issue’s fork.
Added ss of fixes of the space with content.
Added 1 commit:
- b1bf1979 - Issue #3388721: Read more button need style according demo site.
Added ss of the changes.
Esha_Kundu → made their first commit to this issue’s fork.
The filters action button had a design break in the mobile view, I have also fixed that and included in the MR.
I added ss for reference.
I have created the MR for fixing the phpcs.
merge request !4
Added 1 commit
- 12665e98 - Issue #3416993: Fix the issue reported by phpcs
I have created an MR to fix the issue.
merge request !9
Added 1 commit
- ae7d39e3 - Issue #3418802: There is no space below action button
Please review the added ss for reference.
Fixed the phpcs issues reported #8.
Please review the attached patch.
Hi, @shweta__sharma
I'm working on it.
I have created the MR for fixing the issues reported by PHPCS and also the Drupal coding standards.
merge request !5
Added 1 commit
87c4d109 - Issue #3418404 by Esha_Kundu: Fix Drupal coding standards issues.
I have fixed the issues reported by phpcs.
Attached patch.
I have fixed the issues reported by PHPCS.
Attached patch.
I'm working on it.
Hi @shweta__sharma,
I have rechecked the issue by doing a fresh installation, but still the issue persists.
Which Drupal version are you currently using since I'm using Drupal 9.5.11. Attached ss below.
Esha_Kundu → created an issue.
Hi, I am also not able to replicate this issue. Created a content with readmore, checked for different screen sizes (including the iPad Pro dimension) but readmore does not overlaps with the footer.
Please find the ss for reference.
Drupal 10 uses Twig 3.x, where the {% spaceless %} tag was completely removed in favour of the {% apply spaceless %} filter. The codebase of barrio bootstrap 5 is also using {% apply spaceless %} filter in the latest version, so could you explain the steps to reproduce the issue?
Esha_Kundu → made their first commit to this issue’s fork.
Esha_Kundu → created an issue.