@Esha_Kundu

Hello,
I followed the steps below to review the issue:

1. Installed the theme version 1.4.3 in Drupal version 10.4.8.
2. Checked the page /user/1 in anonymous view. Found the 403 default page.
3. In Basic site settings, I configured the 403 page to redirect to /node. Revisited the page in step 2. Noticed the page is still showing the 403 default page.
4. Applied MR!13 cleanly.
5. Repeat step 3; it appears the redirection is corrected, the actual /node page is visible instead of the default 403 page. Checked by adding different redirection paths and also without. All worked correctly.

After applying the patch, the Back to Home button is redirecting to the same page. I think the Back to Home should redirect to the home ( Default front page ) of the site; redirecting to the same page with the button text "Back to Home" is not logical. IMO, using / instead of {{ base_url }} would be proper.
Attaching SS for reference. Moving to NW.
Thanks

Hello,
I've added a growing underline hover effect on the node titles on the front page. Additionally, fixed the alignment on individual node pages. IMO, the title on individual node pages is not represented as a link, hence changing the colour would cause difficulty in differentiating a link and a heading. I also verified with a few other themes and discovered that the node title on the front page is styled with colour and text-decoration, while on the individual page, there is not much styling applied. Bearing this point in mind, I have enlarged the font size of the title, as it appeared too small for a heading on individual node pages. Please review the new changes.
Thanks

Hello,
I found that only CSS changes have been added in MR!26; however, the theme is using SCSS for styling purposes. Additionally, in colour.scss file the variable for light gray is defined as $gray-light: #D3D3D3;. Instead of using this colour, I found a different colour is used for the .background-gray. I've updated the MR!26 with these fixes. Please review.
Thanks

esha_kundu → made their first commit to this issue’s fork.

Hello @divya.sejekan,
The css changes are made in the chahmirian.css file for both MR!26 & MR!29, however this file is removed in this commit: Bootstrap SCSS Setup Commit from the development branch ( main ). The current theme version 1.1.1 is a tag created from branch main consisting of earlier changes. As per my comment in #7, if we resolve the conflicts for MR!26 the design changes would be lost as it is targeted with the development branch ( main ). Thus, please review this changes in Drupal version 9 for now.
Thanks

Hello @danrod,
I've reviewed the MR!7 as per the Readme Template → . The following points need to be addressed,

• Missing two lines before ##/### headings.
• Missing a meaningful link text for links, for example: [Drupal]( https://www.drupal.org/ → ) (i.e. not just the URL)
• The introduction is added along with the project name. We can remove the duplicated introduction head and content.
• The Recommended modules head is optional, as it doesn't have any modules mentioned, so we can remove it.
• In the Installation section, if bulleted points are required, we need to use - instead of *. IMO, as there is no listed content, we can remove the * before the content.

Hence, moving to NW.
Thanks

Hello,
I've resolved the merge conflicts, and I found that the CSS changes for the node color was removed from the file due to which the changes were not being reflected. Hence, I've added it in the css file. Regarding the comment #4 the styling for links in the front page is being addressed in this issue: #3424270 🐛 Read more button needs to be styled. Active . Please review.
Thanks

esha_kundu → made their first commit to this issue’s fork.

Hello,
I've reviewed the issue following the steps mentioned below:

1. Installed theme version 8.x-1.7 in Drupal version 10.4.7.
2. Set this theme as the Administration theme.
3. Ensure that a media & image field is present in the Content Type; if not, add both the fields.
4. On the add/edit page of a content, add a media file in the media field.
5. A modal opens with a cross icon representing the remove button, which differs significantly from the remove button that appears for the image field in this theme.
6. Applied the MR!13 cleanly.
7. Repeated step 4 and found the button similar to that of the image field. The hover is also aligned with the buttons in this theme.

Attaching SS for reference. I am also updating the issue summary for improved clarity. Moving to RTBC.
Thanks

Hello,
The previous MR!26 was targeting the main branch, which had conflicts, and as per my previous comment, the chahmirian.css file has been removed from the main branch. Hence, I've created a new MR!29, with the design fixes and kept the target branch 1.0.2.
Please review.
Thanks

Hi @avpaderno,
I've reviewed the changes and the mentioned issue in /filter/tips was resolved, however, I found that the tips list bullet points were showing a design break, as shown in the image below

To obtain the above design break, navigate to the add/edit page of a node that has having full-format long text field ( e.g., body field ). Change the text format to restricted HTML. Check the design of the listed tips.
I have fixed this issue. Please check. Adding before & after the changes in /filter/tips page.
Thanks

I'll review this.

Hello @avpaderno,
I've updated the summary and title. I found that the theme screenshots for the listed uninstalled theme are rendering in a smaller size compared to the installed theme screenshot. IMO, this issue can be fixed here itself as it is associated with the Uninstalled Theme list design. I've increased the theme screenshot size and additionally fixed the screenshot size for smaller devices, moving to NR.
Attaching SS for reference.
Thanks

esha_kundu → made their first commit to this issue’s fork.

Hello,
I've created three alternatives and modified the text part. I prefer the first one. Would be glad to hear from you.
Will create the MR once the logo is finalised. Moving to NR.
Attaching the PNG and zip for the SVG formats as per the request in #7.
Thanks

Hello,
I've reviewed this issue following the below steps:

• Cloned the theme repo and checkout in 8.x-1.x branch cause the current version 8.x-1.0 is a tag which is not updated.
• Navigated to Block Layout > Main navigation > Configure > Menu Levels > Number of levels to display.
• Increased the number as per the comment in #8.
• Found the alignment issue. Applied the MR!27, which applied cleanly.
• The alignment issue with the submenu is fixed.

IMO, increasing the padding on the right side of the menu-item is creating a large gap between the menu text and the arrow. Before applying the patch the spacing seems to be correct. It would be better if the submenu items right padding is reduced instead. I've updated the Issue Summary for better clarity of the issue.
Attaching SS for reference. Hence, moving to NW.
Thanks

Hello,
I've fixed the design break for the submenus and updated the MR!12.
Please check. Thanks

esha_kundu → changed the visibility of the branch interior_design-3391829 to active.

esha_kundu → changed the visibility of the branch interior_design-3391829 to hidden.

Hello @danrod,
Sorry for the late reply, I've tested the MR!52 in Drupal version 10.4.6. The MR applied cleanly, and the logo is visible and is the correct size. However, I found that you have used a static width for the image, due to which when Use the logo supplied by the theme is disabled and a custom logo is used, the logo renders in a very small size. IMO, we can make use of the below snippet

.navbar-header .site-branding img {
  max-width: 80px;
  max-height: 56px;
}

I'm attaching the SS for reference.
Will be glad you hear from you.
Thanks

I'll review this.

Hello @chhavi.sharma,
I've reviewed the changes in the MR!3, variables has been added as per my last comment. However, it seems like you have missed the point about the variables being undefined. Now after the patch is being applied due to undefined variables the style is not getting applied hence the issue isn't resolved.
It would be better if you defined the undefined variables in the form_input.scss file similar to that of
--lum: var(--lum-body);
and for the border-color you could follow border-color property defined in base.scss for the hr tag.
I would also recommend to use different variable name instead of --button-border, cause to resolve this issue we are defining the variable specifically in form_input.scss file.
Moving to NW. Thanks

Hello,
I've fixed the mentioned issue in MR!28.
Moving to NR.
Thanks

Hello @jaydeep_patel,
I've reviewed the comment section design by following the steps below:

• Cloned the theme repository.
• Checked out the 1.0.2 branch cause the chahmirian.css file was missing in the default main branch ( it seems to be removed in this commit: Bootstrap SCSS Setup Commit
• Applied the MR!26, which applied cleanly.
• The comment section design was improved.

IMO, the background around the comment section doesn't look very appealing. Additionally, the border around every comment represents that they are different comments and not nested replies of a single comment. I think it would be better if the background and padding around the comment section were removed, along with adding a border around the complete comment rather than the individual replies. The conflict in the MR also needs to be resolved.
Attaching SS for reference. Moving to NW.
Thanks!

I'll look into this.

I'll review this.

Hello @tanushree gupta,
I've reviewed the MR by installing the theme in Drupal version 10.3.6. The issue title should be changed because the form is visible without applying the patch. However, the form design has been improved after the patch application. In my opinion, the spacing between the form fields, especially the form buttons, is missing. Thus, moving to NW, attaching the SS for reference.
Thanks!

Hello @yas,
I've rebased the MR please check.
Thanks!

esha_kundu → made their first commit to this issue’s fork.

@yas,
I've rebased the MR please check. Thanks!

Hello @yas,
I've rebased the MR please review. Thanks

Hello @yas,
I've rebased the MR please review. Thanks

Hello @sandip poddar,
I've reviewed the changes in Drupal version 10.4.0, by following the below steps:

• Installed and enabled the theme version 1.0.3.
• Checked the console found "Drupal not defined" error.
• Applied the patch it applied cleanly, resolving the error.

Hence, moving the issue to RTBC.
Thanks

Hello @tanushree Gupta,
I have reviewed MR!10, and it appears that all the form items are getting targeted. Could we make this a bit more specific? I installed the theme on Drupal version 10.4.0, and following the "Getting Started" steps provided in the theme's readme.md file, I encountered the mentioned issue in the "Add Comment" section.
I applied MR!10, which integrated cleanly, and then followed the steps to compile the CSS changes. While the spacing between the form's subject and body looks good, there seems to be too much space above the comment form buttons. Additionally, the form overflows on mobile devices. I am attaching a screenshot for reference.
Therefore, moving this to NW.
Thank you!

Hello,
I have resolved the comments on the MR. I noticed that the submenu item colors and their hover states in the nav.css file were being overwritten, which affected the colors for specific themes such as Red, Blue, Dark, and others. Consequently, I removed those two lines of code to resolve the issue.
Additionally, I encountered visibility issues in the Dark and Typhoon themes. In the Dark theme, the submenu item’s color before hovering was not visible, and in the Typhoon theme, the hover background-color of the submenu item was also not visible. I have addressed these issues and attached screenshots showing the before and after states for your review.
Please take a look.
Thanks!

I'll work on this.

Hello @agentrickard,
As per the comment in #5 📌 Create Logo for Workbench Active , I reviewed the proposed logos by @manojsaha both of them meet the Project Browser requirements of 512x512 dimensions, file size under 10K, and PNG image format, no animations and reasonable image quality. The main objective of this project is to support content editors, clearly represented in the logo. I support the choice of Workbench-v1.png, as it stands out among the other listed projects, which focus on permission-related features indicated by the gear icon in the logo. I would love to hear from the maintainer.
Hence moving it to RTBC.
Thanks!

Hello,
The maintainer has requested the removal of the code instead of simply commenting it out in a few issues. Additionally, there was a conflict in one of the files, which I have now resolved with a new commit. Previously, I had moved the issue to NW due to the unresolved comment in the merge request, but it has now been addressed with the recent commits.
Please take a look.
Thanks!

Hello @shivam_tiwari,
Thanks for pointing out the design issue in the footer. I've addressed it and changed the code to include the container when the footer is displayed in a single row. Please have a look.
Thanks

Hello,
I followed the steps to reproduce the issue by installing the theme version ( 6.0.0-rc6 ) in Drupal version ( 10.4.0 ) along with the address module. Using the address field entity type created a field and added content to the field. On viewing the page I encountered the missing space between the content like name, city and pincode hence I cross checked the spacing in two themes namely Claro and Olivero. I applied the MR!113 which applied cleanly. On revisiting the node page I found the space has been included similar to the other themes. I reviewed the MR!113, the apply spaceless filter has been removed from the required templates as mentioned by @tirupati_singh. The mentioned issue has been resolved therefore moving to RTBC. Attached ss of before and after for reference.
Thanks

Hello,
I installed the theme in Drupal 10.4.0 version.
Visited the /search/node page and found the serach input box is not visible.
Applied the provided MR!3, which applied cleanly.
On revisiting the /search/node page the search input box was visible.
However, it seems variables are being used in the theme for color/background property. Also I noticed that the below border snippet is already present in form_input.css file

  border: var(--button-border);
  border-radius: var(--radius);

Just that the width, style and border color are not defined for the border property. As per my findings the %form_element placeholder in form_input.scss seems to be also not defined anywhere and most likely the above css properties were suppose to be defined in this placeholder due to which this issue might have occurred. IMO we can try to replace the current hex value used for the border color with variables. Attaching ss for before and after. Thus, moving to NW.
For a better solution we would be glad to hear from @tomsaw.
Thanks

Hello,
I've reviewed the mentioned issue by following the belows steps,

• I cloned the theme having the default branch (7.x) in Drupal version 10.4.0.
• I visited a random node page and came across the inactive tabs not being visible however were visible only when hovered.
• I applied the MR!49, which applied cleanly.
• On revisiting the node page the inactive tabs text were visible.

The mentioned issue was resolved however I found the background property used in cloud.css file is kept commented which seems to be unnecessary for the provided issue. I've included the before and after ss.
Moving to NW for the unresolved comment in the MR.
Thanks

I'll review it.

Hello,
I've reviewed the issue following the below steps:

• I installed and set the theme ( version 2.0.2 ) as default theme in Drupal version 10.4.0
• Created an article page and added nested replies. Found the comments where getting aligned on the left side thus providing no significant difference between the nested replies.
• Applied the MR!21 which applied cleanly.
• Checked the indentation of the nested replies, the provided space clearly make the nested replies distinguishable.

I reviewed the MR!21 and found the pipeline failed due to missing CRLF, hence I fixed the same.
Attaching ss for reference. The mentioned is resolved hence moving to RTBC.
Thanks

esha_kundu → made their first commit to this issue’s fork.

Hello @tanushree gupta,
I've reviewed your new changes, the previously mentioned issues regarding the removal of snippet has been resolved. Thanks for pointing out the hamburger menu position, I cleared the cache after applying the patch and it was rectified. The patch applied cleanly in 1.0.x and 9.1.0 versions of the theme. The mentioned issue is resolved hence moving to RTBC.
Thanks

Hello,
I've reviewed by following the below steps,

• I installed and set the rover theme ( 2.0.1) as default theme in Drupal version 10.3.6.
• Visited the search page /search/node, click opened the Advance search section to find the space between the form and button is minimal.
• Hence, applied the MR!19, which applied cleanly.
• Revisited the search page /search/node, click opened the Advance search section to find the space between the form and button is improved.

I've also reviewed the MR!19 and it looks good to me.
Including the ss for before and after for reference.
Thus, moving to RTBC. Thanks

Hello @tanushree gupta,
I reviewed the MR!25 and found that you've included the scss as I had mentioned earlier in the comment. However, you seemed to have removed a small snippet which has already been merged to resolve this 3391594 🐛 In Footer section need to align Footer title with footer Menu. Fixed issue. Additionally, the MR!25 is throwing error on applying the patch on current version 9.1.0.

error: patch failed: lib/style.css:683
error: lib/style.css: patch does not apply
error: patch failed: scss/style.scss:8
error: scss/style.scss: patch does not apply
error: patch failed: templates/layout/page.html.twig:96
error: templates/layout/page.html.twig: patch does not apply

Although the patch applies cleanly when the theme is cloned and applied on the 1.0.x branch. The menu arrow, position and design in mobile devices looks good to me. Moving to NW to resolve the removed snippet. Attaching ss of after patch.
I would suggest to create a MR keeping the target branch as 9.1.x, as the current version 9.1.0 also contains the menu design break in mobile devices.
Thanks

I'll review this.

Hello,
I followed the below steps to review,

• I installed the theme version 2.0.1 in Drupal version 10.3.6.
• Searched a value in the search block, which provided a list of search value in the search result page ( /search/node ).
• The list were having extra space on the left side.
• I applied the MR!4, which applied cleanly.
• The extra space was removed and it had appropriate space to identify the content as a list.

Attached the before and after ss for reference. The issue is resolve hence moving to RTBC.
Thanks

Hello,
I've converted the patch ( 3392873-3.patch ) mentioned in #3 🐛 Footer region rendering multiples time in a page. Active into MR !10 as per Drupal standards. The issue was getting resolved with the provided patch also I agree with @jeetmail72 that the extra if conditions should be removed. I found the indentation was incorrect after applying the patch also I encountered an issue, when the four footer regions had content a horizontal scrolled appeared in the page which seems to be unnecessary in respect to users perspective. Thus I have resolve all this problems. The issue persisted in 2.0.1 version, hence updating the version. I've included ss for the overflow issue.
Please have a look.
Thanks

esha_kundu → changed the visibility of the branch 8.x-1.x to hidden.

esha_kundu → made their first commit to this issue’s fork.

Hello @tanushree gupta,
I've reviewed the updates that you have made and found the media queries for responsive devices have been separated in MR!14. I applied the updated MR!14, which applied cleanly and on visiting the /contact/feedback page, the buttons are properly aligned. I visited the same page in Firefox browser and resized the screen for mobile devices and found the overflow issue has been resolved. As all the problems that I had mentioned earlier in #11 🐛 Website feedback form is not responsive Active have been addressed, hence moving to RTBC. Please find the ss for reference.
Thanks

@yas sorry for too many commits but I've resolved the conflicts and also fixed the Stylelint errors that were present.
Please have a look. Thanks

Sure @yas will look into this.

Hello @ravi kant,
I encountered this issue when I cloned the repo and checked in the development version 1.0.x-dev however when the theme is installed using composer from the project page the spacing issue is not found. After installing the theme I visited the login, register, reset password pages. I faced the mentioned issue. For Article content type when the comment section is placed at the end page by configuring in Manage Display, an extra spacing is noticed if the comment section is not rendering. I applied the MR!12 which applied cleanly. I revisited the pages (login, register, reset password, article content type pages, page where comment section is not rendering) the spacing issue was resolved. I've also reviewed the MR and it looked good to me.
Attaching the ss for reference and moving to RTBC.
Thanks :)

Thanks @tirupati_singh for addressing the issues that I had mentioned in #4 ✨ Display design similar to multiple selected values when the select field allows single value. Active earlier. I re-reviewed the MR!40 and it looks good to me. I applied the patch which applied cleanly after that I configured the admin theme to seven. In Manage Form Display enabled the checkbox in the field widget and verified the design for the single select field elements. The alignment and design for the single select field items was improved.

I've reviewed the MR!40 and found you have included the styling for gin, claro and seven theme in the newly created file select2.single-style.scss however separate scss files are present for these theme styling. IMO we could maintain the discrete structure of styling as present in the module.

Regarding this suggestion that I mentioned earlier, thanks for the clarification and I acknowledge that unnecessary css should be avoided loading on a page when the Single item style option is disabled.
Including ss for the after changes. Moving to RTBC.
Thanks

Hello @yas,
I've resolved the minor comment that you had added in the MR!74. I found the hover effect for this search button is different from the buttons present in theme hence fixed the hover effect for the search button. While I reviewed the MR!74 I came across that the variable was not used for the color property therefore replaced the hex-value for color with the variable. Attached video for the hover effect.
Please have a look.
Thanks

Hello,
I've reviewed the MR!41 and found the column-gap property is used for providing the space, which I think is a better approach than using margin property.
I reviewed the issue following the below steps,

1. I cloned the theme repo in Drupal version 10.3.6.
2. I installed the theme and visited the /contact/feedback page when I came across the missing space problem between the buttons in this page.
3. I applied the MR!41 and found the issue was rectified.

Attaching the before and after ss for reference. Hence moving to RTBC.
Thanks

I'll look into this.

I'll review this.

Hello,
I came across the same problem of missing screenshot in Appearance section. I've installed the theme version 1.0.7 in Drupal version 10.3.6.
When I visited /admin/appearance to install the theme, I saw the missing screenshot. I applied the MR!15, which resolved the issue. I've reviewed the MR and it seems to be a typo error in the naming of the image file, which was addressed.
IMO we should fix this.
Attached ss of before and after patch. Hence, moving to RTBC.
Thanks

Hello,
I found the issue still persists after installing the seven theme version 1.0.0 in Drupal version 10.3.6. As mentioned in #23 🐛 In ui-dialog box at Views button hover effect is odd Active the theme is removed from Drupal core. The MR provided in this issue was for the core hence I moved the code to the seven theme and raised the MR!13.
I also encountered another problem related to the dialog-box button in /en/admin/content page. After visiting the content page , I went to delete option for a content. The dialog-box opened with the delete button being displayed in focused form. On clicking anywhere except the delete button I noticed the visibility issue in the delete button. I have fixed this issue in MR!13. Please find the below image for reference.

I've attached the video for the before patch and the mentioned issue.
Please review.

I'll review it.

esha_kundu → made their first commit to this issue’s fork.

Hello @tirupati_singh,
I've reviewed the MR!40 and found you have included the styling for gin, claro and seven theme in the newly created file select2.single-style.scss however separate scss files are present for these theme styling. IMO we could maintain the discrete structure of styling as present in the module.
I installed the module and followed the steps mentioned in the issue. Encountered the design inconsistency therefore applied your patch. The design of single list item was improved after enabling the checkbox in the field widget present in Manage Form Display page and now it matches the multi-select list item design. I verified the design in seven, claro and gin admin themes. I noticed few issues in case of seven theme. The style for the single list item seems to be different compared to the multi-select list item and the alignment of the dropdown button is inappropriate. It would be nice if we could makes these updates thus moving it to NW.
NOTE: After installing the module we need to follow the steps mentioned in modules project page → to integrate the select2 library.
Attaching ss for reference.
Thanks

Hello @tanushree gupta,
I appled the MR!14 which applied cleanly. The form design is improved, resolving the earlier design issues mentioned in #9 🐛 Website feedback form is not responsive Active , however I find the submit button is not properly aligned with the form fields. In Firefox browser a horizontal scroll is coming for mobile devices. IMO if the left sidebar region includes content it is better to display the sidebar in full width in mobile devices rather than maintaining the Desktop layout as I observed many themes have designed the sidebar in such a manner. I found the horizontal scroll is occuring due to the display: table; property included in the body element. I added the below code in the responsive.css file and the overflow issue is resolved.

@media screen and (max-width: 992px) {
  body.path-contact {
    display: block;
  }
  .path-contact #wrapper {
    display: flex;
    flex-wrap: wrap;
  }
  .path-contact #wrapper>div {
    width: 100%;
  }
  .path-contact #wrapper #content {
    margin-left: 0;
  }
  .path-contact #wrapper #sidebar-left,
  .path-contact #wrapper #sidebar-right {
    width: 100%;
  }
  .path-contact #wrapper #sidebar-left {
    margin-left: 0;
  }
}

I reviewed the MR!14 and noticed that the media query is included in the style.css file while there is a separate file name responsive.css present in the theme. It would be better to maintain the separation of responsive code. Included ss for reference hence moving it to NW.
Thanks

Hello,
I've installed the gin module, followed by enabling the admin toolbar search module. Configured admin toolbar search module by activating the display the search input as menu item in /admin/config/user-interface/admin-toolbar-search-settings and setting the gin theme navigation to Legacy, Classic Drupal Toolbar. I found the overlapping issue on clicking the search bar in Chrome and the mentioned issue in comment #24 🐛 Search icon and text overlapping issue. Active in Firefox. I applied the MR!517, which applied cleanly. Checked the overlapping issue in Chrome and Firefox browser, the alignment is rectified for Desktop and other devices in both the browsers. For the comment in #35 🐛 Search icon and text overlapping issue. Active , I acknowledge that the issue is only for the gin classic-toolbar but as per my findings, the classic_toolbar.css file is attached whenever the navigation is configured to Legacy, Classic Drupal Toolbar in /admin/appearance/settings/gin page using the library gin/gin_classic_toolbar. Additionally, this library contains this file and toolbar.css for styling purpose. The remaining toolbar works correctly without getting affected by this file. Hence wrapping it within body:not(.gin--classic-toolbar) is not required in my opinion. Including ss for reference. Not quite sure about the ss provided by @selfirian in #37 🐛 Search icon and text overlapping issue. Active , cause I didn't face such a issue.
Therefore moving to RTBC as the mentioned issue is resolved. Thanks

Hello, I'll review this one.

Hello,
I've installed the project browser module version 2.0.0-alpha3 in Drupal version 10.3.6 after which I enabled the Drupal Core in the project browser config page (admin/config/development/project_browser). Visted the /admin/modules/browse page after saving the configurations. Tried filtering categories under Drupal core tab however the results obtained are inappropriate as per the filter, also the filter text is not visible after selection. The number in the tab doesn't change after filtering the categories, it shows changed number when different tabs are clicked ( sometimes single tab change works otherwise two tab change works ) but on visiting the Drupal core tab it displays the unchanged number. Attaching ss and video for better understanding.

Hello @sourojeetpaul,
The issue that I had mentioned previously in #19 🐛 Cookie settings modal buttons are not visible on smaller screens Needs review has been resolved with your current patch 3457021-20.patch → hence moving to RTBC. Attaching ss for reference.
Thanks

Hello @sourojeetpaul,
I've re-reviewed by applying the patch 3457021-18.patch → . The design fixes that I had mentioned in #17 🐛 Cookie settings modal buttons are not visible on smaller screens Needs review was addressed, which resolved the incorrect alignment and the smaller width of save button in landscape view of mobile devices. However, it seems like there is still one design issue that is not addressed. In devices having width greater than 576px the buttons are having equal space between them, but the save button is not equally spaced below 576px. I've provided ss for reference.
Please have a look.

Hello,
I've reviewed the issue by following the below steps:

1. Installed the module version 1.2.13 in Drupal version 10.3.4, enabled the module COOKiES.
2. Set Bootstrap 5 theme as Default theme.
3. In Block Layout added the Cookies UI block in the footer section.
4. Switched to responsive screen for mobile devices. Found the missing buttons (Deny all, Accept all) on opening the Cookie Settings.
5. Applied the patch in cookiesjsr library, provided in comment #14 🐛 Cookie settings modal buttons are not visible on smaller screens Needs review . The patch applied cleanly.
6. Checked the three buttons ( Deny all, Accept all, Save ) appearing both in portrait and landscape view for mobile/tab view, it looked fine in desktop devices also.
7. As per the comment #12 🐛 Cookie settings modal buttons are not visible on smaller screens Needs review , checked the buttons design for 3-4 languages (German, French, Spanish, Japanese) and it looked fine.

I would like to point out two design fixes that needs to be rectified,

• For mobile devices, I found the alignment of the save button is'nt correct.
• In landscape view the save button seems to be a bit smaller in size compared to the Deny all and Accept all buttons especially when the save text is small like in japanese its 保存.

Hence, moving to NW.

Hello @tanushree gupta,
I've installed the theme version 1.0.1 in Drupal version 10.3.4 and enabled the theme. After enabling found an unexpected error on the page for which applied the patch provided in issue: Issue #3441416 🐛 The website encountered an unexpected error RTBC . After that visited the contact page (/contact/feedback) and resizing the screen similar to mobile devices, found the form is'nt design for responsive design. I applied MR!2 but the issue wasn't resolved. Then I applied MR!14 which applied cleanly, however the issue still persists. I found the button and form design has been changed which doesn't matches with the theme design. Even the border around the fields in the form makes it difficult to identify the input field, it would be better if the border is'nt added to the div wrapping the form input/textarea elements. Hence, changing to NW. Attached ss for reference.

Hello @tanushree gupta,
The menu arrow, position and design in mobile devices looks good to me after applying the MR!20 and it applies cleanly, however the MR contains css file changes and is missing the scss file changes. Since the theme is using scss, we need to convert the css changes into scss. Therefore, moving to NW.
Thanks

Hello @tirupati_singh,
I've fixed the tags design is overflowing on mobile devices issue that you've mentioned in #13 ✨ The design of tag links needs improvement. Needs work . I found that the tags just changed the cursor pointer on hover whereas the read more button showed border color change while hovering. Therefore, I've implemented the hover effect for the tags. Please review.

Hello,
I've installed the module version 3.0.0 in Drupal 10.3.4 and added icons in the main navigation menu links followed by configuring the appearance to without text. Found the aria-label is being set in the <li> hence when the screen reader reads the menu link, it fails to identify the aria-label. After applying the MR!2, the aria-label is set in the <a> which is identified by the screen reader correctly. The issue is raised for 8.x-2.0, but it still persists in 3.0.0 and the provided MR applies in the latest version cleanly therefore need to port the changes in 3.x-dev. The MR resolves the issue therefore moving to RTBC, including before and after ss.
Thanks

I've fixed the design issue of the form in search block and created the MR!13. The search-block.scss file was using 4 spaces indentation, I've rectified it with 2 spaces indentation as mentioned in css coding standards documentation. Attaching the design fix ss, please have a look.
Thanks

I'll work on this.

I've resolved the conflicts in the MR!11. The previous code targeted #footer_nav id for styling due to which the styling wasn't being applied as the first part (i.e, footer is the menu machine name) is dynamic cause one can create custom menu and not necessarily have machine named footer. I've addressed this by changing the id to class selector and updated the MR!11.
Included ss for before and after. Please review.
Thanks

Hello,
I've reviewed the changes in MR!9, the code looks good. I've applied the new changes and the MR applied cleanly. Checked the contact form preview visibility and spacing, which was resolved. Checked the issue while previewing comments in nodes that I had mentioned previously in #12 🐛 In contact form, preview message has some styling issues. Needs review , the style that was being applied previously due to targeting the form element has been resolved.
Attaching the ss for reference. Moving to RTBC.
Thanks

Hello,
I've reviewed the changes by following the below steps:

• I installed the Project Browser module version 2.0.0-alpha3 in Drupal version 10.3.2, enabled the modules Project Browser, Project Browser Devel, Project Browser Source Example.
• Went to /admin/modules/browse and found the four tabs, on hovering the cursor had default value.
• Applied the MR!570 which applied cleanly.
• Went to /admin/modules/browse. On hovering the tabs cursor had pointer.

Attached the ss and video for reference. RTBC +.
Thanks

I've cloned the project (branch 1.0.x) in Drupal version 10.3.2 and applied the MR!11, the patch couldn't apply got the below error

Checking patch css/style.css...
error: while searching for:
.custom-pagination .page-item .page-link[title="Go to last page"] {
  border-radius: 5px;
}
.breadcrumb a, 
.breadcrumb-saprator {
  color: #f34573;
}
.breadcrumb-saprator {
  padding: 0 8px;
}

error: patch failed: css/style.css:1049
error: css/style.css: patch does not apply

I'll work on this.

Hello,
I've reviewed the changes by following the below steps:

• Installed the theme version 8.x-1.0 in Drupal version 10.3.2, found the overflowing issue on mobile devices. (The theme version 8.x-1.0 is a tag that doesn't consists of the new changes).
• As the changes have been merged in development branches 3.0.x and 8.x-1.x, therefore I removed the theme (installed using composer version 8.x-1.0) and cloned the project from git.
• In branch 8.x-1.x, installed and enabled the theme. The overflow issue was resolved.
• Then, I changed to branch 3.0.x and created a sub-theme followed by enabling the sub-theme. The issue was resolved in this as well.

Including the before and after ss for reference.
Hence, moving to RTBC.
Thanks

Hi @kristen pol,
Like you've mentioned in #5 📌 Project Browser: Create a logo for Office Hours Needs review that the line style needs to be reduced, I've made changes accordingly and also included my proposed design (both transparent).
Please let me know your thoughts.

Hello,
I've cloned the project (branch: 1.0.x), found the module search api ai chatbot is having jquery_once as one of the dependencies however it is not being used, the jquery and once library of the core is used instead. Hence, the module can't be enable due to the missing jquery_once module. To resolve this issue I've applied the MR!28 which applied cleanly and I could install the search api ai chatbot module without jquery_once module. I've included the ss for before and after, please have a look.
Thanks

@smustgrave, as per my findings if we could implement the direction in list element(ul/ol) then while viewing the node, the direction would have been implemented similar to ckeditor 4, however targeting the parent resulted in a blocker and it seems like you didn't like the idea also. I came up with the idea of handling the direction using css, please have a look at the below code

.ck-editor__editable ul:has([dir='rtl']),
.ck-editor__editable ol:has([dir='rtl']) {
  direction: rtl;
}

I've made use of the has selector for checking the direction 'rtl', depending on this condition the direction of the parent list element (ul/ol) is changed. To have a similar affect when viewing the node after changing the direction, I've include the below code in a separate css file after that I made an library for the same and attach it using preprocessor node cause including the css in the existing bidi_direction.css file, the library doesn't get attach for anonymous node view, logically the node page can be opened in anonymous view also.

.node__content ul:has([dir='rtl']),
.node__content ol:has([dir='rtl']) {
  direction: rtl;
}

I've not included the check for dir='ltr' as when it is 'ltr' the p tag isn't set to dir='ltr' it only consists of the class="ck-list-bogus-paragraph" which will result in unnecessary extra css code.
Please have a look at the below ss,

1. The node view of lists after changing the direction to 'rtl' in ckeditor 4.

2. The node view of lists after changing the direction to 'rtl' in ckeditor 5.

3. After including the css
1. ckeditor

2. node view

I've added the patch file, please let me know your opinion.
Thanks

Hello @Tanushree Gupta,
I've installed 2.0.1 version of Simple Classic Corporate Theme on Drupal version 10.3.2, the visibility and padding issue while previewing the contact form still persist. Initially I applied the MR!1 provided in #4 🐛 In contact form, preview message has some styling issues. Needs review and the patch applied cleaning resolving just the padding issue while the visibility issue still persist. I removed the changes applied in MR!1 followed by the application of MR!9 🐛 In contact form, preview message has some styling issues. Needs review , that applied cleanly. The design of the form was improved and the stated issue of visibility, padding was also resolved. I've reviewed the MR!9, changes are made targeting the form element due to which the comment form design is also altered and as per the issue we don't need to change the design of all forms. In case, we need to improve the contact form design we can just include css for that only without affecting other forms. Have attach ss regarding the changes in comment form in node page while previewing, before and after of the contact preview message.
Thanks

Hello,
I have followed the below steps to review,

• Installed the module, used the frontpage view where I enabled Ajax.
• Went to page 2 and checked the prev button href which had /views/ajax.
• Applied the MR!3, which applied cleanly.
• Rechecked by going to page 3, checked the prev button href which had /node (correct href of frontpage).

Have included the before and after ss for reference.
Hence, moving to RTBC.
Thanks :)

Hello @smustgrave,
I'm sorry for not making any updates for such a long time. I faced a blocker in targeting the parent list element (ul/ol) while resolving this issue. In the current scenario the p tag containing the list text which is present within the li element where the direction 'rtl' is getting added whenever the BiDi button is clicked, whereas the list element (ul/ol) still has the direction 'ltr'. I have tried implementing the react js functions for targeting the parent element. Also I have gone through the ckeditor plugins and functionalities. When I came across the ckeditor list reversed plugins that targets the parent element (ul/ol) and adds reversed data attribute which is similar to what I had to achieve in this case but unfortunately the parent target is being identified as paragraph instead of listitem, as a result the 'rtl' direction attribute is not being set in the parent. There is also this open issue in github regarding the incorrect padding for list: https://github.com/abedio/ckeditor5-direction/issues/1.
Sorry for the inconvenience.

I've came up with this logo and I've kept the background transparent.
Please have a look.
Thanks

I'll work on this.