- Issue created by @jaydeep_patel
- 🇮🇳India jaydeep_patel Ahmedabad
Hello, Comment section design issue has been fixed. I have attached screenshot for the reference. kindly review it.
Thank you!!!
- Assigned to Esha_Kundu
- Status changed to Needs review
3 months ago 4:55am 16 April 2025 Hello @jaydeep_patel,
I've reviewed the comment section design by following the steps below:- Cloned the theme repository.
- Checked out the 1.0.2 branch cause the chahmirian.css file was missing in the default main branch ( it seems to be removed in this commit: Bootstrap SCSS Setup Commit
- Applied the MR!26, which applied cleanly.
- The comment section design was improved.
IMO, the background around the comment section doesn't look very appealing. Additionally, the border around every comment represents that they are different comments and not nested replies of a single comment. I think it would be better if the background and padding around the comment section were removed, along with adding a border around the complete comment rather than the individual replies. The conflict in the MR also needs to be resolved.
Attaching SS for reference. Moving to NW.
Thanks!- Merge request !29Issue #3494699 by jaydeep_patel, esha_kundu: Comment section not looks good on article page → (Open) created by Esha_Kundu
Hello,
The previous MR!26 was targeting the main branch, which had conflicts, and as per my previous comment, the chahmirian.css file has been removed from the main branch. Hence, I've created a new MR!29, with the design fixes and kept the target branch 1.0.2.
Please review.
Thanks- 🇮🇳India divya.sejekan
Changes(fix) are not visible after applying patch , tried with applying both MR!26 and MR!29
Steps Followed :
Step1: Install theme and set as default theme.
Step2: Create article page
Step3: View article page and add comment at the bottom of article page. Hello @divya.sejekan,
The css changes are made in the chahmirian.css file for both MR!26 & MR!29, however this file is removed in this commit: Bootstrap SCSS Setup Commit from the development branch ( main ). The current theme version 1.1.1 is a tag created from branch main consisting of earlier changes. As per my comment in #7, if we resolve the conflicts for MR!26 the design changes would be lost as it is targeted with the development branch ( main ). Thus, please review this changes in Drupal version 9 for now.
Thanks