- Issue created by @shweta__sharma
- First commit to issue fork.
- @shiv_yadav opened merge request.
- Status changed to Needs review
over 1 year ago 5:25am 10 October 2023 - 🇮🇳India shiv_yadav
Hello Shewta, I have fixed this issue. Created MR & attached screenshot.
Please review & retested it. - Status changed to Needs work
about 1 year ago 12:26pm 22 February 2024 - 🇮🇳India Kanchan Bhogade
Hi @shiv_yadav
checked on Drupal 10.2, the issue is reproduced
Applied MR !1 successfully but no visual changes after the patch.moving to "needs work"
- Assigned to Tanushree Gupta
- Merge request !9Issue 3392746: Styled the preview message and form. → (Merged) created by Tanushree Gupta
- Issue was unassigned.
- Status changed to Needs review
9 months ago 5:55am 19 July 2024 Updated the design of preview message and form.
Here is the MR: https://git.drupalcode.org/project/classic_corporate_theme/-/merge_reque...- Status changed to Needs work
9 months ago 7:37am 22 July 2024 - 🇮🇳India riddhi.addweb
I have applied the MR9 patch [It applied cleanly], but with and without the patch the issue looks the same, no visual changes are displayed. Attaching SS for the same and moving to Needs to Work.
- Assigned to Tanushree Gupta
- Issue was unassigned.
- Status changed to Needs review
8 months ago 5:58am 1 August 2024 The merge request work perfectly fine, as I have checked.
Here is a screenshot I am attaching for the reference.- Status changed to Needs work
7 months ago 7:33am 2 September 2024 Hello @Tanushree Gupta,
I've installed 2.0.1 version of Simple Classic Corporate Theme on Drupal version 10.3.2, the visibility and padding issue while previewing the contact form still persist. Initially I applied the MR!1 provided in #4 🐛 In contact form, preview message has some styling issues. Needs review and the patch applied cleaning resolving just the padding issue while the visibility issue still persist. I removed the changes applied in MR!1 followed by the application of MR!9 🐛 In contact form, preview message has some styling issues. Needs review , that applied cleanly. The design of the form was improved and the stated issue of visibility, padding was also resolved. I've reviewed the MR!9, changes are made targeting the form element due to which the comment form design is also altered and as per the issue we don't need to change the design of all forms. In case, we need to improve the contact form design we can just include css for that only without affecting other forms. Have attach ss regarding the changes in comment form in node page while previewing, before and after of the contact preview message.
Thanks- Status changed to Needs review
7 months ago 7:32am 9 September 2024 @esha_kundu Thank you for your feedback.
I have update the code according to your suggestion.
Here are the screenshots I am attaching for the reference.
Indicating that the style will only apply to contact form not every form in the site.
Commit id: https://git.drupalcode.org/project/classic_corporate_theme/-/merge_reque...- Status changed to RTBC
7 months ago 6:34am 10 September 2024 Hello,
I've reviewed the changes in MR!9, the code looks good. I've applied the new changes and the MR applied cleanly. Checked the contact form preview visibility and spacing, which was resolved. Checked the issue while previewing comments in nodes that I had mentioned previously in #12 🐛 In contact form, preview message has some styling issues. Needs review , the style that was being applied previously due to targeting the form element has been resolved.
Attaching the ss for reference. Moving to RTBC.
Thanks- Status changed to Fixed
7 months ago 11:39am 10 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.