Added both the approaches in the IS with the MR link.
Thanks
Updated the screenshots in the IS
Thanks
Tested Merge request! 386 on the latest version of Drupal. The space is added at the bottom of the field now.
RTBC+!
I have tested on Drupal 10 the issue is fixed now. We can move to RTBC now.
Thanks
Changes are updated as per #7
Thanks
Found one more issue which is - admin menus also hides with the sticky header.
shweta__sharma → created an issue.
shweta__sharma → created an issue.
shweta__sharma → created an issue.
shweta__sharma → created an issue.
The workspaces icon is not fully visible see the screenshot.
Adding tag for IS update
shweta__sharma → created an issue.
I am not able to see any of the logos in the footer maybe image path issue. I checking on version 2.1.0
MR has failures moving to needs work
shweta__sharma → created an issue.
shweta__sharma → created an issue.
shweta__sharma → created an issue.
Tested MR !389 the issue gets resolved but another issue has been created by this. Changing the status to Needs work.
The changes seem fine as mentioned in the proposed resolution. The workspace switcher is now redirecting to the current page.
Attached after screen recording.
Thanks
Try generating more nodes and check maybe it could be the reason why you are not replicating the wrapping issue.
I am getting the issue only on the media image field when saving the node without uploading any media. It did not show the red border over the field. Adding a STR tag for better clarity.
Moving to needs works as a patch has a CCF error.
MR looks fine no failures moving to NR
Updated issue summary
As per #11 and #12 testing the issue is not resolved with the patch so moving to need work.
Tested the MR 6591 and it worked fine the pager did not wrap into the next line even if there is a sidebar.
Attached Before/After screenshots
Thanks
Updating the status needs review as nothing is left to do in this.
Changes seems fine in the MR
I can confirm this issue when placing any block in the side-bar region the pager wrapped up in the next line.
shweta__sharma → created an issue.
shweta__sharma → created an issue.
Pushed the code for the alignment issue in table.
Thanks
I have updated the IS and added STR but making the first row and first column both a header is not clear for me. So I am not removing the STR tag.
As per #3 closing the issue.
Adding a tag as I am not able to reproduce the issue.
Pushed the code for pointer 1
I was checking the issue and found some more issues related to the dropdown field in Views -
1. Padding issue in view content -
2. toggle icon height issue -
Added standard IS template and updated the IS.
@bendqh1 Can you share some screenshots? I am not able to reproduce the issue with the STR which you mentioned above.
Thanks
shweta__sharma → created an issue.
pipeline failed. Moving to needs works.
Added standard IS template which was missing.
On hover, if the background is dark then the text colour should be light. We have to apply the same design as it has been done in the Claro theme. Moving to NW
shweta__sharma → created an issue.
shweta__sharma → created an issue.
Added standard IS
Hi @wrd-oaitsd,
I tried to replicate the issue but I am unable to replicate can you share more information or add steps in STR?
Tested with CKEditor 5 and version 8.x-3.0-rc9
shweta__sharma → created an issue.
shweta__sharma → created an issue.
Hi @SandeepSingh199,
The patch did not apply.
Added standard IS template.
Updated the Text alternative field label to Alternative text kindly review it.
After Fix -
Thanks
shweta__sharma → made their first commit to this issue’s fork.
The remove button is completely visible I tested on the version - 8.x-1.7
shweta__sharma → created an issue.
shweta__sharma → created an issue.
Mistakenly added an issue in this theme closing the issue sorry for making noise here
shweta__sharma → created an issue.
Adding tag as #15 unable to reproduce the issue.
Kindly review it.
Updated twitter icon with the new one. Kindly review it.
Thanks
As per #4 Moving to RTBC
Added box shadow to the header. Kindly review it.
Thanks
shweta__sharma → made their first commit to this issue’s fork.
Pipeline fails Moving to need work
shweta__sharma → created an issue.
Sure @quietone
Updated IS template.
Thanks
Added standard template.
Tested MR 9 and it's fixed the issue now the space is added in both conditions. Moving to RTBC.
After Patch
shweta__sharma → created an issue.
I reviewed the issue and observed that the remove button has no close icon in other fields (for ex-media, and image fields ) except the media modal. There seems to be a lack of uniformity in design here, so we need to maintain the design consistency here either we should remove the close icon or add a close icon on the remove button globally on all the fields where the remove button exists.
#5 unable to reproduce the issue so adding the tag