- Merge request !5573drupal-3404663: Fixed the alignment of (show preview content) checkbox. → (Closed) created by shweta__sharma
- Status changed to Needs review
about 1 year ago 3:16pm 28 November 2023 - Status changed to RTBC
about 1 year ago 5:20am 29 November 2023 - 🇳🇿New Zealand quietone
I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do. It took me a while to figure out that the image in the 'user interface changes' section of the issue summary is the before image not the after image.
For issues that are changing the UI it is helpful to have the before and after images in the issue summary, or links to the latest before and after screenshots.
Leaving at RTBC.
- Status changed to Needs work
10 months ago 4:08am 22 February 2024 - 🇮🇳India gauravvvv Delhi, India
I have tested merge request !5573, and here are my observations: In the case of the sidebar, the checkbox item is wrapped onto the next line, and the spacing is increased even if we don't want that, as the alignment is already fine on the next line. I have attached a screenshot for reference.
- 🇮🇳India gauravvvv Delhi, India
Gauravvvv → changed the visibility of the branch 3404663-olivero-show-content to hidden.
- Status changed to Needs review
10 months ago 4:11am 22 February 2024 - 🇮🇳India gauravvvv Delhi, India
I have provided a separate patch with a different approach. I'm not updating the current merge request, so the maintainer can choose any approach they prefer.
- last update
10 months ago 29,722 pass - Status changed to Needs work
10 months ago 4:49pm 22 February 2024 - 🇺🇸United States smustgrave
If a different solution is going to be used it should be reflected in the issue summary. #11 doesn't mention what the new solution is.
A separate MR should be opened and in the issue summary have something like
Option A
Option B
So discussion can be had about best approach.
- Status changed to Needs review
10 months ago 7:34pm 22 February 2024 - 🇮🇳India TanujJain-TJ
Created new branch and MR for second solution also updated Issue summary. Please review.
- Status changed to Needs work
9 months ago 2:30pm 19 March 2024 - 🇮🇳India aayushDrupal
aayushmankotia → changed the visibility of the branch 3404663-content-preview-checkbox-alignment to hidden.
- 🇮🇳India aayushDrupal
aayushmankotia → changed the visibility of the branch 3404663-content-preview-checkbox-alignment to hidden.
- First commit to issue fork.
- Status changed to Needs review
8 months ago 10:44am 1 April 2024 - 🇮🇳India aayushDrupal
aayushmankotia → changed the visibility of the branch 3404663-content-preview-checkbox-alignment to active.
- 🇮🇳India aayushDrupal
aayushmankotia → changed the visibility of the branch 3404663-olivero-show-content to active.
- 🇮🇳India Kanchan Bhogade
Hi
I've tested MR !6747 on Drupal 11.x
The patch is applied successfully...my observations:
The checkbox is center-aligned with the layout builder buttons.
In the case of the sidebar- The checkbox wrapped onto the next line, Spacing is not changed.Adding Screenshots
- Status changed to RTBC
8 months ago 7:37am 3 April 2024 - 🇮🇳India sdhruvi5142
Hi, verified and tested MR !6447 and applied Patch successfully on 11.x version. And all the changes are working as expected.
Following steps I followed:
For scenario 1 "Checkbox alignment"
1. Open local and Install Oliverio theme
2. Go to /admin/structure/types/manage/article/display/default/layout
3. Checked the show content preview checkbox and its alignment and observed the changed hereTesting Result for Scenario 1:
The Alignment of the "Show content preview" looks proper as expected.
Attaching the SS for reference.For Scenario 2 " When sidebar is added spacing issue"
1. Go to /admin/structure/types/manage/article/display/default/layout
2. Added the Sidebar in the Layout
3. Now observed the changes hereTesting result for Scenario 2:
The spacing looks as expected when we add the side bar and "Show content preview" Checkbox displayed in next line
Attaching the SS for reference.Hence moving to RTBC!
Thanks - Status changed to Fixed
8 months ago 9:15am 3 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.