🇮🇳India @aayushDrupal

aayushmankotia → made their first commit to this issue’s fork.

Now the mini-pager looks great, changing status to RTBC.

hi,
Please review this patch for the form alignment issue as mentioned in #2. Screenshot attached for your reference.

After:

thanks

aayushmankotia → made their first commit to this issue’s fork.

hi,
I have tested this issue by applying the MR !7. I believe there should be no gap between the next/previous buttons and the horizontal bar, as shown in the After image. Please review the screenshots.

Moving status to Needs Work .

Before:

After :

Thanks.

Hi,
@praveen_inWebWorks You have added new changes in WideSLiderForm.php and its working fine to added more than 5 silde.
Comment #7 merge request is working now I have move to this on RTBC.
Thanks!

Hi,
I tested for the "Missing Classy (D10)" issue by running the composer require 'drupal/classy:^1.0' command. Then I executed #10 commands. Now it's working fine and shows the "Install and set as default" button.

Leaving status as "Needs review" for testing code changes.

After:-

Thanks.

Hi Tanushree Gupta,
I have reviewed the layout for the "food" theme, in my observation header is replaced with navigation.
Screenshot attached below for reference.

thanks.

aayushmankotia → changed the visibility of the branch 3404663-olivero-show-content to active.

aayushmankotia → changed the visibility of the branch 3404663-content-preview-checkbox-alignment to active.

aayushmankotia → changed the visibility of the branch 3404663-content-preview-checkbox-alignment to hidden.

aayushmankotia → changed the visibility of the branch 3404663-content-preview-checkbox-alignment to hidden.

Hi,
I have created a patch as per comment #16. Please review.

Hi,
I have tested this issue locally and found no errors after applying the MR !1. Screenshot attached for reference.

Moving to RTBC.
Thanks.

Hi,
Merge request !3 has resolved all the phpcs errors and everything seems fine to me . A screenshot is attached for reference.

Moving to RTBC.
Thanks

Screenshot:

Thanks.

Hi,
Merge request !17 has been successfully applied without any remaining errors. A screenshot has been attached.

Moving to RTBC.
Thanks.

Hi,

I have reviewed Merge request !4 and it has fixed all the phpcs errors. I have attached a screenshot for reference.

Moving status to RTBC.
Thank you.

Hi,

Your patch #2 has been successfully applied and has resolved all the PHPCS issues. Please refer to the attached screenshot for reference.

Moving to RTBC.
Thank you.

Hi,
There are still PHPCS errors remaining, so I created a patch to fix all the remaining errors.
Thanks

Hi,
Merge request !1 has successfully fixed all the PHPCS errors. A screenshot is attached for your reference.

Moving to RTBC.
Thanks.

Hi sakthi_dev,

I have applied patch #3 and addressed all the PHPCS issues. I have included a screenshot for your convenience.

Moving to RTBC.
Thank you.

Hi Ashutosh Ahirwal,
Patch #4 has been successfully applied, resolving all PHPCS errors. Please refer to the attached screenshot for your reference.

Moving to RTBC.
Thank you.

Hi Akshat26,
Patch #4 failed to apply, leading to unresolved PHPCS errors. For further details, please check the attached screenshot.

Changing status to "Needs work".
Thank you.

Hi Akshat26,
Patch #5 has been successfully applied, but there are still remaining errors. Please check the attached screenshot.

Thanks.

Hi chetan 11,
Merge request !6 has been successfully applied, but there are still remaining phpcs errors. A screenshot is attached for your reference. Please check.

Moving to Needs work.
Thnaks.

Hi,
The patch 0001-Fix-the-errors-found-by-phpcs.patch has been successfully applied, but it does not completely resolve all the errors. Please check the attached screenshot.

Moving to Needs work.
Thanks.

Hi Satish_kumar,
Your patch has been successfully applied with no remaining errors. Please check the attached screenshot.

Moving to RTBC.
Thanks

I have reviewed this module for phpcs errors and there are no remaining errors. Please check the attached screenshot.

Moving to RTBC.
Thanks

Hi Harsh,
Your patch #11 has been successfully applied, but there are still some remaining errors. Please check the attached screenshot.

I have fixed all the remaining errors in my patch #13. Please review.

Hi Mohd Sahzad,
Your patch #6 has been successfully applied, but it does not fully resolve the errors flagged by phpcs. Please review the attached screenshot for verification.

Moving to needs work.
Please review.

Hi Satish_kumar,
Your patch #3 has been successfully applied without any remaining errors by Phpcs. I have attached a screenshot for your reference. Please check.

Moving to RTBC.
Thanks

Hi sakthi_dev,
Your patch #6 has been successfully applied with no remaining errors of phpcs. Additionally, I have found no issues in the stripe_pay.info.yml file, as mentioned in comment #7. Please refer to the attached screenshot for verification.

Moving to RTBC.
Thank you.

Hi sakthi_dev,
Your patch #6 has been successfully applied with no remaining errors of phpcs. Additionally, I have found no issues in the stripe_pay.info.yml file, as mentioned in comment #7. Please refer to the attached screenshot for verification.

Moving to RTBC.
Thank you.

Hi,
The #2 patch was successfully applied with no remaining issues listed for phpcs. Please refer to the attached screenshot for your reference and verification.

Moving to RTBC .
Thanks.

Hi Ashutosh Ahirwal,
In this patch, I have solved all the errors mentioned in comment #5. Screenshot attached for your reference.

Please review.

Hi @sakthi_dev,

I have applied your patch #3 by these following steps:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

../../../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ../stripe_pay/

3. Applied your patch #3 and, again ran phpcs command

I found some remaining errors, please check. Screenshot attached for your reference.

Thank you

Hi Ashutosh Ahirwal,
I have applied your Patch #3 and did not encounter any PHPCS errors. I have attached a screenshot for your reference.

Moving to RTBC for now.

Thank you

Hi Satish_kumar,

I have applied your patch #6 and found no phpcs errors. Screenshot attached for your reference .

Moving to RTBC for now.

Thanks

Hi,
I have fixed all the remaining phpcs errors mentioned in comment #12 in this patch.
Please review.

Hi,
I have applied the #2 patch, which has fixed all the phpcs errors. I have attached a screenshot for reference.

Moving to RTBC for now.

Hi,
I have tested the README.md file locally and everything seems to be functioning correctly.
Moving to RTBC for now.

Hi apaderno,
I have fixed errors in this patch as you mentioned.
Please review.

Fixed remaining issue.

hi nitin_lama,
Patch #4 was not applied successfully and is displaying an error.

 git apply -v coding_standard_fix_4.patch
Checking patch color_picker.module...
error: color_picker.module: No such file or directory

Please check.

I have made some changes as mentioned above.
Please review my patch.

Hi @sakthi_dev
Your patch #4 is fixing some of the issues of #3 but * @param \Drupal\shopify_app\Authentication\ImpersonateShopifyRequest $impersonateShopifyRequest this line is still longer than 80 characters .
Please check

Hi @alok_singh,
Can you please provide the steps to reproduce this issue? Also, how much space is required in the article content? Additionally, could you please confirm if the title should be aligned right or left?

Thanks

Hello, @Shreya_th thanks for the patch, I have applied your patch and it ran successfully.

These are the steps I followed:

1. Took clone from git version 8.x-1.x-dev in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/ajax_add_to_cart/

3. Applied your patch and, again ran phpcs command and found no errors.

Screenshot attached for your reference.

Moving to RTBC for now.

Moving to RTBC for now.

Hi @Shreya_th,
Thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 7.x-2.x-dev in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/submenutree/

3. Applied your patch, and ran the phpcs command again. Now it is showing no errors. Screenshot attached for your reference.

Hi,
I have fixed all the errors, please review my patch .

Hi @Satish_kumar

I have created a patch to address all the PHP coding standard issues. Please review.

aayushmankotia → made their first commit to this issue’s fork.

hi,
I have fixed remaining errors after #2, please review. Moving status to "Needs review".

Hi @Satish_kumar,
Fixed remaining phpcs errors. Please Review.

I have fixed all the errors according to the phpcs. Please review

Hi,
I have fixed some files (Attaching the patch) and still lots of file issues remains (Needs Work).

Hi,

I conducted a test by implementing patch #4 and executing the following command ../../../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ../autogrow_textarea/

After thorough examination, I did not found any errors. Therefore, I am changing the status to RTBC. Screenshot is attached for your reference.

Hi @imustakim,

I have reviewed this issue in drupal version 10.1.x by following steps :

1) git clone --branch '1.0.x' https://git.drupalcode.org/project/sector_layout.git
2) cd sector_layout
3) ran phpcs command ../../../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ../sector_layout/
4) Add and fetch MR !1

• git remote add sector_layout-3375208 git@git.drupal.org:issue/sector_layout-3375208.git
• git fetch sector_layout-3375208

5) git checkout -b '3375208-fix-the-issue' --track sector_layout-3375208/'3375208-fix-the-issue'
6) I ran the phpcs command once more and did not find any errors. I have attached a screenshot for your reference. Also moving status to RTBC.

Hi @roberttabigue,
Issue fixed please review.

Hi @akshay.singh,

I have examined your MR !2. I have attached before and after screenshots for your reference.

BEFORE:

AFTER:

Solution patch for Line exceeds 80 characters; contains 116 characters" (line 84)

Hi @Rohit Rana,

The steps I followed for testing are as follows.

1) git clone --branch '8.x-3.x' https://git.drupalcode.org/project/fast_404.git
2) cd fast_404
3) git remote add fast_404-3380617 git@git.drupal.org:issue/fast_404-3380617.git (MR !8)
4) git fetch fast_404-3380617
5) git checkout -b '3380617-drupal-coding-standard' --track fast_404-3380617/'3380617-drupal-coding-standard'
6) Ran phpcs command.

I came across an error message that says "Line exceeds 80 characters; contains 116 characters" (line 84). So changing status to need work for now . I have attached a screenshot for your reference.

I have created a patch for the remaining errors.
Please review.

Hi @Shreya_th,
I have tested your patch and found no errors. I've attached a screenshot for your reference.

These are the steps I followed:

1. Took clone from git version 3.0.0 in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard="Drupal,DrupalPractice" --extensions="php,module,inc,install,test,profile,theme,md,yml" modules/contrib/live_weather/

3. Applied patch and again ran phpcs command.

I found no error. Moving it to RTBC.

I've conducted a local test and everything is functioning as expected. It's only presenting JavaScript errors, which we don't require to rectify.
It appears ready to be transitioned to RTBC

Can you please provide figma link for Drupal designs ?

Can you please provide figma link for Drupal designs ?