- Issue created by @urvashi_vora
Hi @ urvashi_vora, I have applied your patch and run successfully .
These are the steps I followed:
1. Took clone from git version 1.0.x in drupal 10.1.x
2. Ran this command:
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/shopify_app/3. Applied patch and again ran phpcs command.
found errors.
4. Create a patch and fix the errors.
Needs review.
- Status changed to RTBC
over 1 year ago 11:17am 15 September 2023 - 🇮🇳India aayushDrupal
Hi,
I have applied the #2 patch, which has fixed all the phpcs errors. I have attached a screenshot for reference.
Moving to RTBC for now.
- Status changed to Needs work
about 1 year ago 5:15pm 14 December 2023 - 🇺🇸United States pwolanin
Some of those changes don't make sense like:
+ /** + * Namespace Drupal\Tests\ocf_integration\Kernel. + */ protected WebformInterface $webform;
Other cases they introduce a grammar error.
Did you just run a script on this?
- Status changed to Needs review
about 1 year ago 6:19pm 14 December 2023 - last update
about 1 year ago 4 pass - 🇺🇸United States pwolanin
I redid it from scratch with phpcbf and hand editing.
I don't care that phpcs complains about the JSON formatting - probably some way to disable that.
-
pwolanin →
committed 545a6cbb on 1.0.x
Issue #3372571 by pwolanin, Satish_kumar: Fix the issues reported by...
-
pwolanin →
committed 545a6cbb on 1.0.x
- Status changed to Fixed
about 1 year ago 6:29pm 14 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.