Account created on 17 July 2023, over 1 year ago
#

Recent comments

Hello, @urvashi_vora thanks for the patch

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/xmap_hub/

3. Applied your patch and, again ran phpcs command

found no errors.

Moving to RTBC.

Hello, @urvashi_vora thanks for the patch

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/openai_text_classifier/

3. Applied your patch and, again ran phpcs command

found no errors.

Moving RTBC

Hello, @urvashi_vora thanks for the patch

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/react_views/

3. Applied your patch and, again ran phpcs command

found no errors.

Moving RTBC

Hello, @arti_parmar thanks for the patch

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/labour_code_widgets/

3. Applied your patch and, again ran phpcs command

found no errors.

Moving RTBC.

Hii,

As mentioned above that the patch is failed to apply,

I have created a new patch and fixed all the errors.

Please review.

Hii,

As mentioned above that the patch is failed to apply,

I have created a new patch and fixed all the errors.

Please review.

hii@urvashi_vora
These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/secure_admin_path/

3. Applied your patch and, again ran phpcs command

found errors.

4. Create a patch and fixed the errors.

Please Review.

hii@samit.310@gmail.com

Thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 8.x.1 in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/microcontent/

3. Applied your patch and, again ran phpcs command

found errors.

4. Create a patch and fixed the errors.

Please Review.

Hii, @urvashi_vora ,

Thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/routing_on_exception/

3. Applied your patch and, again ran phpcs command

found no errors.

Moving this to RTBC.

Hii @sidharth_soman

Applied your patch and ran successfully, found warning errors as you mentioned.

I have Created a patch and solve all the warning errors.

Please review.

Hii, @urvashi_vora

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/seb/

3. Applied your patch and, again ran phpcs command

found errors.

4. Fixed the errors and provide the patch.

Please Review.

Hii, @urvashi_vora

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/dmg/

3. Applied your patch and, again ran phpcs command

found errors.

4. Fixed the errors and provide the patch.

Please Review.

Hii, @urvashi_vora thanks for the patch,

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/required_content/

3. Applied your patch and, again ran phpcs command

found errors.

4. Fixed the errors and provide the patch.

Please Review.

Hii, @urvashi_vora thanks for the patch,

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/required_content/

3. Applied your patch and, again ran phpcs command

found errors.

4. Created a patch and resolved the errors again check with
phpcs command found no errors

Please Review.

Hii, @urvashi_vora thanks for the patch

These are the steps I followed:

1. Took clone from git version in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/learneractivities/

3. Applied your patch and, again ran phpcs command

found errors.

4. I created a patch and solved the remaining errors and

again check with phpcs command found no errors.

Please Review.

Hii, @paraderojether,

Thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 2.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/login_history/

3. Applied your patch and, again ran phpcs command

found no errors.

Moving to RTBC.

Hii, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/webform_preset/

3. Applied your patch and, again ran phpcs command

found no errors.

Moving to RTBC.

Hello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/ludt/

3. Applied your patch and, again ran phpcs command

found errors.

4. I have created a patch and fixed all the errors.

again check with phpcs command

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/ludt/

found no errors.

Please review.

Hii

Providing the updated patch all the remaining error were fixed.

again check with phpcs coomand no error were found.

Please Review.

Hii @roshnichordiya
I have Review your patch.

These are the steps I followed:

1. Took clone from git version 8.x-1.x in drupal 10.1.x

2. Applied patch and ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/passwordless/

3. Applied your patch and again ran phpcs command

found errors.

4. I created a patch and fixed some issues but still one warning is there.

Needs Work.

Hi @urvashi_vora, thanks for the patch, I have review your patch.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/accession_reference/

3. Applied patch and again ran phpcs command,

Found errors.

4. I have created a patch and solve the remaining errors,

then again check with phpcs command found no errors.

Please Review.

hiii @rushiraval ,

I have solved all the remaining errors and created a patch.

Please review.

Hi @ urvashi_vora, I have applied your patch and run successfully .

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/shopify_app/

3. Applied patch and again ran phpcs command.

found errors.

4. Create a patch and fix the errors.

Needs review.

hii@aayushmankotia thanks for patch

I have review your patch and ran successfully.

found no errors.

moving this to RTBC.

Hello, @urvashi_vora thanks for the patch

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/stripe_pay/

3. Applied your patch and, again ran phpcs command

found errors

Needs work.

Hello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/config_track/

3. Applied your patch and, again ran phpcs command

found errors

4. I have fixed that error with phpcbf.

Ran this command to fix the errors:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/config_track/
Then again checked with phpcs:

again ran phpcs command

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/config_track/

found no errors.

Please review.

Hello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/mailersend/

3. Applied your patch and, again ran phpcs command

found errors.

Needs work.

Hi @ urvashi_vora, I have applied your patch and run successfully .

These are the steps I followed:

1. Took clone in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/shopify_app/

3. Applied patch and again ran phpcs command.

found errors.

I have fixed that error with phpcbf.

Ran this command to fix the errors:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/shopify_app/

4. Then again checked with phpcs:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/shopify_app/

Found no errors.

Needs review.

Hello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/y_donate/

3. Applied your patch and, again ran phpcs command

found errors

4. I have fixed that error with phpcbf.

Ran this command to fix the errors:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/y_donate/

Then again checked with phpcs:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/y_donate/

5. Some warnings & errors are still there.

Needs work.

Hii @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/ocf_integration/

3. Applied your patch and,

again ran phpcs command and found errors.

Needs work.

Hii @aayushmankotia thanks for the patch, I have applied your patch and ran successfully.

1. Ran this command:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/rest_entity_display/

2. Applied your patch and,

again ran phpcs command and found no errors.

Moving to RTBC.

Hii, @arti_parmar
I have Review your patch.

These are the steps I followed:

1. Took clone in version 1.0.x in drupal 10.1.x

2. Applied patch and ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/advanced_help_block/

3. Applied your patch and again ran phpcs command

But I found errors.

I have fixed that error with phpcbf.

Ran this command to fix the errors:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/advanced_help_block/

4. Then again checked with phpcs:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/advanced_help_block/

Found no errors.

Needs review.

Hii, @sakthi_dev
I have Review your patch.

These are the steps I followed:

1. Took clone in drupal 10.1.x

2. Applied patch and ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/leap_ai/

3. Applied your patch and again ran phpcs command

found error.

Needs work.

Hi @arti_parmar , thanks for the patch, I have review your patch.

These are the steps I followed:

1. Took clone from git version 1.0 in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/harmony_haven/

3. Applied patch and again ran phpcs command.

found no errors.

Moving this to RTBC.

Hii, @roberttabigue, Review your patch.

These are the steps I followed:

1. Took git clone 8.x-1 in drupal 10.1.x

2. Applied patch and ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/search_api_view_modes/

3. Applied your patch and again ran phpcs command.

found errors.

Needs work.

Hi @urvashi_vora, thanks for the patch, I have review your patch.

These are the steps I followed:

1. Took clone from git version 1.3.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/events_list/

3. Applied patch and again ran phpcs command.

found no errors.

Moving this to RTBC.

Hello, @roshni27 thanks for the patch, I have applied your patch.

These are the steps I followed:

1. Took clone from git version 2.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/timesup/

3. Applied your patch and, again ran phpcs command

found errors.

Needs Work.

Hii, @urvashi_vora, Review your patch.

These are the steps I followed:

1. Took clone in drupal 10.1.x

2. Applied patch and ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/color_pickr/

3. Applied your patch and again ran phpcs command.

found errors.

Needs work.

Hi @urvashi_vora, thanks for the patch, I have review your patch.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/myckebutton/

3. Applied patch and again ran phpcs command.

found no errors.

Moving this to RTBC.

Hello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version and switch to branch 1.1.0 in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/commerce_stripe_checkout/

3. Applied your patch and, again ran phpcs command

found errors, some errors are fixed are with phpcbf but again found some errors.

Needs work.

Hii, @urvashi_vora
I have Review your patch.

These are the steps I followed:

1. Took clone from git version 1.2.1 in drupal 10.1.x

2. Applied patch and ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/fb_social_plugins/

3. Applied your patch and again ran phpcs command

found errors.

Needs work.

Hello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version and switch to branch 1.1.0 in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/klavio_marketing/

3. Applied your patch and, again ran phpcs command

found errors.

Needs work.

Hii, @urvashi_vora I have Review your patch.

These are the steps I followed:

1. Took clone from git version 2.0.x in drupal 10.1.x

2. Applied patch and ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/blocktabs_jquery_ui/

3. Applied your patch and, again ran phpcs command

found errors.

Needs work.

Hii, @urvashi_vora I have Review your patch.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Applied patch and ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/opencollective/

But I found errors.

3. I have fixed that error with phpcbf.

Ran this command to fix the errors:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/opencollective/

4. Then again checked with phpcs:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/opencollective/

Found no errors.

Please review this.

Hii, @urvashi_vora I have Review your patch.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Applied patch and ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/random_quotes_block/

But I found errors.

3. I have fixed that error with phpcbf.

Ran this command to fix the errors:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/random_quotes_block/

4. Then again checked with phpcs:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/random_quotes_block/

Found no errors.

Please review this.

Hii @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/ocf_integration/

3. Applied your patch and,

again ran phpcs command and found errors.

Needs work.

Hii @urvashi_vora I have applied your patch.

These are the steps I followed:

1. Took clone from git version 1.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/drupal_sheetjs/

3. Applied patch,
again ran phpcs command and found errors.

Needs work.

Hi @nitin_lama, I have applied your patch and run successfully .

These are the steps I followed:

1. Took clone from git version 3.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/subrequests/

3. Applied patch and again ran phpcs command.

found no errors.

Moving to RTBC.

Hi @chaitanyadessai,

I have applied your patch and ran successfully.

Ran the phpcs command, found no errors, attaching screenshot for same.

Moving to RTBC.

Hi @mrinalini9 7, I have applied your patch and run successfully .

These are the steps I followed:

1. Took clone from git version 1.0 in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/multi_region/

3. Applied patch and again ran phpcs command.

found no errors.

Moving to RTBC.

Hii @sidharth_soman I have applied your patch.

These are the steps I followed:

1. Took clone from git version 2.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/devel_debug_log/

3. applied patch found same errors.

Needs work.

Hi @roshni27, I have applied your patch.

These are the steps I followed:

1. Took clone from git version 8.x-1 in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/advan/

3. Applied patch and again ran phpcs command.

found no errors.

Moving this to RTBC.

Hi @chaitanyadessai, I have applied your patch.

These are the steps I followed:

1. Took clone from git version 2.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/back_to_top_with_pi/

3. Applied patch and again ran phpcs command.

Found no errors.

Moving to RTBC.

Hii, I have Review your patch #2.

These are the steps I followed:

1. Took clone from git version 1.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/widget_type/

But I found errors.

3. I have fixed that error with phpcbf.

Ran this command to fix the errors:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/widgets_type/

Then again checked with phpcs:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/widgets_type/

Found no errors.

Please Review.

hello, @urvashi_vora I have review your merge request.

These are the steps I followed:

1. Took clone from git version 1.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/omdb_api/

Found errors.

3. I ran phpcbf and it fixed the issue.

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/omdb_api/

4. Again ran the phpcs command and found no errors.

Please Review.

Hi @Neeraj333, I have applied your patch.

These are the steps I followed:

1. Took clone from git in drupal 10.1.x
2. Applied patch.
3. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/omdb_api/

But I found errors.

I have fixed that error with phpcbf.

Ran this command to fix the errors:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/omdb_api/

Then again checked with phpcs:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/omdb_api/

Found no errors.

Needs Review.

Hii @urvashi_vora I have applied your patch.

These are the steps I followed:

1. Took clone from git version 1.2.1 in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/addthis_social_share

Found errors.

3. Applied your patch.

4. Again ran the phpcs command but again some found errors.

Hii @urvashi_vora I have applied your patch.

These are the steps I followed:

1. Took clone from git version 1.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/asset_autoload

and found errors.

4.I ran phpcbf and it fixed the issue.

Attaching screenshots and patch.

Please Review.

Hii @sidharth_soman I have applied your patch.

These are the steps I followed:

1. Took clone from git version 1.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/gcontent_moderation

3. applied patch found same errors

needs work.

Hi @Neha-Verma, I have applied your patch.

These are the steps I followed:

1. Took clone from git version 2.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/pagedesigner

3. Applied patch and again ran phpcs command.

Moving To RTBC.

Hi @Neha-Verma, I have applied your patch.

These are the steps I followed:

1. Took clone from git version 2.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/pagedesigner

3. Applied patch and again ran phpcs command.

Hi @Abh1shek Chauhan, I have applied your patch.

These are the steps I followed:

1. Took clone from git version 2.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/verf

3. Applied patch and again ran phpcs command.

I found no error. Moving it to RTBC.

Hi @clarkssquared , Thanks for the MR. I switched to your branch and ran the command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml/modules/contrib/shield

I found 1 error.

I run this command to fix that error:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/shield/

I again run phpcs command and found no errors.

Please Review.

Hi @Ashutosh Ahirwal, I have applied your patch.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x
2. Applied patch.
3. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/stylescomboplus/

But I found 1 error.

I have fixed that error with phpcbf.

Ran this command to fix the errors:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/stylescomboplus/

Then again checked with phpcs:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/stylescomboplus/

Found no errors.

Please review.

Hi @shweta__sharma I have review your merge request the issue on the footer menu is now fixed. Attaching screenshot below. So moving this to RTBC.

Hi@_utsavsharma, I have review your patch, applied successfully. It works fine and also button tag is removed as suggested by @lauriii attaching screenshot for the same.
moving it to RTBC.

@Harish1688, I applied your patch in Drupal 11.x. It is successfully applied. The border issue is now resolved. Attaching screenshot for the same. Moving to RTBC.

Hi @nishant, Thanks for the MR. I switched to your branch and ran the command:
./vendor/bin/phpcbf --standard="Drupal,DrupalPractice" --extensions="php,module,inc,install,test,profile,theme,md" app/modules/contrib/ala/
I found no errors. Attaching screenshot for the same.

Hi @nishant, Thanks for the MR. I switched to your branch and ran the command:
./vendor/bin/phpcbf --standard="Drupal,DrupalPractice" --extensions="php,module,inc,install,test,profile,theme,md" app/modules/contrib/ala/
I found no errors. Attaching screenshot for the same.

Hi @nishant, Thanks for the MR. I switched to your branch and ran the command:
./vendor/bin/phpcbf --standard="Drupal,DrupalPractice" --extensions="php,module,inc,install,test,profile,theme,md" app/modules/contrib/ala/
I found no errors. Attaching screenshot for the same.

Production build 0.71.5 2024