Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 7 July 2023, over 1 year ago
Updated 31 May 2024, 6 months ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/klavio_marketing/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 106 characters
17 | WARNING | Line exceeds 80 characters; contains 154 characters
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/klavio_marketing/klavio_marketing.module
--------------------------------------------------------------------------------
FOUND 34 ERRORS AFFECTING 23 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
12 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
13 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
18 | ERROR | [x] Case breaking statement indented incorrectly; expected 6
| | spaces, found 4
25 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found
25 | ERROR | [x] Doc comment short description must end with a full stop
26 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found
26 | ERROR | [x] There must be exactly one blank line before the tags in a doc
| | comment
26 | ERROR | [ ] Missing parameter type
26 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2
26 | ERROR | [x] Parameter comment must be on the next line
27 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found
27 | ERROR | [ ] Missing parameter type
27 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2
27 | ERROR | [x] Parameter comment must be on the next line
28 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found
28 | ERROR | [x] Separate the @param and @return sections by a blank line.
28 | ERROR | [ ] Return type missing for @return tag in function comment
28 | ERROR | [ ] Description for the @return value is missing
29 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found
31 | ERROR | [x] Opening brace should be on the same line as the declaration
34 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
35 | ERROR | [x] Case breaking statement indented incorrectly; expected 6
| | spaces, found 4
38 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
39 | ERROR | [x] Case breaking statement indented incorrectly; expected 6
| | spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
43 | ERROR | [x] Case breaking statement indented incorrectly; expected 6
| | spaces, found 4
46 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
47 | ERROR | [x] Case breaking statement indented incorrectly; expected 6
| | spaces, found 4
49 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/klavio_marketing/src/Form/KlavioMarketingLists.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
33 | ERROR | [x] Expected 1 blank line after function; 0 found
34 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/klavio_marketing/src/Form/SettingsForm.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
27 | WARNING | [x] A comma should follow the last multiline array item. Found:
| | TRUE
35 | WARNING | [x] A comma should follow the last multiline array item. Found:
| | TRUE
60 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
60 | ERROR | [x] Object operator not indented correctly; expected 6 spaces
| | but found 4
61 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: .../www/html/vb/d_cont/klavio_marketing/src/Form/KlavioMarketingCampaigns.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
55 | WARNING | [ ] Unused private method convertToRate()
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/klavio_marketing/src/KlavioMarketingApi.php
--------------------------------------------------------------------------------
FOUND 109 ERRORS AND 15 WARNINGS AFFECTING 97 LINES
--------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
7 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
17 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [ ] Class property $company_id should use lowerCamel naming
| | without underscores
31 | ERROR | [ ] Missing member variable doc comment
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [ ] Class property $private_key should use lowerCamel naming
| | without underscores
32 | ERROR | [ ] Missing member variable doc comment
35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] Expected 1 blank line before function; 2 found
42 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
45 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
45 | WARNING | [x] There must be no blank line following an inline comment
45 | WARNING | [ ] There must be no blank line following an inline comment
45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
68 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
71 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
71 | ERROR | [x] Concat operator must be surrounded by a single space
72 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
73 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
76 | ERROR | [x] Short array syntax must be used to define arrays
78 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
80 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
81 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
82 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
85 | WARNING | [ ] Unused variable $statusCode.
85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
88 | ERROR | [x] Expected 1 space after "="; 2 found
89 | ERROR | [x] Functions must not contain multiple empty lines in a row;
| | found 2 empty lines
91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
91 | ERROR | [x] Expected 1 space after IF keyword; 0 found
92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 16
93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
95 | ERROR | [x] Expected newline after closing brace
96 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
97 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
112 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
113 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
115 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
117 | ERROR | [x] Array indentation error, expected 10 spaces but found 9
117 | ERROR | [x] Concat operator must be surrounded by a single space
118 | ERROR | [x] Array indentation error, expected 10 spaces but found 9
119 | ERROR | [x] Array indentation error, expected 10 spaces but found 9
120 | ERROR | [x] Array closing indentation error, expected 8 spaces but
| | found 5
122 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
122 | ERROR | [x] Short array syntax must be used to define arrays
124 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
127 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
128 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
131 | WARNING | [ ] Unused variable $statusCode.
131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
132 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
134 | ERROR | [x] Expected 1 space after "="; 2 found
136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
136 | ERROR | [x] Expected 1 space after IF keyword; 0 found
137 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 16
138 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
140 | ERROR | [x] Expected newline after closing brace
142 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
144 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
146 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
148 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
154 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
155 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
156 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
157 | WARNING | [ ] Unused variable $email.
157 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
158 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
160 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
160 | ERROR | [x] Concat operator must be surrounded by a single space
161 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
162 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
163 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
166 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
171 | ERROR | [x] Expected 1 space before "??"; 0 found
171 | ERROR | [x] Expected 1 space after "??"; 0 found
173 | ERROR | [x] Expected 1 space before "??"; 0 found
173 | ERROR | [x] Expected 1 space after "??"; 0 found
175 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: "New Value"
176 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
177 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
178 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
181 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
183 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
184 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
185 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
186 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
189 | WARNING | [ ] Unused variable $statusCode.
189 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
190 | WARNING | [ ] Unused variable $responseBody.
190 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
192 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
192 | ERROR | [x] Expected newline after closing brace
193 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
194 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
195 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 113 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: .../klavio_marketing/src/Plugin/WebformHandler/KlavioMarketingFormHandler.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
71 | ERROR | [x] Expected 1 space before "="; 0 found
71 | ERROR | [x] Expected 1 space after "="; 0 found
71 | ERROR | [x] Expected 1 space before "="; 0 found
71 | ERROR | [x] Expected 1 space after "="; 0 found
75 | ERROR | [x] Expected 1 space after IF keyword; 0 found
190 | WARNING | [x] There must be no blank line following an inline comment
190 | WARNING | [ ] There must be no blank line following an inline comment
198 | ERROR | [x] Expected 1 space before "??"; 0 found
198 | ERROR | [x] Expected 1 space after "??"; 0 found
233 | WARNING | [ ] Unused variable $response.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/klavio_marketing/klavio_marketing.links.menu.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
27 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/klavio_marketing/klavio_marketing.info.yml
------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/klavio_marketing/klavio_marketing.routing.yml
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
31 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

Time: 143ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig klavio_marketing/

Remaining tasks

Patch review

📌 Task
Status

Needs work

Version

1.1

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    Satish_kumar

    Hello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

    These are the steps I followed:

    1. Took clone from git version and switch to branch 1.1.0 in drupal 10.1.x

    2. Ran this command:

    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
    d,yml,twig modules/contrib/klavio_marketing/

    3. Applied your patch and, again ran phpcs command

    found errors.

    Needs work.

  • Assigned to nitin_lama
  • Comment about 1 year ago →
    🇮🇳India nitin_lama India
  • Issue was unassigned.
  • Comment about 1 year ago →
    🇮🇳India nitin_lama India

    Unable to apply initial patch on master branch. Providing an updated patch.

  • Comment about 1 year ago →
    🇮🇳India Ashutosh Ahirwal India

    I have reviewed #4 patch.
    Patch get applied cleanly but still having errors in it.

    Used command to review patch
    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/klavio_marketing

    Remaining issue after applying #4 patch

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/klavio_marketing/klavio_marketing.module
    -----------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 4 LINES
    -----------------------------------------------------------------------------------------------------------------
    3 | ERROR | Missing short description in doc comment
    31 | ERROR | Missing parameter type
    33 | ERROR | Missing parameter type
    36 | ERROR | Return type missing for @return tag in function comment
    36 | ERROR | Description for the @return value is missing
    -----------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/klavio_marketing/klavio_marketing.links.menu.yml
    -------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------
    27 | ERROR | [x] Expected 1 newline at end of file; 0 found
    -------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/klavio_marketing/klavio_marketing.info.yml
    -------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------
    7 | ERROR | [x] Expected 1 newline at end of file; 0 found
    -------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/klavio_marketing/klavio_marketing.routing.yml
    ----------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------
    31 | ERROR | [x] Expected 1 newline at end of file; 0 found
    ----------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/klavio_marketing/src/Form/KlavioMarketingDashboard.php
    -------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------
    6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormBase.
    -------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/klavio_marketing/src/Form/KlavioMarketingCampaigns.php
    -------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------
    53 | WARNING | Unused private method convertToRate()
    -------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/klavio_marketing/src/KlavioMarketingApi.php
    --------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AND 6 WARNINGS AFFECTING 9 LINES
    --------------------------------------------------------------------------------------------------------------------
    8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is GuzzleHttp\Client.
    27 | ERROR | [ ] Class property $company_id should use lowerCamel naming without underscores
    27 | ERROR | [ ] Missing member variable doc comment
    28 | ERROR | [ ] Class property $private_key should use lowerCamel naming without underscores
    28 | ERROR | [ ] Missing member variable doc comment
    39 | WARNING | [ ] Line exceeds 80 characters; contains 113 characters
    77 | WARNING | [ ] Unused variable $statusCode.
    122 | WARNING | [ ] Unused variable $statusCode.
    148 | WARNING | [ ] Unused variable $email.
    180 | WARNING | [ ] Unused variable $statusCode.
    181 | WARNING | [ ] Unused variable $responseBody.
    --------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/klavio_marketing/src/Plugin/WebformHandler/KlavioMarketingFormHandler.php
    --------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------------------------------------------
    232 | WARNING | Unused variable $response.
    --------------------------------------------------------------------------------------------------------------------------------------------------

  • Comment about 1 year ago →
    🇮🇳India aayushDrupal

    Hi Ashutosh Ahirwal,
    In this patch, I have solved all the errors mentioned in comment #5. Screenshot attached for your reference.

    Please review.

  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India aayushDrupal
  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    a.aaronjake

    Hi @aayushmankotia,

    Patch #6 applied not-so successfully because 1 out of 2 hunks FAILED

    klavio_marketing git:(main) ✗ curl https://www.drupal.org/files/issues/2023-09-26/phpcs_error_fixed-3373171-6.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 20502  100 20502    0     0  50865      0 --:--:-- --:--:-- --:--:-- 52569
patching file README.md
Hunk #2 succeeded at 15 with fuzz 2.
patching file klavio_marketing.info.yml
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED -- saving rejects to file klavio_marketing.info.yml.rej
patching file klavio_marketing.links.menu.yml
Hunk #1 succeeded at 24 with fuzz 1.
patching file klavio_marketing.module
Hunk #2 FAILED at 14.
1 out of 2 hunks FAILED -- saving rejects to file klavio_marketing.module.rej
patching file klavio_marketing.routing.yml
patching file src/Form/KlavioMarketingCampaigns.php
patching file src/Form/KlavioMarketingDashboard.php
patching file src/Form/KlavioMarketingLists.php
patching file src/Form/SettingsForm.php
patching file src/KlavioMarketingApi.php
patching file src/Plugin/WebformHandler/KlavioMarketingFormHandler.php

    Kindly check

    Thanks,
    Jake

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024