scott_euser → credited nitin_lama → .
larowlan → credited nitin_lama → .
Please review.
Thanks.
Fixed conflicts in the MR53
MR created. Please review.
Thanks.
nitin_lama → made their first commit to this issue’s fork.
MR created. Please review the MR.
nitin_lama → made their first commit to this issue’s fork.
Please review.
Thanks.
Please review. Thanks.
Please review. Thanks.
nitin_lama → changed the visibility of the branch 2789241-usability-issue-- to hidden.
nitin_lama → changed the visibility of the branch 2789241-usability-issue-- to active.
MR created for the changes.
Please review. Thanks.
MR created. Please review.
Please review.
Only remaining issue:
FILE: /contribution/commerceuserpoints-3374300/src/EventSubscriber/OrderCompleteSubscriber.php
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------
74 | WARNING | Unused variable $userPoints.
81 | WARNING | Unused variable $userPoints.
89 | WARNING | Unused variable $orderTotal.
--------------------------------------------------------------------------------------------------------------------
Time: 110ms; Memory: 8MB
Please review. Thanks.
Please review. Thanks.
Please review. Thanks.
Please review. Thanks.
MR for the changes. Please review. Thanks.
Providing updated patch.
Mentioned issue in comment #16 is fixed.
I don't see any remaining issues on 1.0.x branch. Please review.
@pray_12, as per comment #23. we are not sure if DI issue is fixed or not. For now i have reverted the DI for entity type manager.
Please review. Thanks.
Please review. Thanks.
Please review. Thanks.
Providing updated patch.
nitin_lama → made their first commit to this issue’s fork.
Please review. Thanks.
nitin_lama → made their first commit to this issue’s fork.
Please review. Thanks.
Please review. Thanks.
Please review. Thanks.
Please review. Thanks.
nitin_lama → changed the visibility of the branch 3316196-replace-the-readme.txt to hidden.
nitin_lama → changed the visibility of the branch pcp-3316196-readme.md to active.