Fix the issues reported by phpcs

Open on Drupal.org →

Created on 23 June 2023, about 1 year ago

Updated 20 March 2024, 3 months ago

Problem/Motivation

Fix the issue reported by phpcs command

Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/themes/custom/corporate_lite

Even after using phpcbf command still there are so many issue found.

Steps to reproduce

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/css/components/dropdowns.css
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
32 | ERROR | Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/css/components/inverted-header.css
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
41 | ERROR | Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/css/components/social-links.css
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
41 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/css/components/forms.css
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
130 | ERROR | Style definitions must end with a semicolon
---------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/css/components/menu.css
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
805 | ERROR | Class definition is empty
--------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/css/components/owl-carousel-global.css
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
66 | ERROR | Style definitions must end with a semicolon
-----------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/css/components/tables.css
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
56 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/css/theme/local-theme.css
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/waypoints/shortcuts/inview.min.js
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
---------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/waypoints/shortcuts/sticky.min.js
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
---------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/waypoints/jquery.waypoints.min.js
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
---------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/magnific-popup/jquery.magnific-popup.min.js
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/magnific-popup/jquery.magnific-popup.js
---------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------------------------------------
1106 | ERROR | String concat is not required here; use a single string instead
1107 | ERROR | String concat is not required here; use a single string instead
1108 | ERROR | String concat is not required here; use a single string instead
1109 | ERROR | String concat is not required here; use a single string instead
1110 | ERROR | String concat is not required here; use a single string instead
1113 | ERROR | String concat is not required here; use a single string instead
1114 | ERROR | String concat is not required here; use a single string instead
1115 | ERROR | String concat is not required here; use a single string instead
1116 | ERROR | String concat is not required here; use a single string instead
1544 | ERROR | String concat is not required here; use a single string instead
---------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/slideout/slideout.min.js
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/mt-modernizr/mt-modernizr.js
----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/flexslider/jquery.flexslider-min.js
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/flexslider/changelog.txt
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------
13 | WARNING | Line exceeds 80 characters; contains 103 characters
33 | WARNING | Line exceeds 80 characters; contains 96 characters
36 | WARNING | Line exceeds 80 characters; contains 111 characters
------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/flexslider/jquery.flexslider.js
-------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------
885 | ERROR | [ ] Blank lines are not allowed after DEFAULT statements
1115 | ERROR | [x] Inline control structures are not allowed
1136 | ERROR | [x] Inline control structures are not allowed
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/owl-carousel/README.md
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------------------
37 | WARNING | Line exceeds 80 characters; contains 92 characters
41 | WARNING | Line exceeds 80 characters; contains 96 characters
44 | WARNING | Line exceeds 80 characters; contains 114 characters
61 | WARNING | Line exceeds 80 characters; contains 166 characters
74 | WARNING | Line exceeds 80 characters; contains 116 characters
95 | WARNING | Line exceeds 80 characters; contains 81 characters
98 | WARNING | Line exceeds 80 characters; contains 100 characters
----------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/js/owl-carousel/owl.carousel.min.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/corporate_lite.theme
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 3 WARNINGS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
74 | WARNING | Line exceeds 80 characters; contains 94 characters
81 | WARNING | Line exceeds 80 characters; contains 89 characters
138 | ERROR | Doc comment is empty
180 | ERROR | Doc comment is empty
700 | ERROR | Doc comment is empty
748 | ERROR | Doc comment is empty
805 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
818 | ERROR | Doc comment is empty
827 | ERROR | Doc comment is empty
834 | ERROR | Doc comment is empty
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/themes/custom/corporate_lite/theme-settings.php
---------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
7 | ERROR | Doc comment is empty
121 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
---------------------------------------------------------------------------------------------------------

Time: 3.03 secs; Memory: 54MB

📌 Task

Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India Prachi6824

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

!5Fix the issues reported by phpcs
Open
🇮🇳India nitin_lama
updated 3 months ago

Comments & Activities

Issue created by @Prachi6824
Assigned to Prachi6824
Status changed to Needs review about 1 year ago7:14am 23 June 2023
Comment about 1 year ago →
🇮🇳India Prachi6824
Hello,

I have created a patch to solve all the errors related to phpcs code standard within the slideout.css file .
Please review and apply it .
Comment about 1 year ago →
🇮🇳India Prachi6824
Hello,

I have recreated a patch as above 3368319-#2 failed to solve all the errors related to phpcs code standard within the slideout.css file .
Please review and apply it .
Issue was unassigned.
Status changed to Needs work 4 months ago9:02am 6 March 2024
Comment 4 months ago →
🇮🇳India Ashutosh Ahirwal India
Hi I reviewed it but there are so many issue found related to phpcs issue updating the issue description.
Need work on it.
Comment 4 months ago →
🇮🇳India Preethy_ray
Hi,
Created the patch which fexes few errors and there are few errors and warnings need to be addressed.
Comment 4 months ago →
🇮🇳India Yashaswi18
This patch fixes some more errors, there are still some errors that needs to be addressed
Comment 3 months ago →
Shruthi rao
Fixed some phpcs errors and warnings in the above patch.
Status changed to Needs review 3 months ago11:42am 19 March 2024
Comment 3 months ago →
🇮🇳India Shank115
Status changed to Needs work 3 months ago11:56am 19 March 2024
Comment 3 months ago →
🇮🇳India Yashaswi18
I applied the patch from #7. However, there are still several issues remaining, primarily in JavaScript and CSS files. Do these need to be addressed? Please check.
Assigned to nitin_lama
Comment 3 months ago →
🇮🇳India nitin_lama
Merge request !5#3368906: MR for the changes. → (Open) created by nitin_lama
First commit to issue fork.
Comment 3 months ago →
🇮🇳India nitin_lama
MR created for the changes.
Issue was unassigned.
Status changed to Needs review 3 months ago7:16am 20 March 2024
Comment 3 months ago →
🇮🇳India nitin_lama
Comment 3 months ago →
🇮🇳India shivamsen_12579 Bhopal

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024