🇮🇳India @Preethy_ray

Applied patch #2, Its throwing error. Moving the status to needs work.

Checking patch css/global.css...
error: while searching for:
  display: block;
  color: #333;
}

error: patch failed: css/global.css:1137
error: css/global.css: patch does not apply

"Hi @silvi.addweb,
I applied the MR! The comment by @Yashaswi18 has been addressed in the MR, and the hamburger issue is also solved.
Thank you!"

Hi @sourabhsisodia_ , Sibling menus are now visible on hover for all the devices,but the styling can be improved for better UI.
Thank You!

Hi @Tanushree Gupta , the form styling looks good for all the devices. RTBC++
Thank You!

Hi @4shweta__sharma,

The website feedback form is still not responsive after applying the MR. Moving the status to "Needs Work."
Thank you!

Getting the same error. Moving the status to needs work.

Hi, Applied the patch getting error. Attaching the scrrenshot for reference.
Thank You!

Hi @sourabhjain issue is not resolved. Moving this to Needs Work.

Hi Applied the patch and the spacing issue looks fine. Moving this to RTBC.

Updated the issue summary.

Applied the patch.Form styles looks good and its responsive for all the device.RTBC

Applied the patch, It solves the Search block stretched on tablet and desktop.Moving this to RTBC.

Hi @shweta__sharma I applied the MR. Cancel button style and spacing also looks good.Attaching screenshot for reference.
Thank you!

Applied the MR!,Mini pager style looks good. Moving this to RTBC++

Patch solves the Hamburger issue. Moving this to RTBC++

Patch solves the submenu issue. Moving this to RTBC++

The mobile responsiveness issue described in https://www.drupal.org/project/yg_music/issues/3382796 🐛 On mobile view footer is not responsive. RTBC has been resolved. The styles now look good on all devices. Moving this to RTBC.

Hi @alok_singh the issue is fixed, attaching screenshot for reference.

Hi @alok_singh Reviewed the MR!, footer styles are not responsive for mobile view.
Attaching screenshot for reference.

Hi @Rohit Rana, Patch is applied cleanly and twitter icon is also updated Thank you!

Hi @alok_singh applied the MR, Changes looks good on all the devices. Attaching screenshots for reference.

Applied the MR! It solves the error - Call to undefined function file_load.
Thank you!

Applied MR!,banner is still not rendering.Attaching the screenshot for reference.

Read More button style looks good. Moving this to RTBC++

Hi @swatidhurandhar , content and breadcrumb spacing looks good. Moving this to RTBC++.

Primary tabs looks good for all the devices.Moving this to RTBC.

Searched result font size and spacing looks fine. Moving this to RTBC.

Hi @abhishek_gupta1 ,reviewed the MR ! Description is added for the description field. Attaching screenshot for reference.
Thank you !

Hi @alok_singh,

I applied the MR! The remove button looks fine, but the button color is not as expected; it should be green. Attaching a screenshot for reference.

Thank you!

@alok_singh MR is not working. I am moving this to "Needs Work."

Hi @alok_singh,

I applied the MR, but the changes are not getting reflected as mentioned by @riddhi.addweb. I am moving this to "Needs Work."

Thank you!

Hi @alok_singh,

The issue is solved for the mobile view, but on tablets, the image is moving out of the focused area. Attached is a screenshot for reference.

Thank you!

Hi @alok_singh,
I reviewed the MR! The content spacing from both the left and right sides looks good on all devices.
Thank you!

Hi @silvi.addweb,

Please create the MR. You have committed the changes but have not created the MR yet.

Thank you!

Steps to reproduce the issue:

Create content of type "Article."
Visit the homepage. Below the tags, you will find these two buttons.
I reviewed MR!3 created by Alok Singh. The styles look good. Attaching the screenshot for reference.

Thank you!

Hi,

I applied the MR!18. The site slogan is now visible, but the slogan and site header are not aligned properly. Attached a screenshot for reference. I am keeping the status as "needs work."

@Nupur Badola, please use the following steps to find this issue:

• Navigate to .../admin/config/system/site-information.
• Add the slogan in the slogan field.
• Save the changes.

Thank you!

Hi @alok_singh. Reviewed the MR . The spacing and horizontal line separating two articles style looks good on all devices. Attached screenshot for reference.

Hi @silvi.addweb,Can we remove the horizontal bar that appears at the top of the buttons for the mini pager? The horizontal line is not present for the full pager.
Thanks.

Hi @ravikant, Applied the MR, the css styles are overlapping. Attaching Screenshot for reference. Thank you!

Hi @ravi kant Reviewed the MR . Menu styles are looking good for mobile, tab and desktop view. Moving this to RTBC+1.
Thank You!

Hi @alok_singh, Menu level 2 isn't displaying as expected, and the menu alignment and styles aren't being applied properly.
Thank you!

Hi @Tanushree Gupta, the submenus are working fine in desktop view. However, on tablets and mobile devices, the menu is not working. When clicking the hamburger icon, the menu does not open.
Thank you!

Hi @zetagraph, I reviewed the MR. The spacing looks fine for both desktop and mobile views. Thank you!

Hi @Hamid.ali,
I reviewed the updated patch, and the dashed underline below the text has also been removed.
Thank you!

Hi @Anita Verma,

I reviewed the MR and found that while menu level 0 and menu level 1 are functioning correctly for both desktop and mobile view, menu level 2 is not displaying as expected.
Thank you!

Breadcrumbs looks good. Moving this to RTBC.

The pagination styling looks good. Moving this to RTBC.

The above MR solves the issue of a second click being required for certain screen widths.

Fixed the mobile view issue by adding horizontal scroll.

Hi @kaaarrrtik,
I have reviewed the merge request. The table looks fine for desktop and tablet views, but in the mobile view, the table is moving out of the focus area, and the spacing on the right and left sides of the table is not equal.

Thank you!

Hi @Muskan0215,

I've reviewed the merge request and the tab style looks fine. Moving this to RTBC .

Thank you!

Hi @Muskan0215, Applied the MR. The mini and full pager designs look great.
Thank you!

The issue mentioned in comment #11 has been fixed in the latest MR. The menu looks fine now.
Thank you!

Hi @Muskan0215 reviewed MR!64.I see the blocks are now positioned next to each other on desktop and one below the other on mobile views.The spacing also looks good. Moving this to RTBC.
Thank You,

Patch created by @Aakansha Tyagi is working fine, made few changes in the patch and created MR.

pray_12 → made their first commit to this issue’s fork.

I have updated the patch for mobile responsiveness

Hi @Bhupesh_upadhyay Applied your patch, it is applied cleanly.
The form now displays correctly with the intended styles.

pray_12 → made their first commit to this issue’s fork.

Hi,
Applied the MR!82 and found no PHPCS errors and warnings.
Thank You!!

Hi,
Reviewed the MR !5. Found one warning.

FILE: ...onth_year/src/Plugin/Field/FieldWidget/MonthYearDefaultFieldWidget.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
 45 | WARNING | Line exceeds 80 characters; contains 101 characters
----------------------------------------------------------------------------

pray_12 → made their first commit to this issue’s fork.

hello,
I ran the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml and found no phpcs errors.

Hi,
Reviewed the above patch and found no PHPCS errors and warnings.
Thank you!!

Hi,
I applied the patch, but it is throwing the following errors.

git apply -v 3431293-phpcs-issue-fixed.patch
3431293-phpcs-issue-fixed.patch:9: trailing whitespace.
This module uses sapientpro/image-comparator library
Checking patch README.md...
error: README.md: No such file or directory
Checking patch src/Services/ImageComparatorService.php...
error: src/Services/ImageComparatorService.php: No such file or directory
Checking patch src/Services/ImageComparatorServiceInterface.php...
error: src/Services/ImageComparatorServiceInterface.php: No such file or directory

Thank You!!

Hi,
Patch applied cleanly,but there are many phpcs errors and warnings that need to be resolved.
Thank You!!.

Hi,
Addressed the remaining errors and warnings in the updated patch; we can ignore these 2 errors for readability purposes.

FILE: .../src/Plugin/RateWidgetBase.php
----------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------
 290 | ERROR | The array declaration extends to column 118 (the limit is
     |       | 80). The array content should be split up over multiple
     |       | lines
 296 | ERROR | The array declaration extends to column 103 (the limit is
     |       | 80). The array content should be split up over multiple
     |       | lines
----------------------------------------------------------------------------

pray_12 → made their first commit to this issue’s fork.

pray_12 → made their first commit to this issue’s fork.

pray_12 → made their first commit to this issue’s fork.

Fixed few errors and warnings.
There are few warnings and errors need to be solved.

FILE: .../twilio_otp_login/twilio_otp_login.module
----------------------------------------------------------------------------
FOUND 9 ERRORS AND 6 WARNINGS AFFECTING 13 LINES
----------------------------------------------------------------------------
   3 | ERROR   | Missing short description in doc comment
  14 | WARNING | Hook implementations should not duplicate @param
     |         | documentation
  16 | WARNING | Hook implementations should not duplicate @param
     |         | documentation
  16 | ERROR   | Doc comment for parameter $form_state does not match
     |         | actual variable name $form_id
  18 | WARNING | Hook implementations should not duplicate @param
     |         | documentation
  23 | WARNING | Line exceeds 80 characters; contains 85 characters
  30 | ERROR   | The array declaration extends to column 307 (the limit is
     |         | 80). The array content should be split up over multiple
     |         | lines
  38 | ERROR   | Doc comment is empty
  41 | ERROR   | Invalid function name, expected validate_mobile but found
     |         | validateMobile
  41 | ERROR   | All functions defined in a module file must be prefixed
     |         | with the module's name, found "validateMobile" but
     |         | expected "twilio_otp_login_validateMobile"
  97 | ERROR   | Doc comment short description must end with a full stop
  99 | WARNING | Line exceeds 80 characters; contains 109 characters
 101 | WARNING | Line exceeds 80 characters; contains 85 characters
 127 | ERROR   | Doc comment is empty
 130 | ERROR   | All functions defined in a module file must be prefixed
     |         | with the module's name, found "phone_login_callback" but
     |         | expected "twilio_otp_login_phone_login_callback"
----------------------------------------------------------------------------


FILE: .../twilio_otp_login/css/otp.css
----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------
 1 | ERROR | [x] Additional whitespace found at start of file
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------

Hi,
Reviewed the patch. There are many errors and warnings pending that need to be resolved.
I will work on this issue.

pray_12 → made their first commit to this issue’s fork.

There is one error that needs to be addressed.

FILE: /groupmenu/src/GroupMenuConfigOverrides.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 190 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------

pray_12 → made their first commit to this issue’s fork.

Hi,
Remaining errors and warnings that need to be addressed are:

FILE: /memcache_storage/memcache_storage.install
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
  27 | ERROR | The array declaration extends to column 118 (the limit is 80). The array content should be split up over multiple lines
 107 | ERROR | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /memcache_storage/memcache_storage.module
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------
 8 | WARNING | Global constants should not be used, move it to a class or interface
 9 | WARNING | Global constants should not be used, move it to a class or interface
----------------------------------------------------------------------------------------------------

pray_12 → made their first commit to this issue’s fork.

pray_12 → made their first commit to this issue’s fork.

Fixed Line indented incorrectly for browsersync.module.

pray_12 → made their first commit to this issue’s fork.

hi ,
@clarkssquared Please use this command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig modules/contrib/database_dashboard/

pray_12 → made their first commit to this issue’s fork.

Hi,
Applied the MR !7 found one warning.

FILE: .../cognito/src/Plugin/rest/resource/CognitoAuthToken.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
 32 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------------