Hi @silvi.addweb,Can we remove the horizontal bar that appears at the top of the buttons for the mini pager? The horizontal line is not present for the full pager.
Thanks.
Hi @ravikant, Applied the MR, the css styles are overlapping. Attaching Screenshot for reference. Thank you!
Hi @ravi kant Reviewed the MR . Menu styles are looking good for mobile, tab and desktop view. Moving this to RTBC+1.
Thank You!
Hi @alok_singh, Menu level 2 isn't displaying as expected, and the menu alignment and styles aren't being applied properly.
Thank you!
Hi @Tanushree Gupta, the submenus are working fine in desktop view. However, on tablets and mobile devices, the menu is not working. When clicking the hamburger icon, the menu does not open.
Thank you!
Hi @zetagraph, I reviewed the MR. The spacing looks fine for both desktop and mobile views. Thank you!
Hi @Hamid.ali,
I reviewed the updated patch, and the dashed underline below the text has also been removed.
Thank you!
Hi @Anita Verma,
I reviewed the MR and found that while menu level 0 and menu level 1 are functioning correctly for both desktop and mobile view, menu level 2 is not displaying as expected.
Thank you!
Breadcrumbs looks good. Moving this to RTBC.
The pagination styling looks good. Moving this to RTBC.
The above MR solves the issue of a second click being required for certain screen widths.
Fixed the mobile view issue by adding horizontal scroll.
Hi @kaaarrrtik,
I have reviewed the merge request. The table looks fine for desktop and tablet views, but in the mobile view, the table is moving out of the focus area, and the spacing on the right and left sides of the table is not equal.
Thank you!
Hi @Muskan0215,
I've reviewed the merge request and the tab style looks fine. Moving this to RTBC .
Thank you!
Hi @Muskan0215, Applied the MR. The mini and full pager designs look great.
Thank you!
The issue mentioned in comment #11 has been fixed in the latest MR. The menu looks fine now.
Thank you!
Hi @Muskan0215 reviewed MR!64.I see the blocks are now positioned next to each other on desktop and one below the other on mobile views.The spacing also looks good. Moving this to RTBC.
Thank You,
Patch created by @Aakansha Tyagi is working fine, made few changes in the patch and created MR.
pray_12 → made their first commit to this issue’s fork.
I have updated the patch for mobile responsiveness
Hi @Bhupesh_upadhyay Applied your patch, it is applied cleanly.
The form now displays correctly with the intended styles.
pray_12 → made their first commit to this issue’s fork.
Hi,
Applied the MR!82 and found no PHPCS errors and warnings.
Thank You!!
Hi,
Reviewed the MR !5. Found one warning.
FILE: ...onth_year/src/Plugin/Field/FieldWidget/MonthYearDefaultFieldWidget.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
45 | WARNING | Line exceeds 80 characters; contains 101 characters
----------------------------------------------------------------------------
pray_12 → made their first commit to this issue’s fork.
hello,
I ran the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml and found no phpcs errors.
Hi,
Reviewed the above patch and found no PHPCS errors and warnings.
Thank you!!
Hi,
I applied the patch, but it is throwing the following errors.
git apply -v 3431293-phpcs-issue-fixed.patch
3431293-phpcs-issue-fixed.patch:9: trailing whitespace.
This module uses sapientpro/image-comparator library
Checking patch README.md...
error: README.md: No such file or directory
Checking patch src/Services/ImageComparatorService.php...
error: src/Services/ImageComparatorService.php: No such file or directory
Checking patch src/Services/ImageComparatorServiceInterface.php...
error: src/Services/ImageComparatorServiceInterface.php: No such file or directory
Thank You!!
Hi,
Patch applied cleanly,but there are many phpcs errors and warnings that need to be resolved.
Thank You!!.
Hi,
Addressed the remaining errors and warnings in the updated patch; we can ignore these 2 errors for readability purposes.
FILE: .../src/Plugin/RateWidgetBase.php
----------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------
290 | ERROR | The array declaration extends to column 118 (the limit is
| | 80). The array content should be split up over multiple
| | lines
296 | ERROR | The array declaration extends to column 103 (the limit is
| | 80). The array content should be split up over multiple
| | lines
----------------------------------------------------------------------------
pray_12 → made their first commit to this issue’s fork.
pray_12 → made their first commit to this issue’s fork.
pray_12 → made their first commit to this issue’s fork.
Fixed few errors and warnings.
There are few warnings and errors need to be solved.
FILE: .../twilio_otp_login/twilio_otp_login.module
----------------------------------------------------------------------------
FOUND 9 ERRORS AND 6 WARNINGS AFFECTING 13 LINES
----------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
14 | WARNING | Hook implementations should not duplicate @param
| | documentation
16 | WARNING | Hook implementations should not duplicate @param
| | documentation
16 | ERROR | Doc comment for parameter $form_state does not match
| | actual variable name $form_id
18 | WARNING | Hook implementations should not duplicate @param
| | documentation
23 | WARNING | Line exceeds 80 characters; contains 85 characters
30 | ERROR | The array declaration extends to column 307 (the limit is
| | 80). The array content should be split up over multiple
| | lines
38 | ERROR | Doc comment is empty
41 | ERROR | Invalid function name, expected validate_mobile but found
| | validateMobile
41 | ERROR | All functions defined in a module file must be prefixed
| | with the module's name, found "validateMobile" but
| | expected "twilio_otp_login_validateMobile"
97 | ERROR | Doc comment short description must end with a full stop
99 | WARNING | Line exceeds 80 characters; contains 109 characters
101 | WARNING | Line exceeds 80 characters; contains 85 characters
127 | ERROR | Doc comment is empty
130 | ERROR | All functions defined in a module file must be prefixed
| | with the module's name, found "phone_login_callback" but
| | expected "twilio_otp_login_phone_login_callback"
----------------------------------------------------------------------------
FILE: .../twilio_otp_login/css/otp.css
----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------
Hi,
Reviewed the patch. There are many errors and warnings pending that need to be resolved.
I will work on this issue.
pray_12 → made their first commit to this issue’s fork.
There is one error that needs to be addressed.
FILE: /groupmenu/src/GroupMenuConfigOverrides.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
190 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------
pray_12 → made their first commit to this issue’s fork.
Hi,
Remaining errors and warnings that need to be addressed are:
FILE: /memcache_storage/memcache_storage.install
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
27 | ERROR | The array declaration extends to column 118 (the limit is 80). The array content should be split up over multiple lines
107 | ERROR | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /memcache_storage/memcache_storage.module
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------
8 | WARNING | Global constants should not be used, move it to a class or interface
9 | WARNING | Global constants should not be used, move it to a class or interface
----------------------------------------------------------------------------------------------------
pray_12 → made their first commit to this issue’s fork.
pray_12 → made their first commit to this issue’s fork.
Fixed Line indented incorrectly for browsersync.module.
pray_12 → made their first commit to this issue’s fork.
hi ,
@clarkssquared Please use this command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig modules/contrib/database_dashboard/
pray_12 → made their first commit to this issue’s fork.
Hi,
Applied the MR !7 found one warning.
FILE: .../cognito/src/Plugin/rest/resource/CognitoAuthToken.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
32 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------------
pray_12 → made their first commit to this issue’s fork.
pray_12 → made their first commit to this issue’s fork.
Hi,
Applied the MR!1, found no PHPCS errors and warnings.
Thank You!!
pray_12 → made their first commit to this issue’s fork.
pray_12 → made their first commit to this issue’s fork.
pray_12 → made their first commit to this issue’s fork.
Hi,
The errors and warnings from #45 have been successfully addressed;
however, there are still some remaining errors and warnings that need attention.
FILE: .../eca_cm/src/Form/EcaForm.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
587 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------
FILE: .../eca_cm/src/Form/EcaPluginForm.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
314 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------
pray_12 → made their first commit to this issue’s fork.
Hi,
The changes made in patch #13 have addressed the concerns raised in the comments made in #11.
Hi,
adressed the #13 comment and applied the patch .There are many phpcs errors and warnings that need to be resolved.
pray_12 → made their first commit to this issue’s fork.
Hi,
fixed few errors and warnings.
Remaining errors that need to be addressed are
FILE: .../multi_image_formatter/src/Controller/AssetFormatController.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------
29 | WARNING | Line exceeds 80 characters; contains 92 characters
78 | WARNING | MediaType::load calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------------
FILE: ...multi_image_formatter/src/Routing/RouteSubscriber.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
32 | WARNING | Line exceeds 80 characters; contains 83 characters
----------------------------------------------------------------------------
FILE: ...mage_formatter/src/Plugin/Field/FieldFormatter/MultiImageFormatter.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
46 | WARNING | Line exceeds 80 characters; contains 106 characters
----------------------------------------------------------------------------
Hi ,
Applied MR1 found few more errors and warnings that need to be resolved.
FILE: .../multi_image_formatter/src/Controller/AssetFormatController.php
----------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------
29 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
60 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
76 | ERROR | [x] Additional blank lines found at end of doc comment
79 | WARNING | [ ] MediaType::load calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------
FILE: ../multi_image_formatter/src/Routing/RouteSubscriber.php
----------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------
32 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
78 | ERROR | [x] Concat operator must be surrounded by a single space
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------
FILE: ...mage_formatter/src/Plugin/Field/FieldFormatter/MultiImageFormatter.php
----------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------
46 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
221 | ERROR | [x] Expected 1 blank line after function; 0 found
222 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------
FILE: .../multi_image_formatter/multi_image_formatter.module
----------------------------------------------------------------------------
FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------------
14 | ERROR | [x] Use statements should be sorted alphabetically. The
| | first wrong one is Drupal\media\Entity\MediaType.
24 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
25 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
53 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: FALSE
58 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: FALSE
89 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------
pray_12 → made their first commit to this issue’s fork.
Hi,
Applied the patch #6 and found no errors and warning.
Applied MR!1 and found no errors and warnings.
Thank you!!
Hi,
Applied the MR!1,found no phpcs errors and warnings.
Hi ,
Applied the MR!12 and found few errors and warning.
Hi,
Created the patch which fexes few errors and there are few errors and warnings need to be addressed.
pray_12 → made their first commit to this issue’s fork.
Hi,
Reviewed the above patch. Patch applied cleanly, but found few errors and warnings that need to be addressed.
pray_12 → made their first commit to this issue’s fork.
Hi,
The patch applied cleanly, but I found a few errors and warnings. I have addressed all of them in the updated patch.
Please Review
thank You!!
Hi,
Above Patch applied cleanly, but found few warnings.
FILE: /viewer/assets/chartjs/LICENSE.md
--------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 432 characters
7 | WARNING | Line exceeds 80 characters; contains 126 characters
9 | WARNING | Line exceeds 80 characters; contains 460 characters
--------------------------------------------------------------------------------------------
FILE: /viewer/assets/apexcharts/apexcharts.amd.js.LICENSE.txt
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
8 | WARNING | Line exceeds 80 characters; contains 83 characters
------------------------------------------------------------------------------------------------------------------
Hi,
Applied the MR!5 found one warning.
FILE: /imageapi_optimize/src/ImageAPIOptimizePipelineInterface.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------
23 | WARNING | The @see url '\Drupal\imageapi_optimize\ImageAPIOptimizePipelineStorageInterface::getReplacementId()' does not match the standard:
| | http(s)://www.drupal.org/node/n or http(s)://www.drupal.org/project/aaa/issues/n
------------------------------------------------------------------------------------------------------------------------------------------------------------
Hi,
Solved the phpcs issues.
Remaining errors need to be adressed are
FILE: /group/tests/src/Kernel/ContentEntityAccessComplexTest.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
1004 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
1056 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /group/tests/src/Kernel/QueryAlter/QueryAlterTestBase.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
541 | ERROR | The array declaration extends to column 128 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------
Hi,
Apllied the MR!1 found few errors that need to be addressed.
Thank You!!
pray_12 → made their first commit to this issue’s fork.
Hi,
Applied the above patch found no errors or warnings.
Thank You!!
Hi,
The above patch applied cleanly, but I found a few PHPCS errors and warnings. I have addressed those errors and warnings in the updated patch
pray_12 → made their first commit to this issue’s fork.
Hi,
Addressed the error and warning mentioned in #18.
Please Review.
Thankyou!!
Hi,
Applied the above patch #8, found no Phpcs errors and warning.
Thank you!!
pray_12 → made their first commit to this issue’s fork.
Hi,
Applied patch #24 is applied cleanly and errors are fixed.But line extends characters warning are showing up.
FILE: /force_users_logout/src/Controller/AutocompleteController.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
33 | WARNING | Line exceeds 80 characters; contains 90 characters
----------------------------------------------------------------------------
FILE: /force_users_logout/src/Form/AllOtherUsersLogoutForm.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
39 | WARNING | Line exceeds 80 characters; contains 85 characters
----------------------------------------------------------------------------
FILE: /force_users_logout/src/Form/RoleBasedLogoutForm.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
39 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------------
FILE: /force_users_logout/src/Form/IndividualUserLogoutForm.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
40 | WARNING | Line exceeds 80 characters; contains 86 characters
----------------------------------------------------------------------------
Hi,
I have reviewed MR!6 and did not find any errors or warnings reported by PHPCS.
Thank you!!
Hi,
Updated the patch. Please review.
Thank you!!
pray_12 → made their first commit to this issue’s fork.
Hi,
Reviewed the MR!10[#24] found no Phpcs errors and warnings.
Thank you!!
Hi,
I have addressed the remaining phpcs errors and warnings.
Please review!!!
Hi,
After reviewing patches #9 and #10, patch is applied successfully without any issues. However, there are still a few remaining PHPCS errors that need to be addressed.
command used:phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig swiper_formatter/
FILE: /swiper_formatter/src/SwiperFormatterTrait.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldDefinitionInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------
FILE: /swiper_formatter/src/Element/SwiperFormatterSettings.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------
FILE: /swiper_formatter/src/Form/SwiperFormatterForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /swiper_formatter/src/Plugin/views/style/SwiperFormatterStyle.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------
FILE: /swiper_formatter/src/Plugin/Field/FieldFormatter/SwiperFormatterEntity.php
------------------------------------------------------------------------------------------------------------------------------------------------------------FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Core\Field\Plugin\Field\FieldFormatter\EntityReferenceEntityFormatter.
------------------------------------------------------------------------------------------------------------------------------------------------------------PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /swiper_formatter/src/Plugin/Field/FieldFormatter/SwiperFormatterText.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\swiper_formatter\SwiperFormatterTrait.
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------
FILE: /swiper_formatter/swiper_formatter.module
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\Cache.
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------
Hi,
I have created the MR!.
Please review.
pray_12 → made their first commit to this issue’s fork.
Hi,
Above patch addressed the #12 comments, but there are still few errors and warnings found that need correction.