Fix the issues reported by phpcs

Patch does not apply correctly.

Rashmisoni → made their first commit to this issue’s fork.

MR Needs to update

FILE: /Users/rashmi.krishnachand/projects/drupal-d10/modules/contrib/ds/ds.module
---------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------
 748 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------

Time: 1.71 secs; Memory: 22MB

Fixed all issues, please review MR!17.

Thanks

-          'selector' => Settings::get('ds_switch_field_selector_prefix','node--view-mode-') . str_replace(['_', '.'], '-', $selector),
+          'selector' => Settings::get('ds_switch_field_selector_prefix',
+          'node--view-mode-') . str_replace(['_', '.'], '-', $selector),
         ],

When splitting code over more lines, the new lines must be correctly indented.

-              catch (\Exception $ignored) {}
+              catch (\Exception $ignored) {
+                // Empty.
+              }

Either that comment says something really helpful, or what reported is ignored. I would not add comments like that because phpcs told me it wants a comment.

/**
- * The EntityViewAlter.
+ * The Entity View Alter.
  */

The new comment is still just repeating the class name.

swentel → closed merge request !16

🐛 Fix tests and remove deprecations Active is in, so this can be worked on now!

swentel → closed merge request !14

apaderno → changed the visibility of the branch 3333814-phpcs to hidden.

apaderno → changed the visibility of the branch ds-3333814-coding_standard to hidden.

GitLab CI shows warnings/errors to be yet fixed.

Hi,
Applied MR!17 and ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ds/
Found no phpcs errors and warnings.

GitLab CI does not report any PHP_CodeSniffer warning/error.

Unless I'm doing something wrong, the patch doesn't apply at all anymore - also, there's an existing .gitlab-ci file already in the project, so the fork shouldn't contain that.

VladimirAus → changed the visibility of the branch 3333814-ds-phpcs-coding-standard to hidden.

swentel → closed merge request !17