Osaka
Account created on 28 October 2020, over 4 years ago
#

Merge Requests

More

Recent comments

🇯🇵Japan tyler36 Osaka

Hmmm ... I'm confused.

After following the instructions to fork the project, the project base already has a .gitignore.
So how do we merge out preferences with the project root?

🇯🇵Japan tyler36 Osaka

Just goning to add that Sebastian Bergmann, author of PHPUnit, is now recommending xdebug over pcov.

https://thephp.cc/articles/pcov-or-xdebug

Spoilers:

After five years of PCOV, I am returning to Xdebug. There are two reasons for this: the configuration setting xdebug.mode introduced with Xdebug 3 and the currently uncertain future of PCOV.

🇯🇵Japan tyler36 Osaka

Thank you for the update.

It works when CKeditor is set "Full HTML" but is broken when set to "Basic HTML".
I guess this is a core issue and not a problem with "easy email" module.

Thank you for pointing me in the right direction.

🇯🇵Japan tyler36 Osaka

Attempt to fix issue.

- trim username of leading and trailign spaces.
- replace other spaces with '-'.

Test with database provider also included. This should allow extra edge cases to be added if required.

🇯🇵Japan tyler36 Osaka

I submitted a PR a while ago to fresh the UI.
Doesn't seem to have gained any support.

🇯🇵Japan tyler36 Osaka

Announced in #drupal slack

:tada: New DrupalPod version released! :tada:
- Full support for Drupal 11
- Drupal core version is now determined by issue fork, to prevent conflicts when d.o issues created on a previous major version

Tested on https://www.drupal.org/project/address/issues/3440171 💬 address_update_9201() can fail if row format is not set to dynamic Active

- Drupal version reports as 11.0-dev
- address module 2.0.x-dev successfully installed and enable

🇯🇵Japan tyler36 Osaka

Considered that User #1 is special so

1. Create a new user (2)
2. Log out
3. Visit "/user/2" and check action: `/system/404?destination=/user/2`

🇯🇵Japan tyler36 Osaka

MR doesn't appear to update the "action" URL as required.

## Test

1. Install module.
2. Add "User login" block to sidebar
3. As anonymous user, attempt to visit user profile page.
4. Inspect HTML source form#user-login-form block and check action URL.

username_enumeration_prevention:1.3.0 (current behavior):
- Visit "/user/1": /system/404?destination=/user/1
- Visit "/user/55": /system/404?destination=/

username_enumeration_prevention:1.3.0 with MR:
- Visit "/user/1": /system/404?destination=/user/1
- Visit "/user/55": /system/404?destination=/

With module disabled:
- Visit "/user/1": /system/403?destination=/user/1
- Visit "/user/55": /system/404?destination=/

🇯🇵Japan tyler36 Osaka

Attempted to clarify form message.

(I had problems using Gitlab (I'm use to Github workflow). I may have commited to the wrong branch.)

🇯🇵Japan tyler36 Osaka

tyler36 made their first commit to this issue’s fork.

🇯🇵Japan tyler36 Osaka

Looks good to me.

- Appears to be using the standard Drupal template.
- Pipelines are running correctly.
- Artifacts created and are download-able.

RTBC because this adds the feature requested. #4 states #3437680 fixes PHPunit failures.

🇯🇵Japan tyler36 Osaka

tyler36 created an issue.

🇯🇵Japan tyler36 Osaka

Just tested this and I don't think it's working.

I used DrupalPod this moring to test a MR.
I checked my Git providers and git.drupalcode.org was set to api, read_user permissions.
I next deleted those permissions and logged out of Gitpod and D.O.

Following the steps in #5

1. Open https://gitpod.io/#https://git.drupalcode.org/project/drupalpod
2. Confirmed "Not Authorized" message.
3. Click "Authorize git.drupalcode.org"
4. Grant permission on popup
5. Gitpod no longer shows "Not Authorized" message.
6. Check "git.drupalcode.org" permssions on https://gitpod.io/user/integrations
7. Show "api, read_user"
8. Edit permissions to add "write_repository"
9. "write_respository" is _not_ available as an option.

Unlike #5, when I attempt to add read_repository permissions, I get an authorization popup.

🇯🇵Japan tyler36 Osaka

Reviewed on Drupal 10.2.5.

- All Kernel tests classes are now using TokenKernelTestBase.
- Drupal\Tests\token\Kernel\KernelTestBase::class is marked as depreciated.

🇯🇵Japan tyler36 Osaka

Adding note on "current" behaviour for Drupal 10.2.5 with Claro admin theme.

I have a custom entity with 2 fields:
- BaseFieldDefinition::create('timestamp')
- BaseFieldDefinition::create('timestamp')

When rendering by Drupal\Core\Entity\ContentEntityForm, they appear as such:

However, changin the definition to BaseFieldDefinition::create('datetime') and clearing the cache:

Not sure if current MR/patch updates 'timestamp' too, but I would expect them to both display the same.

🇯🇵Japan tyler36 Osaka

Sounds like a "works as designed" (don't want to add the feature).
The issue linked has a different scope, at least at the time of writing and without the fully context of the conversion you and @alexpott had.

🇯🇵Japan tyler36 Osaka

@smustgrave

I'm confused. This issue is for a config option to change button text.
You marked it as a duplicate of Update README For how to override strings Rename drupal messages Needs work which is "shortening messages"?

🇯🇵Japan tyler36 Osaka

Expanded testing section with specific instructions to update path.

🇯🇵Japan tyler36 Osaka

This seems like a great way to reduce boilerplate and help IDEs help us.

+1 #13 to follow #[Autowire] pattern
+1 #8 to tagging each parameter

🇯🇵Japan tyler36 Osaka

Remove un-paired "]" from "Defining a plugin" example

🇯🇵Japan tyler36 Osaka

Replace Drupal Console reference with Drush. Drupal Console was last updated November 11, 2019 (over 4 years ago),  and targeted Drupal 8.8.

🇯🇵Japan tyler36 Osaka

Just wanted to add a follow up.

I successfully connect the official GitLab Workflow VScode extension to https://git.drupalcode.org/ using an access token.
I was able to view open MRs and the pipeline results in VSCode. I did not test reviews, comments, pushes as I only chose basic permissions setting up the access token as a proof-of-concept.

🇯🇵Japan tyler36 Osaka

I did some more tweaking.

- return to single DDEV section after storybook
- use to include snippet for manually updating `.ddev/config.yaml`
- add note for other dockerized enviroment user

This should now include all previously given suggestions. Move to NR.

🇯🇵Japan tyler36 Osaka

Oh, it's on the MR. I wonder why I didn't get a notification for that.

🇯🇵Japan tyler36 Osaka

> Yes, I agree with @markie here.

Sorry, I do not see any comments here from @markie. What did they say?

🇯🇵Japan tyler36 Osaka

tyler36 made their first commit to this issue’s fork.

🇯🇵Japan tyler36 Osaka

Tests are failing due to un-related issue.

🇯🇵Japan tyler36 Osaka

tyler36 made their first commit to this issue’s fork.

🇯🇵Japan tyler36 Osaka

Rate your excitement about SDC in core: 1 ... 10 | N/A

10
Components have become a common industry practise with Laravel & Symfony already implemented them. Components are also the basis of many javascript frameworks.

Rate your excitement about potential contrib extending SDC: 1 ... 10 | N/A

10
The creativeness of the community never fails to impress.

Rate our documentation: 1 ... 10 | N/A

7

Did you 1️⃣ refactor existing template into a component, or did you 2️⃣ write a component from scratch? 1 | 2

1️⃣ & 2️⃣
I refactored a "scroll-to-top" component which allowed me to drop it into other projects. I have also created some components from scratch.

Rate the helpfulness of error messages encountered: 1 ... 10 | N/A

6 - seem vague but maybe my lack of understanding.

Have you tried the Storybook integration? Yes | No

Yes, I have tried Storybook integrated with mixed results. "Storybook" module feels more polished and better exp. than previous cl_server version.

Any thoughts you would like to share? The sky is the limit

Thank you to everyone that helps keep the #components slack channel active and lively.

🇯🇵Japan tyler36 Osaka

Confirmed.

I just came across this today but don't have the ability to update it.

D.O Rector module home page has typo in URL link.

- ❌ https://github.com/palatinrnet/drupal-rector
- ✅ https://github.com/palantirnet/drupal-rector

🇯🇵Japan tyler36 Osaka

@gaurav_manerkar
Seems I was on beta2; I update the summary.

@MukhtarM
Disabling the enpoint resolves the issue.
Perhaps we can improve the error message?

🇯🇵Japan tyler36 Osaka

Can not reproduce on Drupal 10.1.5 with Views Year Filter 2.1.2

## Test

1. Install Drupal 10
2. Install Views Year Filter
3. Create 3 articles with created date set as 2024-02-01, 2022-02-01, 2023-002-01
4. Create new view page ("/articles" with filter
- Filter: Content: Authored on (exposed) with "equal to" "A date in CCYY format".
5. Visit "/articles" page and enter 2023.
- View should show 1 article.
6. Search for "2023".
- View shows no results because no dates match "2023"
- No error/WSOD is displayed

🇯🇵Japan tyler36 Osaka

Can not reproduce on Drupal 10.1.5 with Views Year Filter 2.1.2

## Test

1. Install Drupal 10
2. Install Views Year Filter
3. Create 3 articles with created date set as 2024-02-01, 2022-02-01, 2023-002-01
4. Create new view page ("/articles" with filter
- Filter: Content: Authored on (exposed) with "equal to" "A date in CCYY format".
5. Visit "/articles" page and confirm filter works
6. Update view to use ajax and clear cache
7. Visit "/articles" page and confirm filter works
8. Add new filter
- Content: Published (exposed) with "equal to" "Publish status any"
9. Clear cache
10. Visit "/articles" page and confirm filters works

🇯🇵Japan tyler36 Osaka

Patch #6 does not apply to drupal/augmentor_chatgpt (1.0.0-alpha1) on Drupal 10.2.2

🇯🇵Japan tyler36 Osaka

Patch #2 fixes issue for me with Drupal 10.2.1, the Gin theme 8.x-3.0-rc8 and the Gin Layout Builder 1.0.0-rc5.

Thank you.

🇯🇵Japan tyler36 Osaka

Unable to replicate with Drupal 10.1.7 an Gutenberg 3.0@beta

However, I do get a console warning when the Gutenberg edit page is displayed:

[Violation] 'setTimeout' handler took 89ms  ...   react-dom.min.js?v=16.8.4

It doesn't seem to affect usage though.

🇯🇵Japan tyler36 Osaka

I am getting this error on Drupal 10.1.7 and Gutenberg 3.0@beta

🇯🇵Japan tyler36 Osaka

Back to NW, noticed the following error appearing under the filter settings:

Drupal\markdown\Form\ParserConfigurationForm::buildParser(): Argument #2 ($form_state) must be of type Drupal\markdown\Form\SubformStateInterface, Drupal\Core\Form\SubformState given, called in /var/www/html/web/modules/contrib/markdown/src/Form/ParserConfigurationForm.php on line 239
🇯🇵Japan tyler36 Osaka

Seem https://www.drupal.org/project/markdown/issues/3409277 🐛 Subformstate incorrect interface error Active is a duplicate but resolves the issue.

Closing as duplicate. Left a note to 3409277 to consider giving credit here for any work.

🇯🇵Japan tyler36 Osaka

Came across https://www.drupal.org/project/markdown/issues/3409277 🐛 Subformstate incorrect interface error Active which attempts to patch issue, but thedoesn't work.
Not sure if maintainer want to give credit for any work there.

I'm going to close 3409277 in favor of this because it's working.

🇯🇵Japan tyler36 Osaka

MR applies on Drupal 10.2 with Markdown 3.0.1 .

However, it changes the error message:

Declaration of Drupal\markdown\BcSupport\SubformState::getIgnoreDestination() must be compatible with Drupal\Core\Form\FormStateInterface::getIgnoreDestination(): bool in /var/www/html/web/modules/contrib/markdown/src/BcSupport/SubformState.php on line 172
🇯🇵Japan tyler36 Osaka

patch #4 worked for me.

Marking as RTBC
Bumping priority to "major" because it breaks site functionality (prevents access to content formats)

## TEST

1. Install and enable Markdown addon

composer require 'drupal/markdown:^3.0'
drush en markdown

2. Visit "/admin/config/content/formats/manage/basic_html"
- Error displays "Class Drupal\markdown\BcSupport\SubformState contains 2..."
3. Apply #4
4. Page displays correctly

Drupal-core: 10.2
Markdown: 3.0.1

🇯🇵Japan tyler36 Osaka

I updated the code with f68ff06627492e87fe6daa0988d6779b8c136a9e but it seems to be on the wrong branch.
Not sure of the best way to "undo" it and move to correct branch.

🇯🇵Japan tyler36 Osaka

Need additional clarification.

🇯🇵Japan tyler36 Osaka

Nothing to review. Changing to "Active"

🇯🇵Japan tyler36 Osaka

Patch #5 applied cleanly to on Drupal 10.1.6 with the following HTTP_client_manager versions
- 3.1
- 9.3.10

Tested multiple API calls in Drush with REPL

\Drupal::service('http_client_manager.factory')->get('pokemon_api')->Berries()
=  GuzzleHttp\Command\Result {#7614
    count: 64,
    results: [
      [
        "name" => "cheri",
        "url" => "https://pokeapi.co/api/v2/berry/1/",
      ],
...

Admin pages of API are correct and unchanged, as expected.
Thank you.

🇯🇵Japan tyler36 Osaka

MR9 allowed a newer version of openai-php/client, specifically v0.7.10

Current Drupal 10.1.x-dev 59b4475 also requires a new version.

$ composer why openai-php/client
drupal/recommended-project dev-main  requires openai-php/client (^0.7.10)      
drupal/ignition            1.0.x-dev requires openai-php/client (^0.4|^v0.7.4) 
🇯🇵Japan tyler36 Osaka

Patch #50 applied for me on Drupal 10.1.6

Before patch:
Time: 00:17.625, Memory: 6.00 MB
OK (4 tests, 46 assertions)

After patch
Time: 00:20.306, Memory: 6.00 MB
OK (4 tests, 46 assertions)

🇯🇵Japan tyler36 Osaka

Need to check compatbility against a D10 compatible environment.

Added test with PHP 8.1 & MySQL 8, D10.1

🇯🇵Japan tyler36 Osaka

The testing repo provided in the "steps to reproduce" didn't include a composer.lock file. So following the provided instruction resulted in the latest version.

🇯🇵Japan tyler36 Osaka

Thank you @phma.

That's a useful snippet.

🇯🇵Japan tyler36 Osaka

Unable to get the tests running with the demo repo

- Submit MR to fix composer setup

Now I'm getting errors:

$ OTEL_COLLECTOR=http://otel-collector:4318/v1/traces vendor/bin/phpunit --group OpenTelemetry -c web/core/phpunit.xml --filter OpenTelemetryFrontPagePerformance
...
1) Drupal\Tests\demo_umami\FunctionalJavascript\OpenTelemetryFrontPagePerformanceTest::testFrontPageColdCache
Error: Call to undefined method OpenTelemetry\SDK\Resource\ResourceInfoFactory::merge()
...
2) Drupal\Tests\demo_umami\FunctionalJavascript\OpenTelemetryFrontPagePerformanceTest::testFrontPageHotCache
Error: Call to undefined method OpenTelemetry\SDK\Resource\ResourceInfoFactory::merge()
...

Does the demo repo include the latest patch/MR? Are there other steps required?

🇯🇵Japan tyler36 Osaka

Any progress on this?
Would love to see it added.

🇯🇵Japan tyler36 Osaka

Any progress on this? Happy to review if needed.

🇯🇵Japan tyler36 Osaka

+1

DDEV is a great fit.

- https://github.com/ddev/ddev-drupal-contrib: DDEV integration for developing Drupal contrib projects.
- https://github.com/shaal/DrupalPod: Great workflow for testing and developing patches / MRs.
- 73 addons including 20 official addons (varnish, solr, redis, selenium-standalone-chrome, elasticsearch ...)
- Gitpod and Codespaces support.

It also supports Drupal 7, 8, 9, 10 (even Drupal6); we would not be locking out Developers supporting unsupported versions of Drupal (they'll update Drupal soon right?).

🇯🇵Japan tyler36 Osaka

This bug prevents Gutenberg module from being uninstalled when using webprofiler module. See #3261040

🇯🇵Japan tyler36 Osaka

Support for Drupal 8 was dropped with MR #3252014 .

Closing as fixed.

🇯🇵Japan tyler36 Osaka

tyler36 made their first commit to this issue’s fork.

🇯🇵Japan tyler36 Osaka

Remove the italics from short description.
The content-type name, is left unchanged, and displays emphasised.

Production build 0.71.5 2024