- Issue created by @mindaugasd
- Assigned to mindaugasd
- Assigned to eleonel
- π¦πΊAustralia murrayw
Eleo, do you have comments on this code suggestion?
- π―π΅Japan eleonel Itoshima π―π΅
At the time we started working on the first version of Augmentor orhanerday/open-ai was the best PHP SDK but now I can see penai-php/client is more popular and the point made by @mindaugasd about guzzle is a good one. Last time I was trying to do parallel requests and with a guzzle middleware is possible to do it in a easy and clean way.
I will upload a patch quite soon.
- Status changed to Needs review
over 1 year ago 9:14pm 16 May 2023 - π―π΅Japan eleonel Itoshima π―π΅
Please ignore the previous patch (that one is for the
augmentor_openai_gpt3
module :P). - π±πΉLithuania mindaugasd
Thanks for this feature - good idea implementing both libraries mitigating PHP 8.1 requirement.
I will test this after a few weeks or later.
Right now, only reviewed the code quickly.First thing I will test / question - does middleware work?
It may not work, because it does not define to use
\Drupal::httpClient()
client as I gave example in issue description.\OpenAI::factory()
in particular is a fresh new feature of the library enabling to do various customizations. They created this to implement various feature requests.Can library discover Drupal client automatically?
Using\OpenAI::factory()
would ensure that it will work for certain. - π―π΅Japan eleonel Itoshima π―π΅
Hi @mindaugasd, thanks for your feedback, I will answer those questions soon.
- π―π΅Japan tyler36 Osaka
Patch #6 does not apply to drupal/augmentor_chatgpt (1.0.0-alpha1) on Drupal 10.2.2
- Status changed to Needs work
10 months ago 3:22am 24 January 2024 - πΊπΈUnited States keiserjb
I installed this patch on the dev branch of the module. An issue adding additional models was committed. https://www.drupal.org/project/augmentor_chatgpt/issues/3400720 β¨ Make available the gpt4 engine on the augmentor configuration Fixed
Because the method for getting the models is different for orhanderday and openai-php, the module breaks.
- π―π΅Japan eleonel Itoshima π―π΅
@keiserjb feel free to share the patch here, on this issue.
-
eleonel β
committed e2153bec on 1.0.x
Issue #3357893 by eleonel, mindaugasd, murrayw, keiserjb: Consider using...
-
eleonel β
committed e2153bec on 1.0.x
- Status changed to Fixed
7 months ago 5:55am 2 May 2024 - π―π΅Japan eleonel Itoshima π―π΅
Compatibility with openai-php/client library pushed to the dev branch, thanks everyone.
- πΊπΈUnited States keiserjb
I'll make a new issue with the altered methods if that is still a problem.
- π―π΅Japan eleonel Itoshima π―π΅
All good @keiserjb, I pushed a fix for that too, thanks.
Automatically closed - issue fixed for 2 weeks with no activity.