Itoshima 🇯🇵
Account created on 24 February 2009, almost 16 years ago
#

Merge Requests

More

Recent comments

🇯🇵Japan eleonel Itoshima 🇯🇵

Confirmed the patch solves the issue, thank you!

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

I pushed a fix on 2.0.x branch to validate the value of $cardinality_container before calling the function.

🇯🇵Japan eleonel Itoshima 🇯🇵

Tested and merged.

🇯🇵Japan eleonel Itoshima 🇯🇵

Tested and merged.

🇯🇵Japan eleonel Itoshima 🇯🇵

Thanks for your contributions.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

Ready for review.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel created an issue.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

Ready for review.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel created an issue.

🇯🇵Japan eleonel Itoshima 🇯🇵

Thanks for your contribution

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

Thanks for your contribution.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

The File bundle is base type and is created by the Media module, that's why you can't see it listed in the media types page "/admin/structure/media", the error reported may come from a different issue.

Please share how you setup the augmentor field in your entity type.

🇯🇵Japan eleonel Itoshima 🇯🇵

Thank for your fix.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

Ready for QA

🇯🇵Japan eleonel Itoshima 🇯🇵

Thanks, ready to close.

🇯🇵Japan eleonel Itoshima 🇯🇵

Each augmentor module could provide a response with different keys, the default one is default, that means it will get the value associated to that key in the json response. You can check the key resturned in the sub-module you are using with your augmentor, check the response from the execute function in the augmentor sub-module.

We are thinking to improve this part to allow multilevel selection, see https://www.drupal.org/project/augmentor/issues/3358649#comment-15323029 Provide more flexible multi-target widget with json data Active

🇯🇵Japan eleonel Itoshima 🇯🇵

We use that widget for cases when the target field of the augmentation is a file field, for example if you do a text to speech using https://www.drupal.org/project/augmentor_google_cloud_text_to_speech you can select for example a body field as a source and then save the result in the audio field file. We didn't trying using dall-e but in theory it should works.

The error that you are getting is related to the configuration of the model in your OpenAI account, you need to grant access to the dall-e API.

🇯🇵Japan eleonel Itoshima 🇯🇵

Issue solved by https://www.drupal.org/project/project_composer/issues/3357952 📌 Improve composer.json matching Fixed

🇯🇵Japan eleonel Itoshima 🇯🇵

Thanks for your contribution.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

Thanks for your contribution.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

I created a new release branch 1.2.x to avoid breaking existing installations.

🇯🇵Japan eleonel Itoshima 🇯🇵

Thank you, I pushed a fix for that.

🇯🇵Japan eleonel Itoshima 🇯🇵

Tested and merged, thanks for your contribution.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

Tested and merged, thanks for your contribution.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

I can see you are doing a reset($choices), so that means we will have only one option always, please check https://git.drupalcode.org/project/augmentor_chatgpt/-/blob/1.0.x/src/Pl... we should support multiple choices

🇯🇵Japan eleonel Itoshima 🇯🇵

Good finding, please check if the MR that I pushed solves your issue, you could use it as a patch: https://git.drupalcode.org/project/augmentor/-/merge_requests/28.patch

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

Furthermore I think ->hasTranslation() and ->getTranslation() on $entity would be more sufficient?

The function getTranslationFromContext already checks if the the entity has a translation for the given language: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

I created a MR with a small change (now we send the langcode parameter).

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

@Anybody, we will manage that in a different issue https://www.drupal.org/project/entity_reference_display/issues/3312668 📌 Drop the support of Drupal 8 Needs work

🇯🇵Japan eleonel Itoshima 🇯🇵

Thanks everyone for the contributions, I did a bit of refactoring and I pushed the patch to the 2.0.X branch.

🇯🇵Japan eleonel Itoshima 🇯🇵

Thank you for offering to help with the Entity Reference Display module. We truly value your support and the initiative you've shown.

Currently, we have allocated more resources to manage the module effectively and do not require additional maintainers at this moment. However, we encourage you to continue contributing through issue reports and patches, which are greatly appreciated.

We're committed to improving the module's maintenance and ensuring it serves the community well. Thanks again for your understanding and continued support.

🇯🇵Japan eleonel Itoshima 🇯🇵

Is not necessary to send the protocol as an option because by default the Recombee library will use https.

🇯🇵Japan eleonel Itoshima 🇯🇵

Hi there, I wasn't able to replicate the issue using:

  • drupal/core (10.2.x-dev)
  • drupal/augmentor (dev-1.1.x 74c3aaa)
  • drupal/augmentor_chatgpt (dev-1.0.x e2153be)

Could you please upgrading the modules to the latest commits?

🇯🇵Japan eleonel Itoshima 🇯🇵

Sure, I will coordinate that for you. Thanks.

🇯🇵Japan eleonel Itoshima 🇯🇵

I think instead of removing the case for field_storage_config_edit_form we should add an extra case for field_config_edit_form, for compatibility with versions < 10.2.x. What do you think?

🇯🇵Japan eleonel Itoshima 🇯🇵

Thanks everyone for your contributions.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

Thanks everyone for your contributions.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

Thanks everyone for your contributions.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

All good @keiserjb, I pushed a fix for that too, thanks.

🇯🇵Japan eleonel Itoshima 🇯🇵

Merged, thank you.

🇯🇵Japan eleonel Itoshima 🇯🇵

eleonel made their first commit to this issue’s fork.

🇯🇵Japan eleonel Itoshima 🇯🇵

THe main augmentor module nows returns the response from the LLM respecting the format: plain text, html, json, and depending on the target field the value will be leaved (for rich text fields) as it is or converted to plain text (for plain text fields and select box, taxonomies, etc)

🇯🇵Japan eleonel Itoshima 🇯🇵

Compatibility with openai-php/client library pushed to the dev branch, thanks everyone.

Production build 0.71.5 2024