- Issue created by @fathima.asmat
- Status changed to Needs review
over 1 year ago 5:10pm 10 March 2023 - fathima.asmat London, UK
Entity repository service corrected in this patch.
- 🇩🇪Germany Anybody Porta Westfalica
@fathima.asmat could you please prepare this as MR?
Furthermore I think
->hasTranslation()and->getTranslation()on $entity would be more sufficient? - Status changed to Needs work
about 2 months ago 9:19am 3 May 2024 - First commit to issue fork.
- Merge request !10Issue #3445038: Fix schema error: variable type is integer but applied schema... → (Open) created by eleonel
- Status changed to Needs review
about 2 months ago 5:15am 10 May 2024 - 🇯🇵Japan eleonel Itoshima 🇯🇵
Furthermore I think ->hasTranslation() and ->getTranslation() on $entity would be more sufficient?
The function getTranslationFromContext already checks if the the entity has a translation for the given language: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...
I created a MR with a small change (now we send the langcode parameter).
- Status changed to Needs work
about 2 months ago 7:42am 10 May 2024 - 🇩🇪Germany Anybody Porta Westfalica
Thanks @eleonel that LGTM. Last point:
\Drupal::service('entity.repository')should be using dependency injection instead