- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 4:44am 1 February 2023 - ๐ฎ๐ณIndia Charchil Khandelwal
Charchil Khandelwal โ made their first commit to this issueโs fork.
- Assigned to Charchil Khandelwal
- ๐ฎ๐ณIndia Charchil Khandelwal
Patch #2 applied clearly, all the errors and warnings are fixed now.
- Merge request !5Issue #3338106: Drupal Coding Standards Issues | phpcs โ (Open) created by Charchil Khandelwal
- Issue was unassigned.
- ๐ฎ๐ณIndia Charchil Khandelwal
Created MR !5 for this issue, please review.
Thank You.
- Status changed to Needs work
over 1 year ago 7:15am 19 July 2023 - Open on Drupal.org โCore: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - ๐ฏ๐ตJapan tyler36 Osaka
I updated the code with f68ff06627492e87fe6daa0988d6779b8c136a9e but it seems to be on the wrong branch.
Not sure of the best way to "undo" it and move to correct branch. - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
@tyler36 The branch is correct. The problem is that the project branch has been changed since the MR was created. I will see if I can fix it.
- last update
12 months ago 4 fail - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
It seems I fixed the conflict. Now the MR can be used again.
As a side note, the commits that caused conflicts were added in ๐ Fix the issues reported by phpcs Fixed .
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
I re-run PHP_CodeSniffer for the project branch, and updated the report shown in the issue summary. There are just two warnings/errors that need to be fixed.
- Status changed to Needs review
12 months ago 9:16am 2 January 2024 - Status changed to Needs work
12 months ago 10:22pm 3 January 2024 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
(I am trying to rebase, but it seems to take too much.)
- last update
12 months ago 4 fail - Merge request !13Issue #3338106: Fix the errors/warnings reported by PHP_CodeSniffer โ (Open) created by apaderno
- last update
12 months ago 4 fail - Status changed to Needs review
12 months ago 3:10pm 4 January 2024 - Status changed to Needs work
12 months ago 5:23am 11 January 2024 - ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
I've added gitlab CI to the project and I closed ๐ Get gitlab CI passing Closed: duplicate as a duplicate of this.
It would be good to get a green run before we merge this, including for phpcs and phpstan
Thanks