🇮🇳India @samit.310@gmail.com

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @smustgrave,,

Test also added, Please review.

Thanks
Samit K.

Hi @smustgrave,

Updated the code based on your suggestion. Also updated the changes record [#3384294] → .

Thanks
Samit K.

Hi @smustgrave,

As per the changes record [#3384294] it is deprecated in 10.2.0 and will removed with 11.x, so i removed it for 11.x branch.

Thanks
Samit K.

breidert → credited samit.310@gmail.com → .

samit.310@gmail.com → created an issue.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @smustgrave,

I have update my code to Deprecate the $messageproperty, Update the title as well.

Also create the change record page https://www.drupal.org/node/3479310 → .

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @mstrelan,

I tried to find existing "remove unused params" issue related to this, not gets succeeded.

So i have created PR for the same.

Thanks
Samit K.

Hi @2dareis2do ,

Please provide steps to reproduce it.

Thanks
Samit K.

Hello @andypost,

Changes applied as per your suggestion, Please review.
Please also review https://www.drupal.org/node/3477235 →

Thanks
Samit K.

Thanks @andypost,

I am working as you suggested.

Thanks
Samit K.

Hi @m.stenta,

I have created the MR and Change records → page as well. Please review.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @dpi,

I observe a issue, that post enabling Path entity_test_external module, The URL alias field value is not getting saved while saving the entity_test_external entity.

attaching the Screenshot.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @mitsuko,

The issue you mentioned mentions fixed with MR 20 → ,

Use this MR and check. I hope you issue should be resolved. Please don't hesitate to let us know if the problem will remain.

Thanks
Samit K.

Hi @chrisfromredfin,

Mean while i have added placeholder() and addWhereExpression() in the MR, now looking the way to add regex to search the multiple fields selected in the views filter.

Meanwhile, if you can help with some ideas, it would be very helpful.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

Fixed the conflicts and refactor the test cases code,

Following test cases are getting failed, not sure why, as i am not able to view errors in the pipeline. getting The current user is not authorized to access the job log. error, Attaching the screenshot.

• phpunit (previous minor): [automatic_updates, Build]

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

I have fixed the failed phpunit test cases, Please review.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

@longwave, @smustgrave,

I guess it will be useful for new (inexperienced) developers. Description will help them what will be the use of that title field. A kind of help text.

Thanks
Samit K.

Hello,

I have fixed conflicts, failed pipeline issues, Please review.

@mstrelan The following line of code of a test was getting failed, not sure why, so i break it down and removed the container_yamls code.

      'example settings' => [
        [
          'container_yamls' => [
            DRUPAL_ROOT . '/sites/development.services.yml',
          ],
          'rebuild_access' => TRUE,
          'skip_permissions_hardening' => TRUE,
        ],
        'HyPdYHsolTJKyvFEtMMD1f4-E-Gvz8-1s1-lZya76JE',
      ],

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

Fixed the failing test cases.

Thanks
Samit K.

Hello,

I have moved #description to core/lib/Drupal/Core/Block/BlockPluginTrait.php as it seams generic.
Also changed the docblock of blockForm as it seams wrong.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

Looks like this ticket is not relevant for Drupal 11, not able to reproduce it with Drupal 11.x. Please provide the steps to reproduce it with Drupal 11.

As i am checking the code the getProviderByUrl in core/modules/media/src/OEmbed/UrlResolver.php and
fetchResource in core/modules/media/src/OEmbed/ResourceFetcher.php validate it with core/modules/media/src/Plugin/Validation/Constraint/OEmbedResourceConstraintValidator.php.

Thanks
Samit K.

Hello,

This ticket is not relevant for Drupal 11, As in Drupal 11 the shortcut is an entity and it marked translatable = TRUE. So it doesn't require any code changes.

We can easily add the translatable string of shortcut's entity name field.

Adding Screenshot for the reference.

• Content-language-and-translation-Drush-Site-Install.png
• Add-shortcut-entity-translation.png

@quietone , We can open this ticket if required for Drupal 7. Meanwhile i am closing it.

Thanks
Samit K.

Hi @smustgrave ,

It has a small difference that i introduced the BatchBuilder class to create batch.

Thanks
Samit K.

Hello,

Updated the code as per latest 11.x changes.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

Batch process for comment_user_cancel has been added.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

The comment_uri function is only been used in uri_callbackcomment entity's annotation.

As per https://www.drupal.org/project/drupal/issues/2667040 📌 Deprecate uri_callback in routes for entities Needs work ticket the uri_callback is also depricated.

In template_preprocess_comment hook $comment->permalink(); is already been used to generate Comment link.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi, I have created the MR, I also added an extra condition in viewsFormValidate that fixed following error(Also added the screenshot).

TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in array_filter() (line 185 of /var/www/html/core/modules/media_library/src/Plugin/views/field/MediaLibrarySelectForm.php).

Test case is still pending, Post observing core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaLibraryTest.php it seems not compatible with Drupal 11 as it still using create blog content permission.

One related issue is https://www.drupal.org/project/drupal/issues/3351597 🐛 [random test failure] Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest Active

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → made their first commit to this issue’s fork.

HI,

I have fixed other issue reported by GitLab pipeline, but getting some errors with PHPUnit Functional Javascript and NightWatch, Post reviewing the errors, they looks like related to core.

https://git.drupalcode.org/issue/drupal-2823541/-/jobs/2599151
https://git.drupalcode.org/issue/drupal-2823541/-/jobs/2599078

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

HI @jeffschuler,

The 4xx-response Cache tag is already there while following the Steps to reproduce You can check core/lib/Drupal/Core/EventSubscriber/ClientErrorResponseSubscriber.php, The onRespond function is used to Sets the '4xx-response' cache tag on 4xx responses.

I am also adding adding the working screenshots.

Not sure but it might be because of some other contrib modules that you are using.

My Drupal Version is 11.x and PHP is 8.3.10.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @smustgrave,

Thanks for the review, i have updated the code based on your suggestions. Also changed the previous branch 2386195-state-has-no.

Please review it again.

Thanks
Samit K.

samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no-test-coverage to hidden.

samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no to active.

samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no to hidden.

Hi @catch,

I have checked it with PHP 8.3.10 and Drupal 11.x, Not getting any issue, I have run the testcases with both with by providing Absolute Path of the class also by providing the group as well.

Looks like it is outdated, Please confirm.

Thanks
Samit K.

Hi @voleger,

The test cases are failing, The main error is following

Expectation failed for method name is "getMultiple" when invoked 2 times.
Method was expected to be called 2 times, actually called 0 times.

As i observe the getMultiple function is invoked with $this->keyValueStorage but values are asserting with $this->state.

Thanks
Samit K.

I have rebased it with latest 11.x and resolved conflicts from following files.

• core/modules/statistics/src/StatisticsSettingsForm.php
• core/modules/system/src/Form/SiteInformationForm.php

Also reverted the code of core/modules/language/src/Form/NegotiationSessionForm.php file back to 11.x, because getting following error due to failing test cases.

1)
Drupal\Tests\language\Functional\LanguageUILanguageNegotiationTest::testUILanguageNegotiation
Behat\Mink\Exception\ResponseTextException: The text "In zh-hans In zh-hans
In zh-hans" was not found anywhere in the text of the current page.
/builds/issue/drupal-3384790/vendor/behat/mink/src/WebAssert.php:907
/builds/issue/drupal-3384790/vendor/behat/mink/src/WebAssert.php:293
/builds/issue/drupal-3384790/core/tests/Drupal/Tests/WebAssert.php:979
/builds/issue/drupal-3384790/core/modules/language/tests/src/Functional/LanguageUILanguageNegotiationTest.php:433
/builds/issue/drupal-3384790/core/modules/language/tests/src/Functional/LanguageUILanguageNegotiationTest.php:413
FAILURES!
Tests: 5, Assertions: 115, Failures: 1.

Here is the reference link https://git.drupalcode.org/issue/drupal-3384790/-/jobs/2532792

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

I am not able to reproduce it with Drupal 11.x, Looks like this issue has been resolved,

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi,

We should use a new Git Branch/Tag for Drupal 10.2 and 11, As TypedConfigManagerInterface $typed_config_manager changes related to ConfigFormBase are introduced in 10.2.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @joseph.olstad,

yes I have tested it with Drupal 11.

Thanks
Samit K.

the_g_bomb → credited samit.310@gmail.com → .

Hi,

We should use a new Git Branch/Tag for Drupal 10.2 and 11, As TypedConfigManagerInterface $typed_config_manager changes related to ConfigFormBase are introduced in 10.2.

I also removed following 2 functions as they are not in use, also i18n is not exists in Drupal 11.

1. tagclouds_i18n_taxonomy_term_description
2. tagclouds_i18n_taxonomy_vocabulary_description

Thanks
Samit K.

samit.310@gmail.com → changed the visibility of the branch project-update-bot-only to hidden.

samit.310@gmail.com → made their first commit to this issue’s fork.

Fix conflicts and chnages in test file with D11 compatibility.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → changed the visibility of the branch project-update-bot-only to hidden.

samit.310@gmail.com → made their first commit to this issue’s fork.

We should use a new Git Branch/Tag for Drupal 10.2 and 11, As TypedConfigManagerInterface $typed_config_manager changes related to ConfigFormBase are introduced in 10.2.

Thanks
Samit K.

samit.310@gmail.com → created an issue.

Hi @rodrigoaguilera,

if 1.7 version is dropping support for Drupal < 10.2, this will also works.

+1 for ready for release.

Thanks
Samit K.

We should use a new Git Branch for Drupal 10.2 and 11, As TypedConfigManagerInterface $typed_config_manager changes related to ConfigFormBase are introduced in 10.2.

Thanks
Samit K.

samit.310@gmail.com → changed the visibility of the branch project-update-bot-only to hidden.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → created an issue.

Hi @Liam Morland,

Issue fixed, also fixed Creation of dynamic property issue and phpstan error as well.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

fixed test cases. Please review.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

The Drupal 11 compatibility fixes has been done. Please review the changes.

Thanks
Samit K.