🇮🇳India @samit.310@gmail.com

Hello,

The comment_uri function is only been used in uri_callbackcomment entity's annotation.

As per https://www.drupal.org/project/drupal/issues/2667040 📌 Deprecate uri_callback in routes for entities Needs work ticket the uri_callback is also depricated.

In template_preprocess_comment hook $comment->permalink(); is already been used to generate Comment link.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi, I have created the MR, I also added an extra condition in viewsFormValidate that fixed following error(Also added the screenshot).

TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in array_filter() (line 185 of /var/www/html/core/modules/media_library/src/Plugin/views/field/MediaLibrarySelectForm.php).

Test case is still pending, Post observing core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaLibraryTest.php it seems not compatible with Drupal 11 as it still using create blog content permission.

One related issue is https://www.drupal.org/project/drupal/issues/3351597 🐛 [random test failure] Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest Active

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → made their first commit to this issue’s fork.

HI,

I have fixed other issue reported by GitLab pipeline, but getting some errors with PHPUnit Functional Javascript and NightWatch, Post reviewing the errors, they looks like related to core.

https://git.drupalcode.org/issue/drupal-2823541/-/jobs/2599151
https://git.drupalcode.org/issue/drupal-2823541/-/jobs/2599078

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

HI @jeffschuler,

The 4xx-response Cache tag is already there while following the Steps to reproduce You can check core/lib/Drupal/Core/EventSubscriber/ClientErrorResponseSubscriber.php, The onRespond function is used to Sets the '4xx-response' cache tag on 4xx responses.

I am also adding adding the working screenshots.

Not sure but it might be because of some other contrib modules that you are using.

My Drupal Version is 11.x and PHP is 8.3.10.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @smustgrave,

Thanks for the review, i have updated the code based on your suggestions. Also changed the previous branch 2386195-state-has-no.

Please review it again.

Thanks
Samit K.

samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no-test-coverage to hidden.

samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no to active.

samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no to hidden.

Hi @catch,

I have checked it with PHP 8.3.10 and Drupal 11.x, Not getting any issue, I have run the testcases with both with by providing Absolute Path of the class also by providing the group as well.

Looks like it is outdated, Please confirm.

Thanks
Samit K.

Hi @voleger,

The test cases are failing, The main error is following

Expectation failed for method name is "getMultiple" when invoked 2 times.
Method was expected to be called 2 times, actually called 0 times.

As i observe the getMultiple function is invoked with $this->keyValueStorage but values are asserting with $this->state.

Thanks
Samit K.

I have rebased it with latest 11.x and resolved conflicts from following files.

• core/modules/statistics/src/StatisticsSettingsForm.php
• core/modules/system/src/Form/SiteInformationForm.php

Also reverted the code of core/modules/language/src/Form/NegotiationSessionForm.php file back to 11.x, because getting following error due to failing test cases.

1)
Drupal\Tests\language\Functional\LanguageUILanguageNegotiationTest::testUILanguageNegotiation
Behat\Mink\Exception\ResponseTextException: The text "In zh-hans In zh-hans
In zh-hans" was not found anywhere in the text of the current page.
/builds/issue/drupal-3384790/vendor/behat/mink/src/WebAssert.php:907
/builds/issue/drupal-3384790/vendor/behat/mink/src/WebAssert.php:293
/builds/issue/drupal-3384790/core/tests/Drupal/Tests/WebAssert.php:979
/builds/issue/drupal-3384790/core/modules/language/tests/src/Functional/LanguageUILanguageNegotiationTest.php:433
/builds/issue/drupal-3384790/core/modules/language/tests/src/Functional/LanguageUILanguageNegotiationTest.php:413
FAILURES!
Tests: 5, Assertions: 115, Failures: 1.

Here is the reference link https://git.drupalcode.org/issue/drupal-3384790/-/jobs/2532792

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

I am not able to reproduce it with Drupal 11.x, Looks like this issue has been resolved,

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi,

We should use a new Git Branch/Tag for Drupal 10.2 and 11, As TypedConfigManagerInterface $typed_config_manager changes related to ConfigFormBase are introduced in 10.2.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @joseph.olstad,

yes I have tested it with Drupal 11.

Thanks
Samit K.

the_g_bomb → credited samit.310@gmail.com → .

Hi,

We should use a new Git Branch/Tag for Drupal 10.2 and 11, As TypedConfigManagerInterface $typed_config_manager changes related to ConfigFormBase are introduced in 10.2.

I also removed following 2 functions as they are not in use, also i18n is not exists in Drupal 11.

1. tagclouds_i18n_taxonomy_term_description
2. tagclouds_i18n_taxonomy_vocabulary_description

Thanks
Samit K.

samit.310@gmail.com → changed the visibility of the branch project-update-bot-only to hidden.

samit.310@gmail.com → made their first commit to this issue’s fork.

Fix conflicts and chnages in test file with D11 compatibility.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → changed the visibility of the branch project-update-bot-only to hidden.

samit.310@gmail.com → made their first commit to this issue’s fork.

We should use a new Git Branch/Tag for Drupal 10.2 and 11, As TypedConfigManagerInterface $typed_config_manager changes related to ConfigFormBase are introduced in 10.2.

Thanks
Samit K.

samit.310@gmail.com → created an issue.

Hi @rodrigoaguilera,

if 1.7 version is dropping support for Drupal < 10.2, this will also works.

+1 for ready for release.

Thanks
Samit K.

We should use a new Git Branch for Drupal 10.2 and 11, As TypedConfigManagerInterface $typed_config_manager changes related to ConfigFormBase are introduced in 10.2.

Thanks
Samit K.

samit.310@gmail.com → changed the visibility of the branch project-update-bot-only to hidden.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → created an issue.

Hi @Liam Morland,

Issue fixed, also fixed Creation of dynamic property issue and phpstan error as well.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

fixed test cases. Please review.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

The Drupal 11 compatibility fixes has been done. Please review the changes.

Thanks
Samit K.

Not sure why, but phpunit test cases was getting failed because of $anonymousSettings['user_login_path'] = '<front>';,
So i changes it to $anonymousSettings['user_login_path'] = '/';.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @Uroki,

I am trying it to reproduce it with Drupal 11.x, it is wotking as expected, looks like it it is not relate to 11.x branch. Can you please share all the reproducible steps here.

Thanks
Samit K.

Hi,

Issue is already fixed with 3.0.x.

Thanks
Samit K.

Rerolled with 11.x branch, only one phpunit https://git.drupalcode.org/issue/drupal-3390193/-/jobs/2285879 issue is remaining.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → created an issue.

Hi @heddn,

Rebased with 4.x, Please review.

Thanks
Samit K.

Fixed failed phpunit test cases.

Thanks
Samit K.

larowlan → credited samit.310@gmail.com → .

samit.310@gmail.com → changed the visibility of the branch 3450175-typeerror-fieldtypepluginmanagercreatefielditem-called to hidden.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @smustgrave, @BramDriesen,

One issue, I found is that the user is not getting saved in edit mode, getting the error message 'Email field is required.', Also while saving the new user, user is getting created but Email address is not getting saved. The mail column has the null value in DB for that newly created user.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → changed the visibility of the branch 3446788-add-metadata-to to hidden.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @handkerchief,

Agree with your point, but here the idea is the only trusted or some specific user roles have this permission Use the site in maintenance mode(access site in maintenance mode).

The functionality will remain the same for other users, meaning whenever the maintenance mode will on all the users except those with the above permission will logout.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

HI,

We have permission provided by Drupal Use the site in maintenance mode(access site in maintenance mode) that allow any user to work on maintenance mode, A simple change can fix this user logout issue,

Here all the users who have Use the site in maintenance mode(access site in maintenance mode) permission, will not logout if the site goes to maintenance mode.

Here is the PR link: https://git.drupalcode.org/project/drupal/-/merge_requests/8876/diffs

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @dmytro.chornyi,

I verified it both in 10.2.x and 11.x, i am not able to reproduce it at my end, I added following code in sites/development.services.yml

twig.config:
    debug: true
    auto_reload: true

Also checked all the check-boxes on admin/config/development/settings page. Adding screenshot for the reference.

It might me the Theme issue. Can you please share all the details like the theme name etc.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → made their first commit to this issue’s fork.

MR added with new branch 3456871-support-null-services-fix against 11.x

Thanks
Samit K.

samit.310@gmail.com → changed the visibility of the branch 3456871-support-null-services to hidden.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → made their first commit to this issue’s fork.

MR added for Drupal 11 support, also modify some PHPunit test cases, Onlyone test case is failing.

https://git.drupalcode.org/issue/access_unpublished-3458066/-/jobs/2141954

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

Only one phpunit test case is failing,
https://git.drupalcode.org/issue/images_optimizer-3458252/-/jobs/2122230

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi,
Above code is already changed in 8.x-1.x branch.

Thanks
Samit K.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → created an issue.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → made their first commit to this issue’s fork.