larowlan → credited samit.310@gmail.com → .
samit.310@gmail.com → changed the visibility of the branch 3450175-typeerror-fieldtypepluginmanagercreatefielditem-called to hidden.
samit.310@gmail.com → made their first commit to this issue’s fork.
Hi @smustgrave, @BramDriesen,
One issue, I found is that the user is not getting saved in edit mode, getting the error message 'Email field is required.', Also while saving the new user, user is getting created but Email address is not getting saved. The mail column has the null value in DB for that newly created user.
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → changed the visibility of the branch 3446788-add-metadata-to to hidden.
samit.310@gmail.com → made their first commit to this issue’s fork.
Hi @handkerchief,
Agree with your point, but here the idea is the only trusted or some specific user roles have this permission Use the site in maintenance mode(access site in maintenance mode).
The functionality will remain the same for other users, meaning whenever the maintenance mode will on all the users except those with the above permission will logout.
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
HI,
We have permission provided by Drupal Use the site in maintenance mode(access site in maintenance mode) that allow any user to work on maintenance mode, A simple change can fix this user logout issue,
Here all the users who have Use the site in maintenance mode(access site in maintenance mode) permission, will not logout if the site goes to maintenance mode.
Here is the PR link: https://git.drupalcode.org/project/drupal/-/merge_requests/8876/diffs
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
Hi @dmytro.chornyi,
I verified it both in 10.2.x and 11.x, i am not able to reproduce it at my end, I added following code in sites/development.services.yml
twig.config:
debug: true
auto_reload: true
Also checked all the check-boxes on admin/config/development/settings page. Adding screenshot for the reference.
It might me the Theme issue. Can you please share all the details like the theme name etc.
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
MR added with new branch 3456871-support-null-services-fix against 11.x
Thanks
Samit K.
samit.310@gmail.com → changed the visibility of the branch 3456871-support-null-services to hidden.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
MR added for Drupal 11 support, also modify some PHPunit test cases, Onlyone test case is failing.
https://git.drupalcode.org/issue/access_unpublished-3458066/-/jobs/2141954
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
Only one phpunit test case is failing,
https://git.drupalcode.org/issue/images_optimizer-3458252/-/jobs/2122230
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
Hi,
Above code is already changed in 8.x-1.x branch.
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → created an issue.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
HI @uttam,
Fixed, Pleae review again.
Thanks
Samit K.
samit.310@gmail.com → changed the visibility of the branch project-update-bot-only to hidden.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
I Created a new MR(with new branch) against 11.x, as per my analysis it should be a small 1 to 2 line fix, Please review it,
It has 1 phpstan error, ideally it should not be there as save() function has {@inheritdoc} comment block.
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
As it is dependent on mailsystem module, Git Tag for Drupal 11 is not available yet for mailsystem, we have to wait till.
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → changed the visibility of the branch 3415921-add-accesscheck-call to hidden.
samit.310@gmail.com → made their first commit to this issue’s fork.
Hello,
I checked it on Both Drupal 10.2.7 with Commerce 8.x-2.39 also validated it in Drupal 11, it is working as expected. Looks like no need to do any code changes in Drupal 10 and Drupal 11.
Please provide reproducible steps for Drupal 10 or Drupal 11 if some once facing it.
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → changed the visibility of the branch 3423775-symfony-mailer-description to hidden.
samit.310@gmail.com → changed the visibility of the branch 10.2.x to hidden.
samit.310@gmail.com → made their first commit to this issue’s fork.
Adding interdiff as well.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
I reviewed this there are some issues related to Facets → Module, as it is not converted to Drupal 11 yet.
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
Hi @smustgrave,
I have changed it to existing MR, Please review.
https://git.drupalcode.org/project/stage_file_proxy/-/merge_requests/72
Thanks
Samit K.
samit.310@gmail.com → changed the visibility of the branch 3434751-automated-drupal-11-fix to hidden.
samit.310@gmail.com → changed the visibility of the branch 3434751-automated-drupal-11 to active.
Hi @smustgrav,
actually the 3434751-automated-drupal-11 branch is not sync with 3.0.x, initially i used that branch and founds so much conflicts, so open a new MR for the sam.
Thanks
Samit K.
samit.310@gmail.com → changed the visibility of the branch 3434751-automated-drupal-11 to hidden.
samit.310@gmail.com → changed the visibility of the branch 3434751-automated-drupal-11 to active.
samit.310@gmail.com → changed the visibility of the branch 3434751-automated-drupal-11 to hidden.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
HI @fms,
Do we need a new ticket for this feature request?
Thanks
Samit K.
It is working at my end, i am getting the Node view counts in all the languages,
The only problem I found is, all the languages have the same count,
For Example: If node id 1 in English have 10 count, then I translate node i to another language it also have the same count 10, ideally it should starts from 1.
@fms please suggest.
Thanks
Samit K.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → changed the visibility of the branch 3425947-a to hidden.
samit.310@gmail.com → made their first commit to this issue’s fork.
samit.310@gmail.com → made their first commit to this issue’s fork.
Hi @smustgrave,
Please review.
Thanks
Samit K.
samit.310@gmail.com → changed the visibility of the branch 3123224-replace-non-test-usages to hidden.
samit.310@gmail.com → made their first commit to this issue’s fork.