- Status changed to Needs review
over 1 year ago 6:19pm 30 July 2023 - last update
over 1 year ago 29,908 pass - Status changed to Needs work
over 1 year ago 8:21pm 30 July 2023 - ๐บ๐ธUnited States smustgrave
Still needs a test case.
Typically with these type of issues just putting an isset() or empty() check is masking a deeper issue that should be determined.
- last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 28,526 pass - ๐ง๐ดBolivia alvarito75 Cochabamba
I have the same issue.
This is my setup:
- Drupal 10.1.3
- PHP 8.1.14
- MariaDB: 10.4.22-MariaDB-1:10.4.22+maria~focal
- Admin theme is Gin
- CKEditor5
By the way, patch #30 is already included in this Drupal version. And I'm upgrading from CKEditor 4 to CKEditor 5.
- ๐ง๐ดBolivia xjkwak
I was able to reproduce the issue only with Twig Debug enabled.
- last update
about 1 year ago Patch Failed to Apply 50:11 48:08 Running- last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 28,526 pass - last update
about 1 year ago 28,526 pass - ๐ท๐ดRomania ion.macaria Bucharest, ๐ท๐ด
Reroll patch for drupal 10.1.7.
- last update
11 months ago Custom Commands Failed - last update
11 months ago Custom Commands Failed - ๐ท๐ดRomania ion.macaria Bucharest, ๐ท๐ด
Fix missed used statements. Drupal 10.1.7
- last update
11 months ago 29,722 pass 44:58 41:35 Running- ๐ฎ๐ณIndia zeeshan_khan
@ion.macaria - Can you provide interdiff from #30 as it looks same to me.
Also we still need test case for this as mentioned by @smustgrave in #23
Also we need to update the code as suggested in #28 by @smustgrave I agree that using empty() check in this kind situation can cause deeper problems. - ๐จ๐ฆCanada joseph.olstad
patch #34 applies cleanly to Drupal 10.2.3 and fixes the bug.
Needed this after an upgrade from 10.0.11 - ๐ง๐ชBelgium herved
This seems to relate/overlap with ๐ Error: Call to a member function uuid() on null in Drupal\media_library\MediaLibraryEditorOpener->getSelectionResponse() (line 72 of /app/docroot/core/modules/media_library/src/MediaLibraryEditorOpener.php) Needs work .
The MR there seems to fix it but I haven't compared the code of both solutions yet. - ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- Merge request !94133303889: Error: Call to a member function โ (Open) created by samit.310@gmail.com
- Status changed to Needs review
2 months ago 12:50pm 4 September 2024 - ๐ฎ๐ณIndia samit.310@gmail.com
Hi, I have created the MR, I also added an extra condition in
viewsFormValidate
that fixed following error(Also added the screenshot).TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in array_filter() (line 185 of /var/www/html/core/modules/media_library/src/Plugin/views/field/MediaLibrarySelectForm.php).
Test case is still pending, Post observing
core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaLibraryTest.php
it seems not compatible with Drupal 11 as it still usingcreate blog content
permission.One related issue is https://www.drupal.org/project/drupal/issues/3351597 ๐ [random test failure] Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest Active
Thanks
Samit K. - Status changed to Needs work
2 months ago 1:11pm 4 September 2024 - ๐บ๐ธUnited States smustgrave
Previously tagged for tests and issue summary both appear still needed.