Confirming #141 patch works for
- Drupal 10.2.6
- PHP 8.2.12
So far for Drupal 10.2.4 patch #6 worked
alvarito75 → created an issue.
Patch #18 also fixed the problem
Here is the project version that might help others:
- Drupal 10.2.2
- PHP 8.2.12
- Gin theme 3.0@RC
For me Fullscreen is Safari is working, and I have this setup:
- Drupal core updated from D 10.2.1 => D 10.2.2
- Gin Admin Theme updated from 3.0.0-rc7 => 3.0.0-rc8
Thanks, @saschaeggi, may you please add the original ticket here so I can follow that work?
I appreciate any help you can provide.
In the meantime, I created a simple patch.
alvarito75 → created an issue.
alvarito75 → created an issue.
I have the same issue.
This is my setup:
- Drupal 10.1.3
- PHP 8.1.14
- MariaDB: 10.4.22-MariaDB-1:10.4.22+maria~focal
- Admin theme is Gin
- CKEditor5
By the way, patch #30 is already included in this Drupal version. And I'm upgrading from CKEditor 4 to CKEditor 5.
Thanks, @phma for the patch
After my test, I can verify it is working for most cases but still have edge cases, below are the versions of the project I'm working on:
Drupal Setup
- Gin theme 8.x-3.0-rc5
- Gin Layout Builder 1.0.0-rc4
- Drupal 10.1.2
The edge case is for an autocomplete field, please see the attached image.
I'll continue testing
I'm still having these issues.
What I did recently:
- Gin theme updated from to RC4 -> RC5
- Gin 8.x-3.0-rc5
- Still Drupal 10.1.2
These tests I did might help understand the issue in more use cases, please see attached images:
- Adding a block
- Working with sortable content
- I added a pair of images when the CSS/JS Aggregation is turned off
- I added a pair of images when the CSS/JS Aggregation is turned on
- The images are about adding blocks and editing content with sortable capabilities
Some things I tried:
- I created new custom libraries and copied the Gin LB libraries into my custom module and I turned on the CSS/JS Aggregation to see if the issue was still there and I got the same problem
- I debugged the CSS and JS in Firefox but it seems CSS/JS from Gin LB is not being aggregated
- Also I noticed that for the Gin LB CSS, the variables are not working properly in Chrome but they work well in Firefox
I hope this info is useful while I'll be
Btw I just saw another release for Gin, I'll test it and let you know
I am facing issues with Layout Builder in Drupal 10.1.2
I agree with what @mherchel stated because Layout Builder is in the core for D10+
ckrina → credited alvarito75 → .
alvarito75 → created an issue.
baluv3 → credited alvarito75 → .
There is a new patch created based on the current branch of Gin Layout Builder 1.0.0-rc4
I created a patch to remove an edge case since this only happens with a block with multiple autocomplete field
I have the same issue :/
Thanks to everyone
I still have this issue but not in all places though, I attached screenshots
My setup
- Drupal 10.1.1
- Gin Layout Builder 1.0.0-rc4
I have the same issue on Drupal 9.5.3.
My setup:
- PHP 8.1.14
- Module version: 8.x-5.1
#5 solves it, thank you!