- last update
over 1 year ago 39 pass - 🇧🇴Bolivia alvarito75 Cochabamba
Patch #18 also fixed the problem
Here is the project version that might help others:
- Drupal 10.2.2
- PHP 8.2.12
- Gin theme 3.0@RC
- Status changed to Needs work
7 months ago 3:58am 31 May 2024 - 🇦🇺Australia acbramley
Thank you for your contribution. This issue currently does not meet the Contribution guidelines which are required to get this change committed.
- Status changed to Needs review
7 months ago 4:01pm 31 May 2024 - Status changed to RTBC
7 months ago 4:02pm 31 May 2024 - 🇨🇦Canada joseph.olstad
Existing test coverage should ensure that this doesn't cause regression.
It's been 6 years without test coverage. Would be good to fix this.
- Merge request !87Issue #3004705 by toiletfinder.com, oleh.tarasiuk, simbaw, Kevin W,... → (Open) created by joseph.olstad
- 🇨🇦Canada joseph.olstad
patch #11 is the one we've been using for years.
patch #18 and #21 failed phpstan, both of these patches are a bit tough on the eyes.
patch #11 passes tests, it's a one line fix.
6 years now and counting.
- Status changed to Needs work
7 months ago 11:16pm 2 June 2024 - 🇦🇺Australia acbramley
Existing test coverage should ensure that this doesn't cause regression.
We need test coverage for the bug fix.
It should go into 2.x first.
- 🇺🇸United States recrit
@joseph.olstad using the automatically generate patch is dangerous since it is actively updated. A static patch is preferred to avoid any issues with new code pushed to the MR
- 🇨🇦Canada joseph.olstad
The actual patch code it hasn't changed in several years.
with that said, all that is left is test coverage and that won't affect anyone using it.
