- Merge request !2851Issue #2264739: Allow multiple field widgets to not use tabledrag β (Open) created by pasqualle
- π³π±Netherlands anneke_vde
Attached is the patch version of MR 450 for those working with composer patches.
- π¬π§United Kingdom Driskell
Hi @anneke_vde
You can access the composer patch you need for an MR by visiting the changes tab and adding β.diffβ or β.patchβ to the end of the url: https://git.drupalcode.org/project/drupal/-/merge_requests/2851/diffs.diff - π¨π΄Colombia jedihe
@Driskell: the .diff url is very practical, but I think it'll return a different diff as the MR gets commits pushed. In order to ensure a build doesn't end up having code you didn't properly test/review, it's better to have an actual patch file.
- π¬π§United Kingdom Driskell
@jedihe Ah quite right! I see now, thanks. I normally download the patch and commit it and hadn't considered that approach of direct URL. I'll edit my comment to clarify in case others see it.
- π³π±Netherlands anneke_vde
Thanx for the clarification, that was indeed the reason why I uploaded the patch file.
- First commit to issue fork.
- πͺπΈSpain rodrigoaguilera Barcelona
Added a rebase removing the template for "stable" (only stable9 remains in D10) and an attempt at fixing the failing test from last run.
Only did it for 10.1.x since is the only branch that is receiving features now.
Another thing the proposed code is not handling is the existing widgets that will be rendered as non-orderable after the change.
I found this change
https://git.drupalcode.org/project/drupal/-/commit/2c3f5743df1dc19515258...
That sets thetooltip
as a mandatory setting for Drupal 11.
We should something similar here:- Treat non-configured widgets (orderable is null) as orderable
- Add a entity presave that adds the default settings
Since there is no layout builder for forms modes there is no need for a hook_post_update.
- First commit to issue fork.
- last update
over 1 year ago 29,443 pass - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - π³π±Netherlands wilfred waltman
The patch did not apply on 10.2 because the field.widget.settings.language_select are moved from language.schema.yml to core.entity.schema.yml.
Here is a patch that does apply to 10.2
- π§π΄Bolivia alvarito75 Cochabamba
Confirming #141 patch works for
- Drupal 10.2.6
- PHP 8.2.12
- π¬π§United Kingdom mjmorley
The patch from #141 works well for me on Drupal 10.2.7 and PHP 8.2.12. I have extended the patch to only build the _weight field when "orderable" is set to TRUE.
- π¬π§United Kingdom mjmorley
My last patch missed the template /core/modules/system/templates/field-multiple-value-without-order-form.html.twig so this one adds that in