Account created on 21 March 2011, about 14 years ago
  • QA Engineer at GizraΒ  …
#

Merge Requests

More

Recent comments

πŸ‡­πŸ‡ΊHungary balagan

I can confirm this snippet fixes the broken progress tracker.

πŸ‡­πŸ‡ΊHungary balagan

Not sure if this was originally is a bug report or a support request, but now ran into the issue of the pager date format set in the view being ignored. After debugging it turned out that adding arrays with the + operator ignored the values from the second array, so I have replaced this part with an array_merge().

πŸ‡­πŸ‡ΊHungary balagan

balagan β†’ made their first commit to this issue’s fork.

πŸ‡­πŸ‡ΊHungary balagan

Just rerolled patch from comment #25

πŸ‡­πŸ‡ΊHungary balagan

Reroll for 1.1.2.

πŸ‡­πŸ‡ΊHungary balagan

Thanks for the patch. It's working fine with metatag 2.1.0. Just adding my 2 cents that using the small select box is not the best UX.

πŸ‡­πŸ‡ΊHungary balagan

Removed the custom close function, as it interferes with the default close behavior, and doesn't remove the lock from the body tag, when closing the dialog by clicking on the close icon.

πŸ‡­πŸ‡ΊHungary balagan

This is already merged in 2.4.

πŸ‡­πŸ‡ΊHungary balagan

Closing the jquery dialogs doesn't clear the body scroll locks, so I made some changes to call close() on Drupal.dialog.
Changed dialogClass to classes according to https://www.drupal.org/node/3440844 β†’

πŸ‡­πŸ‡ΊHungary balagan

With D10.3.1 this is what works for me.

πŸ‡­πŸ‡ΊHungary balagan

Missed the patch in #4. Here you go.

πŸ‡­πŸ‡ΊHungary balagan

For me it did not solve the problem. Under D10.3.1 the active menu item has wrong background.


Attaching a patch that solves my problem Under D10.3.1.

πŸ‡­πŸ‡ΊHungary balagan

Related issue https://www.drupal.org/project/drupal/issues/3344200 πŸ› PathBasedBreadcrumbBuilder needs to be able to exclude pointless paths Needs work changes the logic that is modified here, and seems to solve the problem we encountered.

πŸ‡­πŸ‡ΊHungary balagan

Confirming that patch in #5 solves that problem, but probably that should be a separate issue.

πŸ‡­πŸ‡ΊHungary balagan

Reroll of patch in https://www.drupal.org/project/drupal/issues/3439580#comment-15549200 πŸ“Œ Make drupal.tableheader only use CSS for sticky table headers Needs review for D 10.2.6

πŸ‡­πŸ‡ΊHungary balagan

Just rerolled patch #15 for D10.2.5.

πŸ‡­πŸ‡ΊHungary balagan

Rerolled the patch in #34 to apply to 5.0.4.

πŸ‡­πŸ‡ΊHungary balagan

Removing the message.messages route from the message.routing.yml file and its link from the message.links.yml file solves the problem.
The Message tab displays, linking to the view, and the link from the toolbar dropdown is removed.

πŸ‡­πŸ‡ΊHungary balagan

The problem is, currently the Messages tab under /admin/content doesn't display. As the view is optional, maybe should revert this change and keep the different paths?

πŸ‡­πŸ‡ΊHungary balagan

Now we have a view with path: 'admin/content/message' and this path is also specified in the message.routing.yml file

message.messages:
  path: '/admin/content/message'
  defaults:
    _title: 'Messages'
    _entity_list: 'message'
  requirements:
    _permission: 'overview messages'
πŸ‡­πŸ‡ΊHungary balagan

I have rerolled patch #47 against 10.2.x
No conflicts were shown when rebasing.

πŸ‡­πŸ‡ΊHungary balagan

Applying patch in #42 gives me the following error

error: patch fragment without header at line 1127: @@ -23,7 +26,11 @@ class DateTimeFieldTest extends DateTestBase {

I suppose I also got the error in #44, because now I see that I was actually using a local file 3185750-44.patch for patching. I suppose I have forgotten to get back to the issue and attach it. I have renamed it to 3185750-47.patch and will upload it here.

πŸ‡­πŸ‡ΊHungary balagan

balagan β†’ made their first commit to this issue’s fork.

πŸ‡­πŸ‡ΊHungary balagan

Also, in the book.module file book_form_node_form_alter() function the 'Change book (update list of parents)' submit button is placed in the forms, if user has 'administer book outlines' permission, disregarding the allowed node type.

πŸ‡­πŸ‡ΊHungary balagan

Reroll of patch 2862291-34.patch

πŸ‡­πŸ‡ΊHungary balagan

Well, this problem doesn't occur on a clean D10 install, so closing this issue and sorry for the confusion.

πŸ‡­πŸ‡ΊHungary balagan

Just removed background:none, which was responsible for this.

.ui-widget {
  background: none;
}
πŸ‡­πŸ‡ΊHungary balagan

Rerolled the patch, as it didn't apply anymore.

πŸ‡­πŸ‡ΊHungary balagan

I confirm that applying the patch in #4 solves the problem. Edit/Delete operation buttons only display for eligible translations.

πŸ‡­πŸ‡ΊHungary balagan

I confirm that this error doesn't occur in 8.x-1.2

πŸ‡­πŸ‡ΊHungary balagan

Attached a patch that displays superscript on the widget summary form and the edit form.

πŸ‡­πŸ‡ΊHungary balagan

hook_entity_field_info and hook_entity_field_info_alter are probably hook_entity_base_field_info and ..._alter
 

πŸ‡­πŸ‡ΊHungary balagan

I have simplified the condition a bit more.
$bid = !empty($entity->book['bid']) ? $entity->book['bid'] : 0;

πŸ‡­πŸ‡ΊHungary balagan

Rerolled the patch in https://www.drupal.org/project/entity_clone/issues/3076356#comment-14715404 ✨ Book Pages Clone Needs work to apply for the 2.x branch.

Meanwhile looking at the code I think the condition at line 117 is not what really what we want.

I have changed
$bid = isset($entity->book) && empty($entity->book['bid']) ? 0 : $entity->book['bid'];
to
$bid = !isset($entity->book) || empty($entity->book['bid']) ? 0 : $entity->book['bid'];

πŸ‡­πŸ‡ΊHungary balagan

Just created a patch from the PR. Works fine.

Production build 0.71.5 2024