🇭🇺Hungary @balagan

Reroll of patch in https://www.drupal.org/project/drupal/issues/3439580#comment-15549200 📌 Make drupal.tableheader only use CSS for sticky table headers Needs review for D 10.2.6

Just rerolled patch #15 for D10.2.5.

Rerolled the patch in #34 to apply to 5.0.4.

Removing the message.messages route from the message.routing.yml file and its link from the message.links.yml file solves the problem.
The Message tab displays, linking to the view, and the link from the toolbar dropdown is removed.

The problem is, currently the Messages tab under /admin/content doesn't display. As the view is optional, maybe should revert this change and keep the different paths?

Now we have a view with path: 'admin/content/message' and this path is also specified in the message.routing.yml file

message.messages:
  path: '/admin/content/message'
  defaults:
    _title: 'Messages'
    _entity_list: 'message'
  requirements:
    _permission: 'overview messages'

balagan → created an issue.

I have rerolled patch #47 against 10.2.x
No conflicts were shown when rebasing.

Applying patch in #42 gives me the following error

error: patch fragment without header at line 1127: @@ -23,7 +26,11 @@ class DateTimeFieldTest extends DateTestBase {

I suppose I also got the error in #44, because now I see that I was actually using a local file 3185750-44.patch for patching. I suppose I have forgotten to get back to the issue and attach it. I have renamed it to 3185750-47.patch and will upload it here.

balagan → made their first commit to this issue’s fork.

balagan → created an issue.

balagan → created an issue.

balagan → created an issue.

balagan → created an issue.

Also, in the book.module file book_form_node_form_alter() function the 'Change book (update list of parents)' submit button is placed in the forms, if user has 'administer book outlines' permission, disregarding the allowed node type.

Reroll off patch #42

Reroll of patch 2862291-34.patch

Well, this problem doesn't occur on a clean D10 install, so closing this issue and sorry for the confusion.

Just removed background:none, which was responsible for this.

.ui-widget {
  background: none;
}

balagan → created an issue.

Rerolled the patch, as it didn't apply anymore.

I confirm that applying the patch in #4 solves the problem. Edit/Delete operation buttons only display for eligible translations.

I confirm that this error doesn't occur in 8.x-1.2

Attached a patch that displays superscript on the widget summary form and the edit form.

balagan → created an issue.

hook_entity_field_info and hook_entity_field_info_alter are probably hook_entity_base_field_info and ..._alter
 

I have simplified the condition a bit more.
$bid = !empty($entity->book['bid']) ? $entity->book['bid'] : 0;

Rerolled the patch in https://www.drupal.org/project/entity_clone/issues/3076356#comment-14715404 ✨ Book Pages Clone Needs review to apply for the 2.x branch.

Meanwhile looking at the code I think the condition at line 117 is not what really what we want.

I have changed
$bid = isset($entity->book) && empty($entity->book['bid']) ? 0 : $entity->book['bid'];
to
$bid = !isset($entity->book) || empty($entity->book['bid']) ? 0 : $entity->book['bid'];

Just created a patch from the PR. Works fine.