Host translation shows incorrect translation of embedded entity

Patch created based on #9

Rerolled the patch, as it didn't apply anymore.

The last submitted patch, 12: entity_embed_3116547-11.patch, failed testing. View results →

Re-rolled above patch which didn't contain the reference to the TranslatableInterface

I disagree with the change of approach starting in #6. This new approach is causing tests in ContentTranslationTest to fail, since the data-langcode value doesn't match the embedded entity's language.

I think the approach in #2 was correct, since this actually fixes the data. If we use a filter to fix this, then the data on non-English languages will still use an incorrect data-langcode value, but the problem is masked while viewing the content. This would cause issues for anyone needing to manipulate the data programmatically and relying on the language code to be correct. I re-rolled #2 to apply against 1.5.0.

I also modified the ContentTranslationTest test as follows:

• Do not create a French translation right after the initial entity creation.
• Save the English node after adding an embedded entity.
• Go to the add translation route, ensure a element exists with the data-langcode set to "fr".
• Delete the embedded entity and continue tests with French embedding.

I'm not very good with tests, so this might need to be adjusted.

Found an issue with patch #15, now getting the following error on a term translation (new translation) page, for example here - /fr/taxonomy/term/193/translations/add/en/fr

Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in entity_embed_entity_translation_create() (line 369 of modules/contrib/entity_embed/entity_embed.module).

This appears to be an issue if a text field on the entity doesn't have a value. With the updated patch this issue no longer occurs.

The approach in #16 doesn't fix any existing embedded content however.