Just tested migrations for gcweb on 5.4.x and 6.1.x, both appear to be working as expected.
Some other things to test/fix
- drupal/toc_api, remove drupaloverride in composer and get working with CKE5/D11
- Test GCIntranet, ensure no JS errors and theme works as expected, with migrations
@joseph admin_toolbar.install has the admin_toolbar_update_8003() hook which uninstalls the admin_toolbar_links_access_filter module. Putting this issue back to Fixed since this is not an issue with WxT 6.1.x.
Marking this ticket as postponed since it is not clear what is causing this translation string issue.
This has now also been fixed in 5.4.x, using the new wxt_bootstrap release 8.x-8.6. I tested a fresh install of 5.4.x and the translation error is now resolved:
Looks like footnotes went through a refactoring and broke our templates. Was able to apply MR !3 and it fixed the issue. Tested against a footnote with multiple instances and seems to work as expected even with latest wet-boew and jQuery4! Merged this into wxt_bootstrap 8.x as well as the 11.1.x branch.
Thanks for everyone's help on this one!
Found an issue with patch #15, now getting the following error on a term translation (new translation) page, for example here - /fr/taxonomy/term/193/translations/add/en/fr
Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in entity_embed_entity_translation_create() (line 369 of modules/contrib/entity_embed/entity_embed.module).
This appears to be an issue if a text field on the entity doesn't have a value. With the updated patch this issue no longer occurs.
@web247 this is great! Will take a look at this shortly and merge in.
This plugin is provided in 6.1.x, although not enabled by default, but available for those that need it.
+1 RTBC
@web247 yes let's get this into 5.4.x and 6.1.x. If you re-roll the patches that would be great, I can merge them in and test. You will notice the patches in #3 also simplify the page content type, removes the sidebar and layout (layout builder).
@alok_singh can you please update ticket with steps to reproduce? Need to know how to test this fix, thanks!
@web247 5.4.x has drupal/bootstrap pinned at 3.31.0. The fix in question was added to 3.33.0 -https://git.drupalcode.org/project/bootstrap/-/blob/8.x-3.33/src/Bootstrap.php?ref_type=tags#L608
So this is fixed in WxT 6.1.x which uses drupal/bootstrap 3.35.0. We can look at upgrading bootstrap for 5.4.x next. Thanks for pointing this out!
PR created to update documentation as per your request. I will need @sylus to merge this since I don't have perms to this repo - https://github.com/drupalwxt/drupalwxt.github.io/pull/6
@alok_singh thanks for your help with this! As Joseph mentioned, can you please fix your MR to remove the indents so only the lines that have changes are displayed? Thanks!
Upgrading to 4.0.85 fixes the modal issue, so was able to remove our custom polyfill from wxt_library. PR merged and updated site-wxt accordingly.
I added wet-boew/wet-boew 4.0.85 to drupalwxt/composer-extdeps - https://github.com/drupalwxt/composer-extdeps/commit/8690d2a46f15142707bbbd4884a3a90c24ca2831
Will test and merge your PR for wxt_library now.
@joseph I added the fontawesome library as a repository to site-wxt so it should work without any additional steps - https://github.com/drupalwxt/site-wxt/blob/384fb0d41e431f6c8cab13ef026bab630b8e560f/composer.json#L58. The two modules still pending D11 versions (layout_builder_st, toc_api) have the overrides needed in site-wxt, so should be able to use site-wxt 11.1.x to test the D11 upgrade without any additional entries in composer.
I will look at wxt_library now for the wet-boew upgrade, thanks!
@web247 will be good to get another set of eyes on the 6.1.x upgrade. We have it going through QA now with one of our projects, once we fix all the issues identified then we will push out an alpha release.
Ok I see this patch in 5.4.x, changing ticket to match this version since 5.3.x is no longer supported (5.4.x is D10 LTS). This patch has been removed in 6.1.x. It makes sense to remove this patch since drupal/book is no longer in core, and a bunch of fixes were merged once it hit the contrib space. I will remove this patch from 5.4.x, for 5.3.x you can just ignore the patch in composer.json.
Ran into an issue with patch #15 where it was calling the wrong method getSource() on a File entity. New patch accounts for this.
Patch in #62 fixed my issue using core 11.1.2
@jwylarsen 5.3.x is no longer supported, changing this to 5.4.x (D10 LTS).
Fix issue reported by HC; fontawesome plugin for CKE5 missing. I had to re-roll a fontawesome patch and udpate coms configs in WxT to get this working, as well as composer changes to automatically bring in the needed library (fontawesome/fontawesome). Byt default the text formats do not include this plugin, but after fresh install all you have to do is add the plugin to a text format and it should work same as CKE4.
Tested patches #44 and #52 together, seems to work well. I am not experiencing any performance issues with content that has icons when I toggle source mode, and I am using a pretty slow VM on an old laptop. Posting a patch here that combines both of these patches together.
Fixed issue reported by AAFC; media browser dialog in CKE5 is too small. This is caused by a CSS directive in claro, which sets the max-width to 500px. This has been fixed and set to 80% max-width, pushed to wxt_bootstrap 11.1.x.
@joseph I tested your PR #313 for WxT. To completely fix the issue with entity_browser I had to make a small change to wxt_ext_media, as well as created a patch for entity_browser which is included with WxT. With all of these changes, the issue reported has been resolved, and now I can add images with entity_browser without any errors. I also merged your PR #33 for wxt_bootstrap to keep inline with upstream bootstrap changes, thanks for this!
I have just replaced 3 drupaloverrides in composer.json with their corresponding D11 versions. Now there are only two drupaloverrides remaining; layout_builder_st and toc_api.
I'm seeing the same error using 2.12.0. In my case, I have an image field using Entity browser on the user profile. When I select an image to use, I get the AJAX error reported in ticket description.
The error "Call to undefined method Drupal\media\Entity\Media::getFileUri()" occurs because Media entities do not have a getFileUri() method. Instead, we need to get the file entity from the media field.
Attached is a patch that fixes the issue for me.
joseph.olstad → credited smulvih2 → .
The MR branch was pretty old, so I rebased it on 11.x and added patch #43 on top. Fixed linting and default tests. The non-default tests are failing for unrelated reasons, so think we can ignore those.
Re-rolling patch #42 for 11.1.1
smulvih2 → made their first commit to this issue’s fork.
PR: https://git.drupalcode.org/project/safedelete/-/merge_requests/8
The following changes were made:
- Retrieve the base path dynamically using \Drupal::request()->getBasePath() and store it in a variable.
- Prepend the base path to href values (if missing) during validation to ensure consistency across environments.
smulvih2 → created an issue.
I tested the latest MR #35 and it is working for me on linkit 7.0.2, using CKE5. I am attaching the associated patch here so I can use it in my project. With the patch I can copy/past a node's URL into linkit and it provides the proper suggestion, and formats the link as expected.
@joseph thanks for the patch, this get the jQuery4 fixes into wxt_bootstrap for the local bootstrap files. This has been merged with wxt_bootstrap 11.1.x. I also added GitLab CI for wxt_bootstrap and got all tests passing. Pushed out a dev release, 11.1.x-dev.
Actually I see that the latest drupal/bootstrap 3.34 has the JS fixes for jQuery4 support, so need to update the JS files in wxt_bootstrap to use these, or remove from wxt_bootstrap and just reference the ones from drupal/bootstrap.
Here's one example JS error:
Uncaught TypeError: $.isFunction is not a function
This is coming from themes/contrib/wxt_bootstrap/js/bootstrap/tooltip.js. If I look at the latest boostrap v3.4.1, it still uses the ifFunction call. I think this will be an issue with Bootstrap 3 with jQuery4; Bootstrap 3 is not compatible with jQuery 4. Might have to fork Bootstrap 3 to get working with jQuery4, or get wet-boew upgraded to use Bootstrap 4+.
Running into some JS errors on a project, and noticed the bootstrap JS files that come with wxt_bootstrap are from v3.3.6 (2015). We should try updating these to the latest 3.4.1 (2019).
Based on feedback from #15, and because I'm using this in my distro to fix the reported error, setting this to RTBC.
This ended up being introduced by a drupal/core patch, see related issue. Updated core patch and now issue is resolved, closing ticket.
Missing two use statements in content_moderation.module, which was causing error on node create forms.
Removed dependencies on block_content_permissions and ckeditor4_codemirror from 5.4.x-dev to prepare for 6.1.x upgrade. This will allow uninstalling the following modules as part of pre-deployment steps for the upgrade:
Uninstall the following modules (pre-deployment for 6.1.x):
- block_content_permissions
- ckeditor4_codemirror
- ckeditor
Ran into the same issue as #13, although in my case it was through PageManager.php instead of Ds.php. Fixed the issue in the PR and attaching a new patch to use in my project.
Got all tests passing in GitHub and now also all tests passing with GitLab CI. Pushed out a dev release, 6.1.x-dev. Still a few known issues to resolve, and more testing (fresh install and upgrade from 5.4.x), but wanted to get a dev release out so people can start testing.
Known issues / Remaining tasks:
- Using [toc] token and saving a page results in WSOD (issue being worked on by @joseph)
- GitHub actions like
changelog.ymlandtag.ymlare failing. (will need @sylus for input here) drupalwxt/docker-scaffoldanddrupalwxt/site-wxthave been updated, but still need to look atdrupalwxt/wxt-project,drupalwxt/helm-drupal, anddrupalwxt/terraform-kubernetes-drupalwxt(will need @sylus for input here)- Need full regression of all functionality (creating nodes, CKE5 plugins, WxT migrated content, themes, etc...)
- Removal of drupaloverrides in
composer.jsonas remaining modules get stable releases for D11
I'm testing this on core 11.1.1, using toc_api from this MR, along with toc_filter 2.3.0. I'm running into an error when saving a node that is using the [toc] token, assume the error is coming from toc_api:
TypeError: Drupal\Core\Render\MetadataBubblingUrlGenerator::generateFromRoute(): Argument #2 ($parameters) must be of type array, null given, called in /var/www/html/core/lib/Drupal/Core/Url.php on line 769 in Drupal\Core\Render\MetadataBubblingUrlGenerator->generateFromRoute() (line 104 of core/lib/Drupal/Core/Render/MetadataBubblingUrlGenerator.php).
Drupal\Core\Url->toString(1) (Line: 175)
Drupal\Core\Utility\LinkGenerator->generate(Object, Object) (Line: 102)
Drupal\Core\Render\Element\Link::preRenderLink(Array)
call_user_func_array(Array, Array) (Line: 107)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725 → ', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 825)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 387)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 203)
Drupal\Core\Render\Renderer->render(Array) (Line: 484)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 120)
__TwigTemplate_e9204f7060e2bc684929174b8b8efc1d->{closure}() (Line: 2058)
Twig\Extension\CoreExtension::captureOutput(Object) (Line: 88)
__TwigTemplate_e9204f7060e2bc684929174b8b8efc1d->macro_tree_links(Array) (Line: 67)
__TwigTemplate_e9204f7060e2bc684929174b8b8efc1d->doDisplay(Array, Array) (Line: 387)
Twig\Template->yield(Array, Array) (Line: 343)
Twig\Template->display(Array) (Line: 358)
Twig\Template->render(Array) (Line: 35)
Twig\TemplateWrapper->render(Array) (Line: 33)
twig_render_template('modules/contrib/toc_api/templates/toc-tree.html.twig', Array) (Line: 354)
Drupal\Core\Theme\ThemeManager->render('toc_tree', Array) (Line: 446)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 203)
Drupal\Core\Render\Renderer->render(Array) (Line: 484)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 51)
__TwigTemplate_2dc37c9b3f055a0c562225983c06be41->doDisplay(Array, Array) (Line: 387)
Twig\Template->yield(Array, Array) (Line: 343)
Twig\Template->display(Array) (Line: 358)
Twig\Template->render(Array) (Line: 35)
Twig\TemplateWrapper->render(Array) (Line: 33)
twig_render_template('modules/contrib/toc_api/templates/toc-default.html.twig', Array) (Line: 354)
Drupal\Core\Theme\ThemeManager->render('toc_default', Array) (Line: 446)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 203)
Drupal\Core\Render\Renderer->render(Array) (Line: 157)
Drupal\toc_api\TocBuilder->renderToc(Object) (Line: 184)
Drupal\toc_filter\Plugin\Filter\TocFilter->process
Ok figured out the issue with my tests, a bit confusing.
I thought this was drupal/core: https://git.drupalcode.org/project/drupal/-/tree/11.1.x?ref_type=heads
But the composer.json in the root of this repo is drupal/drupal. There is another composer.json file in /core, and that's drupal/core. So when we are requiring drupal/core-recommended, that requires drupal/core, and so the other files/directories in the root of that repo are not included.
To fix the issue, I added drupal/drupal to require-dev. This puts drupal/drupal in the vendor directory. I then use a composer post install/update script to move vendor/drupal/drupal/composer/* into html/composer (only if it exists with require-dev).
"scripts": {
"post-install-cmd": [
"@copy-composer-directory"
],
"post-update-cmd": [
"@copy-composer-directory"
],
"copy-composer-directory": [
"[ -d vendor/drupal/drupal/composer ] && mkdir -p html/composer && cp -R vendor/drupal/drupal/composer/* html/composer/ || echo 'composer directory not found; skipping copy'"
],
}
Now the Drupal\Tests\Composer\Generator\BuilderTest class, which requires the /composer directory to be in place, can access the proper drupal verison of composer with the Composer::drupalVersionBranch() method, which is obviously drupal specific.
Ok figured out the issue with the tests, a bit confusing.
I thought this was drupal/core: https://git.drupalcode.org/project/drupal/-/tree/11.1.x?ref_type=heads
But the composer.json in the root of this repo is drupal/drupal. There is another composer.json file in /core, and that's drupal/core. So when we are requiring drupal/core-recommended, that requires drupal/core, and so the otehr files/directories in the root of that repo are not included.
To fix the issue, I added drupal/drupal to require-dev. This puts drupal/drupal in the vendor directory. I then use a composer post install/update script to move vendor/drupal/drupal/composer/* into html/composer.
Now the Drupal\Tests\Composer\Generator\BuilderTest class, which requires the /composer directory to be in place, can access the proper drupal verison of composer with the Composer::drupalVersionBranch() method, which is obviously drupal specific.
Now both mysql and psql tests are passing in GitHub.
Think I found the issue with the failing phpunit tests. For some reason, composer is not bringing in the /composer directory from core.
Ok think I found the issue. For some reason, composer is not bringing in the /composer directory from core, still troubleshooting why.
I'm running into the same issue with this:
./docker/bin/phpunit --colors=always \
-c /var/www/html/core/phpunit.xml.dist \
--testsuite=unit \
--group=$(PROFILE_NAME)There were 2 PHPUnit errors:
1) Drupal\Tests\Composer\Generator\BuilderTest::testBuilder
The data provider specified for Drupal\Tests\Composer\Generator\BuilderTest::testBuilder is invalid
Class "Drupal\Composer\Composer" not found/var/www/html/core/tests/Drupal/Tests/Composer/Generator/BuilderTest.php:91
2) Drupal\Tests\ComposerIntegrationTest::testComposerTilde
The data provider specified for Drupal\Tests\ComposerIntegrationTest::testComposerTilde is invalid
The "/var/www/html/composer" directory does not exist./var/www/html/core/tests/Drupal/Tests/ComposerIntegrationTest.php:55
The first error is looking for class Drupal\Composer\Composer, which would suggest composer is in the vendor/drupal/composer directory, but it's location in my project is actually vendor/composer/composer, so this should probably be changed to:
use Composer/Composer;
Upgraded to psql 16, and fixed the issue with the mysql test from #52. Now running into these phpunit test errors:
There were 2 PHPUnit errors:
1) Drupal\Tests\Composer\Generator\BuilderTest::testBuilder
The data provider specified for Drupal\Tests\Composer\Generator\BuilderTest::testBuilder is invalid
Class "Drupal\Composer\Composer" not found/var/www/html/core/tests/Drupal/Tests/Composer/Generator/BuilderTest.php:91
2) Drupal\Tests\ComposerIntegrationTest::testComposerTilde
The data provider specified for Drupal\Tests\ComposerIntegrationTest::testComposerTilde is invalid
The "/var/www/html/composer" directory does not exist./var/www/html/core/tests/Drupal/Tests/ComposerIntegrationTest.php:55
Seems to be same issues as the related ticket.
The drupal/group and drupal/flexible_permissions modules have both been upgraded in 6.1.x as per #5.
I am upgrading the same site from comment #9, from WxT 4.5.3 to 5.4.0. I had the following workaround in place to fix the wet-boew slick slider JS issue:
"wet-boew/wet-boew": "4.0.43.1 as 4.0.50.1"
I can confirm now that I've upgraded to 5.4.0 (wet-boew 4.0.75) the issues I was seeing with the slick sliders is no longer occurring. I also tested a dataTable and no errors as well.
Patch #25 works for me with 10.4.x
Running the builds in GitHub to get them passing before releasing an alpha version. There were some changes to the docker-scaffold needed, as well as some PHPCS fixes.
Both builds (mysql, psql) are still failing.
For psql, D11 requires >=16:
* The database server version /12.22/ is less than the minimum required
version /16/.
For mysql, it can't find a Kernel test file:
Test file "/var/www/html/core/./tests/TestSuites/KernelTestSuite.php" not found
make: *** [docker/Makefile:137: phpunit] Error 2
Will continue looking into these issues tomorrow.
This has been fixed and included in 6.1.x. Removed the if statements from the two block template files as per patch #25, but also removed the preprocess logic that was driving these. Now instead of having both webform blocks on a default install of WxT, we only have the one "Did you find..." block. The older "Report a problem" block can be added easily in the block layout UI if needed.
@joseph the page_manager issue has been resolved, and is now fixed in 6.1.x.
I was using patch #50 and this was causing an error after logging into my site. Using the latest MR from #51 fixed the issue for me, and now I can login to my site without error. Posting latest patch here so I can use it in my project.
@joseph I tested and merged patch 42a, I can confirm it fixes the issue with the performance page. Patch 42b was already fixed the other day. For patch 43, although it did fix the warning/error, the success message for that webform was not returning. I had to use an AjaxResponse() to get this work, and now the success message is displayed after the "Yes" button is clicked on the webform "did you find...". I also confirmed that the "Yes" is being logged to the webform submission as expected. This has all been resolved and pushed to 6.1.x.
Will look at the page_manager issue now, and why it's preventing us from logging in. Thanks!
This will be included in 6.1.x
@joseph thanks for the patches. Patch 42b is not needed, I made this change earlier today - https://github.com/drupalwxt/wxt_library/commit/c4dce84af54132cf62c4f21a5a3db85d3f80083c
I'll include patches 42a and 43 next, thanks for this!
This will be included in 6.1.x
Got WxT 6.1.x installing from scratch! Will be testing the migrations, theme, and other functionality next, but looking good so far.
I created a new branch for docker-scaffold, 11.1.x, that uses drupal:11.1.1-php8.3-fpm-alpine3.21 as a base image. Just tested this branch locally and it works well on a site upgraded from docker-scaffold 10.4.x.
Updated wet-boew/wet-boew to 4.0.83 to get jQuery 4 compatibility, now all JS console errors on forward-facing GCWeb theme are gone, everything functions as expected!
Specifically we needed this PR from @joseph - https://github.com/wet-boew/wet-boew/pull/9831
Will need to prepare 5.4.x to unsinstall the following modules:
- block_content_permissions
- ckeditor
This has been included in 1.0.4, thanks guys!
This gets the GitLab tests working without errors, just warnings on some dependency injection. Will close this ticket and we can fix dependency injection issues in separate ticket.
This has been merged with the 1.0.x branch and will be included in next release.
My MR for drupal/entity_block was just merged and now there is a D11 version available, 2.0.x. Scratching this one off the list, only 9 remaining.
Opened a MR with your feature branch, and attached a patch to facilitate testing. @joel please test the patch, if it works we can merge this into the 1.0.x branch. @alan.wallac would be nice to get your input on this fix as well, see if it works for your scenario.
Fixed one issue with the wxt_ext_layout module and now I have successfully upgraded a vanilla WxT 5.3.x to 6.1.x on core 11.1.0. This is just the first iteration to get the site functional, although there are a few issues I notice immediately, which I will work on next. All changes pushed to drupalwxt/wxt 6.1.x.
Was able to get WxT composer update working with core 11.1.0. This includes updating all dependencies and replacing/removing patches as needed. Please find below a snapshot of my local composer.json overrides that were needed in order to get this working. These changes have been rolled into the 6.1.x branch so other can install. Next will be fixing some errors in our custom module space.
Local composer.json changes:
"patches": {
"drupal/page_manager": {
"Enter drupal/page_manager patch #2752227 description here": "https://www.drupal.org/files/issues/2024-08-22/2752227-50.patch"
},
"drupal/bootstrap_layouts": {
"3481450": "https://www.drupal.org/files/issues/2025-01-06/3481450-12.patch"
},
"drupal/menu_breadcrumb": {
"3485520": "https://www.drupal.org/files/issues/2025-01-06/3485520-8.patch"
}
},
"patches-ignore": {
"drupalwxt/wxt": {
"drupal/core": {
"3177182 - Book title in breadcrumb not translated": "https://www.drupal.org/files/issues/2020-10-20/book-breadcrumb_title_xlate-3177182-3.patch",
"Enter drupal/core patch #2546212 description here": "https://www.drupal.org/files/issues/2020-11-07/2546212-158.patch",
"Enter drupal/core patch #2938129 description here": "https://www.drupal.org/files/issues/2024-01-21/drupal-PageTitle_block-2938129-42.patch",
"Enter drupal/core patch #3173808 description here": "https://www.drupal.org/files/issues/2024-01-14/3173808-26.patch",
"Enter drupal/core patch #3207813 description here": "https://www.drupal.org/files/issues/2021-04-08/3207813-2.patch",
"Enter drupal/core patch #3236799 description here": "https://www.drupal.org/files/issues/2021-12-22/drupal-core-9.2.x-li-role-separator-tag-linkGenerator-3236799-11.patch",
"3150294 - New translations for moderated nodes are not created in the initial workflow state": "https://www.drupal.org/files/issues/2024-01-03/3150294-128.patch"
},
"drupal/bootstrap": {
"3249470 - Error generated when importing translation": "https://www.drupal.org/files/issues/2021-11-17/3249470-3.patch"
},
"drupal/page_manager": {
"Enter drupal/page_manager patch #2710169 description here": "https://www.drupal.org/files/issues/page_manager-block-css-attributes-9.patch",
"Enter drupal/page_manager patch #2752227 description here": "https://www.drupal.org/files/issues/2021-04-14/2752227-47.patch"
},
"drupal/linkit": {
"Enter drupal/linkit patch #3457958 description here": "https://www.drupal.org/files/issues/2024-06-28/linkit--testing-static-methods--3457958.patch",
"Detect and strip base URL from pasted URLs to increase matching hits": "https://www.drupal.org/files/issues/2023-11-02/linkit6x-3078075-77.patch"
}
}
}
Adding patch from MR to use in my project.
+1 this works for me, was getting critical error when running Drush during an upgrade.
Adding lates MR changes to patch to use in my project.
smulvih2 → changed the visibility of the branch 3481450-cannot-install-module to active.
Sorry didn't mean to hide visibility of the branch, accidently clicked the wrong link. Add fix to the MR, broken reference to ContainerAwareInterface.
smulvih2 → changed the visibility of the branch 3481450-cannot-install-module to hidden.
Changes seem to be included in latest release 7.0.2:
I think this ticket can be closed as duplicate.
Need the above fixed before I can get drupal/blog pulled into my project with composer.
@nevergone, you committed the change to the *.info file, but not to composer - https://git.drupalcode.org/project/blog/-/commit/74cfa3ccc8a8a14d51ad1b1596eea1527ec76fe9
Still need change in this patch.
smulvih2 → made their first commit to this issue’s fork.
Yes we need a D11 release ASAP. Other module, like url_embed, require this module (drupal/embed). I am currently updating a distro to D11.1, and running into an issue. Both url_embed and embed do not have D11 releases, and one requires the other, so it is not possible to do my usual composer.json workaround for this by defining a repository that points to the D11 PR branch in Drupal's gitlab. Therefore, to get the working, I will need to have a D11 release for embed.
I agree with @borisson_, it's better to just get a release out, so that people can actually include this module in their project, then issues can be ironed out quickly using patches in separate tickets.
+1 let's get a new release
+1 let's get a new release with this included!
Fixed issues reported by PHPCS, now the build is passing.
smulvih2 → made their first commit to this issue’s fork.
Here is the list of all module in WxT that do not have a D11 compatible version, even in their respective dev branches:
- drupal/button_link
- drupal/embed
- drupal/entity_block
- drupal/entity_browser_block
- drupal/entity_embed
- drupal/fontawesome
- drupal/layout_builder_st
- drupal/layout_library
- drupal/linkit
- drupal/toc_api
Proposing to remove the following modules:
- drupal/webform_migrate (not being used by other modules, should be required in root composer file if needed on a project)
- drupal/block_content_permissions (Apparently this module's functionality is now in core, as per https://www.drupal.org/project/block_content_permissions/issues/3428999#comment-15829451 📌 Automated Drupal 11 compatibility fixes for block_content_permissions Needs review )
- Any CKE4-specific module(s) (TBD)
+1 let's get a new release!!!
@hatuhay can we get this merged and a new release? Upgrading a distro to D11 and we use this module. Can help report any bugs once it's installed on my D11 site. Thanks!
@joseph I'm working on WxT 6.1.x now and using your drupal/bootstrap ^5.0, great work on this!
Running into another issue, with views_bootstrap → . To keep on Bootstrap 3, we need to use the 5.3.x branch, which doesn't support D11 (yet). Could use your help with this, especially since you are a maintainer for drupal/bootstrap.
@sylus yep this makes sense to me, thanks!
This ticket would be good to get into the next release. Even just the patch I create for ckeditor_details is worth merging for, as it makes this plugin MUCH more robust. Without this, migrated content with details elements become unusable in CKE5, and this is a common component. The tabbed interface, although not as common, is also nice to have support for, else tabs are not editable in CKE5. This feature has been tested thoroughly with new content and migrated content.
@joseph good call on including this fix! It has been merged with 5.3.x, automated tests are passing, let me know if this helps your upgrade. Thanks!
This has now been fixed in the 10.3.x branch.
While unpinning drupal/core-recommended from 10.3.6 to ^10.3 and testing, I noticed the site was actually upgraded to 10.4.0. There was only two issues needing to be resolved before jumping to 10.4.0, which have been addressed:
- Had to re-roll a
drupal/corepatch from related ticket. - Had to fix declaration of
TaxonomyBreadcrumbBuilder::appliesin wxt_ext_breadcrumb
After these two fixes WxT was working well on 10.4.0. These changes also got the automated tests passing in GitHub.
Changes have been pushed to 10.3.x, will wait for @sylus to review and determine if we push a 5.3.1 version for WxT LTS on Drupal 10, or if we we create a new 10.4.x for this.
smulvih2 → created an issue.
@gturnbull I tested the upgrade to the latest block_class 4.0.0 and it works well. Tested existing WxT blocks and updating block classes and all is good. The build in GitHub is also passing after this upgrade. This has been pushed to 5.3.x and will be included in the next release.