- 🇭🇺Hungary balagan
Rerolled the patch in https://www.drupal.org/project/entity_clone/issues/3076356#comment-14715404 ✨ Book Pages Clone Needs review to apply for the 2.x branch.
Meanwhile looking at the code I think the condition at line 117 is not what really what we want.
I have changed
$bid = isset($entity->book) && empty($entity->book['bid']) ? 0 : $entity->book['bid'];
to
$bid = !isset($entity->book) || empty($entity->book['bid']) ? 0 : $entity->book['bid'];
- 🇭🇺Hungary balagan
I have simplified the condition a bit more.
$bid = !empty($entity->book['bid']) ? $entity->book['bid'] : 0;
- Status changed to Needs review
over 1 year ago 6:13am 28 March 2023 The last submitted patch, 17: entity_clone-book_support-3076356-17.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.